Re: [PATCH v4] PCI: Add quirk for preventing bus reset on TI C667X

2021-04-19 Thread Kishon Vijay Abraham I
this change device can be assigned to VMs with VFIO, > but it will leak state between VMs. > > Reference: https://e2e.ti.com/support/processors/f/791/t/954382 > Signed-off-by: Antti Järvinen Reviewed-by: Kishon Vijay Abraham I > --- > drivers/pci/quirks.c | 10 ++ &g

[PATCH v5 7/7] Documentation: PCI: endpoint/pci-endpoint-cfs: Guide to use SR-IOV

2021-04-19 Thread Kishon Vijay Abraham I
Add Documentation to help users use PCI endpoint to create virtual functions using configfs. An endpoint function is designated as a virtual endpoint function device when it is linked to a physical endpoint function device (instead of a endpoint controller). Signed-off-by: Kishon Vijay Abraham I

[PATCH v5 6/7] misc: pci_endpoint_test: Populate sriov_configure ops to configure SR-IOV device

2021-04-19 Thread Kishon Vijay Abraham I
Populate sriov_configure ops with pci_sriov_configure_simple to configure SR-IOV device. Signed-off-by: Kishon Vijay Abraham I --- drivers/misc/pci_endpoint_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index

[PATCH v5 4/7] PCI: endpoint: Add virtual function number in pci_epc ops

2021-04-19 Thread Kishon Vijay Abraham I
Add virtual function number in pci_epc ops. EPC controller driver can perform virtual function specific initialization based on the virtual function number. Signed-off-by: Kishon Vijay Abraham I --- .../pci/controller/cadence/pcie-cadence-ep.c | 44 +++--- .../pci/controller/dwc/pcie

[PATCH v5 5/7] PCI: cadence: Add support to configure virtual functions

2021-04-19 Thread Kishon Vijay Abraham I
Now that support for SR-IOV is added in PCIe endpoint core, add support to configure virtual functions in the Cadence PCIe EP driver. Signed-off-by: Kishon Vijay Abraham I --- .../pci/controller/cadence/pcie-cadence-ep.c | 241 +++--- drivers/pci/controller/cadence/pcie-cadence.h

[PATCH v5 3/7] PCI: endpoint: Add support to link a physical function to a virtual function

2021-04-19 Thread Kishon Vijay Abraham I
While the physical function has to be linked to endpoint controller, the virtual function has to be linked to a physical function. Add support to link a physical function to a virtual function in pci-ep-cfs. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-ep-cfs.c | 24

[PATCH v5 0/7] Add SR-IOV support in PCIe Endpoint Core

2021-04-19 Thread Kishon Vijay Abraham I
[2] -> http://lore.kernel.org/r/20201112175358.2653-1-kis...@ti.com [3] -> https://lore.kernel.org/r/20210305050410.9201-1-kis...@ti.com [4] -> http://lore.kernel.org/r/20210310160943.7606-1-kis...@ti.com Kishon Vijay Abraham I (7): dt-bindings: PCI: pci-ep: Add binding to specify virt

[PATCH v5 2/7] PCI: endpoint: Add support to add virtual function in endpoint core

2021-04-19 Thread Kishon Vijay Abraham I
Add support to add virtual function in endpoint core. The virtual function can only be associated with a physical function instead of a endpoint controller. Provide APIs to associate a virtual function with a physical function here. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint

[PATCH v5 1/7] dt-bindings: PCI: pci-ep: Add binding to specify virtual function

2021-04-19 Thread Kishon Vijay Abraham I
Add binding to specify virtual function (associated with each physical function) in endpoint mode. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pci/pci-ep.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation

Re: [PATCH v3 2/4] phy: Add API for devm_of_phy_optional_get_by_index

2021-04-15 Thread Kishon Vijay Abraham I
Hi Aswath, On 15/04/21 8:19 pm, Aswath Govindraju wrote: > Add API for devm_of_phy_optional_get_by_index, to obtain a reference to an > optional phy by index. Rob has posted a patch http://lore.kernel.org/r/20210414135525.3535787-1-r...@kernel.org that doesn't require consumers to get a phy by

Re: [Discussion] Uninitialized variable in wiz_mode_select()

2021-04-01 Thread Kishon Vijay Abraham I
Hi, On 01/04/21 1:08 pm, Kishon Vijay Abraham I wrote: > Hi Usama, > > On 01/04/21 1:03 pm, Muhammad Usama Anjum wrote: >> Hi, >> >> `mode` remains uninitialized when `lane_phy_type` isn't PHY_TYPE_DP >> or >> PHY_TYPE_QSGMII. I've checked the d

Re: [Discussion] Uninitialized variable in wiz_mode_select()

2021-04-01 Thread Kishon Vijay Abraham I
Hi Usama, On 01/04/21 1:03 pm, Muhammad Usama Anjum wrote: > Hi, > > `mode` remains uninitialized when `lane_phy_type` isn't PHY_TYPE_DP > or > PHY_TYPE_QSGMII. I've checked the dtsi (k3-j721e-common-proc- > board.dts) > and possible values of `lane_phy_type` are justPHY_TYPE_USB3 and >

Re: [PATCH v5 2/5] phy: Add LVDS configuration options

2021-03-31 Thread Kishon Vijay Abraham I
set of parameters > should cover all potential users. > > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > Cc: NXP Linux Team > Signed-off-by: Liu Ying > --- > v4->v5: > * Align kernel-doc style to include/linux/phy/phy.h. (Vinod) > * Trivial tweaks. > * Drop R

[PATCH] phy: ti: j721e-wiz: Configure 'p_standard_mode' only for DP/QSGMII

2021-03-31 Thread Kishon Vijay Abraham I
Configure 'p_standard_mode' only for DP/QSGMII as for other modes it's not used as per the programming sequence. Add "continue" in the else to prevent random value from being written to p_standard_mode. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/ti/phy-j721e-wiz.c | 2

[PATCH v2 3/5] phy: cadence-torrent: Do not configure SERDES if it's already configured

2021-03-30 Thread Kishon Vijay Abraham I
Do not configure torrent SERDES if it's already configured. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 32 --- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/phy/cadence/phy

[PATCH v2 2/5] phy: cadence-torrent: Group reset APIs and clock APIs

2021-03-30 Thread Kishon Vijay Abraham I
No functional change intended. Group reset APIs and clock APIs in preparation for adding support to skip configuration if the SERDES is already configured by bootloader. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 84

[PATCH v2 5/5] phy: cadence-torrent: Add delay for PIPE clock to be stable

2021-03-30 Thread Kishon Vijay Abraham I
The Torrent spec specifies delay of 660.5us after phy_reset is asserted by the controller. To be on the safe side provide a delay of 5ms to 10ms in ->phy_on() callback where the SERDES is already configured in bootloader. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cade

[PATCH v2 4/5] phy: cadence-torrent: Explicitly request exclusive reset control

2021-03-30 Thread Kishon Vijay Abraham I
No functional change. Since the reset controls obtained in Torrent is exclusively used by the Torrent device, use exclusive reset control request API calls. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-torrent.c | 2 +- 1 file changed

[PATCH v2 1/5] phy: ti: j721e-wiz: Do not configure wiz if its already configured

2021-03-30 Thread Kishon Vijay Abraham I
if any of the lanes has already been enabled. Signed-off-by: Faiz Abbas Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/ti/phy-j721e-wiz.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c

[PATCH v2 0/5] j721e-wiz/cadence-torrent: Support to skip SERDES configuration

2021-03-30 Thread Kishon Vijay Abraham I
if its already configured Kishon Vijay Abraham I (4): phy: cadence-torrent: Group reset APIs and clock APIs phy: cadence-torrent: Do not configure SERDES if it's already configured phy: cadence-torrent: Explicitly request exclusive reset control phy: cadence-torrent: Add delay for PIPE

Re: [PATCH 3/4] phy: cadence-torrent: Do not configure SERDES if it's already configured

2021-03-30 Thread Kishon Vijay Abraham I
Hi Swapnil, On 18/03/21 3:25 pm, Swapnil Kashinath Jakhade wrote: > > >> -Original Message----- >> From: Kishon Vijay Abraham I >> Sent: Wednesday, March 10, 2021 9:25 PM >> To: Kishon Vijay Abraham I ; Vinod Koul >> ; Rob Herring ; Philipp Zabel >

Re: [PATCH 1/6] dt-bindings: PCI: ti,am65: Add PCIe host mode dt-bindings for TI's AM65 SoC

2021-03-30 Thread Kishon Vijay Abraham I
Hi Rob, On 26/03/21 5:08 am, Rob Herring wrote: > On Thu, Mar 25, 2021 at 02:30:21PM +0530, Kishon Vijay Abraham I wrote: >> Add PCIe host mode dt-bindings for TI's AM65 SoC. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> .../bindings/pci/t

Re: [PATCH v9 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems

2021-03-26 Thread Kishon Vijay Abraham I
B – APRIL 2020 – REVISED JANUARY 2021) > > Signed-off-by: Aswath Govindraju > Reviewed-by: Kishon Vijay Abraham I Thanks! Patch looks good to me. Regards Kishon > --- > .../dts/ti/k3-j7200-common-proc-board.dts | 78 +++ > arch/arm64/boot/dts/ti/k3-j7200-m

Re: [PATCH v8 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems

2021-03-25 Thread Kishon Vijay Abraham I
7B – APRIL 2020 – REVISED JANUARY 2021) minor comments below.. once you fix them, please add Reviewed-by: Kishon Vijay Abraham I > > Signed-off-by: Aswath Govindraju > --- > .../dts/ti/k3-j7200-common-proc-board.dts | 78 +++ > arch/arm64/boot/dts/ti/k3-

[PATCH 4/4] PCI: j721e: Add PCIe support for AM64

2021-03-25 Thread Kishon Vijay Abraham I
AM64 has the same PCIe IP as in J7200 (legacy interrupt handling is same as J7200 instead of J721E). Add support for "ti,am64-pcie-host" compatible that is specific to AM64. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/cadence/pci-j721e.c | 4 1 file

[PATCH 3/4] PCI: j721e: Add PCIe support for j7200

2021-03-25 Thread Kishon Vijay Abraham I
-by: Kishon Vijay Abraham I --- drivers/pci/controller/cadence/pci-j721e.c | 111 ++--- 1 file changed, 99 insertions(+), 12 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c index 17db86a51ca8..f175f116abf6 100644

[PATCH 2/4] PCI: j721e: Add PCI legacy interrupt support for J721E

2021-03-25 Thread Kishon Vijay Abraham I
functionality to edge interrupt line, PCIe in J721E has provided IRQ_EOI register. When the SW writes to IRQ_EOI register after handling the interrupt, the IP checks the state of legacy interrupt and re-triggers pulse interrupt invoking the handler again. Signed-off-by: Kishon Vijay Abraham I

[PATCH 0/4] PCI: Add legacy interrupt support in pci-j721e

2021-03-25 Thread Kishon Vijay Abraham I
by configuring EOI register. Kishon Vijay Abraham I (4): dt-bindings: PCI: ti,j721e: Add bindings to specify legacy interrupts PCI: j721e: Add PCI legacy interrupt support for J721E PCI: j721e: Add PCIe support for j7200 PCI: j721e: Add PCIe support for AM64 .../bindings/pci/ti,j721e-pci

[PATCH 1/4] dt-bindings: PCI: ti,j721e: Add bindings to specify legacy interrupts

2021-03-25 Thread Kishon Vijay Abraham I
Add bindings to specify interrupt controller for legacy interrupts. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b

[PATCH 4/6] PCI: keystone: Convert to using hierarchy domain for legacy interrupts

2021-03-25 Thread Kishon Vijay Abraham I
K2G provides separate IRQ lines for each of the four legacy interrupts. Model this using hierarchy domain instead of linear domain with chained IRQ handler. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 214 -- 1 file changed, 120

[PATCH 6/6] PCI: keystone: Add workaround for Errata #i2037 (AM65x SR 1.0)

2021-03-25 Thread Kishon Vijay Abraham I
ttp://www.ti.com/lit/er/sprz452d/sprz452d.pdf Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 42 +++ 1 file changed, 42 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c in

[PATCH 5/6] PCI: keystone: Add PCI legacy interrupt support for AM654

2021-03-25 Thread Kishon Vijay Abraham I
functionality to edge interrupt line, PCIe in AM654 has provided IRQ_EOI register. When the SW writes to IRQ_EOI register after handling the interrupt, the IP checks the state of legacy interrupt and re-triggers pulse interrupt invoking the handler again. Signed-off-by: Kishon Vijay Abraham I

[PATCH 2/6] dt-bindings: PCI: ti,am65: Add PCIe endpoint mode dt-bindings for TI's AM65 SoC

2021-03-25 Thread Kishon Vijay Abraham I
Add PCIe endpoint mode dt-bindings for TI's AM65 SoC. Signed-off-by: Kishon Vijay Abraham I --- .../bindings/pci/ti,am65-pci-ep.yaml | 80 +++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/pci/ti,am65-pci-ep.yaml diff --git

[PATCH 3/6] irqdomain: Export of_phandle_args_to_fwspec()

2021-03-25 Thread Kishon Vijay Abraham I
ild-wind.fr.eu.org/ Signed-off-by: Kishon Vijay Abraham I --- include/linux/irqdomain.h | 2 ++ kernel/irq/irqdomain.c| 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index 42d196805f58..0236f508259e 100644 --- a/incl

[PATCH 0/6] PCI: Add legacy interrupt support in Keystone

2021-03-25 Thread Kishon Vijay Abraham I
hon Vijay Abraham I (6): dt-bindings: PCI: ti,am65: Add PCIe host mode dt-bindings for TI's AM65 SoC dt-bindings: PCI: ti,am65: Add PCIe endpoint mode dt-bindings for TI's AM65 SoC irqdomain: Export of_phandle_args_to_fwspec() PCI: keystone: Convert to using hierarchy domain for leg

[PATCH 1/6] dt-bindings: PCI: ti,am65: Add PCIe host mode dt-bindings for TI's AM65 SoC

2021-03-25 Thread Kishon Vijay Abraham I
Add PCIe host mode dt-bindings for TI's AM65 SoC. Signed-off-by: Kishon Vijay Abraham I --- .../bindings/pci/ti,am65-pci-host.yaml| 111 ++ 1 file changed, 111 insertions(+) create mode 100644 Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml diff --git

[PATCH 2/2] PCI: keystone: Add link up check in ks_child_pcie_ops.map_bus()

2021-03-24 Thread Kishon Vijay Abraham I
driver commit 15b23906347c ("PCI: dwc: Add link up check in dw_child_pcie_ops.map_bus()"). Fixes: 10a797c6e54a ("PCI: dwc: keystone: Use pci_ops for config space accessors") Signed-off-by: Kishon Vijay Abraham I Cc: # v5.10 --- drivers/pci/controller/dwc/pci-keystone.c | 11

[PATCH 0/2] PCI: Fixes in pci-keystone driver

2021-03-24 Thread Kishon Vijay Abraham I
Patch series includes a couple of fixes in pci-keystone driver for issues seen when testing Root Complex mode in K2G driver. Kishon Vijay Abraham I (2): PCI: keystone: Set mode as RootComplex for "ti,keystone-pcie" compatible PCI: keystone: Add link up check in ks_child_pcie_o

[PATCH 1/2] PCI: keystone: Set mode as RootComplex for "ti,keystone-pcie" compatible

2021-03-24 Thread Kishon Vijay Abraham I
ode as RootComplex for "ti,keystone-pcie" compatible here. Fixes: 23284ad677a9 ("PCI: keystone: Add support for PCIe EP in AM654x Platforms") Signed-off-by: Kishon Vijay Abraham I Cc: # v5.4+ --- drivers/pci/controller/dwc/pci-keystone.c | 1 + 1 file changed, 1 insertion(+

Re: [PATCH RESEND] PCI: dwc: Fix MSI not work after resume

2021-03-23 Thread Kishon Vijay Abraham I
Hi, On 23/03/21 8:42 pm, Bjorn Helgaas wrote: > [-cc Dilip (mail to him bounced)] > > On Tue, Mar 23, 2021 at 11:01:15AM +0800, Jisheng Zhang wrote: >> On Mon, 22 Mar 2021 20:24:41 -0500 Bjorn Helgaas wrote: >>> >>> [+cc Kishon, Richard, Lucas, Dilip] >>> >>> On Mon, Mar 01, 2021 at 11:10:31AM

Re: [PATCH v7 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems

2021-03-23 Thread Kishon Vijay Abraham I
Hi Aswath, On 23/03/21 10:54 am, Aswath Govindraju wrote: > Hi Nishanth, > > On 22/03/21 9:05 pm, Nishanth Menon wrote: >> On 18:42-20210322, Aswath Govindraju wrote: >>> The following speed modes are now supported in J7200 SoC, >>> - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0

Re: [PATCH 1/2] arm64: dts: ti: k3-am64: Add SERDES DT node

2021-03-19 Thread Kishon Vijay Abraham I
Hi Aswath, On 19/03/21 1:30 pm, Aswath Govindraju wrote: > From: Kishon Vijay Abraham I > > Add SERDES DT node for the single one lane SERDES present in > AM64. > > Signed-off-by: Kishon Vijay Abraham I > Signed-off-by: Aswath Govindraju > --- > arch/arm64/boot/dt

[PATCH v7 10/13] phy: cadence: Sierra: Add missing clk_disable_unprepare() in .remove callback

2021-03-19 Thread Kishon Vijay Abraham I
commit 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") enabled the clock in probe and failed to disable in remove callback. Add missing clk_disable_unprepare() in cdns_sierra_phy_remove(). Fixes: 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") Signed-off-by:

[PATCH v7 11/13] dt-bindings: phy: phy-cadence-sierra: Add binding to model Sierra as clock provider

2021-03-19 Thread Kishon Vijay Abraham I
Add #clock-cells binding to model Sierra as clock provider and include clock IDs for PLL_CMNLC and PLL_CMNLC1. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Rob Herring --- .../bindings/phy/phy-cadence-sierra.yaml| 17 - include/dt-bindings/phy/phy-cadence.h

[PATCH v7 12/13] phy: cadence: Sierra: Model PLL_CMNLC and PLL_CMNLC1 as clocks (mux clocks)

2021-03-19 Thread Kishon Vijay Abraham I
Vijay Abraham I Reviewed-by: Swapnil Jakhade --- drivers/phy/cadence/Kconfig | 1 + drivers/phy/cadence/phy-cadence-sierra.c | 267 ++- 2 files changed, 265 insertions(+), 3 deletions(-) diff --git a/drivers/phy/cadence/Kconfig b/drivers/phy/cadence/Kconfig

[PATCH v7 09/13] phy: cadence: Sierra: Add array of input clocks in "struct cdns_sierra_phy"

2021-03-19 Thread Kishon Vijay Abraham I
Instead of having separate structure members for each input clock, add an array for the input clocks within "struct cdns_sierra_phy". This is in preparation for adding more input clocks required for supporting additional clock combination. Signed-off-by: Kishon Vijay Abraham I

[PATCH v7 07/13] phy: cadence: Sierra: Explicitly request exclusive reset control

2021-03-19 Thread Kishon Vijay Abraham I
No functional change. Since the reset controls obtained in Sierra is exclusively used by the Sierra device, use exclusive reset control request API calls. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Philipp Zabel --- drivers/phy/cadence/phy-cadence-sierra.c | 4 ++-- 1 file changed, 2

[PATCH v7 08/13] phy: cadence-torrent: Use a common header file for Cadence SERDES

2021-03-19 Thread Kishon Vijay Abraham I
No functional change. In order to have a single header file for all Cadence SERDES move phy-cadence-torrent.h to phy-cadence.h. This is in preparation for adding Cadence Sierra SERDES specific macros. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Swapnil Jakhade --- .../devicetree

[PATCH v7 06/13] phy: cadence: Sierra: Move all reset_control_get*() to a separate function

2021-03-19 Thread Kishon Vijay Abraham I
No functional change. Group devm_reset_control_get() and devm_reset_control_get_optional() to a separate function. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Philipp Zabel --- drivers/phy/cadence/phy-cadence-sierra.c | 36 1 file changed, 25 insertions(+), 11

[PATCH v7 05/13] phy: cadence: Sierra: Move all clk_get_*() to a separate function

2021-03-19 Thread Kishon Vijay Abraham I
No functional change. Group all devm_clk_get_optional() to a separate function. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-sierra.c | 57 +++- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/drivers

[PATCH v7 04/13] phy: ti: j721e-wiz: Get PHY properties only for "phy" or "link" subnode

2021-03-19 Thread Kishon Vijay Abraham I
node's name is "phy" or "link" subnode. Ideally all PHY dt nodes should have node name as "phy", however existing devicetree used "link" as subnode. So in order to maintain old DT compatibility get PHY properties for "phy" or "link" subnod

[PATCH v7 03/13] phy: cadence: Sierra: Create PHY only for "phy" or "link" sub-nodes

2021-03-19 Thread Kishon Vijay Abraham I
d device tree) which represent the actual PHY. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-sierra.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-ca

[PATCH v7 02/13] phy: ti: j721e-wiz: Invoke wiz_init() before of_platform_device_create()

2021-03-19 Thread Kishon Vijay Abraham I
wiz_init() immediately before invoking of_platform_device_create(). Fixes: 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC") Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Swapnil Jakhade Cc: # v5.10 --- drivers/phy/ti/phy-j721e-

[PATCH v7 00/13] PHY: Add support in Sierra to use external clock

2021-03-19 Thread Kishon Vijay Abraham I
310154558.32078-1-kis...@ti.com Kishon Vijay Abraham I (13): phy: cadence: Sierra: Fix PHY power_on sequence phy: ti: j721e-wiz: Invoke wiz_init() before of_platform_device_create() phy: cadence: Sierra: Create PHY only for "phy" or "link" sub-nodes phy: ti: j7

[PATCH v7 01/13] phy: cadence: Sierra: Fix PHY power_on sequence

2021-03-19 Thread Kishon Vijay Abraham I
re. Fixes: 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I Cc: # v5.4+ Reviewed-by: Philipp Zabel --- drivers/phy/cadence/phy-cadence-sierra.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/phy/cadence/phy

[PATCH v7 13/13] phy: cadence: Sierra: Enable pll_cmnlc and pll_cmnlc1 clocks

2021-03-19 Thread Kishon Vijay Abraham I
Get pll_cmnlc and pll_cmnlc1 optional clocks and enable them. This will enable REFRCV/1 in case the pll_cmnlc/1 takes input from REFRCV/1 respectively. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Swapnil Jakhade --- drivers/phy/cadence/phy-cadence-sierra.c | 40

Re: [PATCH v6 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems

2021-03-18 Thread Kishon Vijay Abraham I
(SPRSP57B – APRIL 2020 – REVISED JANUARY 2021) Thanks for fixing the link. Reviewed-by: Kishon Vijay Abraham I > > Signed-off-by: Aswath Govindraju > --- > .../dts/ti/k3-j7200-common-proc-board.dts | 42 +++ > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 14 ++-

Re: [PATCH v5 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems

2021-03-18 Thread Kishon Vijay Abraham I
Hi, On 10/03/21 9:49 pm, Aswath Govindraju wrote: > The following speed modes are now supported in J7200 SoC, > - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1]. > - UHS-I speed modes in MMCSD1 subsystem [1]. > > Add support for UHS-I modes by adding voltage regulator

Re: [PATCH v3 0/2] AM64: Add USB support

2021-03-17 Thread Kishon Vijay Abraham I
Aswath and Nishanth, On 17/03/21 10:00 am, Aswath Govindraju wrote: > The following series of patches, add USB support for AM642 evm. > > USB test logs, > https://pastebin.ubuntu.com/p/YSQRBWGmzd/ Vinod has provided stable tag [1] git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git

Re: [PATCH v3 0/2] AM64: Add USB support

2021-03-17 Thread Kishon Vijay Abraham I
Hi, On 17/03/21 8:22 pm, Kishon Vijay Abraham I wrote: > Aswath and Nishanth, > > On 17/03/21 10:00 am, Aswath Govindraju wrote: >> The following series of patches, add USB support for AM642 evm. >> >> USB test logs, >> https://pastebin.ubuntu.com/p/YSQRBWGmzd/ &

[PATCH] PCI: keystone: Let AM65 use the pci_ops defined in pcie-designware-host.c

2021-03-17 Thread Kishon Vijay Abraham I
65x and K2. This breaks configuration space access for AM65x platform. Fix it here. Fixes: 10a797c6e54a ("PCI: dwc: keystone: Use pci_ops for config space accessors") Signed-off-by: Kishon Vijay Abraham I Cc: # v5.10 --- drivers/pci/controller/dwc/pci-keystone.c | 3 ++- 1 file changed

Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings

2021-03-16 Thread Kishon Vijay Abraham I
borg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: lin

Re: [PATCH 0/3] AM64: Add SERDES DT bindings

2021-03-16 Thread Kishon Vijay Abraham I
Hi Vinod, On 10/03/21 4:57 pm, Kishon Vijay Abraham I wrote: > Patch series adds device tree bindings to support SERDES in AM64 > platform. > > This is split from [1] since this binding is also required for AM64 > USB DT patches to be merged. > > Vinod, > > Once

Re: [PATCH v15 2/4] phy: Add media type and speed serdes configuration interfaces

2021-03-16 Thread Kishon Vijay Abraham I
iewed-by: Andrew Lunn > Reviewed-by: Alexandre Belloni Acked-By: Kishon Vijay Abraham I > --- > drivers/phy/phy-core.c | 30 ++ > include/linux/phy/phy.h | 26 ++ > 2 files changed, 56 insertions(+) > > diff --git a/drive

Re: [PATCH 2/2] PCI: cadence: Set LTSSM Detect.Quiet state delay.

2021-03-15 Thread Kishon Vijay Abraham I
Hi Nadeem, On 09/03/21 1:01 pm, Nadeem Athani wrote: > The parameter detect_quiet_min_delay can be used to program the minimum > time that LTSSM waits on entering Detect.Quiet state. > 00 : 0us minimum wait time in Detect.Quiet state. > 01 : 100us minimum wait time in Detect.Quiet state. > 10 :

Re: [PATCH v2 0/2] AM64: Add USB support

2021-03-14 Thread Kishon Vijay Abraham I
Would prefer simple data transfer tests in the log but other than that for the patches itself Reviewed-by: Kishon Vijay Abraham I > > Aswath Govindraju (2): > arm64: dts: ti: k3-am64-main: Add DT node for USB subsystem > arm64: dts: ti: k3-am642-evm: Add USB support > > arc

[PATCH v4 7/7] Documentation: PCI: endpoint/pci-endpoint-cfs: Guide to use SR-IOV

2021-03-10 Thread Kishon Vijay Abraham I
Add Documentation to help users use PCI endpoint to create virtual functions using configfs. An endpoint function is designated as a virtual endpoint function device when it is linked to a physical endpoint function device (instead of a endpoint controller). Signed-off-by: Kishon Vijay Abraham I

[PATCH v4 6/7] misc: pci_endpoint_test: Populate sriov_configure ops to configure SR-IOV device

2021-03-10 Thread Kishon Vijay Abraham I
Populate sriov_configure ops with pci_sriov_configure_simple to configure SR-IOV device. Signed-off-by: Kishon Vijay Abraham I --- drivers/misc/pci_endpoint_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index

[PATCH v4 5/7] PCI: cadence: Add support to configure virtual functions

2021-03-10 Thread Kishon Vijay Abraham I
Now that support for SR-IOV is added in PCIe endpoint core, add support to configure virtual functions in the Cadence PCIe EP driver. Signed-off-by: Kishon Vijay Abraham I --- .../pci/controller/cadence/pcie-cadence-ep.c | 207 -- drivers/pci/controller/cadence/pcie-cadence.h

[PATCH v4 3/7] PCI: endpoint: Add support to link a physical function to a virtual function

2021-03-10 Thread Kishon Vijay Abraham I
While the physical function has to be linked to endpoint controller, the virtual function has to be linked to a physical function. Add support to link a physical function to a virtual function in pci-ep-cfs. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-ep-cfs.c | 24

[PATCH v4 4/7] PCI: endpoint: Add virtual function number in pci_epc ops

2021-03-10 Thread Kishon Vijay Abraham I
Add virtual function number in pci_epc ops. EPC controller driver can perform virtual function specific initialization based on the virtual function number. Signed-off-by: Kishon Vijay Abraham I --- .../pci/controller/cadence/pcie-cadence-ep.c | 44 +++--- .../pci/controller/dwc/pcie

[PATCH v4 1/7] dt-bindings: PCI: pci-ep: Add binding to specify virtual function

2021-03-10 Thread Kishon Vijay Abraham I
Add binding to specify virtual function (associated with each physical function) in endpoint mode. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pci/pci-ep.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation

[PATCH v4 2/7] PCI: endpoint: Add support to add virtual function in endpoint core

2021-03-10 Thread Kishon Vijay Abraham I
Add support to add virtual function in endpoint core. The virtual function can only be associated with a physical function instead of a endpoint controller. Provide APIs to associate a virtual function with a physical function here. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint

[PATCH v4 0/7] Add SR-IOV support in PCIe Endpoint Core

2021-03-10 Thread Kishon Vijay Abraham I
ttp://lore.kernel.org/r/20191231113534.30405-1-kis...@ti.com [2] -> http://lore.kernel.org/r/20201112175358.2653-1-kis...@ti.com [3] -> https://lore.kernel.org/r/20210305050410.9201-1-kis...@ti.com Kishon Vijay Abraham I (7): dt-bindings: PCI: pci-ep: Add binding to specify virtual function PCI:

[PATCH 3/4] phy: cadence-torrent: Do not configure SERDES if it's already configured

2021-03-10 Thread Kishon Vijay Abraham I
Do not configure torrent SERDES if it's already configured. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-torrent.c | 32 --- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy

[PATCH 2/4] phy: cadence-torrent: Group reset APIs and clock APIs

2021-03-10 Thread Kishon Vijay Abraham I
No functional change intended. Group reset APIs and clock APIs in preparation for adding support to skip configuration if the SERDES is already configured by bootloader. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-torrent.c | 84 ++- 1 file

[PATCH 4/4] phy: cadence-torrent: Explicitly request exclusive reset control

2021-03-10 Thread Kishon Vijay Abraham I
No functional change. Since the reset controls obtained in Torrent is exclusively used by the Torrent device, use exclusive reset control request API calls. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-torrent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 1/4] phy: ti: j721e-wiz: Do not configure wiz if its already configured

2021-03-10 Thread Kishon Vijay Abraham I
if any of the lanes has already been enabled. Signed-off-by: Faiz Abbas Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/ti/phy-j721e-wiz.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c

[PATCH 0/4] j721e-wiz/cadence-torrent: Support to skip SERDES configuration

2021-03-10 Thread Kishon Vijay Abraham I
0-1-kis...@ti.com Faiz Abbas (1): phy: ti: j721e-wiz: Do not configure wiz if its already configured Kishon Vijay Abraham I (3): phy: cadence-torrent: Group reset APIs and clock APIs phy: cadence-torrent: Do not configure SERDES if it's already configured phy: cadence-torrent: Explici

[PATCH v6 11/13] dt-bindings: phy: phy-cadence-sierra: Add binding to model Sierra as clock provider

2021-03-10 Thread Kishon Vijay Abraham I
Add #clock-cells binding to model Sierra as clock provider and include clock IDs for PLL_CMNLC and PLL_CMNLC1. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Rob Herring --- .../bindings/phy/phy-cadence-sierra.yaml| 17 - include/dt-bindings/phy/phy-cadence.h

[PATCH v6 12/13] phy: cadence: phy-cadence-sierra: Model PLL_CMNLC and PLL_CMNLC1 as clocks (mux clocks)

2021-03-10 Thread Kishon Vijay Abraham I
Vijay Abraham I --- drivers/phy/cadence/Kconfig | 1 + drivers/phy/cadence/phy-cadence-sierra.c | 267 ++- 2 files changed, 265 insertions(+), 3 deletions(-) diff --git a/drivers/phy/cadence/Kconfig b/drivers/phy/cadence/Kconfig index 27e9d6c377e5..a62910ff5591

[PATCH v6 13/13] phy: cadence: sierra: Enable pll_cmnlc and pll_cmnlc1 clocks

2021-03-10 Thread Kishon Vijay Abraham I
Get pll_cmnlc and pll_cmnlc1 optional clocks and enable them. This will enable REFRCV/1 in case the pll_cmnlc/1 takes input from REFRCV/1 respectively. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-sierra.c | 40 ++-- 1 file changed, 37 insertions

[PATCH v6 08/13] phy: cadence-torrent: Use a common header file for Cadence SERDES

2021-03-10 Thread Kishon Vijay Abraham I
No functional change. In order to have a single header file for all Cadence SERDES move phy-cadence-torrent.h to phy-cadence.h. This is in preparation for adding Cadence Sierra SERDES specific macros. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-torrent.c

[PATCH v6 09/13] phy: cadence: cadence-sierra: Add array of input clocks in "struct cdns_sierra_phy"

2021-03-10 Thread Kishon Vijay Abraham I
Instead of having separate structure members for each input clock, add an array for the input clocks within "struct cdns_sierra_phy". This is in preparation for adding more input clocks required for supporting additional clock combination. Signed-off-by: Kishon Vijay Abraham I --- d

[PATCH v6 10/13] phy: cadence: cadence-sierra: Add missing clk_disable_unprepare() in .remove callback

2021-03-10 Thread Kishon Vijay Abraham I
commit 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") enabled the clock in probe and failed to disable in remove callback. Add missing clk_disable_unprepare() in cdns_sierra_phy_remove(). Fixes: 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") Signed-off-by:

[PATCH v6 07/13] phy: cadence: cadence-sierra: Explicitly request exclusive reset control

2021-03-10 Thread Kishon Vijay Abraham I
No functional change. Since the reset controls obtained in Sierra is exclusively used by the Sierra device, use exclusive reset control request API calls. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Philipp Zabel --- drivers/phy/cadence/phy-cadence-sierra.c | 4 ++-- 1 file changed, 2

[PATCH v6 05/13] phy: cadence: cadence-sierra: Move all clk_get_*() to a separate function

2021-03-10 Thread Kishon Vijay Abraham I
No functional change. Group all devm_clk_get_optional() to a separate function. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-sierra.c | 57 +++- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence

[PATCH v6 06/13] phy: cadence: cadence-sierra: Move all reset_control_get*() to a separate function

2021-03-10 Thread Kishon Vijay Abraham I
No functional change. Group devm_reset_control_get() and devm_reset_control_get_optional() to a separate function. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Philipp Zabel --- drivers/phy/cadence/phy-cadence-sierra.c | 36 1 file changed, 25 insertions(+), 11

[PATCH v6 02/13] phy: ti: j721e-wiz: Invoke wiz_init() before of_platform_device_create()

2021-03-10 Thread Kishon Vijay Abraham I
wiz_init() immediately before invoking of_platform_device_create(). Fixes: 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC") Signed-off-by: Kishon Vijay Abraham I Cc: # v5.10 --- drivers/phy/ti/phy-j721e-wiz.c | 17 +++-- 1 file

[PATCH v6 03/13] phy: cadence: cadence-sierra: Create PHY only for "phy" or "link" sub-nodes

2021-03-10 Thread Kishon Vijay Abraham I
d device tree) which represent the actual PHY. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-sierra.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index 19f32ae877b9.

[PATCH v6 04/13] phy: ti: j721e-wiz: Get PHY properties only for "phy" or "link" subnode

2021-03-10 Thread Kishon Vijay Abraham I
node's name is "phy" or "link" subnode. Ideally all PHY dt nodes should have node name as "phy", however existing devicetree used "link" as subnode. So in order to maintain old DT compatibility get PHY properties for "phy" or "link" subnod

[PATCH v6 01/13] phy: cadence: Sierra: Fix PHY power_on sequence

2021-03-10 Thread Kishon Vijay Abraham I
re. Fixes: 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I Cc: # v5.4+ Reviewed-by: Philipp Zabel --- drivers/phy/cadence/phy-cadence-sierra.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/phy/cadence/phy

[PATCH v6 00/13] PHY: Add support in Sierra to use external clock

2021-03-10 Thread Kishon Vijay Abraham I
://lore.kernel.org/r/20210308050732.7140-1-kis...@ti.com Kishon Vijay Abraham I (13): phy: cadence: Sierra: Fix PHY power_on sequence phy: ti: j721e-wiz: Invoke wiz_init() before of_platform_device_create() phy: cadence: cadence-sierra: Create PHY only for "phy" or "link&qu

Re: [PATCH v3 0/6] AM64: Add SERDES driver support

2021-03-10 Thread Kishon Vijay Abraham I
Hi, On 10/03/21 5:38 pm, Kishon Vijay Abraham I wrote: > AM64 uses the same SERDES as in J7200, however AM642 EVM doesn't > have a clock generator (unlike J7200 base board). Here the clock from > the SERDES has to be routed to the PCIE connector. This series adds > support to dri

[PATCH v3 6/6] phy: cadence-torrent: Add support to drive refclk out

2021-03-10 Thread Kishon Vijay Abraham I
efclk both in local SERDES and remote device. Add support here to drive refclk out. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/Kconfig | 1 + drivers/phy/cadence/phy-cadence-torrent.c | 188 +- 2 files changed, 186 insertions(+), 3 deletion

[PATCH v3 5/6] phy: ti: j721e-wiz: Enable reference clock output in cmn_refclk_

2021-03-10 Thread Kishon Vijay Abraham I
as a clock, so that platforms like AM642 EVM can enable it. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/ti/phy-j721e-wiz.c | 89 ++ 1 file changed, 89 insertions(+) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index f9299dcdbdb7

[PATCH v3 4/6] phy: ti: j721e-wiz: Model the internal clocks without device tree input

2021-03-10 Thread Kishon Vijay Abraham I
nt DT node and model the clocks within the driver. Model the mux clocks without device tree input for AM64x SoC. Don't remove the earlier design since DT nodes for J7200 and J721e are already upstreamed. [1] -> http://lore.kernel.org/r/20210108025943.ga1790...@robh.at.kernel.org Signed-off-by:

[PATCH v3 3/6] phy: ti: j721e-wiz: Configure full rate divider for AM64

2021-03-10 Thread Kishon Vijay Abraham I
The frequency of the txmclk between PCIe and SERDES has changed to 250MHz from 500MHz. Configure full rate divider for AM64 accordingly. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/ti/phy-j721e-wiz.c | 39 +++--- 1 file changed, 36 insertions(+), 3

[PATCH v3 2/6] phy: ti: j721e-wiz: Delete "clk_div_sel" clk provider during cleanup

2021-03-10 Thread Kishon Vijay Abraham I
j721e-wiz: Add support for WIZ module present in TI J721E SoC") Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/ti/phy-j721e-wiz.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 956a93d96d9b..1a4e09a394a8

[PATCH v3 1/6] phy: ti: j721e-wiz: Remove "regmap_field" from wiz_clk_{mux|div}_sel

2021-03-10 Thread Kishon Vijay Abraham I
wiz_clk_div_sel" and "struct wiz_clk_mux_sel" and make them point to constant data. So far no issues are observed since both these structures are not accessed outside the probe. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/ti/phy-j721e-wiz.c | 75 +++---

  1   2   3   4   5   6   7   8   9   10   >