RE: [PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value

2017-12-25 Thread Lipengcheng
Hi, > -Original Message- > From: Manu Gautam [mailto:mgau...@codeaurora.org] > Sent: Tuesday, December 26, 2017 1:01 PM > To: Lipengcheng; ba...@kernel.org > Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org > Subject: Re

RE: [PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value

2017-12-25 Thread Lipengcheng
Hi, > -Original Message- > From: Manu Gautam [mailto:mgau...@codeaurora.org] > Sent: Tuesday, December 26, 2017 1:01 PM > To: Lipengcheng; ba...@kernel.org > Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org > Subject: Re

[PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value

2017-12-25 Thread Lipengcheng
The value is 4, it can cache four descriptors. When streaming_interval = 1, it can tolerate 500us. Some busy scenes, it may be more than 500us because cpu scheduling is not timely. There will have some problems. It is better set to eight. Signed-off-by: Pengcheng Li ---

[PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value

2017-12-25 Thread Lipengcheng
The value is 4, it can cache four descriptors. When streaming_interval = 1, it can tolerate 500us. Some busy scenes, it may be more than 500us because cpu scheduling is not timely. There will have some problems. It is better set to eight. Signed-off-by: Pengcheng Li ---

[PATCH] usb: dwc3: gadget: decrease the queued_requests in removal

2017-12-24 Thread Lipengcheng
In removal requests, it is necessary to make the corresponding trb disable state (HWO = 1) and dep->queued_requests a corresponding reduction. It is better to use a alone funtion to disable trb (HWO = 0). Signed-off-by: Pengcheng Li --- drivers/usb/dwc3/gadget.c | 30

[PATCH] usb: dwc3: gadget: decrease the queued_requests in removal

2017-12-24 Thread Lipengcheng
In removal requests, it is necessary to make the corresponding trb disable state (HWO = 1) and dep->queued_requests a corresponding reduction. It is better to use a alone funtion to disable trb (HWO = 0). Signed-off-by: Pengcheng Li --- drivers/usb/dwc3/gadget.c | 30

RE: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

2017-12-24 Thread Lipengcheng
Hi, > -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Friday, December 22, 2017 3:54 PM > To: Lipengcheng > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Lipengcheng > Subject: Re: [PATCH] usb: dwc3: gadget:Core consumes a tr

RE: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

2017-12-24 Thread Lipengcheng
Hi, > -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Friday, December 22, 2017 3:54 PM > To: Lipengcheng > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Lipengcheng > Subject: Re: [PATCH] usb: dwc3: gadget:Core consumes a tr

RE: [usb gadget]use dev_kfree_skb_irq instead of dev_kfree_skb

2017-12-22 Thread Lipengcheng
Hi, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, December 22, 2017 3:50 PM > To: Lipengcheng > Cc: ba...@kernel.org; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [usb gadget]use dev_kfree_skb_irq instea

RE: [usb gadget]use dev_kfree_skb_irq instead of dev_kfree_skb

2017-12-22 Thread Lipengcheng
Hi, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, December 22, 2017 3:50 PM > To: Lipengcheng > Cc: ba...@kernel.org; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [usb gadget]use dev_kfree_skb_irq instea

[PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

2017-12-21 Thread Lipengcheng
Iso transmission, the current process is that all trb(HWO=1) is handled. Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin refill trb, this will produce 0 length package, the patch is to achieve the core consumes a trb, and then the software fill a trb. Normally, there will never

[PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

2017-12-21 Thread Lipengcheng
Iso transmission, the current process is that all trb(HWO=1) is handled. Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin refill trb, this will produce 0 length package, the patch is to achieve the core consumes a trb, and then the software fill a trb. Normally, there will never

RE: EHCI

2017-03-17 Thread Lipengcheng
Hi, > -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Saturday, March 18, 2017 12:44 AM > To: Lipengcheng > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: EHCI > > On Fr

RE: EHCI

2017-03-17 Thread Lipengcheng
Hi, > -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Saturday, March 18, 2017 12:44 AM > To: Lipengcheng > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: EHCI > > On Fr

RE: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting

2016-10-21 Thread Lipengcheng
> -Original Message- > From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] > Sent: Monday, October 17, 2016 5:37 PM > To: Lipengcheng; johny...@synopsys.com > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org; Xuej

RE: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting

2016-10-21 Thread Lipengcheng
> -Original Message- > From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] > Sent: Monday, October 17, 2016 5:37 PM > To: Lipengcheng; johny...@synopsys.com > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org; Xuej

RE: USB GADGET: have a question about usb2eth

2016-10-17 Thread Lipengcheng
> -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Monday, October 17, 2016 5:29 PM > To: Lipengcheng; Peter Chen > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: RE: USB GADGET: have a q

RE: USB GADGET: have a question about usb2eth

2016-10-17 Thread Lipengcheng
> -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Monday, October 17, 2016 5:29 PM > To: Lipengcheng; Peter Chen > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: RE: USB GADGET: have a q

RE: USB GADGET: have a question about usb2eth

2016-10-17 Thread Lipengcheng
October 17, 2016 9:56 AM > To: Lipengcheng > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: USB GADGET: have a question about usb2eth > > On Sat, Oct 15, 2016 at 09:19:33AM +, Lipengcheng wrote: >

RE: USB GADGET: have a question about usb2eth

2016-10-17 Thread Lipengcheng
October 17, 2016 9:56 AM > To: Lipengcheng > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: USB GADGET: have a question about usb2eth > > On Sat, Oct 15, 2016 at 09:19:33AM +, Lipengcheng wrote: >

USB GADGET: have a question about usb2eth

2016-10-15 Thread Lipengcheng
Hi, I have a question about usb2eth. In the function gen_ndis_set_resp of the rndis.c, the value of *params->filter may be 0x20 from the pc set command; Howerver the value is used cdc_filter = dev->port_usb->cdc_filter in the function eth_start_xmit of the u_ether.c. If we do not judge

USB GADGET: have a question about usb2eth

2016-10-15 Thread Lipengcheng
Hi, I have a question about usb2eth. In the function gen_ndis_set_resp of the rndis.c, the value of *params->filter may be 0x20 from the pc set command; Howerver the value is used cdc_filter = dev->port_usb->cdc_filter in the function eth_start_xmit of the u_ether.c. If we do not judge

Why is the max_sectors set the 240

2016-09-24 Thread Lipengcheng
Hi, Some special superspeed u3 disk connect xhci control. Then the u3 disk is read/write and has the Transfer error on endpoint (COMP_TX_ERR) error. However in the pc windows does not have the problem.By analysis, the windows is each transfer 64K size. The Linux is 120K size. In the scsiglue.c,

Why is the max_sectors set the 240

2016-09-24 Thread Lipengcheng
Hi, Some special superspeed u3 disk connect xhci control. Then the u3 disk is read/write and has the Transfer error on endpoint (COMP_TX_ERR) error. However in the pc windows does not have the problem.By analysis, the windows is each transfer 64K size. The Linux is 120K size. In the scsiglue.c,

RE: usb device to ether is not identification in 64bit Windows OS

2016-09-18 Thread Lipengcheng
--Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Monday, September 19, 2016 12:46 AM > To: Lipengcheng > Cc: cor...@lwn.net; linux-...@vger.kernel.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject:

RE: usb device to ether is not identification in 64bit Windows OS

2016-09-18 Thread Lipengcheng
--Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Monday, September 19, 2016 12:46 AM > To: Lipengcheng > Cc: cor...@lwn.net; linux-...@vger.kernel.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject:

usb device to ether is not identification in 64bit Windows OS

2016-09-18 Thread Lipengcheng
Hi, kernel version:4.8.0 file:Documentation / usb / linux.inf problem:PC windows is 32bit OS, using Ethernet gadget driver, it can be correct identification. But PC windows is 64bit OS, while modifying linux.inf file LinuxDevice parameters, it can not correct identification, the serial port can

usb device to ether is not identification in 64bit Windows OS

2016-09-18 Thread Lipengcheng
Hi, kernel version:4.8.0 file:Documentation / usb / linux.inf problem:PC windows is 32bit OS, using Ethernet gadget driver, it can be correct identification. But PC windows is 64bit OS, while modifying linux.inf file LinuxDevice parameters, it can not correct identification, the serial port can

RE: [PATCH] [PATCH v3] phy: add phy hisi inno usb2

2016-07-30 Thread Lipengcheng
> -Original Message- > From: Rob Herring [mailto:robh...@kernel.org] > Sent: Monday, July 25, 2016 11:26 PM > To: Lipengcheng > Cc: Kishon Vijay Abraham I; Mark Rutland; linux-kernel@vger.kernel.org; > Xuejiancheng; Lidongpo; Zhangzhenxing (Christian, Device Chip

RE: [PATCH] [PATCH v3] phy: add phy hisi inno usb2

2016-07-30 Thread Lipengcheng
> -Original Message- > From: Rob Herring [mailto:robh...@kernel.org] > Sent: Monday, July 25, 2016 11:26 PM > To: Lipengcheng > Cc: Kishon Vijay Abraham I; Mark Rutland; linux-kernel@vger.kernel.org; > Xuejiancheng; Lidongpo; Zhangzhenxing (Christian, Device Chip

RE: [PATCH] usb:solve resume usb device identification problem

2016-07-12 Thread Lipengcheng
> -Original Message- > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Tuesday, July 12, 2016 10:24 AM > To: Lipengcheng; gre...@linuxfoundation.org; st...@rowland.harvard.edu; > chasemetzge...@gmail.com; mathias.ny...@linux.intel.com; > oneu...@suse.com; ju

RE: [PATCH] usb:solve resume usb device identification problem

2016-07-12 Thread Lipengcheng
> -Original Message- > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Tuesday, July 12, 2016 10:24 AM > To: Lipengcheng; gre...@linuxfoundation.org; st...@rowland.harvard.edu; > chasemetzge...@gmail.com; mathias.ny...@linux.intel.com; > oneu...@suse.com; ju

RE: [PATCH] usb:solve resume usb device identification problem

2016-07-11 Thread Lipengcheng
Hi, > -Original Message- > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Tuesday, July 12, 2016 8:42 AM > To: Lipengcheng; gre...@linuxfoundation.org; st...@rowland.harvard.edu; > chasemetzge...@gmail.com; mathias.ny...@linux.intel.com; > oneu...@suse.com; ju

RE: [PATCH] usb:solve resume usb device identification problem

2016-07-11 Thread Lipengcheng
Hi, > -Original Message- > From: Lu Baolu [mailto:baolu...@linux.intel.com] > Sent: Tuesday, July 12, 2016 8:42 AM > To: Lipengcheng; gre...@linuxfoundation.org; st...@rowland.harvard.edu; > chasemetzge...@gmail.com; mathias.ny...@linux.intel.com; > oneu...@suse.com; ju

RE: [PATCH] usb:solve resume usb device identification problem

2016-07-11 Thread Lipengcheng
Hi, > -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Monday, July 11, 2016 10:51 PM > To: Lipengcheng > Cc: gre...@linuxfoundation.org; baolu...@linux.intel.com; > chasemetzge...@gmail.com; mathias.ny...@linux.intel.com; >

RE: [PATCH] usb:solve resume usb device identification problem

2016-07-11 Thread Lipengcheng
Hi, > -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Monday, July 11, 2016 10:51 PM > To: Lipengcheng > Cc: gre...@linuxfoundation.org; baolu...@linux.intel.com; > chasemetzge...@gmail.com; mathias.ny...@linux.intel.com; >

RE: [PATCH v2] phy: add phy-hisi-inno-usb2

2016-07-06 Thread Lipengcheng
Hi, Kishon I am sorry. Please ignore the patch. The mail received maintainer incomplete and patch version is not correct. I will send the patch again. Thanks, Pengcheng Li > -Original Message- > From: Lipengcheng > Sent: Thursday, July 07, 2016 11:12 AM > To: '

RE: [PATCH v2] phy: add phy-hisi-inno-usb2

2016-07-06 Thread Lipengcheng
Hi, Kishon I am sorry. Please ignore the patch. The mail received maintainer incomplete and patch version is not correct. I will send the patch again. Thanks, Pengcheng Li > -Original Message- > From: Lipengcheng > Sent: Thursday, July 07, 2016 11:12 AM > To: '

RE: [PATCH v2] phy: add phy-hisi-inno-usb2

2016-07-06 Thread Lipengcheng
Hi, Kishon > -Original Message- > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, July 04, 2016 6:59 PM > To: Lipengcheng; linux-kernel@vger.kernel.org; Lidongpo > Subject: Re: [PATCH v2] phy: add phy-hisi-inno-usb2 > > Hi, > > On S

RE: [PATCH v2] phy: add phy-hisi-inno-usb2

2016-07-06 Thread Lipengcheng
Hi, Kishon > -Original Message- > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, July 04, 2016 6:59 PM > To: Lipengcheng; linux-kernel@vger.kernel.org; Lidongpo > Subject: Re: [PATCH v2] phy: add phy-hisi-inno-usb2 > > Hi, > > On S

[PATCH] coresight: etm4x: Add DT implementation.

2016-04-23 Thread lipengcheng
Add DT implementation for A72 board. Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight-etm4x.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c

[PATCH] coresight: etm4x: Add DT implementation.

2016-04-23 Thread lipengcheng
Add DT implementation for A72 board. Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight-etm4x.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c

[PATCH] coresight: etm4x: Add DT implementation.

2016-04-18 Thread lipengcheng
Add DT implementation for A72 and Atermis board. Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight-etm4x.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH] coresight: etm4x: Add DT implementation.

2016-04-18 Thread lipengcheng
Add DT implementation for A72 and Atermis board. Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight-etm4x.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c

[PATCH] coresight: no need to do the forced type conversion

2016-04-13 Thread lipengcheng
activated and enable are already unsigned type, no need to change them to unsigned. Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] coresight: no need to do the forced type conversion

2016-04-13 Thread lipengcheng
activated and enable are already unsigned type, no need to change them to unsigned. Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight.c

[PATCH] coresight: etm4x: modify q_support type

2016-04-13 Thread lipengcheng
Because this operation exceed the range of boolean, so we should modify q_support to unit8 bit. drvdata->q_support = BMVAL(etmidr0, 15, 16) Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight-etm4x.h |

[PATCH] coresight: etm4x: modify q_support type

2016-04-13 Thread lipengcheng
Because this operation exceed the range of boolean, so we should modify q_support to unit8 bit. drvdata->q_support = BMVAL(etmidr0, 15, 16) Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight-etm4x.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] coresight: etm4x: modify q_support type

2016-04-12 Thread lipengcheng
Because this operation exceed the range of boolean, so we should modify q_support to unit32 bit. drvdata->q_support = BMVAL(etmidr0, 15, 16) Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight-etm4x.h |

[PATCH] coresight: etm4x: modify q_support type

2016-04-12 Thread lipengcheng
Because this operation exceed the range of boolean, so we should modify q_support to unit32 bit. drvdata->q_support = BMVAL(etmidr0, 15, 16) Signed-off-by: Li Pengcheng Signed-off-by: Li Zhong --- drivers/hwtracing/coresight/coresight-etm4x.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH RESEND] coresight-etm4x: Change ETM setting.

2016-04-11 Thread lipengcheng (C)
Hi Mathieu, Thanks for your reply, I will modify this patch. Thanks, Li Pengcheng -邮件原件- 发件人: Mathieu Poirier [mailto:mathieu.poir...@linaro.org] 发送时间: 2016年4月9日 1:04 收件人: lipengcheng (C) 抄送: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; Lizhong (lizhong, Hisi

Re: [PATCH RESEND] coresight-etm4x: Change ETM setting.

2016-04-11 Thread lipengcheng (C)
Hi Mathieu, Thanks for your reply, I will modify this patch. Thanks, Li Pengcheng -邮件原件- 发件人: Mathieu Poirier [mailto:mathieu.poir...@linaro.org] 发送时间: 2016年4月9日 1:04 收件人: lipengcheng (C) 抄送: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; Lizhong (lizhong, Hisi

[PATCH RESEND] coresight-etm4x: Change ETM setting.

2016-04-08 Thread lipengcheng
From: Pengcheng Li Force ETM idle acknowleghe when CPU enter WFI. writel_relaxed(0x2, drvdata->base + TRCAUXCTLR); Because linux kernel execute on EL1, so we just need to open EL1 trace,close EL1 trace. drvdata->vinst_ctrl |= BIT(20); Because this operation exceed the

[PATCH RESEND] coresight-etm4x: Change ETM setting.

2016-04-08 Thread lipengcheng
From: Pengcheng Li Force ETM idle acknowleghe when CPU enter WFI. writel_relaxed(0x2, drvdata->base + TRCAUXCTLR); Because linux kernel execute on EL1, so we just need to open EL1 trace,close EL1 trace. drvdata->vinst_ctrl |= BIT(20); Because this operation exceed the range of boolean, so we

[PATCH] coresight-etm4x: Change ETM setting.

2016-04-08 Thread lipengcheng
From: Pengcheng Li Force ETM idle acknowleghe when CPU enter WFI. writel_relaxed(0x2, drvdata->base + TRCAUXCTLR); Because linux kernel execute on EL1,so we just need to open EL1 trace,close EL1 trace. drvdata->vinst_ctrl |= BIT(20); Because this operation exceed the

[PATCH] coresight-etm4x: Change ETM setting.

2016-04-08 Thread lipengcheng
From: Pengcheng Li Force ETM idle acknowleghe when CPU enter WFI. writel_relaxed(0x2, drvdata->base + TRCAUXCTLR); Because linux kernel execute on EL1,so we just need to open EL1 trace,close EL1 trace. drvdata->vinst_ctrl |= BIT(20); Because this operation exceed the range of boolean,so we

[PATCH] Force ETM idle acknowleghe when CPU enter WFI. writel_relaxed(0x2, drvdata->base + TRCAUXCTLR);

2016-04-08 Thread lipengcheng
From: Pengcheng Li Because linux kernel execute on EL1,so we just need to open EL1 trace,close EL1 trace. drvdata->vinst_ctrl |= BIT(20); Because this operation exceed the range of boolean,so we should modify q_support to unit32 bit. drvdata->q_support =

[PATCH] Force ETM idle acknowleghe when CPU enter WFI. writel_relaxed(0x2, drvdata->base + TRCAUXCTLR);

2016-04-08 Thread lipengcheng
From: Pengcheng Li Because linux kernel execute on EL1,so we just need to open EL1 trace,close EL1 trace. drvdata->vinst_ctrl |= BIT(20); Because this operation exceed the range of boolean,so we should modify q_support to unit32 bit. drvdata->q_support = BMVAL(etmidr0, 15, 16) Adding PM