Re: [PATCH v3] module: create weak dependecies

2024-05-14 Thread Lucas De Marchi
behavior as always (keeping backward compatibility) and the information for the 'weak' dependency will not be provided. Signed-off-by: Jose Ignacio Tornos Martinez Reviewed-by: Lucas De Marchi thanks Lucas De Marchi --- V2 -> V3: - Include note about backward compatibility. - Bala

Re: [PATCH v2] module: create weak dependecies

2024-05-09 Thread Lucas De Marchi
ine MODULE_SOFTDEP(_softdep) MODULE_INFO(softdep, _softdep) +/* Weak module dependencies. See man modprobe.d for details. Documentation/process/coding-style.rst section 8 says to balance the /* and */, but up to Luis what he enforces in the module tree. Reviewed-by: Lucas De Marchi Lucas De Mar

Re: [PATCH 0/2] kmod /usr support

2023-12-06 Thread Lucas De Marchi
applied, thanks Lucas De Marchi

Re: [PATCH] kmod: Add FIPS 202 SHA-3 support

2023-12-06 Thread Lucas De Marchi
case NID_sha3_512: + return PKEY_HASH_SHA3_512; with your other patch, libkmod: remove pkcs7 obj_to_hash_algo(), this hunk is not needed anymore. Do you want to send a new version of this patch? thanks Lucas De Marchi default: return -1; } -- 2.34.1

Re: [PATCH kmod] libkmod: remove pkcs7 obj_to_hash_algo()

2023-11-07 Thread Lucas De Marchi
that openssl and kernel know about. For example SHA3 are being added for v6.7 and with this patch are automatically supported. Signed-off-by: Dimitri John Ledkov Applied, thanks Lucas De Marchi

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-10-17 Thread Lucas De Marchi
t;mod-loop-j.ko" + ["test-depmod/detect-loop$MODULE_DIRECTORY/4.4.4/kernel/mod-loop-k.ko"]="mod-loop-k.ko" + ["test-depmod/search-order-external-first$MODULE_DIRECTORY/4.4.4/foo/"]="mod-simple.ko" + ["test-depmod/search-order-external-first$MODULE_DIRECTORY/4.4.4/foobar/"]="mod-simple.ko" ["test-depmod/search-order-external-first/lib/modules/external/"]="mod-simple.ko" why didn't you change it here? - ["test-depmod/search-order-external-last/lib/modules/4.4.4/foo/"]="mod-simple.ko" - ["test-depmod/search-order-external-last/lib/modules/4.4.4/foobar/"]="mod-simple.ko" + ["test-depmod/search-order-external-last$MODULE_DIRECTORY/4.4.4/foo/"]="mod-simple.ko" + ["test-depmod/search-order-external-last$MODULE_DIRECTORY/4.4.4/foobar/"]="mod-simple.ko" ["test-depmod/search-order-external-last/lib/modules/external/"]="mod-simple.ko" and here... Otherwise looks good to me. Pushed the first 4 patches. thanks Lucas De Marchi

Re: [PATCH kmod v5 0/5] kmod /usr support

2023-10-17 Thread Lucas De Marchi
the preferred solution? Lucas De Marchi

[ANNOUNCE] kmod 31

2023-09-29 Thread Lucas De Marchi
x override of `stat` on 32-bit architectures Lucas De Marchi (8): testsuite: Move setup-rootfs logic from Makefile to script testsuite: Handle different sysconfdir libkmod: Do not inititialize file->memory on open libkmod: Extract finit_module vs init_module paths

[ANNOUNCE] kmod 28

2021-01-07 Thread Lucas De Marchi
to configure) - Bug fixes - Ignore ill-formed kernel command line, e.g. with "ivrs_acpihid[00:14.5]=AMD0020:0" option in it - Fix some memory leaks - Fix 0-length builtin.alias.bin: it needs at least the index header Shortlog is below: Lucas De Marchi (17):

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Lucas De Marchi
t;ELK", reg_val); drivers/gpu/drm/i915/gem/i915_gem_stolen.c: * Whether ILK really reuses the ELK register for this is unclear. drivers/gpu/drm/i915/intel_pm.c: * Not 100% sure which way ELK should go here as the drivers/gpu/drm/i915/intel_pm.c: * assume ELK doesn't nee

Re: [PATCH] module: Add more error message for failed kernel module loading

2020-09-01 Thread Lucas De Marchi
On Tue, Sep 1, 2020 at 12:56 PM Prarit Bhargava wrote: > > > > On 9/1/20 2:50 PM, Lucas De Marchi wrote: > > On Sat, Aug 29, 2020 at 4:15 AM Qu Wenruo wrote: > >> > >> When kernel module loading failed, user space only get one of the > >&

Re: [PATCH] module: Add more error message for failed kernel module loading

2020-09-01 Thread Lucas De Marchi
dules: Add kernel parameter to blacklist modules as a way to overcome broken initrd generation afaics. Either kernel command line (using modprobe.blacklist) or /etc/modprobe.d options are honoured by libkmod and allow a sufficiently privileged user to bypass it. +Rusty, +Prarit: is there anything this module parameter is covering that I'm missing? For the changes here, Reviewed-by: Lucas De Marchi thanks Lucas De Marchi > goto free_copy; > } > > -- > 2.27.0 >

Re: [PATCH] depmod: create and use System.map.no_namespaces

2019-10-04 Thread Lucas De Marchi
> [1] > https://lore.kernel.org/linux-modules/20191004094136.166621-1-maenn...@google.com/ > > Reported-by: Stefan Wahren > Fixes: 8651ec01daed ("module: add support for symbol namespaces.") > Cc: Masahiro Yamada > Cc: Lucas De Marchi > Cc: Jessica Yu >

Re: [kmod][PATCH] module: fix error path in kmod_module_probe_insert_module()

2019-05-28 Thread Lucas De Marchi
es"). If you look at the definition of 'enum kmod_probe' you will see that not all flags are returned as positive values - the only values that have this behavior are the ones related to blacklist. Could you rather patch the documentation? thanks Lucas De Marchi

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-16 Thread Lucas De Marchi
r bug, nothing we can do about that :) It's actually not a bug. For external modules it works pretty much as intended. See DEPMOD.D(5): the search directive tells what's the preference among the directories for modules with the same name. depmod respects that order and put the right one into your modules.dep. This allows to put external modules in a different dir and also to make backports of modules from recent to ancient kernels. These modules with the same name are usually the same module, with a different version. Of course what we have here and you are fixing is a different story. Reviewed-by: Lucas De Marchi Lucas De Marchi

Re: [PATCH v2] moduleparam: Save information about built-in modules in separate file

2019-04-18 Thread Lucas De Marchi
ild already produces "modules.order" and "modules.builtin" > files, why not just name it "modules.builtin.modinfo" to keep the I agree with modules.builtin.modinfo > names consistent with what is already there? It clearly conveys that > this file contains modinfo for builtin modules. > > I'll leave it up to Lucas to decide if the file format is OK for kmod. > With the modinfo dump, kmod could then decide what to do with the > information, append to modules.alias{,.bin}, etc. I think it's ok with the current format. It's simple enough. I would delay merging it until the userspace counterpart is implemented though. So to make sure we have everything we need. I can work on that in ~1 or 2 weeks. thanks Lucas De Marchi > > Also, I think this file needs to be documented in > Documentation/kbuild/kbuild.txt. > > Thanks, > > Jessica -- Lucas De Marchi

Re: [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file

2019-03-28 Thread Lucas De Marchi
nd it has almost the same format as the > modules. So I think it will be easier to parse in kmod. adding a modules.builtin.alias with the same format of modules.alias means during modprobe we would only need to load one more file to lookup aliases. That doesn't mean the kernel built system should do it though. The same way it's depmod job to create the modules.alias{,.bin}, we could leave this to depmod if it's in fact useful to split the information. I think your version is simple enough and we would get more information that would be useful for modinfo. It would indeed be nice to output something useful in "modinfo ext4". In kmod, I think we would create modules.builtin.modinfo{,.bin} and just add the aliases to modules.alias{,.bin}, This would keep the names consistent with what is already there. thanks Lucas De Marchi > > -- > Rgrds, legion >

Re: [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file

2019-03-28 Thread Lucas De Marchi
se we don't have parameters for that module always annoyed me. Lucas De Marchi

[ANNOUNCE] kmod 26

2019-02-07 Thread Lucas De Marchi
elhardt (1): kmod: build: cure compiler warnings showing up externally Luca Bruno (1): libkmod-module: check for NULL before accessing pointers Lucas De Marchi (17): testsuite: raise arch image to 3GB man: depmod: remove deprecated -m option mkosi: allow Clear t

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2019-01-29 Thread Lucas De Marchi
t over by > broken SNB BIOSen") > > It seems this was cherry-picked incorrectly :-( while the cherry-pick was correct, the macro is different on drm-intel-fixes. IS_GEN(dev_priv, 6) needs to be converted to IS_GEN6(dev_priv). Lucas De Marc

Re: [PATCH 2/6] module: add support for symbol namespaces.

2018-07-25 Thread Lucas De Marchi
ould do nothing if the symbol doesn't have the suffix. As for dependency on a new version, this seems trivial enough to be backported to previous releases used on distros so even if they are not rolling they would get a compatible depmod. CC'ing linux-modu...@vger.kernel.org to keep track of this the

Re: [PATCH 2/6] module: add support for symbol namespaces.

2018-07-25 Thread Lucas De Marchi
ould do nothing if the symbol doesn't have the suffix. As for dependency on a new version, this seems trivial enough to be backported to previous releases used on distros so even if they are not rolling they would get a compatible depmod. CC'ing linux-modu...@vger.kernel.org to keep track of this the

[ANNOUNCE] kmod 25

2018-01-08 Thread Lucas De Marchi
d override test depmod: module_is_higher_priority: fix modname length calculation Lucas De Marchi (9): test-depmod: avoid warning when we don't have zlib build: add mkosi hooks build: use tool from configure testsuite: generalize mkosi support for other distros

[ANNOUNCE] kmod 25

2018-01-08 Thread Lucas De Marchi
d override test depmod: module_is_higher_priority: fix modname length calculation Lucas De Marchi (9): test-depmod: avoid warning when we don't have zlib build: add mkosi hooks build: use tool from configure testsuite: generalize mkosi support for other distros

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-09-08 Thread Lucas De Marchi
d use it to handle dependencies). For this particular case, not going through the modprobe helper would be a way to accomplish that since you wouldn't need the corresponding binfmt module to run modprobe. Udev handles module loading via libkmod , but the only way to trigger it is via the rules rather than via a request from kernel. Lucas De Marchi

Re: [RFC PATCH] exec: Avoid recursive modprobe for binary format handlers

2017-09-08 Thread Lucas De Marchi
ncies). For this particular case, not going through the modprobe helper would be a way to accomplish that since you wouldn't need the corresponding binfmt module to run modprobe. Udev handles module loading via libkmod , but the only way to trigger it is via the rules rather than via a request from kernel. Lucas De Marchi

Re: [PATCH] libkmod-elf: resolve CRC if module is built with MODULE_REL_CRCS

2017-07-19 Thread Lucas De Marchi
> else > bind = ELF64_ST_BIND(info); > > - a[count].crc = crc; > + a[count].crc = kmod_elf_resolve_crc(elf, crc, shndx); > a[count].bind = kmod_symbol_bind_from_elf(bind); > a[count].symbol = itr; > slen = strlen(name); > -- LGTM. I'll give this a try and apply. Do you think it's possible to build an out-of-tree module with this option so we can add one to the testsuite? Lucas De Marchi

Re: [PATCH] libkmod-elf: resolve CRC if module is built with MODULE_REL_CRCS

2017-07-19 Thread Lucas De Marchi
IND(info); > > - a[count].crc = crc; > + a[count].crc = kmod_elf_resolve_crc(elf, crc, shndx); > a[count].bind = kmod_symbol_bind_from_elf(bind); > a[count].symbol = itr; > slen = strlen(name); > -- LGTM. I'll give this a try and apply. Do you think it's possible to build an out-of-tree module with this option so we can add one to the testsuite? Lucas De Marchi

[ANNOUNCE] kmod 24

2017-02-23 Thread Lucas De Marchi
Shortlog is below Bartosz Golaszewski (1): module: fix a memory leak James Minor (1): libkmod: Fix handling of quotes in kernel command line Lucas De Marchi (15): libkmod: fix use of strcpy util: fix warning of equal values on logical OR testsuite: include stdio.h

[ANNOUNCE] kmod 24

2017-02-23 Thread Lucas De Marchi
Shortlog is below Bartosz Golaszewski (1): module: fix a memory leak James Minor (1): libkmod: Fix handling of quotes in kernel command line Lucas De Marchi (15): libkmod: fix use of strcpy util: fix warning of equal values on logical OR testsuite: include stdio.h

[PATCH v4 0/4] i2c: designware: improve performance for transfers

2016-08-23 Thread Lucas De Marchi
he last patch the bits were changed as suggested by Jarkko. - This is tested on BayTrail and CherryTrail, both of them returning true for "dynamically update TAR" José Roberto de Souza (1): i2c: designware: wait for disable/enable only if necessary Lucas De Marchi (3): i2c:

[PATCH v4 4/4] i2c: designware: do not disable adapter after transfer

2016-08-23 Thread Lucas De Marchi
register reads on 2 slaves: perf stat -r4 chrt -f 10 ./i2c-test /dev/i2c-1 25000 0x40 0x6 0x1e 0x00 Before: 8.638705161 seconds time elapsed ( +- 5.90% ) After: 7.516821591 seconds time elapsed ( +- 0.11% ) Signed-off-by: Lucas De Marchi

[PATCH v4 0/4] i2c: designware: improve performance for transfers

2016-08-23 Thread Lucas De Marchi
is tested on BayTrail and CherryTrail, both of them returning true for "dynamically update TAR" José Roberto de Souza (1): i2c: designware: wait for disable/enable only if necessary Lucas De Marchi (3): i2c: designware: add common functions for locking i2c: designware: detect whe

[PATCH v4 4/4] i2c: designware: do not disable adapter after transfer

2016-08-23 Thread Lucas De Marchi
register reads on 2 slaves: perf stat -r4 chrt -f 10 ./i2c-test /dev/i2c-1 25000 0x40 0x6 0x1e 0x00 Before: 8.638705161 seconds time elapsed ( +- 5.90% ) After: 7.516821591 seconds time elapsed ( +- 0.11% ) Signed-off-by: Lucas De Marchi Signed

[PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

2016-08-23 Thread Lucas De Marchi
After: 8.638705161 seconds time elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza <jose.so...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deleti

[PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

2016-08-23 Thread Lucas De Marchi
elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c

[PATCH v4 3/4] i2c: designware: detect when dynamic tar update is possible

2016-08-23 Thread Lucas De Marchi
it indirectly by writing to the 10BIT_ADDR field in IC_CON: this field is read only when dynamic tar update is enabled. Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Signed-off-by: José Roberto de Souza <jose.so...@intel.com> --- drivers/i2c/busses/i2c-designware

[PATCH v4 2/4] i2c: designware: add common functions for locking

2016-08-23 Thread Lucas De Marchi
These are used in 2 places and will be needed in more. Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/i2c/busses/i2c-designware-core.c | 52 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-desi

[PATCH v4 3/4] i2c: designware: detect when dynamic tar update is possible

2016-08-23 Thread Lucas De Marchi
it indirectly by writing to the 10BIT_ADDR field in IC_CON: this field is read only when dynamic tar update is enabled. Signed-off-by: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/i2c/busses/i2c-designware-core.c | 44 drivers/i2c/busses/i2c

[PATCH v4 2/4] i2c: designware: add common functions for locking

2016-08-23 Thread Lucas De Marchi
These are used in 2 places and will be needed in more. Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 52 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c

[PATCH v3 3/3] i2c: designware: do not disable adapter after transfer

2016-07-28 Thread Lucas De Marchi
register reads on 2 slaves: perf stat -r4 chrt -f 10 ./i2c-test /dev/i2c-1 25000 0x40 0x6 0x1e 0x00 Before: 8.638705161 seconds time elapsed ( +- 5.90% ) After: 7.516821591 seconds time elapsed ( +- 0.11% ) Signed-off-by: Lucas De Marchi

[PATCH v3 3/3] i2c: designware: do not disable adapter after transfer

2016-07-28 Thread Lucas De Marchi
register reads on 2 slaves: perf stat -r4 chrt -f 10 ./i2c-test /dev/i2c-1 25000 0x40 0x6 0x1e 0x00 Before: 8.638705161 seconds time elapsed ( +- 5.90% ) After: 7.516821591 seconds time elapsed ( +- 0.11% ) Signed-off-by: Lucas De Marchi Signed

[PATCH v3 0/3] i2c: designware: improve performance for transfers

2016-07-28 Thread Lucas De Marchi
2c: designware: wait for disable/enable only if necessary Lucas De Marchi (2): i2c: designware: detect when dynamic tar update is possible i2c: designware: do not disable adapter after transfer drivers/i2c/busses/i2c-designware-core.c | 103 +-- drivers/i2c/busses/i

[PATCH v3 0/3] i2c: designware: improve performance for transfers

2016-07-28 Thread Lucas De Marchi
2c: designware: wait for disable/enable only if necessary Lucas De Marchi (2): i2c: designware: detect when dynamic tar update is possible i2c: designware: do not disable adapter after transfer drivers/i2c/busses/i2c-designware-core.c | 103 +-- drivers/i2c/busses/i

[PATCH v3 1/3] i2c: designware: wait for disable/enable only if necessary

2016-07-28 Thread Lucas De Marchi
After: 8.638705161 seconds time elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza <jose.so...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deleti

[PATCH v3 1/3] i2c: designware: wait for disable/enable only if necessary

2016-07-28 Thread Lucas De Marchi
elapsed ( +- 5.90% ) Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c

[PATCH v3 2/3] i2c: designware: detect when dynamic tar update is possible

2016-07-28 Thread Lucas De Marchi
it indirectly by writing to the 10BIT_ADDR field in IC_CON: this field is read only when dynamic tar update is enabled. Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Signed-off-by: José Roberto de Souza <jose.so...@intel.com> --- drivers/i2c/busses/i2c-designware

[PATCH v3 2/3] i2c: designware: detect when dynamic tar update is possible

2016-07-28 Thread Lucas De Marchi
it indirectly by writing to the 10BIT_ADDR field in IC_CON: this field is read only when dynamic tar update is enabled. Signed-off-by: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/i2c/busses/i2c-designware-core.c | 37 ++-- drivers/i2c/busses/i2c

[ANNOUNCE] kmod 23

2016-07-19 Thread Lucas De Marchi
): depmod: Ignore PowerPC64 ABIv2 .TOC. symbol Héctor Orón Martínez (1): kmod: compiling with old sed version (!ERE support) Josh Triplett (1): depmod: Don't insert comment in modules.devname if otherwise empty Lucas De Marchi (8): travis: workaround bug in environment setup

[ANNOUNCE] kmod 23

2016-07-19 Thread Lucas De Marchi
): depmod: Ignore PowerPC64 ABIv2 .TOC. symbol Héctor Orón Martínez (1): kmod: compiling with old sed version (!ERE support) Josh Triplett (1): depmod: Don't insert comment in modules.devname if otherwise empty Lucas De Marchi (8): travis: workaround bug in environment setup

Re: [PATCH] modprobe: install default configuration

2016-06-14 Thread Lucas De Marchi
CC'ing lkml and Rusty to get opinions on this. On Sat, Apr 23, 2016 at 3:18 PM, Lubomir Rintel <lkund...@v3.sk> wrote: > On Wed, 2016-04-13 at 01:11 -0300, Lucas De Marchi wrote: >> On Tue, Mar 29, 2016 at 7:27 AM, Lubomir Rintel <lkund...@v3.sk> >> wrote: >> &

Re: [PATCH] modprobe: install default configuration

2016-06-14 Thread Lucas De Marchi
CC'ing lkml and Rusty to get opinions on this. On Sat, Apr 23, 2016 at 3:18 PM, Lubomir Rintel wrote: > On Wed, 2016-04-13 at 01:11 -0300, Lucas De Marchi wrote: >> On Tue, Mar 29, 2016 at 7:27 AM, Lubomir Rintel >> wrote: >> > >> > On Fri, 2016-03-04 at 0

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-04 Thread Lucas De Marchi
Hi Christian, On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert <christian.rupp...@alitech.com> wrote: > Dear Lucas, > > On 22.04.2016 17:19, Lucas De Marchi wrote: >> CC'ing Christian. >> >> On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi >> <luca

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-05-04 Thread Lucas De Marchi
Hi Christian, On Mon, May 2, 2016 at 7:11 AM, Christian Ruppert wrote: > Dear Lucas, > > On 22.04.2016 17:19, Lucas De Marchi wrote: >> CC'ing Christian. >> >> On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi >> wrote: >>> Disabling the adapter aft

Re: [RFT PATCH] iio: magn: Add support for BMM150 magnetometer

2016-04-27 Thread Lucas De Marchi
, so expect delay on testing this. thanks Lucas De Marchi

Re: [RFT PATCH] iio: magn: Add support for BMM150 magnetometer

2016-04-27 Thread Lucas De Marchi
f it works for you. I don't have yet the BMM150 evaluation > board. It should be available in few weeks. > > I'll just leave this patch here in case anyone steps in to test it. It will take a while for my test board to arrive here, so expect delay on testing this. thanks Lucas De Marchi

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-25 Thread Lucas De Marchi
send an update. Lucas De Marchi

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-25 Thread Lucas De Marchi
send an update. Lucas De Marchi

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
CC'ing Christian. On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi <lucas.demar...@intel.com> wrote: > Disabling the adapter after each transfer is pretty bad for sensors and > other devices doing small transfers at a high rate. It slows down the > transfer rate a lot since ea

Re: [PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
CC'ing Christian. On Fri, Apr 22, 2016 at 12:08 PM, Lucas De Marchi wrote: > Disabling the adapter after each transfer is pretty bad for sensors and > other devices doing small transfers at a high rate. It slows down the > transfer rate a lot since each of them have to wait th

[PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
: i2c-transfer-time -w -a 0x40 -x 6 -n 2 -- 0 0 0xd0 0x07 0 0 0xd0 0x07 0 0 0xd0 0x07 0 0 0xd0 0x07 num_transfers=2 transfer_time_avg=470.256050us Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/i2c/busses/i2c-designware-core.

[PATCH] i2c: designware: do not disable adapter after transfer

2016-04-22 Thread Lucas De Marchi
: i2c-transfer-time -w -a 0x40 -x 6 -n 2 -- 0 0 0xd0 0x07 0 0 0xd0 0x07 0 0 0xd0 0x07 0 0 0xd0 0x07 num_transfers=2 transfer_time_avg=470.256050us Signed-off-by: Lucas De Marchi --- drivers/i2c/busses/i2c-designware-core.c | 48 drivers

Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magny

2016-04-18 Thread Lucas De Marchi
LSM9DS0 just a package of LSM303D and L3GD20 that could reuse the drivers already present? Lucas De Marchi

Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magny

2016-04-18 Thread Lucas De Marchi
of LSM303D and L3GD20 that could reuse the drivers already present? Lucas De Marchi

[PATCH] i2c: designware: do not disable adapter after transfer

2016-03-31 Thread Lucas De Marchi
From: Lucas De Marchi <lucas.demar...@intel.com> Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. It was done in

[PATCH] i2c: designware: do not disable adapter after transfer

2016-03-31 Thread Lucas De Marchi
From: Lucas De Marchi Disabling the adapter after each transfer is pretty bad for sensors and other devices doing small transfers at a high rate. It slows down the transfer rate a lot since each of them have to wait the adapter to be enabled again. It was done in order to avoid the adapter

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Lucas De Marchi
e in a previous version of the patch. I remember it being fixed in the last version (or at least I could not reproduce). I'll test again tomorrow with your script. Lucas De Marchi

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Lucas De Marchi
of the patch. I remember it being fixed in the last version (or at least I could not reproduce). I'll test again tomorrow with your script. Lucas De Marchi

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Lucas De Marchi
r id? Other than that, I tested it on the MinnowBoard Max with a Drone Lure connected and it works fine. thanks Lucas De Marchi

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Lucas De Marchi
n't it be better to use another id? Other than that, I tested it on the MinnowBoard Max with a Drone Lure connected and it works fine. thanks Lucas De Marchi

Re: Duplicated module names

2016-01-29 Thread Lucas De Marchi
Hi! On Fri, Jan 29, 2016 at 3:54 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as module, and t

Re: Duplicated module names

2016-01-29 Thread Lucas De Marchi
Hi! On Fri, Jan 29, 2016 at 3:54 AM, Rusty Russell <ru...@rustcorp.com.au> wrote: > Lucas De Marchi <lucas.de.mar...@gmail.com> writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_

Re: modinfo crc32 broken after fd44a98ae2eb

2016-01-28 Thread Lucas De Marchi
Hi! CC'ing Rusty and mailing lists On Thu, Jan 28, 2016 at 8:40 PM, Samson Yeung wrote: > > On 01/28/2016 11:21 AM, Lucas De Marchi wrote: >> >> Hi Samson, >> >> On Wed, Jan 27, 2016 at 5:32 PM, Samson Yeung >> wrote: >>> >>> Hi all,

Re: modinfo crc32 broken after fd44a98ae2eb

2016-01-28 Thread Lucas De Marchi
Hi! CC'ing Rusty and mailing lists On Thu, Jan 28, 2016 at 8:40 PM, Samson Yeung <samson.ye...@oracle.com> wrote: > > On 01/28/2016 11:21 AM, Lucas De Marchi wrote: >> >> Hi Samson, >> >> On Wed, Jan 27, 2016 at 5:32 PM, Samson Yeung <samson.ye.

Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

2016-01-26 Thread Lucas De Marchi
_DEVICE_TABLE(i2c, ads1015_id); > + > +static struct i2c_driver ads1015_driver = { > + .driver = { > + .name = ADS1015_DRV_NAME, same here, otherwise we will have an i2c:ads1015 alias Lucas De Marchi

Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

2016-01-26 Thread Lucas De Marchi
his be ti-ads1015 so not to clash with the hwmon driver? > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, ads1015_id); > + > +static struct i2c_driver ads1015_driver = { > + .driver = { > + .name = ADS1015_DRV_NAME, same here, otherwise we will have an i2c:ads1015 alias Lucas De Marchi

[ANNOUNCE] kmod 22

2015-11-17 Thread Lucas De Marchi
requirements modprobe: Update error message when path is missing Change default log level depmod: Remove unprinted debug messages depmod: Don't fall back to uname on bad version Lucas De Marchi (4): Add README.md file with build details libkmod-module: fix return code

[ANNOUNCE] kmod 22

2015-11-17 Thread Lucas De Marchi
requirements modprobe: Update error message when path is missing Change default log level depmod: Remove unprinted debug messages depmod: Don't fall back to uname on bad version Lucas De Marchi (4): Add README.md file with build details libkmod-module: fix return code

Re: [PATCH 2/2] pinctrl: baytrail: Serialize all register access

2015-10-30 Thread Lucas De Marchi
rl: baytrail: Use raw_spinlock for locking The ones to Cherryview could be sent too but I couldn't test them. Leaving the patch below for reference. thanks Lucas De Marchi > drivers/pinctrl/intel/pinctrl-baytrail.c | 21 - > 1 file changed, 16 insertions(+), 5 deletions

Re: [PATCH 2/2] pinctrl: baytrail: Serialize all register access

2015-10-30 Thread Lucas De Marchi
tree: 39ce815 pinctrl: baytrail: Serialize all register access 78e1c89 pinctrl: baytrail: Use raw_spinlock for locking The ones to Cherryview could be sent too but I couldn't test them. Leaving the patch below for reference. thanks Lucas De Marchi > drivers/pinctrl/intel/pinctrl-baytrail.c

Re: [PATCH] spi: Force the registration of the spidev devices

2015-07-15 Thread Lucas De Marchi
rtunately) They are still used today for all kind of sensors. Boards like RPi, beaglebone, minnowboard expose the pins so we can actually talk to those sensors, plugging in anyone we'd like to. For some of them for example there are IIO drivers that we could use the driver model to allow bindin

Re: [PATCH] spi: Force the registration of the spidev devices

2015-07-15 Thread Lucas De Marchi
that support that. ACPI doesn't support overlays (yet) so we need to keep awful external platform drivers[1] just to make spidev to work. -- Lucas De Marchi [1] https://github.com/MinnowBoard/minnow-max-extras/blob/master/modules/low-speed-spidev/low-speed-spidev.c -- To unsubscribe from this list: send

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-23 Thread Lucas De Marchi
On Tue, Jun 23, 2015 at 1:45 PM, wrote: > Hello, > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16: >> Mika Westerberg wrote on 10.06. >> 2015 09:07:22: >> > On Tue, Jun 09, 2015 at 03:29:01PM -0300, Lucas De Marchi wrote: >> > > Hi Mika,

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-23 Thread Lucas De Marchi
On Tue, Jun 23, 2015 at 1:45 PM, christian.rupp...@alitech.com wrote: Hello, Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16: Mika Westerberg mika.westerb...@linux.intel.com wrote on 10.06. 2015 09:07:22: On Tue, Jun 09, 2015 at 03:29:01PM -0300, Lucas De Marchi wrote: Hi

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-12 Thread Lucas De Marchi
f (!i_dev->pm_runtime_disabled) >> - i2c_dw_init(i_dev); >> + i2c_dw_enable(i_dev); > > This will not work if the device power gets removed (for example being > put to D3cold) as it looses context. Do you mean we should keep the i2c_dw_init() here?

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-12 Thread Lucas De Marchi
-pm_runtime_disabled) - i2c_dw_init(i_dev); + i2c_dw_enable(i_dev); This will not work if the device power gets removed (for example being put to D3cold) as it looses context. Do you mean we should keep the i2c_dw_init() here? -- Lucas De Marchi -- To unsubscribe from

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-11 Thread Lucas De Marchi
older versions of the > hardware? Mika, do you have any memories about this? I'm not sure if it's a hw bug or if it's just an oversight from previous versions of this driver. So adding a quirk with correct versions will be difficult IMO. We've been only testing this with well behaved slaves. Do yo

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-11 Thread Lucas De Marchi
previous versions of this driver. So adding a quirk with correct versions will be difficult IMO. We've been only testing this with well behaved slaves. Do you have any idea how to test the bad guys? Maybe connecting a slave with a long wire to introduce errors? -- Lucas De Marchi

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-09 Thread Lucas De Marchi
controller keeps its state >> between disable/enable. Change the target address is also allowed. >> >> So, this patch replaces the initialization on module resume with a >> simple enable, and removes the (non required anymore) enables and >> disables. >> &

Re: [PATCH] i2c: designware: use enable on resume instead initialization

2015-06-09 Thread Lucas De Marchi
...@intel.com Signed-off-by: Lucas De Marchi lucas.demar...@intel.com --- These pictures explain a little more the consequence of letting the enable+disable in the code: http://pub.politreco.com/paste/TEK0011-before.jpg http://pub.politreco.com/paste/TEK0007-after.jpg The yellow

[ANNOUNCE] kmod 21

2015-06-08 Thread Lucas De Marchi
ed by "make check". No changes to the tests are needed and all of them can run fine. Shortlog: Lucas De Marchi (12): build: use dolt build: sync dolt with upstream util: use UINT64_MAX build: cache modules from playground tools: Hide new

Re: [PATCH kmod 3/3] tools: display features together with version information

2015-06-08 Thread Lucas De Marchi
On Sun, Jun 7, 2015 at 6:17 AM, Andreas Mohr wrote: > Hi, > > On Sun, Jun 07, 2015 at 03:27:29AM -0300, lucas.de.mar...@gmail.com wrote: >> From: Lucas De Marchi >> diff --git a/tools/kmod.c b/tools/kmod.c >> index c9d2cc8..28217df 100644 >> --- a/tools/kmod.c &

Re: [PATCH kmod 0/3] Add feature list together with version

2015-06-08 Thread Lucas De Marchi
On Sun, Jun 7, 2015 at 6:25 AM, Andreas Mohr wrote: > Hi, > > On Sun, Jun 07, 2015 at 03:27:26AM -0300, lucas.de.mar...@gmail.com wrote: >> From: Lucas De Marchi >> >> Sample output: >> >> $ ./tools/kmod --version >> kmod version 20 >> +XZ +

[PATCH] i2c: designware: use enable on resume instead initialization

2015-06-08 Thread lucas . de . marchi
, and removes the (non required anymore) enables and disables. Signed-off-by: Fabio Mello Signed-off-by: Lucas De Marchi --- These pictures explain a little more the consequence of letting the enable+disable in the code: http://pub.politreco.com/paste/TEK0011-before.jpg http

[PATCH] i2c: designware: use enable on resume instead initialization

2015-06-08 Thread lucas . de . marchi
with a simple enable, and removes the (non required anymore) enables and disables. Signed-off-by: Fabio Mello fabio.me...@intel.com Signed-off-by: Lucas De Marchi lucas.demar...@intel.com --- These pictures explain a little more the consequence of letting the enable+disable in the code: http

Re: [PATCH kmod 3/3] tools: display features together with version information

2015-06-08 Thread Lucas De Marchi
On Sun, Jun 7, 2015 at 6:17 AM, Andreas Mohr a...@lisas.de wrote: Hi, On Sun, Jun 07, 2015 at 03:27:29AM -0300, lucas.de.mar...@gmail.com wrote: From: Lucas De Marchi lucas.demar...@intel.com diff --git a/tools/kmod.c b/tools/kmod.c index c9d2cc8..28217df 100644 --- a/tools/kmod.c +++ b

Re: [PATCH kmod 0/3] Add feature list together with version

2015-06-08 Thread Lucas De Marchi
On Sun, Jun 7, 2015 at 6:25 AM, Andreas Mohr a...@lisas.de wrote: Hi, On Sun, Jun 07, 2015 at 03:27:26AM -0300, lucas.de.mar...@gmail.com wrote: From: Lucas De Marchi lucas.demar...@intel.com Sample output: $ ./tools/kmod --version kmod version 20 +XZ +ZLIB -EXPERIMENTAL Thank you

[ANNOUNCE] kmod 21

2015-06-08 Thread Lucas De Marchi
are needed and all of them can run fine. Shortlog: Lucas De Marchi lucas.demar...@intel.com (12): build: use dolt build: sync dolt with upstream util: use UINT64_MAX build: cache modules from playground tools: Hide new commands behind experimental flag

[PATCH kmod 0/3] Add feature list together with version

2015-06-07 Thread lucas . de . marchi
From: Lucas De Marchi Sample output: $ ./tools/kmod --version kmod version 20 +XZ +ZLIB -EXPERIMENTAL Lucas De Marchi (3): build: add function to build string of features build: add relevant features to KMOD_FEATURES in config.h tools: display features together with version information

[PATCH kmod 2/3] build: add relevant features to KMOD_FEATURES in config.h

2015-06-07 Thread lucas . de . marchi
From: Lucas De Marchi Not all the features (i.e. those available in --enable-* or --with-*) are really relevant to the final user. Create a KMOD_FEATURES definition in config.h containing these features. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b

  1   2   3   4   >