Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-30 Thread Lukasz Stelmach
It was <2021-03-30 wto 02:02>, when Alexandre Belloni wrote: > On 16/03/2021 19:04:14+0100, Lukasz Stelmach wrote: >> OK, you are right. The problem seems to be elsewhere. >> >> How about this scnario? We call rtc_update_irq_enable(). We read rtc >> with __rtc_re

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-16 Thread Lukasz Stelmach
It was <2021-03-16 wto 13:32>, when Alexandre Belloni wrote: > On 16/03/2021 13:12:08+0100, Lukasz Stelmach wrote: >> It was <2021-03-15 pon 23:01>, when Alexandre Belloni wrote: >> > Hello, >> > >> > On 05/03/2021 18:44:11+0100, Łukasz Stelmach

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-16 Thread Lukasz Stelmach
It was <2021-03-15 pon 23:01>, when Alexandre Belloni wrote: > Hello, > > On 05/03/2021 18:44:11+0100, Łukasz Stelmach wrote: >> For an RTC without an IRQ assigned rtc_update_irq_enable() should >> return -EINVAL. It will, when uie_unsupported is set. >> > > I'm surprised this is an issue

Re: [PATCH v10 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-01-20 Thread Lukasz Stelmach
It was <2021-01-15 pią 17:27>, when Jakub Kicinski wrote: > On Wed, 13 Jan 2021 19:40:28 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The

Re: [PATCH v9 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-17 Thread Lukasz Stelmach
It was <2020-12-17 czw 11:08>, when Jakub Kicinski wrote: > On Thu, 17 Dec 2020 12:53:30 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-17 Thread Lukasz Stelmach
It was <2020-12-16 śro 08:13>, when Jakub Kicinski wrote: > On Wed, 16 Dec 2020 13:21:52 +0100 Lukasz Stelmach wrote: >> So, the only thing that's left is pskb_expand_head(). I need to wrap my >> head around it. Can you tell me how a cloned skb is different and why >> t

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-16 Thread Lukasz Stelmach
It was <2020-12-15 wto 17:46>, when Jakub Kicinski wrote: > On Wed, 16 Dec 2020 01:42:03 +0100 Lukasz Stelmach wrote: >>>> + ax_local->stats.rx_packets++; >>>> + ax_local->stats.rx_bytes += skb->len; >>>> + skb->dev = ndev; >&g

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-15 Thread Lukasz Stelmach
It was <2020-12-04 pią 19:37>, when Jakub Kicinski wrote: > On Wed, 2 Dec 2020 22:47:09 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> Before

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Lukasz Stelmach
It was <2020-12-02 śro 09:18>, when Jakub Kicinski wrote: > On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote: >> >> + status = netif_rx(skb); >> > >> > If I'm reading things right this is in process context, so netif_rx_ni() >>

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Lukasz Stelmach
It was <2020-11-25 śro 13:26>, when Jakub Kicinski wrote: > On Tue, 24 Nov 2020 13:03:30 +0100 Łukasz Stelmach wrote: >> +static int >> +ax88796c_start_xmit(struct sk_buff *skb, struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> + >> +

Re: [PATCH v2] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-12-02 Thread Lukasz Stelmach
nced. I remove err_clock label at the same. > > Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") > Reported-by: Hulk Robot > Suggested-by: Lukasz Stelmach > Signed-off-by: Qinglang Miao > --- > v2: remobe useless label as

Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe

2020-11-27 Thread Lukasz Stelmach
It was <2020-11-27 pią 17:44>, when Qinglang Miao wrote: > pm_runtime_get_sync will increment pm usage counter even it > failed. Forgetting to putting operation will result in a > reference leak here. > > A new function pm_runtime_resume_and_get is introduced in > [0] to keep usage counter

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-24 Thread Lukasz Stelmach
It was <2020-11-24 wto 13:17>, when Krzysztof Kozlowski wrote: > On Tue, Nov 24, 2020 at 01:03:30PM +0100, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection.

Re: [PATCH v6 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-16 Thread Lukasz Stelmach
It was <2020-11-13 pią 12:35>, when Jakub Kicinski wrote: > On Thu, 12 Nov 2020 12:51:04 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The

Re: [PATCH v8 3/6] software node: implement reference properties

2020-11-09 Thread Lukasz Stelmach
It was <2020-11-09 pon 10:53>, when Dmitry Torokhov wrote: > On Mon, Nov 09, 2020 at 07:18:37PM +0100, Lukasz Stelmach wrote: >> It was <2020-11-09 pon 19:24>, when Andy Shevchenko wrote: >> > On Mon, Nov 09, 2020 at 06:02:29PM +0100, Lukasz Stelmach wrote: >

Re: [PATCH v8 3/6] software node: implement reference properties

2020-11-09 Thread Lukasz Stelmach
It was <2020-11-09 pon 21:02>, when Andy Shevchenko wrote: > On Mon, Nov 09, 2020 at 07:18:37PM +0100, Lukasz Stelmach wrote: >> It was <2020-11-09 pon 19:24>, when Andy Shevchenko wrote: >> > On Mon, Nov 09, 2020 at 06:02:29PM +0100, Lukasz Stelmach wrote: >

Re: [PATCH v8 3/6] software node: implement reference properties

2020-11-09 Thread Lukasz Stelmach
It was <2020-11-09 pon 19:24>, when Andy Shevchenko wrote: > On Mon, Nov 09, 2020 at 06:02:29PM +0100, Lukasz Stelmach wrote: >> It was <2019-11-07 czw 20:22>, when Dmitry Torokhov wrote: >> > It is possible to store references to software nodes in the same fashion a

Re: [PATCH v8 3/6] software node: implement reference properties

2020-11-09 Thread Lukasz Stelmach
It was <2019-11-07 czw 20:22>, when Dmitry Torokhov wrote: > It is possible to store references to software nodes in the same fashion as > other static properties, so that users do not need to define separate > structures: > > static const struct software_node gpio_bank_b_node = { > .name =

Re: [PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-04 Thread Lukasz Stelmach
It was <2020-11-04 śro 03:42>, when Andrew Lunn wrote: >> +config SPI_AX88796C_COMPRESSION >> +bool "SPI transfer compression" >> +default n >> +depends on SPI_AX88796C >> +help >> + Say Y here to enable SPI transfer compression. It saves up >> + to 24 dummy cycles during

[BUG] ax88179_178a - broken hw checksumming after resume

2020-11-03 Thread Lukasz Stelmach
Hi, I've got a generic AX88179 based USB ethernet interface and I am experiencing a following problem. + After resuming from suspend + hw tx-checksuming doesn't work + for UDP packets. I've got an RPi4 on the other end of the cable. To test the connection I use the following commands

Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3

2020-11-03 Thread Lukasz Stelmach
It was <2020-11-03 wto 17:36>, when Krzysztof Kozlowski wrote: > On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote: >> Create ethernet alias > > Your commit msg should explain why. > OK. (And a separate patch - ack) >> and assign appropriate compatible properties. > > Then what

Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

2020-11-03 Thread Lukasz Stelmach
It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote: > On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote: >> Add Ethernet interface description for Odroid X/X2. >> >> Signed-off-by: Łukasz Stelmach >> --- >> arch/arm/boot/dts/exynos4412-odroidx.dts | 28

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 18:27>, when Marc Kleine-Budde wrote: > On 10/28/20 10:40 PM, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 01:31>, when Andrew Lunn wrote: > > Reverse christmass tree > >> + >> +static int ax88796c_process_isr(struct ax88796c_device *ax_local) >> +{ >> +u16 isr; >> +u8 done = 0; >> +struct net_device *ndev = ax_local->ndev; > > ... > >> +static irqreturn_t

Re: [PATCH v4 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 18:06>, when Marc Kleine-Budde wrote: > On 10/28/20 10:40 PM, Łukasz Stelmach wrote: >> Add bindings for AX88796C SPI Ethernet Adapter. >> >> Signed-off-by: Łukasz Stelmach >> --- >> .../bindings/net/asix,ax88796c.yaml | 69 +++ >> 1 file

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 01:31>, when Andrew Lunn wrote: >> +static void >> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs, void >> *_p) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> +u16 *p = _p; >> +int offset, i; > > You missed a

Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-23 Thread Lukasz Stelmach
It was <2020-10-23 pią 18:27>, when Krzysztof Kozlowski wrote: > On Fri, 23 Oct 2020 at 18:05, Rob Herring wrote: >> >> On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote: >> > Add bindings for AX88796C SPI Ethernet Adapter. >> > >> > Signed-off-by: Łukasz Stelmach >> > --- >> >

Re: [PATCH] checkpatch: ignore ethtool CamelCase constants

2020-10-22 Thread Lukasz Stelmach
It was <2020-10-22 czw 04:57>, when Joe Perches wrote: > On Thu, 2020-10-22 at 13:01 +0200, Łukasz Stelmach wrote: >> Ignore CamelCase constants describing Ethernet link parameters defined >> in include/uapi/linux/ethtool.h. > [] >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > []

Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-22 Thread Lukasz Stelmach
It was <2020-10-22 czw 09:15>, when Marek Szyprowski wrote: > On 21.10.2020 23:49, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has been

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-19 Thread Lukasz Stelmach
It was <2020-10-02 pią 22:36>, when Andrew Lunn wrote: >> +static int >> +ax88796c_open(struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> +int ret; >> +unsigned long irq_flag = IRQF_SHARED; >> + >> +mutex_lock(_local->spi_lock); >> +

Re: [PATCH v2] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-16 Thread Lukasz Stelmach
It was <2020-10-16 pią 20:09>, when Andrew Lunn wrote: > On Thu, Oct 15, 2020 at 10:44:35AM +0200, Łukasz Stelmach wrote: >> Do not report advertised link modes (local and remote) when >> autonegotiation is turned off. mii_ethtool_get_link_ksettings() exhibits >> the same behaviour and this patch

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-16 Thread Lukasz Stelmach
It was <2020-10-16 pią 20:01>, when Andrew Lunn wrote: >> >> +static void >> >> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs, >> >> void *_p) >> >> +{ >> >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> >> + u16 *p = _p; >> >> + int offset, i; >> >> +

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Lukasz Stelmach
It was <2020-10-14 śro 23:04>, when Russell King - ARM Linux admin wrote: > On Wed, Oct 14, 2020 at 04:39:47PM +0200, Lukasz Stelmach wrote: >> It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: >> > In any case, the mii.c code does fil

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Lukasz Stelmach
It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: > On Wed, Oct 14, 2020 at 02:56:50PM +0200, Łukasz Stelmach wrote: >> Do not report advertised link modes when autonegotiation is turned >> off. mii_ethtool_get_link_ksettings() exhibits the same behaviour. > > Please

Re: [PATCH v2 2/2] x86: kexec_file: print appropriate variable

2020-10-13 Thread Lukasz Stelmach
It was <2020-04-30 czw 18:31>, when Łukasz Stelmach wrote: > The value of kbuf->memsz may be different than kbuf->bufsz after calling > kexec_add_buffer(). Hence both values should be logged. > > Fixes: ec2b9bfaac44e ("kexec_file: Change kexec_add_buffer to take kexec_buf > as argument.") >

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-13 Thread Lukasz Stelmach
It was <2020-10-02 pią 22:36>, when Andrew Lunn wrote: >> +static u32 ax88796c_get_link(struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> + >> +mutex_lock(_local->spi_lock); >> + >> +phy_read_status(ndev->phydev); >> + >> +

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-13 Thread Lukasz Stelmach
It was <2020-10-03 sob 14:59>, when Heiner Kallweit wrote: > On 02.10.2020 21:22, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has been

Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-06 wto 12:17>, when Krzysztof Kozlowski wrote: > On Tue, 6 Oct 2020 at 12:06, Lukasz Stelmach wrote: >> It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote: >>> On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: >>>>

Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote: > On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach wrote: >> >> Add node for ax88796c ethernet chip. >> >> Signed-off-by: Łukasz Stelmach >> --- >> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 >> 1 file

Re: [PATCH v2 0/4] AX88796C SPI Ethernet Adapter

2020-10-06 Thread Lukasz Stelmach
It was <2020-10-02 pią 21:45>, when Andrew Lunn wrote: > On Fri, Oct 02, 2020 at 09:22:06PM +0200, Łukasz Stelmach wrote: >> This is a driver for AX88796C Ethernet Adapter connected in SPI mode as >> found on ARTIK5 evaluation board. The driver has been ported from a >> v3.10.9 vendor kernel for

Re: [PATCH v2 RESEND 2/9] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250

2020-10-02 Thread Lukasz Stelmach
It was <2020-10-01 czw 21:04>, when Krzysztof Kozlowski wrote: > On Thu, Oct 01, 2020 at 05:21:41PM +0200, Łukasz Stelmach wrote: >> Fix issues with DMA transfers bigger than 512 bytes on Exynos3250. Without >> the patches such transfers fail. >> >> The vendor kernel for ARTIK5 handles CS in a

Re: [PATCH v2 RESEND 0/9] Some fixes for spi-s3c64xx

2020-10-01 Thread Lukasz Stelmach
It was <2020-10-01 czw 17:13>, when Mark Brown wrote: > On Thu, Oct 01, 2020 at 05:21:39PM +0200, Łukasz Stelmach wrote: >> This is a series of fixes created during porting a device driver (these >> patches will be released soon too) for an SPI device to the current kernel. > > There appeared to

Re: [PATCH] ARM: dts: exynos: Add a placeholder for a MAC address

2020-10-01 Thread Lukasz Stelmach
It was <2020-10-01 czw 11:16>, when Krzysztof Kozlowski wrote: > On Thu, 1 Oct 2020 at 10:36, Lukasz Stelmach wrote: >> >> It was <2020-10-01 czw 09:22>, when Krzysztof Kozlowski wrote: >> > On Wed, Sep 30, 2020 at 04:31:51PM +0200, Łukasz Stelmach wrote: >&

Re: [PATCH] ARM: dts: exynos: Add a placeholder for a MAC address

2020-10-01 Thread Lukasz Stelmach
It was <2020-10-01 czw 09:22>, when Krzysztof Kozlowski wrote: > On Wed, Sep 30, 2020 at 04:31:51PM +0200, Łukasz Stelmach wrote: >> Add a placeholder for a MAC address. A bootloader may fill it >> to set the MAC address and override EEPROM settings. >> >> Signed-off-by: Łukasz Stelmach >> ---

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-08 Thread Lukasz Stelmach
It was <2020-09-07 pon 20:18>, when Andrew Lunn wrote: >> > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >> >> +++ b/drivers/net/ethernet/asix/ax88796c_ioctl.c >> > >> > This is an odd filename. The ioctl code is wrong anyway, but there is >> > a lot more than ioctl in here. I

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-07 Thread Lukasz Stelmach
It was <2020-08-26 śro 15:06>, when David Laight wrote: > From: Lukasz Stelmach >> Sent: 26 August 2020 15:59 >> >> It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote: >> > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-07 Thread Lukasz Stelmach
It was <2020-08-26 śro 09:13>, when Geert Uytterhoeven wrote: > On Tue, Aug 25, 2020 at 8:02 PM Andrew Lunn wrote: >> On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >> > + if (netif_msg_pktdata(ax_local)) { >> > + int loop; >> > + netdev_info(ndev,

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-07 Thread Lukasz Stelmach
It was <2020-08-25 wto 20:01>, when Andrew Lunn wrote: > Hi Łukasz > > It is pretty clear this is a "vendor crap driver". I can't deny. > It needs quite a bit more work on it. I'll be more than happy to take your suggestions. > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote:

Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values

2020-09-03 Thread Lukasz Stelmach
It was <2020-09-02 śro 10:14>, when Sylwester Nawrocki wrote: > On 9/1/20 17:21, Lukasz Stelmach wrote: >> It was <2020-08-25 wto 21:06>, when Sylwester Nawrocki wrote: >>> On 8/21/20 18:13, Łukasz Stelmach wrote: >>>> Check return valu

Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values

2020-09-01 Thread Lukasz Stelmach
It was <2020-08-25 wto 21:06>, when Sylwester Nawrocki wrote: > On 8/21/20 18:13, Łukasz Stelmach wrote: >> Check return values in prepare_dma() and s3c64xx_spi_config() and >> propagate errors upwards. >> >> Signed-off-by: Łukasz Stelmach >> --- >> drivers/spi/spi-s3c64xx.c | 47

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-08-26 Thread Lukasz Stelmach
It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote: > On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection.

Re: [PATCH 3/3] ARM: defconfig: Enable ax88796c driver

2020-08-25 Thread Lukasz Stelmach
It was <2020-08-25 wto 20:51>, when Krzysztof Kozlowski wrote: > On Tue, Aug 25, 2020 at 07:03:11PM +0200, Łukasz Stelmach wrote: >> Enable ax88796c driver for the ethernet chip on Exynos3250-based >> ARTIK5 boards. >> >> Signed-off-by: Łukasz Stelmach >> --- >>

Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-08-25 Thread Lukasz Stelmach
It was <2020-08-25 wto 10:19>, when Randy Dunlap wrote: > On 8/25/20 10:03 AM, Łukasz Stelmach wrote: >> diff --git a/drivers/net/ethernet/asix/Kconfig >> b/drivers/net/ethernet/asix/Kconfig >> new file mode 100644 >> index ..4b127a4a659a >> --- /dev/null >> +++

Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value

2020-08-25 Thread Lukasz Stelmach
It was <2020-08-25 wto 17:11>, when Tomasz Figa wrote: > On Tue, Aug 25, 2020 at 11:02 AM Lukasz Stelmach > wrote: >> >> It was <2020-08-24 pon 15:21>, when Tomasz Figa wrote: >> > On Mon, Aug 24, 2020 at 3:17 PM Lukasz Stelmach >> > wrote:

Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value

2020-08-25 Thread Lukasz Stelmach
It was <2020-08-24 pon 15:21>, when Tomasz Figa wrote: > On Mon, Aug 24, 2020 at 3:17 PM Lukasz Stelmach > wrote: >> >> It was <2020-08-22 sob 14:43>, when Krzysztof Kozlowski wrote: >> > On Fri, Aug 21, 2020 at 06:13:59PM +0200, Łukasz Stelmach wrot

Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value

2020-08-24 Thread Lukasz Stelmach
It was <2020-08-22 sob 14:43>, when Krzysztof Kozlowski wrote: > On Fri, Aug 21, 2020 at 06:13:59PM +0200, Łukasz Stelmach wrote: >> cur_speed is used to calculate transfer timeout and needs to be >> set to the actual value of (half) the clock speed for precise >> calculations. > > If you need

Re: [PATCH 1/8] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath()

2020-08-20 Thread Lukasz Stelmach
It was <2020-08-19 śro 20:12>, when Mark Brown wrote: > On Wed, Aug 19, 2020 at 04:01:52PM +0200, Lukasz Stelmach wrote: >> It was <2020-08-19 śro 14:16>, when Mark Brown wrote: >>> On Wed, Aug 19, 2020 at 02:58:22PM +0200, Krzysztof Kozlowski wrote: >>>>

Re: [PATCH 2/8] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250

2020-08-20 Thread Lukasz Stelmach
It was <2020-08-19 śro 20:38>, when Mark Brown wrote: > On Wed, Aug 19, 2020 at 03:01:21PM +0200, Lukasz Stelmach wrote: >> It was <2020-08-19 śro 14:39>, when Krzysztof Kozlowski wrote: > >>> There is here no commit msg, no explanation. > >> As I wr

Re: [PATCH 6/8] spi: spi-s3c64xx: Check return values

2020-08-19 Thread Lukasz Stelmach
It was <2020-08-19 śro 14:48>, when Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 02:32:06PM +0200, Łukasz Stelmach wrote: >> Signed-off-by: Łukasz Stelmach >> --- >> drivers/spi/spi-s3c64xx.c | 12 >> 1 file changed, 12 insertions(+) > > Oh, come on, stop fixing the same

Re: [PATCH 1/8] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath()

2020-08-19 Thread Lukasz Stelmach
It was <2020-08-19 śro 14:16>, when Mark Brown wrote: > On Wed, Aug 19, 2020 at 02:58:22PM +0200, Krzysztof Kozlowski wrote: >> On Wed, Aug 19, 2020 at 02:51:27PM +0200, Lukasz Stelmach wrote: > >> > Honestly, I don't know and I couldn't find out why. It makes stuf

Re: [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout

2020-08-19 Thread Lukasz Stelmach
It was <2020-08-19 śro 14:49>, when Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 02:32:07PM +0200, Łukasz Stelmach wrote: >> Signed-off-by: Łukasz Stelmach > > Why? Everything works fine and suddenly minimum timeout is 100 ms? Actually I am not 100% sure the max() call is required, maybe

Re: [PATCH 8/8] spi: spi-s3c64xx: Turn on interrupts upon resume

2020-08-19 Thread Lukasz Stelmach
It was <2020-08-19 śro 14:53>, when Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 02:32:08PM +0200, Łukasz Stelmach wrote: >> Signed-off-by: Łukasz Stelmach >> --- >> drivers/spi/spi-s3c64xx.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/spi/spi-s3c64xx.c

Re: [PATCH 5/8] spi: spi-s3c64xx: Fix doc comment for struct s3c64xx_spi_driver_data

2020-08-19 Thread Lukasz Stelmach
It was <2020-08-19 śro 14:37>, when Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 02:32:05PM +0200, Łukasz Stelmach wrote: >> Signed-off-by: Łukasz Stelmach > > Hi, > > Missing commit msg - fix what exactly? > > You need to rebase your patch as most of these were already fixed by Lee >

Re: [PATCH 2/8] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250

2020-08-19 Thread Lukasz Stelmach
It was <2020-08-19 śro 14:39>, when Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 02:32:02PM +0200, Łukasz Stelmach wrote: >> Signed-off-by: Łukasz Stelmach > > Add a quirk - why? Because stuff does not work without it and works with it and it is turned on for other SoCs which have

Re: [PATCH 1/8] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath()

2020-08-19 Thread Lukasz Stelmach
It was <2020-08-19 śro 14:38>, when Krzysztof Kozlowski wrote: > On Wed, Aug 19, 2020 at 02:32:01PM +0200, Łukasz Stelmach wrote: >> Fix issues with DMA transfers bigger than 512 on Exynos3250. > > Fix, but how? With proper explanation this should go to CC-stable. Honestly, I don't know and I

Re: [PATCH 16/23] initramfs: simplify clean_rootfs

2020-07-23 Thread Lukasz Stelmach
It was <2020-07-23 czw 11:22>, when Christoph Hellwig wrote: > On Sat, Jul 18, 2020 at 12:00:35PM +0200, Christoph Hellwig wrote: >> On Fri, Jul 17, 2020 at 10:55:48PM +0200, Marek Szyprowski wrote: >>> On 14.07.2020 21:04, Christoph Hellwig wrote: Just use d_genocide instead of iterating

Re: [PATCH] char: hw_random: Fix a reference count leak.

2020-06-15 Thread Lukasz Stelmach
It was <2020-06-13 sob 16:41>, when wu000...@umn.edu wrote: > From: Qiushi Wu > > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count if pm_runtime_put_sync is not > called in error handling paths. Thus replace the jump target > "err_pm_get"

Re: [PATCH 3/5] arm: decompressor: define a new zImage tag

2020-06-02 Thread Lukasz Stelmach
It was <2020-06-01 pon 21:41>, when Russell King - ARM Linux admin wrote: > On Mon, Jun 01, 2020 at 10:27:45PM +0200, Lukasz Stelmach wrote: >> It was <2020-06-01 pon 19:25>, when Russell King - ARM Linux admin wrote: >>> On Mon, Jun 01, 2020 at 06:19:52P

Re: [PATCH 3/5] arm: decompressor: define a new zImage tag

2020-06-01 Thread Lukasz Stelmach
It was <2020-06-01 pon 19:25>, when Russell King - ARM Linux admin wrote: > On Mon, Jun 01, 2020 at 06:19:52PM +0200, Lukasz Stelmach wrote: >> It was <2020-06-01 pon 15:55>, when Russell King - ARM Linux admin wrote: >> > On Mon, Jun 01, 2020 at 04:27:52PM +0200, Łu

Re: [PATCH 5/5] arm: kexec_file: load zImage or uImage, initrd and dtb

2020-06-01 Thread Lukasz Stelmach
It was <2020-06-01 pon 16:07>, when Russell King - ARM Linux admin wrote: > On Mon, Jun 01, 2020 at 04:27:54PM +0200, Łukasz Stelmach wrote: >> This is kexec_file_load implementation for ARM. It loads zImage and >> initrd from file descripters and resuses DTB. >> >> Most code is derived from

Re: [PATCH 1/5] arm: decompressor: set malloc pool size for the decompressor

2020-06-01 Thread Lukasz Stelmach
It was <2020-06-01 pon 16:10>, when Russell King - ARM Linux admin wrote: > On Mon, Jun 01, 2020 at 04:56:40PM +0200, Lukasz Stelmach wrote: >> It was <2020-06-01 pon 15:46>, when Russell King - ARM Linux admin wrote: >> > On Mon, Jun 01, 2020 at 04:27:50PM +0200, Łuk

Re: [PATCH 5/5] arm: kexec_file: load zImage or uImage, initrd and dtb

2020-06-01 Thread Lukasz Stelmach
It was <2020-06-01 pon 16:14>, when Russell King - ARM Linux admin wrote: > On Mon, Jun 01, 2020 at 04:07:45PM +0100, Russell King - ARM Linux admin > wrote: >> On Mon, Jun 01, 2020 at 04:27:54PM +0200, Łukasz Stelmach wrote: >> > diff --git a/arch/arm/kernel/kexec_zimage.c >> >

Re: [PATCH 4/5] arm: Add kexec_image_info

2020-06-01 Thread Lukasz Stelmach
It was <2020-06-01 pon 15:56>, when Russell King - ARM Linux admin wrote: > On Mon, Jun 01, 2020 at 04:27:53PM +0200, Łukasz Stelmach wrote: >> Add kexec_image_info to print detailed information about a kexec image. > > Isn't this already visible through kexec debugging? Why do we need > to

Re: [PATCH 3/5] arm: decompressor: define a new zImage tag

2020-06-01 Thread Lukasz Stelmach
It was <2020-06-01 pon 15:55>, when Russell King - ARM Linux admin wrote: > On Mon, Jun 01, 2020 at 04:27:52PM +0200, Łukasz Stelmach wrote: >> Add DCSZ tag which holds dynamic memory (stack, bss, malloc pool) >> requirements of the decompressor code. > > Why do we need to know the stack and BSS

Re: [PATCH 1/5] arm: decompressor: set malloc pool size for the decompressor

2020-06-01 Thread Lukasz Stelmach
It was <2020-06-01 pon 15:46>, when Russell King - ARM Linux admin wrote: > On Mon, Jun 01, 2020 at 04:27:50PM +0200, Łukasz Stelmach wrote: >> Move the definition of malloc pool size of the decompressor to >> a single place. This value will be exposed later for kexec_file loader. >> >>

Re: [PATCH] [v2] hwrng: exynos - Fix runtime PM imbalance on error

2020-05-22 Thread Lukasz Stelmach
d-off-by: Dinghao Liu > --- > > Changelog: > > v2: -- Remove unnecessary 'err_clock' label > --- > drivers/char/hw_random/exynos-trng.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > Reviewed-by: Lukasz Stelmach Thank you. > diff --git a/drivers/char/hw_rand

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-21 Thread Lukasz Stelmach
It was <2020-05-21 czw 13:00>, when Stefan Wahren wrote: > Hi Lukasz, > > Am 19.05.20 um 23:25 schrieb Łukasz Stelmach: >> The value was estimaded with ea_iid[1] using on 10485760 bytes read from >> the RNG via /dev/hwrng. The min-entropy value calculated using the most >> common value estimate

Re: [PATCH] hwrng: exynos - fix runtime pm imbalance on error

2020-05-21 Thread Lukasz Stelmach
It was <2020-05-20 śro 21:19>, when Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu > --- >

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Lukasz Stelmach
It was <2020-05-20 śro 13:53>, when Stephan Mueller wrote: > Am Mittwoch, 20. Mai 2020, 12:44:33 CEST schrieb Lukasz Stelmach: >> It was <2020-05-20 śro 11:18>, when Stephan Mueller wrote: >>> Am Mittwoch, 20. Mai 2020, 11:10:32 CEST schrieb Lukasz Stelmach: >

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Lukasz Stelmach
It was <2020-05-20 śro 11:18>, when Stephan Mueller wrote: > Am Mittwoch, 20. Mai 2020, 11:10:32 CEST schrieb Lukasz Stelmach: >> It was <2020-05-20 śro 08:23>, when Stephan Mueller wrote: >>> Am Dienstag, 19. Mai 2020, 23:25:51 CEST schrieb Łukasz Stelmach

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Lukasz Stelmach
It was <2020-05-20 śro 08:23>, when Stephan Mueller wrote: > Am Dienstag, 19. Mai 2020, 23:25:51 CEST schrieb Łukasz Stelmach: > >> The value was estimaded with ea_iid[1] using on 10485760 bytes read from >> the RNG via /dev/hwrng. The min-entropy value calculated using the most >> common value

Re: [PATCH v6] ARM: boot: Obtain start of physical memory from DTB

2020-05-19 Thread Lukasz Stelmach
It was <2020-05-19 wto 14:12>, when Russell King - ARM Linux admin wrote: > On Tue, May 19, 2020 at 02:49:57PM +0200, Lukasz Stelmach wrote: >> It was <2020-05-19 wto 13:27>, when Russell King - ARM Linux admin wrote: >>> On Tue, May 19, 2020 at 02:20:25P

Re: [PATCH v6] ARM: boot: Obtain start of physical memory from DTB

2020-05-19 Thread Lukasz Stelmach
It was <2020-05-19 wto 13:27>, when Russell King - ARM Linux admin wrote: > On Tue, May 19, 2020 at 02:20:25PM +0200, Lukasz Stelmach wrote: >> It was <2020-05-19 wto 12:43>, when Russell King - ARM Linux admin wrote: >>> On Tue, May 19, 2020 at 01:21:09PM +

Re: [PATCH v6] ARM: boot: Obtain start of physical memory from DTB

2020-05-19 Thread Lukasz Stelmach
0200, Geert Uytterhoeven wrote: >> > > On Tue, May 19, 2020 at 10:54 AM Lukasz Stelmach >> > > wrote: >> > > > It was <2020-04-29 śro 10:21>, when Geert Uytterhoeven wrote: >> > > > > Currently, the start address of physical memory is o

Re: [PATCH v6] ARM: boot: Obtain start of physical memory from DTB

2020-05-19 Thread Lukasz Stelmach
It was <2020-05-19 wto 13:21>, when Geert Uytterhoeven wrote: > Hi Russell, > > CC devicetree > > On Tue, May 19, 2020 at 11:46 AM Russell King - ARM Linux admin > wrote: >> On Tue, May 19, 2020 at 11:44:17AM +0200, Geert Uytterhoeven wrote: >>> On Tue, M

Re: [PATCH v6] ARM: boot: Obtain start of physical memory from DTB

2020-05-19 Thread Lukasz Stelmach
It was <2020-04-29 śro 10:21>, when Geert Uytterhoeven wrote: > Currently, the start address of physical memory is obtained by masking > the program counter with a fixed mask of 0xf800. This mask value > was chosen as a balance between the requirements of different platforms. > However, this

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-15 Thread Lukasz Stelmach
It was <2020-05-15 pią 11:10>, when Stephan Mueller wrote: > As I mentioned, all that is or seems to be analyzed here is the > quality of the cryptographic post-processing. Thus none of the data > can be used for getting an idea of the entropy content. > > That said, the ent value indeed looks too

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-15 Thread Lukasz Stelmach
It was <2020-05-15 pią 10:32>, when Stephan Mueller wrote: > Am Freitag, 15. Mai 2020, 00:18:41 CEST schrieb Lukasz Stelmach: > >> I am running tests using SP800-90B tools and the first issue I can see >> is the warning that samples contain less than 1e6 bytes of data. I kn

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-15 Thread Lukasz Stelmach
It was <2020-05-15 pią 00:18>, when Lukasz Stelmach wrote: > It was <2020-05-14 czw 22:20>, when Stephan Mueller wrote: >> Am Donnerstag, 14. Mai 2020, 21:07:33 CEST schrieb Łukasz Stelmach: >> >> Hi Łukasz, >> >>> The value has been estimaded by

Re: [PATCH 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-14 Thread Lukasz Stelmach
It was <2020-05-14 czw 22:20>, when Stephan Mueller wrote: > Am Donnerstag, 14. Mai 2020, 21:07:33 CEST schrieb Łukasz Stelmach: > > Hi Łukasz, > >> The value has been estimaded by obtainig 1024 chunks of data 128 bytes >> (1024 bits) each from the generator and finding chunk with minimal >>

Re: [PATCH] arm64: kexec_file: print appropriate variable

2020-04-30 Thread Lukasz Stelmach
It was <2020-04-30 czw 12:19>, when Mark Rutland wrote: > On Thu, Apr 30, 2020 at 12:50:34PM +0200, Łukasz Stelmach wrote: >> Fixes: 4312057681929 ("arm64: kexec_file: load initrd and device-tree") > > This commit ID is bogus (doesn't exist in mainline or the arm64 tree). > > The upstream commit

[BUG] ohci_enable() fails during resume

2015-06-21 Thread Lukasz Stelmach
Hi, A bit, suddenly by desktop PC started to fail to resume. I have redirected the console to ttyS0 and managed to caputere the oops (attached). I am not a dissassebling expert and I have built my kernel without full debuging symbold but here is what I found (at least for the first trace in the

[BUG] ohci_enable() fails during resume

2015-06-21 Thread Lukasz Stelmach
Hi, A bit, suddenly by desktop PC started to fail to resume. I have redirected the console to ttyS0 and managed to caputere the oops (attached). I am not a dissassebling expert and I have built my kernel without full debuging symbold but here is what I found (at least for the first trace in the

Re: [PATCH v4 4/5] pstore: add pmsg

2015-02-03 Thread Lukasz Stelmach
On 03.02.2015 17:05, Mark Salyzyn wrote: > Thanks for your response. [...] > pstore is all about persistence. kmsg is not, until pstore supports > it. A user-space persistent storehouse felt appropriate to support > at the bottom layer. OK. Thanks, for the additional information. Like I said, I

Re: [PATCH v4 4/5] pstore: add pmsg

2015-02-03 Thread Lukasz Stelmach
On 03.02.2015 17:05, Mark Salyzyn wrote: Thanks for your response. [...] pstore is all about persistence. kmsg is not, until pstore supports it. A user-space persistent storehouse felt appropriate to support at the bottom layer. OK. Thanks, for the additional information. Like I said, I am no

Re: [PATCH v4 4/5] pstore: add pmsg

2015-01-30 Thread Lukasz Stelmach
On 28.01.2015 18:28, Mark Salyzyn wrote: > On 01/13/2015 04:16 PM, Łukasz Stelmach wrote: >>> A secured user-space accessible pstore object. Writes >>> to /dev/pmsg0 are appended to the buffer, on reboot >>> the persistent contents are available in >>> /sys/fs/pstore/pmsg-ramoops-[ID]. >>> >>> One

Re: [PATCH v4 4/5] pstore: add pmsg

2015-01-30 Thread Lukasz Stelmach
On 28.01.2015 18:28, Mark Salyzyn wrote: On 01/13/2015 04:16 PM, Łukasz Stelmach wrote: A secured user-space accessible pstore object. Writes to /dev/pmsg0 are appended to the buffer, on reboot the persistent contents are available in /sys/fs/pstore/pmsg-ramoops-[ID]. One possible use is

autoconf.h and auto.conf missing

2006-11-27 Thread Lukasz Stelmach
Greetings. It seems that someone has broken *conf programs in 2.6.18 because only "make silentoldconfig" recreates autoconf.h and auto.conf properly after configuration (.config) has changed. I do everything as I always have done. 1. create an empty dir and put my current .config there 2. make

autoconf.h and auto.conf missing

2006-11-27 Thread Lukasz Stelmach
Greetings. It seems that someone has broken *conf programs in 2.6.18 because only make silentoldconfig recreates autoconf.h and auto.conf properly after configuration (.config) has changed. I do everything as I always have done. 1. create an empty dir and put my current .config there 2. make