Le 07/11/2021 à 18:25, Marion & Christophe JAILLET a écrit :
Le 07/11/2021 à 18:20, Christophe JAILLET a écrit :
Le 07/11/2021 à 18:11, Ira Weiny a écrit :
On Sat, Nov 06, 2021 at 06:27:11PM +0100, Christophe JAILLET wrote:
If 'devm_init_badblocks()' fails, a previous 'blk_alloc_
Le 07/11/2021 à 18:20, Christophe JAILLET a écrit :
Le 07/11/2021 à 18:11, Ira Weiny a écrit :
On Sat, Nov 06, 2021 at 06:27:11PM +0100, Christophe JAILLET wrote:
If 'devm_init_badblocks()' fails, a previous 'blk_alloc_disk()' call
must
be undone.
I think this is a problem...
Le 18/12/2020 à 19:59, Marc Zyngier a écrit :
Hi Christophe,
On Tue, 15 Dec 2020 20:07:47 +,
Christophe JAILLET wrote:
Add a description for 'irq_create_of_mapping()' and make explicit the fact
that the resources allocated by this function can be freed by calling
'irq_dispose_mapping()'
Le 17/11/2020 à 03:55, Zhang Changzhong a écrit :
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API")
Hi, should it have any importance, the Fixes tag is
Le 17/11/2020 à 03:57, Zhang Changzhong a écrit :
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API")
Hi, should it have any importance, the Fixes tag is
Le 10/08/2020 à 17:42, Dan Carpenter a écrit :
On Sun, Aug 09, 2020 at 10:34:06PM +0200, Christophe JAILLET wrote:
When '*sgt' is allocated, we must allocated 'sizeof(**sgt)' bytes instead
of 'sizeof(*sg)'. 'sg' (i.e. struct scatterlist) is smaller than
'sgt' (i.e struct sg_table), so this
Le 24/06/2020 à 09:38, Christoph Hellwig a écrit :
Hi Guenter,
can you try the patch below? This just converts the huge allocations
in mptbase to use GFP_KERNEL. Christophe (added to Cc) actually has
a scripted conversion for the rest that he hasn't posted yet, so I'll
aim for the minimal
Le 27/06/2020 à 07:15, Greg KH a écrit :
On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote:
---
v2: takes Dan's comment into account and fix another resource leak.
v3: merge the previous 4 patches in a single one to ease review
No, 4 small patches are _MUCH_ easier to
Hi,
This one must NOT be included. It generates a regression.
This should be removed from 5.4 as well.
See 13f2d25b951f139064ec2dd53c0c7ebdf8d8007e.
There is also a thread on ML about it. I couldn't find it right away,
but I'm sure that Dan will be quicker than me for finding it, if needed
Le 30/05/2020 à 11:43, Russell King - ARM Linux admin a écrit :
On Sat, May 30, 2020 at 09:35:55AM +0200, Christophe JAILLET wrote:
The dev_id used in 'request_irq()' and 'free_irq()' should match.
So use 'host' in both cases.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by:
Hi,
sorry for the noise, I have messed up my
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ usage.
I thought I was looking at the 3.16.83 branch, but I was not.
The patch looks good to me.
CJ
Le 21/05/2020 à 16:09, Marion & Christophe JAILLET a écrit :
Hi,
I don't t
Hi,
I don't think that this one is applicable to 3.16.x
The remove function and the error handling path of the probe function
both use 'dma_free_wc'.
I've not look in details, but it looks consistent and the patch would
not apply as-is anyway.
just my 2c.
CJ
Le 20/05/2020 à 16:14, Ben
Le 08/05/2020 à 10:49, Dan Carpenter a écrit :
On Wed, May 06, 2020 at 10:09:07PM +0200, Christophe JAILLET wrote:
@@ -237,7 +239,7 @@ static int tegra186_emc_probe(struct platform_device *pdev)
"failed to set rate range [%lu-%lu] for %pC\n",
Le 06/05/2020 à 12:38, Andy Shevchenko a écrit :
On Wed, May 6, 2020 at 6:55 AM Christophe JAILLET
wrote:
This looks really unusual to have a 'get_device()' hidden in a 'dev_err()'
call.
Remove it.
While at it add a missing \n at the end of the message.
It should have Fixes tag because it
Le 10/05/2017 à 06:46, Julia Lawall a écrit :
On Wed, 10 May 2017, Christophe JAILLET wrote:
Le 09/05/2017 à 17:18, Joe Perches a écrit :
On Mon, 2017-05-08 at 17:35 -0700, Florian Fainelli wrote:
On 05/08/2017 04:46 PM, Julia Lawall wrote:
On Mon, 8 May 2017, Joe Perches wrote:
Each
Le 10/05/2017 à 06:46, Julia Lawall a écrit :
On Wed, 10 May 2017, Christophe JAILLET wrote:
Le 09/05/2017 à 17:18, Joe Perches a écrit :
On Mon, 2017-05-08 at 17:35 -0700, Florian Fainelli wrote:
On 05/08/2017 04:46 PM, Julia Lawall wrote:
On Mon, 8 May 2017, Joe Perches wrote:
Each
Hi,
I had a patch similar to:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/mips/ath79/clock.c?id=b3d91db3f71d5f70ea60d900425a3f96aeb3d065
in my own tree.
However, mine was slightly different and was also freeing the memory
mapping in the normal case, when
Hi,
I had a patch similar to:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/mips/ath79/clock.c?id=b3d91db3f71d5f70ea60d900425a3f96aeb3d065
in my own tree.
However, mine was slightly different and was also freeing the memory
mapping in the normal case, when
Hi,
while playing with coccinelle, a missing 'of_node_put()' triggered in
'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'.
/* The sd3 and sd9 shared all pins, and the function select by
* SYS2PCI_SDIO9SEL register
*/
sys2pci_np =
Hi,
while playing with coccinelle, a missing 'of_node_put()' triggered in
'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'.
/* The sd3 and sd9 shared all pins, and the function select by
* SYS2PCI_SDIO9SEL register
*/
sys2pci_np =
Hi,
in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37
auto-negotiation"), we can find:
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-common.h
b/drivers/net/ethernet/amd/xgbe/xgbe-common.h
index 695e982..8bcf4ef 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-common.h
+++
Hi,
in commit 1bf40ada6290 ("amd-xgbe: Add support for clause 37
auto-negotiation"), we can find:
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-common.h
b/drivers/net/ethernet/amd/xgbe/xgbe-common.h
index 695e982..8bcf4ef 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-common.h
+++
Le 14/09/2016 à 10:25, Guoqing Jiang a écrit :
On 09/13/2016 01:24 PM, Shaohua Li wrote:
On Mon, Sep 12, 2016 at 09:09:48PM +0200, Christophe JAILLET wrote:
Hi,
I'm puzzled by commit f9a67b1182e5 ("md/bitmap: clear bitmap if
bitmap_create failed").
Hi Christophe,
Thank you very much to
Le 14/09/2016 à 10:25, Guoqing Jiang a écrit :
On 09/13/2016 01:24 PM, Shaohua Li wrote:
On Mon, Sep 12, 2016 at 09:09:48PM +0200, Christophe JAILLET wrote:
Hi,
I'm puzzled by commit f9a67b1182e5 ("md/bitmap: clear bitmap if
bitmap_create failed").
Hi Christophe,
Thank you very much to
Le 27/10/2015 11:27, Jarkko Sakkinen a écrit :
On Fri, Oct 23, 2015 at 10:37:33AM +0300, Jarkko Sakkinen wrote:
On Thu, Oct 22, 2015 at 10:32:41PM +0200, Christophe JAILLET wrote:
Reference to the 'np' node is dropped before dereferencing the 'sizep' and
'basep' pointers, which could by then
Le 27/10/2015 11:27, Jarkko Sakkinen a écrit :
On Fri, Oct 23, 2015 at 10:37:33AM +0300, Jarkko Sakkinen wrote:
On Thu, Oct 22, 2015 at 10:32:41PM +0200, Christophe JAILLET wrote:
Reference to the 'np' node is dropped before dereferencing the 'sizep' and
'basep' pointers, which could by then
Hi,
yes, you are correct, it's a mistake.
Should I resubmit with an updated subject?
CJ
Le 01/05/2015 16:19, Dan Carpenter a écrit :
The "[PATCH 2/2]" bit is a mistake. It's not part of a patchset. It's
just that you have sent two patches today. The first patch wasn't even
named [1/2]...
Hi,
yes, you are correct, it's a mistake.
Should I resubmit with an updated subject?
CJ
Le 01/05/2015 16:19, Dan Carpenter a écrit :
The [PATCH 2/2] bit is a mistake. It's not part of a patchset. It's
just that you have sent two patches today. The first patch wasn't even
named [1/2]...
28 matches
Mail list logo
