Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-08 Thread Michael Ellerman
ch/powerpc/kvm/book3s_hv.c | 1 - > arch/powerpc/kvm/book3s_pr.c | 7 > arch/powerpc/kvm/e500_mmu_host.c | 6 --- LGTM. Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

2023-12-21 Thread Michael Ellerman
Cc +Kees Christophe Leroy writes: > Declaring rodata_enabled and mark_rodata_ro() at all time > helps removing related #ifdefery in C files. > > Signed-off-by: Christophe Leroy > --- > include/linux/init.h | 4 > init/main.c | 21 +++-- > 2 files changed, 7

Re: (subset) [PATCH v2 0/2] m68k/powerpc: Kill references to non-existent README.legal

2023-10-15 Thread Michael Ellerman
On Mon, 18 Sep 2023 12:14:42 +0200, Geert Uytterhoeven wrote: > Note that the "COPYING" file at that time corresponded to the version > from upstream Linux v0.99.11 until v2.1.104, and thus predated the > addition of the "only valid GPL version is v2" clause in v2.4.0-test8. > > This patch series

Re: [PATCH v2 2/2] powerpc: Replace GPL 2.0+ README.legal boilerplate with SPDX

2023-09-19 Thread Michael Ellerman
Geert Uytterhoeven writes: > Hi Michael, > > On Tue, Sep 19, 2023 at 4:13 AM Michael Ellerman wrote: >> Geert Uytterhoeven writes: >> > Upstream Linux never had a "README.legal" file, but it was present >> > in early source releases of Linux/m68k.

Re: [PATCH v2 2/2] powerpc: Replace GPL 2.0+ README.legal boilerplate with SPDX

2023-09-18 Thread Michael Ellerman
he "only valid GPL version is v2" clause. > > Get rid of the references to non-existent files by replacing the > boilerplate with SPDX license identifiers. > > Signed-off-by: Geert Uytterhoeven LGTM. Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-23 Thread Michael Ellerman
Dan Williams writes: > On Tue, Mar 22, 2022 at 7:30 AM kajoljain wrote: >> On 3/22/22 03:09, Dan Williams wrote: >> > On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >> >> >> >> The following build failure occures when CONFIG_PERF_EVENTS is not set >> >> as generic pmu functions are not

Re: [RFC PATCH v2] powerpc/papr_scm: Move duplicate definitions to common header files

2021-09-07 Thread Michael Ellerman
Shivaprasad G Bhat writes: > papr_scm and ndtest share common PDSM payload structs like > nd_papr_pdsm_health. Presently these structs are duplicated across papr_pdsm.h > and ndtest.h header files. Since 'ndtest' is essentially arch independent and > can > run on platforms other than PPC64, a

Re: PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-20 Thread Michael Ellerman
Christophe Leroy writes: > Le 19/04/2021 à 23:39, Randy Dunlap a écrit : >> On 4/19/21 6:16 AM, Michael Ellerman wrote: >>> Randy Dunlap writes: >> >>>> Sure. I'll post them later today. >>>> They keep FPU and ALTIVEC as independent

Re: [PATCH 0/2] Change struct page layout for page_pool

2021-04-19 Thread Michael Ellerman
"Matthew Wilcox (Oracle)" writes: > The first patch here fixes two bugs on ppc32, and mips32. It fixes one > bug on arc and arm32 (in certain configurations). It probably makes > sense to get it in ASAP through the networking tree. I'd like to see > testing on those four architectures if

Re: [PATCH] powerpc/pseries: Add shutdown() to vio_driver and vio_bus

2021-04-19 Thread Michael Ellerman
Tyrel Datwyler writes: > On 4/17/21 5:30 AM, Michael Ellerman wrote: >> Tyrel Datwyler writes: >>> On 4/1/21 5:13 PM, Tyrel Datwyler wrote: >>>> Currently, neither the vio_bus or vio_driver structures provide support >>>> for a shutdown() routine. >&g

Re: PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-19 Thread Michael Ellerman
Randy Dunlap writes: > On 4/18/21 10:46 AM, Segher Boessenkool wrote: >> On Sun, Apr 18, 2021 at 06:24:29PM +0200, Christophe Leroy wrote: >>> Le 17/04/2021 à 22:17, Randy Dunlap a écrit : Should the code + Kconfigs/Makefiles handle that kind of kernel config or should ALTIVEC always

Re: [PATCH v2] perf vendor events: Initial json/events list for power10 platform

2021-04-19 Thread Michael Ellerman
Kajol Jain writes: > Patch adds initial json/events for POWER10. Acked-by: Michael Ellerman cheers > Signed-off-by: Kajol Jain > Tested-by: Paul A. Clarke > Reviewed-by: Paul A. Clarke > --- > .../perf/pmu-events/arch/powerpc/mapfile.csv | 1 + > .../arch/power

Re: linux-next: build failure after merge of the powerpc tree

2021-04-19 Thread Michael Ellerman
Xiongwei Song writes: > Thank you so much Stephen. Sorry for my negligence. My fault. I forgot to run allyesconfig. > Should I fix this myself on powerpc tree? I'll fix it up. cheers

Re: [PATCH v3] powerpc: fix EDEADLOCK redefinition error in uapi/asm/errno.h

2021-04-18 Thread Michael Ellerman
On Thu, 17 Sep 2020 06:54:37 -0700, Tony Ambardar wrote: > A few archs like powerpc have different errno.h values for macros > EDEADLOCK and EDEADLK. In code including both libc and linux versions of > errno.h, this can result in multiple definitions of EDEADLOCK in the > include chain.

Re: [PATCH] windfarm: make symbol 'wf_thread' static

2021-04-18 Thread Michael Ellerman
On Wed, 7 Apr 2021 20:57:38 +0800, Yu Kuai wrote: > The sparse tool complains as follows: > > drivers/macintosh/windfarm_core.c:59:20: warning: > symbol 'wf_thread' was not declared. Should it be static? > > This symbol is not used outside of windfarm_core.c, so this > commit marks it static.

Re: [PATCH] powerpc/smp: Make some symbols static

2021-04-18 Thread Michael Ellerman
On Wed, 7 Apr 2021 20:59:03 +0800, Yu Kuai wrote: > The sparse tool complains as follows: > > arch/powerpc/kernel/smp.c:86:1: warning: > symbol '__pcpu_scope_cpu_coregroup_map' was not declared. Should it be > static? > arch/powerpc/kernel/smp.c:125:1: warning: > symbol

Re: [PATCH] macintosh/windfarm: Make symbol 'pm121_sys_state' static

2021-04-18 Thread Michael Ellerman
On Wed, 7 Apr 2021 20:57:12 +0800, Yu Kuai wrote: > The sparse tool complains as follows: > > drivers/macintosh/windfarm_pm121.c:436:24: warning: > symbol 'pm121_sys_state' was not declared. Should it be static? > > This symbol is not used outside of windfarm_pm121.c, so this > commit marks it

Re: [PATCH] macintosh/via-pmu: Make some symbols static

2021-04-18 Thread Michael Ellerman
On Wed, 7 Apr 2021 20:58:03 +0800, Yu Kuai wrote: > The sparse tool complains as follows: > > drivers/macintosh/via-pmu.c:183:5: warning: > symbol 'pmu_cur_battery' was not declared. Should it be static? > drivers/macintosh/via-pmu.c:190:5: warning: > symbol '__fake_sleep' was not declared.

Re: [PATCH] powerpc/pseries: extract host bridge from pci_bus prior to bus removal

2021-04-18 Thread Michael Ellerman
On Thu, 11 Feb 2021 12:24:35 -0600, Tyrel Datwyler wrote: > The pci_bus->bridge reference may no longer be valid after > pci_bus_remove() resulting in passing a bad value to device_unregister() > for the associated bridge device. > > Store the host_bridge reference in a separate variable prior to

Re: [PATCH v5] powerpc/traps: Enhance readability for trap types

2021-04-18 Thread Michael Ellerman
On Wed, 14 Apr 2021 19:00:33 +0800, Xiongwei Song wrote: > Define macros to list ppc interrupt types in interttupt.h, replace the > reference of the trap hex values with these macros. > > Referred the hex numbers in arch/powerpc/kernel/exceptions-64e.S, > arch/powerpc/kernel/exceptions-64s.S,

Re: [PATCH -next] powerpc/fadump: make symbol 'rtas_fadump_set_regval' static

2021-04-18 Thread Michael Ellerman
On Thu, 8 Apr 2021 14:20:12 +0800, Pu Lehui wrote: > Fix sparse warnings: > > arch/powerpc/platforms/pseries/rtas-fadump.c:250:6: warning: > symbol 'rtas_fadump_set_regval' was not declared. Should it be static? Applied to powerpc/next. [1/1] powerpc/fadump: make symbol

Re: [PATCH -next] powerpc/xmon: Make symbol 'spu_inst_dump' static

2021-04-18 Thread Michael Ellerman
On Fri, 9 Apr 2021 15:01:51 +0800, Pu Lehui wrote: > Fix sparse warning: > > arch/powerpc/xmon/xmon.c:4216:1: warning: > symbol 'spu_inst_dump' was not declared. Should it be static? > > This symbol is not used outside of xmon.c, so make it static. Applied to powerpc/next. [1/1] powerpc/xmon:

Re: [PATCH -next] powerpc/mce: Make symbol 'mce_ue_event_work' static

2021-04-18 Thread Michael Ellerman
On Thu, 8 Apr 2021 11:58:02 +0800, Li Huafei wrote: > The sparse tool complains as follows: > > arch/powerpc/kernel/mce.c:43:1: warning: > symbol 'mce_ue_event_work' was not declared. Should it be static? > > This symbol is not used outside of mce.c, so this commit marks it > static. Applied

Re: [PATCH v3 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR

2021-04-18 Thread Michael Ellerman
On Thu, 8 Apr 2021 17:19:16 -0300, Leonardo Bras wrote: > According to LoPAR, ibm,query-pe-dma-window output named "IO Page Sizes" > will let the OS know all possible pagesizes that can be used for creating a > new DDW. > > Currently Linux will only try using 3 of the 8 available options: > 4K,

Re: [PATCH -next] powerpc/perf/hv-24x7: Make some symbols static

2021-04-18 Thread Michael Ellerman
On Fri, 9 Apr 2021 17:01:24 +0800, Bixuan Cui wrote: > The sparse tool complains as follows: > > arch/powerpc/perf/hv-24x7.c:229:1: warning: > symbol '__pcpu_scope_hv_24x7_txn_flags' was not declared. Should it be > static? > arch/powerpc/perf/hv-24x7.c:230:1: warning: > symbol

Re: [PATCH -next] powerpc/security: Make symbol 'stf_barrier' static

2021-04-18 Thread Michael Ellerman
On Thu, 8 Apr 2021 11:39:51 +0800, Li Huafei wrote: > The sparse tool complains as follows: > > arch/powerpc/kernel/security.c:253:6: warning: > symbol 'stf_barrier' was not declared. Should it be static? > > This symbol is not used outside of security.c, so this commit marks it > static.

Re: [PATCH 1/2] powerpc: syscalls: switch to generic syscalltbl.sh

2021-04-18 Thread Michael Ellerman
On Tue, 2 Mar 2021 00:30:18 +0900, Masahiro Yamada wrote: > Many architectures duplicate similar shell scripts. > > This commit converts powerpc to use scripts/syscalltbl.sh. This also > unifies syscall_table_32.h and syscall_table_c32.h. Applied to powerpc/next. [1/2] powerpc: syscalls: switch

Re: [PATCH] powerpc/vdso: Separate vvar vma from vdso

2021-04-18 Thread Michael Ellerman
On Fri, 26 Mar 2021 19:17:20 +, Dmitry Safonov wrote: > Since commit 511157ab641e ("powerpc/vdso: Move vdso datapage up front") > VVAR page is in front of the VDSO area. In result it breaks CRIU > (Checkpoint Restore In Userspace) [1], where CRIU expects that "[vdso]" > from /proc/../maps

Re: [PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static

2021-04-18 Thread Michael Ellerman
On Fri, 9 Apr 2021 17:01:14 +0800, Bixuan Cui wrote: > The sparse tool complains as follows: > > arch/powerpc/platforms/pseries/pmem.c:142:27: warning: > symbol 'drc_pmem_match' was not declared. Should it be static? > > This symbol is not used outside of pmem.c, so this > commit marks it

Re: [PATCH -next] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static

2021-04-18 Thread Michael Ellerman
On Fri, 9 Apr 2021 17:01:09 +0800, Bixuan Cui wrote: > The sparse tool complains as follows: > > arch/powerpc/platforms/pseries/hvCall_inst.c:29:1: warning: > symbol '__pcpu_scope_hcall_stats' was not declared. Should it be static? > > This symbol is not used outside of hvCall_inst.c, so this >

Re: [PATCH -next] powerpc/powernv: make symbol 'mpipl_kobj' static

2021-04-18 Thread Michael Ellerman
On Fri, 9 Apr 2021 14:38:55 +0800, Bixuan Cui wrote: > The sparse tool complains as follows: > > arch/powerpc/platforms/powernv/opal-core.c:74:16: warning: > symbol 'mpipl_kobj' was not declared. > > This symbol is not used outside of opal-core.c, so marks it static. Applied to powerpc/next.

Re: [PATCH -next] powerpc/perf: Make symbol 'isa207_pmu_format_attr' static

2021-04-18 Thread Michael Ellerman
On Fri, 9 Apr 2021 17:01:19 +0800, Bixuan Cui wrote: > The sparse tool complains as follows: > > arch/powerpc/perf/isa207-common.c:24:18: warning: > symbol 'isa207_pmu_format_attr' was not declared. Should it be static? > > This symbol is not used outside of isa207-common.c, so this > commit

Re: [PATCH RESEND v1 0/4] powerpc/vdso: Add support for time namespaces

2021-04-18 Thread Michael Ellerman
On Wed, 31 Mar 2021 16:48:43 + (UTC), Christophe Leroy wrote: > [Sorry, resending with complete destination list, I used the wrong script on > the first delivery] > > This series adds support for time namespaces on powerpc. > > All timens selftests are successfull. > > Christophe Leroy

Re: [PATCH v2 1/9] powerpc/mem: Move cache flushing functions into mm/cacheflush.c

2021-04-18 Thread Michael Ellerman
On Thu, 8 Apr 2021 15:30:24 + (UTC), Christophe Leroy wrote: > Cache flushing functions are in the middle of completely > unrelated stuff in mm/mem.c > > Create a dedicated mm/cacheflush.c for those functions. > > Also cleanup the list of included headers. Applied to powerpc/next. [1/9]

Re: [PATCH] powerpc/signal32: Fix build failure with CONFIG_SPE

2021-04-18 Thread Michael Ellerman
On Sun, 11 Apr 2021 16:39:53 + (UTC), Christophe Leroy wrote: > Add missing fault exit label in unsafe_copy_from_user() in order to > avoid following build failure with CONFIG_SPE > > CC arch/powerpc/kernel/signal_32.o > arch/powerpc/kernel/signal_32.c: In function 'restore_user_regs':

Re: [PATCH 1/3] powerpc/modules: Load modules closer to kernel text

2021-04-18 Thread Michael Ellerman
On Thu, 1 Apr 2021 13:30:41 + (UTC), Christophe Leroy wrote: > On book3s/32, when STRICT_KERNEL_RWX is selected, modules are > allocated on the segment just before kernel text, ie on the > 0xb000-0xbfff when PAGE_OFFSET is 0xc000. > > On the 8xx, TASK_SIZE is 0x8000. The space

Re: [PATCH] powerpc/pseries: Add shutdown() to vio_driver and vio_bus

2021-04-17 Thread Michael Ellerman
Tyrel Datwyler writes: > On 4/1/21 5:13 PM, Tyrel Datwyler wrote: >> Currently, neither the vio_bus or vio_driver structures provide support >> for a shutdown() routine. >> >> Add support for shutdown() by allowing drivers to provide a >> implementation via function pointer in their vio_driver

Re: linux-next: build warning after merge of the powerpc tree

2021-04-16 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > After merging the powerpc tree, today's linux-next build (powerpc > allyesconfig) produced this warning: > > In file included from include/linux/device.h:15, > from arch/powerpc/include/asm/io.h:27, > from

Re: [PATCH v3] powerpc: fix EDEADLOCK redefinition error in uapi/asm/errno.h

2021-04-16 Thread Michael Ellerman
efinition >>#define EDEADLOCK 58 >> >> cc1: all warnings being treated as errors >> >> CC: Stable >> Reported-by: Rosen Penev >> Signed-off-by: Tony Ambardar >> --- >> v1 -> v2: >> * clean up commit description formatting >&

Re: [PATCH RESEND v1 0/4] powerpc/vdso: Add support for time namespaces

2021-04-13 Thread Michael Ellerman
Thomas Gleixner writes: > On Wed, Mar 31 2021 at 16:48, Christophe Leroy wrote: >> [Sorry, resending with complete destination list, I used the wrong script on >> the first delivery] >> >> This series adds support for time namespaces on powerpc. >> >> All timens selftests are successfull. > > If

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-12 Thread Michael Ellerman
Alex Williamson writes: > On Fri, 26 Mar 2021 07:13:10 +0100 > Christoph Hellwig wrote: > >> This driver never had any open userspace (which for VFIO would include >> VM kernel drivers) that use it, and thus should never have been added >> by our normal userspace ABI rules. >> >> Signed-off-by:

[GIT PULL] Please pull powerpc/linux.git powerpc-5.12-6 tag

2021-04-10 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.12: The following changes since commit 53f1d31708f6240e4615b0927df31f182e389e2f: powerpc/mm/book3s64: Use the correct storage key value when calling H_PROTECT (2021-03-26 22:19:39 +1100) are

Re: [PATCH v2] powerpc: iommu: fix build when neither PCI or IBMVIO is set

2021-04-10 Thread Michael Ellerman
On Sun, 4 Apr 2021 12:26:23 -0700, Randy Dunlap wrote: > When neither CONFIG_PCI nor CONFIG_IBMVIO is set/enabled, iommu.c has a > build error. The fault injection code is not useful in that kernel config, > so make the FAIL_IOMMU option depend on PCI || IBMVIO. > > Prevents this build error

Re: [PATCH] powerpc/pseries: remove unneeded semicolon

2021-04-10 Thread Michael Ellerman
On Tue, 6 Apr 2021 09:33:05 +0800, Yang Li wrote: > Eliminate the following coccicheck warning: > ./arch/powerpc/platforms/pseries/lpar.c:1633:2-3: Unneeded semicolon Applied to powerpc/next. [1/1] powerpc/pseries: remove unneeded semicolon

Re: [PATCH v2 0/8] Implement EBPF on powerpc32

2021-04-10 Thread Michael Ellerman
On Mon, 22 Mar 2021 16:37:45 + (UTC), Christophe Leroy wrote: > This series implements extended BPF on powerpc32. For the implementation > details, see the patch before the last. > > The following operations are not implemented: > > case BPF_ALU64 | BPF_DIV | BPF_X: /* dst /=

Re: [PATCH v3 03/15] powerpc/align: Convert emulate_spe() to user_access_begin

2021-04-10 Thread Michael Ellerman
On Fri, 12 Mar 2021 13:25:11 + (UTC), Christophe Leroy wrote: > This patch converts emulate_spe() to using user_access_begin > logic. > > Since commit 662bbcb2747c ("mm, sched: Allow uaccess in atomic with > pagefault_disable()"), might_fault() doesn't fire when called from > sections where

Re: [PATCH v2 00/15] powerpc: Cleanup of uaccess.h and adding asm goto for get_user()

2021-04-10 Thread Michael Ellerman
On Wed, 10 Mar 2021 17:46:39 + (UTC), Christophe Leroy wrote: > This series cleans up uaccess.h and adds asm goto for get_user() > > v2: > - Further clean ups > - asm goto for get_user() > - Move a few patches unrelated to put_user/get_user into another misc series. > > [...] Applied to

Re: [PATCH] powerpc/32: Remove powerpc specific definition of 'ptrdiff_t'

2021-04-10 Thread Michael Ellerman
On Mon, 5 Apr 2021 09:57:27 + (UTC), Christophe Leroy wrote: > For unknown reason, old commit d27dfd388715 ("Import pre2.0.8") > changed 'ptrdiff_t' from 'int' to 'long'. > > GCC expects it as 'int' really, and this leads to the following > warning when building KFENCE: > > CC

Re: [PATCH] powerpc: Switch to relative jump labels

2021-04-10 Thread Michael Ellerman
On Tue, 23 Mar 2021 15:47:59 + (UTC), Christophe Leroy wrote: > Convert powerpc to relative jump labels. > > Before the patch, pseries_defconfig vmlinux.o has: > 9074 __jump_table 0003f2a0 01321fa8 > 2**0 > > With the patch, the same config gets: >

Re: [PATCH 00/10] Convert signal32 to user read access by block

2021-04-10 Thread Michael Ellerman
On Fri, 19 Mar 2021 11:06:49 + (UTC), Christophe Leroy wrote: > Similarly to the work done earlier with writes, this series > converts signal32 to using user_read_access_begin/end and > unsafe_get_user() and friends. > > Applies on to of the signal64 series, ie on merge-test (ca6e327fefb2) >

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-09 Thread Michael Ellerman
Christophe Leroy writes: > Le 08/04/2021 à 16:07, Xiongwei Song a écrit : >> From: Xiongwei Song >> >> Create a new header named traps.h, define macros to list ppc interrupt >> types in traps.h, replace the reference of the trap hex values with these >> macros. ... >> diff --git

Re: [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR

2021-04-08 Thread Michael Ellerman
Leonardo Bras writes: > On Thu, 2021-04-08 at 03:20 -0300, Leonardo Bras wrote: >> > > +#define QUERY_DDW_PGSIZE_4K 0x01 >> > > +#define QUERY_DDW_PGSIZE_64K0x02 >> > > +#define QUERY_DDW_PGSIZE_16M0x04 >> > > +#define QUERY_DDW_PGSIZE_32M0x08 >> > > +#define QUERY_DDW_PGSIZE_64M

Re: [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR

2021-04-08 Thread Michael Ellerman
Alexey Kardashevskiy writes: > On 08/04/2021 15:37, Michael Ellerman wrote: >> Leonardo Bras writes: >>> According to LoPAR, ibm,query-pe-dma-window output named "IO Page Sizes" >>> will let the OS know all possible pagesizes that can be used for creating a

Re: [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR

2021-04-07 Thread Michael Ellerman
Leonardo Bras writes: > According to LoPAR, ibm,query-pe-dma-window output named "IO Page Sizes" > will let the OS know all possible pagesizes that can be used for creating a > new DDW. > > Currently Linux will only try using 3 of the 8 available options: > 4K, 64K and 16M. According to LoPAR,

Re: [PATCH] powerpc/dts: fix not include DTC_FLAGS

2021-04-07 Thread Michael Ellerman
Youlin Song writes: > I wanted to build the fsl dts in my machine and found that > the dtb have not extra space,so uboot will cause about > FDT_ERR_NOSPACE issue. > > Signed-off-by: Youlin Song > --- > arch/powerpc/boot/dts/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2] powerpc/signal32: Fix Oops on sigreturn with unmapped VDSO

2021-04-03 Thread Michael Ellerman
On Wed, 31 Mar 2021 14:07:04 + (UTC), Christophe Leroy wrote: > PPC32 encounters a KUAP fault when trying to handle a signal with > VDSO unmapped. > > Kernel attempted to read user page (7fc07ec0) - exploit attempt? (uid: > 0) > BUG: Unable to handle kernel data access on read at

Re: [PATCH] powerpc/vdso: Make sure vdso_wrapper.o is rebuilt everytime vdso.so is rebuilt

2021-04-03 Thread Michael Ellerman
On Wed, 31 Mar 2021 09:12:19 + (UTC), Christophe Leroy wrote: > Commit bce74491c300 ("powerpc/vdso: fix unnecessary rebuilds of > vgettimeofday.o") moved vdso32_wrapper.o and vdso64_wrapper.o out > of arch/powerpc/kernel/vdso[32/64]/ and removed the dependencies in > the Makefile. This leads

Re: [PATCH] powerpc/ptrace: Don't return error when getting/setting FP regs without CONFIG_PPC_FPU_REGS

2021-04-03 Thread Michael Ellerman
On Wed, 31 Mar 2021 14:14:58 + (UTC), Christophe Leroy wrote: > An #ifdef CONFIG_PPC_FPU_REGS is missing in arch_ptrace() leading > to the following Oops because [REGSET_FPR] entry is not initialised in > native_regsets[]. > > [ 41.917608] BUG: Unable to handle kernel instruction fetch > [

[GIT PULL] Please pull powerpc/linux.git powerpc-5.12-5 tag

2021-04-03 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.12: The following changes since commit cc7a0bb058b85ea03db87169c60c7cfdd5d34678: PCI: rpadlpar: Fix potential drc_name corruption in store functions (2021-03-17 13:48:07 +1100) are available

Re: [PATCH] powerpc/8xx: Load modules closer to kernel text

2021-03-31 Thread Michael Ellerman
Christophe Leroy writes: > Le 31/03/2021 à 15:39, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> On the 8xx, TASK_SIZE is 0x8000. The space between TASK_SIZE and >>> PAGE_OFFSET is not used. >>> >>> Use it to load modules in order to

Re: [PATCH v2] powerpc/traps: Enhance readability for trap types

2021-03-31 Thread Michael Ellerman
Segher Boessenkool writes: > On Wed, Mar 31, 2021 at 08:58:17PM +1100, Michael Ellerman wrote: >> So perhaps: >> >> EXC_SYSTEM_RESET >> EXC_MACHINE_CHECK >> EXC_DATA_STORAGE >> EXC_DATA_SEGMENT >> EXC_INST_STORAGE >> EXC_INST_SEG

Re: [PATCH] powerpc/8xx: Load modules closer to kernel text

2021-03-31 Thread Michael Ellerman
Christophe Leroy writes: > On the 8xx, TASK_SIZE is 0x8000. The space between TASK_SIZE and > PAGE_OFFSET is not used. > > Use it to load modules in order to minimise the distance between > kernel text and modules and avoid trampolines in modules to access > kernel functions or other module

Re: [PATCH] powerpc/signal32: Fix Oops on sigreturn with unmapped VDSO

2021-03-31 Thread Michael Ellerman
Christophe Leroy writes: > PPC32 encounters a KUAP fault when trying to handle a signal with > VDSO unmapped. > > Kernel attempted to read user page (7fc07ec0) - exploit attempt? (uid: > 0) > BUG: Unable to handle kernel data access on read at 0x7fc07ec0 > Faulting instruction

Re: [PATCH] powerpc/vdso: Separate vvar vma from vdso

2021-03-31 Thread Michael Ellerman
ression as no other userspace got broken, but I'd really appreciate >> if it gets backported to v5.11 after v5.12 is released, so as not >> to complicate already non-simple CRIU-vdso code. Thanks! >> >> Cc: Andrei Vagin >> Cc: Andy Lutomirski >> Cc: Be

Re: [PATCH v2] powerpc/traps: Enhance readability for trap types

2021-03-31 Thread Michael Ellerman
Xiongwei Song writes: > From: Xiongwei Song > > Create a new header named traps.h, define macros to list ppc exception > types in traps.h, replace the reference of the real trap values with > these macros. Personally I find the hex values easier to recognise, but I realise that's probably not

Re: [PATCH] powerpc: kernel: Trivial spelling fixes throughout the file head_fsl_booke.S

2021-03-30 Thread Michael Ellerman
On Mon, 15 Mar 2021 03:34:36 +0530, Bhaskar Chowdhury wrote: > Trivial spelling fixes throughout the file. Applied to powerpc/next. [1/1] powerpc: kernel: Trivial spelling fixes throughout the file head_fsl_booke.S https://git.kernel.org/powerpc/c/f239873fcd953557ba9a9781d10ca95c0594e2b3

Re: [PATCH] powerpc/xive: use true and false for bool variable

2021-03-30 Thread Michael Ellerman
On Mon, 15 Mar 2021 15:24:56 +0800, Yang Li wrote: > fixed the following coccicheck: > ./arch/powerpc/sysdev/xive/spapr.c:552:8-9: WARNING: return of 0/1 in > function 'xive_spapr_match' with return type bool Applied to powerpc/next. [1/1] powerpc/xive: use true and false for bool variable

Re: [PATCH] arch: powerpc: kernel: Change droping to dropping in the file traps.c

2021-03-30 Thread Michael Ellerman
On Wed, 24 Feb 2021 13:25:47 +0530, Bhaskar Chowdhury wrote: > s/droping/dropping/ Applied to powerpc/next. [1/1] arch: powerpc: kernel: Change droping to dropping in the file traps.c https://git.kernel.org/powerpc/c/5c4a4802b9ac8c1acdf2250fad3f8f2d6254f9c7 cheers

Re: [PATCH] cxl: Fix couple of spellings

2021-03-30 Thread Michael Ellerman
On Mon, 22 Mar 2021 08:03:07 +0530, Bhaskar Chowdhury wrote: > s/filesytem/filesystem/ > s/symantics/semantics/ Applied to powerpc/next. [1/1] cxl: Fix couple of spellings https://git.kernel.org/powerpc/c/e23ecdf9fd87c547a3ac55bcebaf7df28df2fab0 cheers

Re: [PATCH] powerpc: mm: book3s64: Fix a typo in the file mmu_context.c

2021-03-30 Thread Michael Ellerman
On Fri, 12 Mar 2021 16:55:37 +0530, Bhaskar Chowdhury wrote: > s/detalis/details/ Applied to powerpc/next. [1/1] powerpc: mm: book3s64: Fix a typo in the file mmu_context.c https://git.kernel.org/powerpc/c/7a7d744ffe87ae10ab98004d1a6ca1f691af58e1 cheers

Re: [PATCH] powerpc/prom: Mark identical_pvr_fixup as __init

2021-03-30 Thread Michael Ellerman
On Tue, 2 Mar 2021 13:08:29 -0700, Nathan Chancellor wrote: > If identical_pvr_fixup() is not inlined, there are two modpost warnings: > > WARNING: modpost: vmlinux.o(.text+0x54e8): Section mismatch in reference > from the function identical_pvr_fixup() to the function >

Re: [PATCH] powerpc: kernel: Trivial typo fix in the file kgdb.c

2021-03-30 Thread Michael Ellerman
On Wed, 17 Mar 2021 14:34:13 +0530, Bhaskar Chowdhury wrote: > s/procesing/processing/ Applied to powerpc/next. [1/1] powerpc: kernel: Trivial typo fix in the file kgdb.c https://git.kernel.org/powerpc/c/89f7d2927ae16ea470d29234447763826e40c6cf cheers

Re: [PATCH v5] powerpc/uprobes: Validation for prefixed instruction

2021-03-30 Thread Michael Ellerman
On Thu, 11 Mar 2021 14:45:38 +0530, Ravi Bangoria wrote: > As per ISA 3.1, prefixed instruction should not cross 64-byte > boundary. So don't allow Uprobe on such prefixed instruction. > > There are two ways probed instruction is changed in mapped pages. > First, when Uprobe is activated, it

Re: [PATCH] selftests: powerpc: unmark non-kernel-doc comments

2021-03-30 Thread Michael Ellerman
On Thu, 25 Mar 2021 13:08:20 -0700, Randy Dunlap wrote: > Drop the 'beginning of kernel-doc' notation markers (/**) > in places that are not in kernel-doc format. Applied to powerpc/next. [1/1] selftests: powerpc: unmark non-kernel-doc comments

Re: [PATCH] powerpc/fadump: Mark fadump_calculate_reserve_size as __init

2021-03-30 Thread Michael Ellerman
On Tue, 2 Mar 2021 12:50:14 -0700, Nathan Chancellor wrote: > If fadump_calculate_reserve_size() is not inlined, there is a modpost > warning: > > WARNING: modpost: vmlinux.o(.text+0x5196c): Section mismatch in > reference from the function fadump_calculate_reserve_size() to the > function

Re: [PATCH] arch/powerpc/include:fix misspellings in tlbflush.h

2021-03-30 Thread Michael Ellerman
On Wed, 3 Mar 2021 19:13:18 -0800, menglong8.d...@gmail.com wrote: > Some typos are found out.The information at the end of the file > does not match the beginning. Applied to powerpc/next. [1/1] arch/powerpc/include:fix misspellings in tlbflush.h

Re: [PATCH] powerpc/iommu/debug: fix ifnullfree.cocci warnings

2021-03-30 Thread Michael Ellerman
On Fri, 19 Mar 2021 07:44:41 +0800, kernel test robot wrote: > arch/powerpc/kernel/iommu.c:76:2-16: WARNING: NULL check before some freeing > functions is not needed. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check

Re: [PATCH] cxl: don't manipulate the mm.mm_users field directly

2021-03-30 Thread Michael Ellerman
On Wed, 10 Mar 2021 18:44:05 +0100, Laurent Dufour wrote: > It is better to rely on the API provided by the MM layer instead of > directly manipulating the mm_users field. Applied to powerpc/next. [1/1] cxl: don't manipulate the mm.mm_users field directly

Re: [PATCH v2] powerpc/pseries: export LPAR security flavor in lparcfg

2021-03-30 Thread Michael Ellerman
On Fri, 5 Mar 2021 13:55:54 +0100, Laurent Dufour wrote: > This is helpful to read the security flavor from inside the LPAR. > > In /sys/kernel/debug/powerpc/security_features it can be seen if > mitigations are on or off but the level set through the ASMI menu. > Furthermore, reporting it

Re: [PATCH] powerpc/pci: fix warning comparing pointer to 0

2021-03-30 Thread Michael Ellerman
On Mon, 15 Mar 2021 15:35:24 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./arch/powerpc/platforms/maple/pci.c:37:16-17: WARNING comparing pointer > to 0. Applied to powerpc/next. [1/1] powerpc/pci: fix warning comparing pointer to 0

Re: [RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location

2021-03-30 Thread Michael Ellerman
On Wed, 3 Mar 2021 12:46:03 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for > ‘hvc_vio_init_early’ [-Wmissing-prototypes] > 385 | void __init hvc_vio_init_early(void) > | ^~

Re: [PATCH] powerpc/chrp: Make hydra_init() static

2021-03-30 Thread Michael Ellerman
On Tue, 23 Feb 2021 10:53:45 +0100, Geert Uytterhoeven wrote: > Commit 407d418f2fd4c20a ("powerpc/chrp: Move PHB discovery") moved the > sole call to hydra_init() to the source file where it is defined, so it > can be made static. Applied to powerpc/next. [1/1] powerpc/chrp: Make hydra_init()

Re: [PATCH] powerpc: remove unneeded semicolon

2021-03-30 Thread Michael Ellerman
On Wed, 24 Feb 2021 15:29:21 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./arch/powerpc/kernel/prom_init.c:2986:2-3: Unneeded semicolon. Applied to powerpc/next. [1/1] powerpc: remove unneeded semicolon

Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings

2021-03-30 Thread Michael Ellerman
On Tue, 16 Mar 2021 00:11:48 -0400, He Ying wrote: > warning: symbol 'rfi_flush' was not declared. > warning: symbol 'entry_flush' was not declared. > warning: symbol 'uaccess_flush' was not declared. > We found warnings above in arch/powerpc/kernel/setup_64.c by using > sparse tool. > > Define

Re: [PATCH] powerpc/ptrace: Remove duplicate check from pt_regs_check()

2021-03-30 Thread Michael Ellerman
On Fri, 5 Mar 2021 14:28:07 +0300, Denis Efremov wrote: > "offsetof(struct pt_regs, msr) == offsetof(struct user_pt_regs, msr)" > checked in pt_regs_check() twice in a row. Remove the second check. Applied to powerpc/next. [1/1] powerpc/ptrace: Remove duplicate check from pt_regs_check()

Re: [PATCH] powerpc: powernv: Remove unneeded variable: "rc"

2021-03-30 Thread Michael Ellerman
On Fri, 26 Mar 2021 19:53:56 +0800, dingsen...@163.com wrote: > Remove unneeded variable: "rc". Applied to powerpc/next. [1/1] powerpc: powernv: Remove unneeded variable: "rc" https://git.kernel.org/powerpc/c/69931cc387cca289e0415c79ce5389119670066d cheers

Re: [PATCH v3 00/41] powerpc/32: Switch to interrupt entry/exit in C

2021-03-30 Thread Michael Ellerman
On Fri, 12 Mar 2021 12:50:09 + (UTC), Christophe Leroy wrote: > This series aims at porting interrupt entry/exit in C on PPC32, using > the work already merged for PPC64. > > First patch is an optimisation around unrecoverable_exception() function. > > Six following patches do minimal

Re: [PATCH 0/3] powerpc/qspinlock: Some tuning updates

2021-03-30 Thread Michael Ellerman
On Mon, 8 Mar 2021 17:59:47 -0800, Davidlohr Bueso wrote: > A few updates while going through the powerpc port of the qspinlock. > > Patches 1 and 2 are straightforward, while patch 3 can be considered > more of an rfc as I've only tested on a single machine, and there > could be an alternative

Re: [PATCH] powerpc/mm: Remove unneeded #ifdef CONFIG_PPC_MEM_KEYS

2021-03-30 Thread Michael Ellerman
On Mon, 15 Mar 2021 14:52:51 + (UTC), Christophe Leroy wrote: > In fault.c, #ifdef CONFIG_PPC_MEM_KEYS is not needed because all > functions are always defined, and arch_vma_access_permitted() > always returns true when CONFIG_PPC_MEM_KEYS is not defined so > access_pkey_error() will return

Re: [PATCH v2 1/4] powerpc: Enable KFENCE for PPC32

2021-03-30 Thread Michael Ellerman
On Thu, 4 Mar 2021 14:35:09 + (UTC), Christophe Leroy wrote: > Add architecture specific implementation details for KFENCE and enable > KFENCE for the ppc32 architecture. In particular, this implements the > required interface in . > > KFENCE requires that attributes for pages from its memory

Re: [PATCH v1 1/4] powerpc: Activate HAVE_RELIABLE_STACKTRACE for all

2021-03-30 Thread Michael Ellerman
On Tue, 16 Mar 2021 07:57:13 + (UTC), Christophe Leroy wrote: > CONFIG_HAVE_RELIABLE_STACKTRACE is applicable to all, no > reason to limit it to book3s/64le Applied to powerpc/next. [1/4] powerpc: Activate HAVE_RELIABLE_STACKTRACE for all

Re: [PATCH v1 0/8] Miscellaneous user access improvement

2021-03-30 Thread Michael Ellerman
On Wed, 10 Mar 2021 17:56:59 + (UTC), Christophe Leroy wrote: > Patches 1-3 are cleaning parts of uaccess.h not related > to put_user/get_user > Patch 4 removes some usage of consecutives __get_user > Patches 5 rewrite __patch_instruction to not use uaccess.h internals. > Patches 6-8 switch

Re: [PATCH] powerpc/math: Fix missing __user qualifier for get_user() and other sparse warnings

2021-03-30 Thread Michael Ellerman
On Mon, 15 Mar 2021 12:00:09 + (UTC), Christophe Leroy wrote: > Sparse reports the following problems: > > arch/powerpc/math-emu/math.c:228:21: warning: Using plain integer as NULL > pointer > arch/powerpc/math-emu/math.c:228:31: warning: Using plain integer as NULL > pointer >

Re: [PATCH] powerpc/Makefile: Remove workaround for gcc versions below 4.9

2021-03-30 Thread Michael Ellerman
On Wed, 10 Mar 2021 12:43:12 + (UTC), Christophe Leroy wrote: > Commit 6ec4476ac825 ("Raise gcc version requirement to 4.9") > made it impossible to build with gcc 4.8 and under. > > Remove related workaround. Applied to powerpc/next. [1/1] powerpc/Makefile: Remove workaround for gcc

Re: [PATCH] powerpc/embedded6xx: Remove CONFIG_MV64X60

2021-03-30 Thread Michael Ellerman
On Thu, 18 Mar 2021 17:25:07 + (UTC), Christophe Leroy wrote: > Commit 92c8c16f3457 ("powerpc/embedded6xx: Remove C2K board support") > moved the last selector of CONFIG_MV64X60. > > As it is not a user selectable config, it can be removed. Applied to powerpc/next. [1/1]

Re: [PATCH v2] powerpc: Fix HAVE_HARDLOCKUP_DETECTOR_ARCH build configuration

2021-03-30 Thread Michael Ellerman
On Mon, 29 Mar 2021 10:27:00 +0800, Chen Huang wrote: > When compiling the powerpc with the SMP disabled, it shows the issue: > > arch/powerpc/kernel/watchdog.c: In function ‘watchdog_smp_panic’: > arch/powerpc/kernel/watchdog.c:177:4: error: implicit declaration of function >

Re: [PATCH] powerpc: Fix HAVE_HARDLOCKUP_DETECTOR_ARCH build configuration

2021-03-30 Thread Michael Ellerman
On Sat, 27 Mar 2021 09:49:00 +, Chen Huang wrote: > When compiling the powerpc with the SMP disabled, it shows the issue: > > arch/powerpc/kernel/watchdog.c: In function ‘watchdog_smp_panic’: > arch/powerpc/kernel/watchdog.c:177:4: error: implicit declaration of function >

Re: [PATCH] powerpc/asm-offsets: GPR14 is not needed either

2021-03-30 Thread Michael Ellerman
On Mon, 15 Mar 2021 11:01:26 + (UTC), Christophe Leroy wrote: > Commit aac6a91fea93 ("powerpc/asm: Remove unused symbols in > asm-offsets.c") removed GPR15 to GPR31 but kept GPR14, > probably because it pops up in a couple of comments when doing > a grep. > > However, it was never used

Re: [PATCH v11 0/6] KASAN for powerpc64 radix

2021-03-29 Thread Michael Ellerman
Christophe Leroy writes: > Le 23/03/2021 à 02:21, Daniel Axtens a écrit : >> Hi Christophe, >> >>> In the discussion we had long time ago, >>> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20190806233827.16454-5-...@axtens.net/#2321067 >>> , I challenged you on why it was not possible

Re: [PATCH V2 1/5] powerpc/perf: Expose processor pipeline stage cycles using PERF_SAMPLE_WEIGHT_STRUCT

2021-03-27 Thread Michael Ellerman
Arnaldo writes: > On March 25, 2021 11:38:01 AM GMT-03:00, Peter Zijlstra > wrote: >>On Thu, Mar 25, 2021 at 10:01:35AM -0300, Arnaldo Carvalho de Melo >>wrote:. >>> > > Also for CPU_FTR_ARCH_31, capture the two cycle counter >>information in >>> > > two 16 bit fields of perf_sample_weight

  1   2   3   4   5   6   7   8   9   10   >