Re: [PATCH] drivers: gpio: gpio-adp5588: Fix sleep-in-atomic-context bug

On 29.08.2018 10:55, Linus Walleij wrote: On Mon, Aug 13, 2018 at 3:53 PM wrote: From: Michael Hennerich This fixes: [BUG] gpio: gpio-adp5588: A possible sleep-in-atomic-context bug in adp5588_gpio_write() [BUG] gpio: gpio-adp5588: A possible sleep-in-atomic

Re: [PATCH] drivers: gpio: gpio-adp5588: Fix sleep-in-atomic-context bug

On 29.08.2018 10:55, Linus Walleij wrote: On Mon, Aug 13, 2018 at 3:53 PM wrote: From: Michael Hennerich This fixes: [BUG] gpio: gpio-adp5588: A possible sleep-in-atomic-context bug in adp5588_gpio_write() [BUG] gpio: gpio-adp5588: A possible sleep-in-atomic

Re: [BUG] gpio: gpio-adp5588: A possible sleep-in-atomic-context bug in adp5588_gpio_direction_input()

On 11.08.2018 04:03, Jia-Ju Bai wrote: The driver may sleep with holding a spinlock. The function call paths (from bottom to top) in Linux-4.16 are: [FUNC] mutex_lock_nested drivers/gpio/gpio-adp5588.c, 113: mutex_lock_nested in adp5588_gpio_direction_input drivers/gpio/gpio-adp5588.c, 224:

Re: [BUG] gpio: gpio-adp5588: A possible sleep-in-atomic-context bug in adp5588_gpio_direction_input()

On 11.08.2018 04:03, Jia-Ju Bai wrote: The driver may sleep with holding a spinlock. The function call paths (from bottom to top) in Linux-4.16 are: [FUNC] mutex_lock_nested drivers/gpio/gpio-adp5588.c, 113: mutex_lock_nested in adp5588_gpio_direction_input drivers/gpio/gpio-adp5588.c, 224:

Re: [PATCH v2 09/14] staging: iio: ad7746: Add remove()

On 18.04.2018 21:25, Hernán Gonzalez wrote: On Sun, Apr 15, 2018 at 12:31 PM, Jonathan Cameron wrote: On Fri, 13 Apr 2018 13:36:46 -0300 Hernán Gonzalez wrote: This allows the driver to be probed and removed as a module powering it down on

Re: [PATCH v2 09/14] staging: iio: ad7746: Add remove()

On 18.04.2018 21:25, Hernán Gonzalez wrote: On Sun, Apr 15, 2018 at 12:31 PM, Jonathan Cameron wrote: On Fri, 13 Apr 2018 13:36:46 -0300 Hernán Gonzalez wrote: This allows the driver to be probed and removed as a module powering it down on remove(). Signed-off-by: Hernán Gonzalez ---

Re: [PATCH 1/4] i2c: mux: ltc4306: switch to using .probe_new

On 17.04.2018 16:32, Peter Rosin wrote: Use the new probe style for i2c drivers. Signed-off-by: Peter Rosin <p...@axentia.se> Thanks Peter, Don't know why i2c needs a new probe style to save one function parameter... But this patch looks otherwise good to me. Acked-by: Michael Hen

Re: [PATCH 1/4] i2c: mux: ltc4306: switch to using .probe_new

On 17.04.2018 16:32, Peter Rosin wrote: Use the new probe style for i2c drivers. Signed-off-by: Peter Rosin Thanks Peter, Don't know why i2c needs a new probe style to save one function parameter... But this patch looks otherwise good to me. Acked-by: Michael Hennerich --- drivers/i2c

Re: [PATCH 5/5] backlight: adp8860: document sysfs attributes

On 26.01.2018 15:55, Aishwarya Pant wrote: Add documentation for sysfs interface of adp8860 series backlight devices by reading through code and git commits. Signed-off-by: Aishwarya Pant <aishp...@gmail.com> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- ...

Re: [PATCH 5/5] backlight: adp8860: document sysfs attributes

On 26.01.2018 15:55, Aishwarya Pant wrote: Add documentation for sysfs interface of adp8860 series backlight devices by reading through code and git commits. Signed-off-by: Aishwarya Pant Acked-by: Michael Hennerich --- .../ABI/testing/sysfs-class-backlight-adp8860 | 54

Re: [PATCH 4/5] backlight: adp5520: document sysfs attributes

On 26.01.2018 15:54, Aishwarya Pant wrote: Add documentation for sysfs interface of adp5520/adp5501 analog devices backlight driver by reading code and looking through git commit logs. Signed-off-by: Aishwarya Pant <aishp...@gmail.com> Acked-by: Michael Hennerich <michael.henner...@a

Re: [PATCH 4/5] backlight: adp5520: document sysfs attributes

On 26.01.2018 15:54, Aishwarya Pant wrote: Add documentation for sysfs interface of adp5520/adp5501 analog devices backlight driver by reading code and looking through git commit logs. Signed-off-by: Aishwarya Pant Acked-by: Michael Hennerich --- .../ABI/testing/sysfs-class-backlight

Re: [PATCH] Input: adp5520-keys: Delete an error message for a failed memory allocation in adp5520_keys_probe()

Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/input/keyboard/adp5520-keys.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/keyboard/adp5520-keys.c b/drivers/input/keyboard/ad

Re: [PATCH] Input: adp5520-keys: Delete an error message for a failed memory allocation in adp5520_keys_probe()

On 27.01.2018 15:20, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 27 Jan 2018 15:15:52 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Michael

Re: [PATCH] staging: iio: ad7192: Use the dedicated reset function

com> Acked-by: Michael Hennerich <michael.henner...@analog.com> Well done! --- drivers/staging/iio/adc/ad7192.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c index d11c6de..6150d27 100644 -

Re: [PATCH] staging: iio: ad7192: Use the dedicated reset function

On 14.09.2017 15:50, Stefan Popa wrote: SPI host drivers can use DMA to transfer data, so the buffer should be properly allocated. Keeping it on the stack could cause an undefined behavior. The dedicated reset function solves this issue. Signed-off-by: Stefan Popa Acked-by: Michael

Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm

> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- arch/blackfin/mach-bf537/boards/stamp.c| 2 +- drivers/video/backlight/adp8860_bl.c | 2 +- include/linux/{i2c => platform_data}/adp8860.h | 0 3 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm

On 07.06.2017 12:57, Daniel Thompson wrote: On 21/05/17 23:09, Wolfram Sang wrote: include/linux/i2c is not for client devices. Move the header file to a more appropriate location. Signed-off-by: Wolfram Sang Acked-by: Daniel Thompson Acked-by: Michael Hennerich --- arch/blackfin

Re: [PATCH v5 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 12.04.2017 18:53, Peter Rosin wrote: On 2017-04-12 10:26, Linus Walleij wrote: On Tue, Apr 11, 2017 at 2:16 PM, <michael.henner...@analog.com> wrote: From: Michael Hennerich <michael.henner...@analog.com> This patch adds support for the Analog Devices / Linear Techno

Re: [PATCH v5 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 12.04.2017 18:53, Peter Rosin wrote: On 2017-04-12 10:26, Linus Walleij wrote: On Tue, Apr 11, 2017 at 2:16 PM, wrote: From: Michael Hennerich This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 06.04.2017 22:03, Peter Rosin wrote: On 2017-04-06 13:31, Michael Hennerich wrote: On 06.04.2017 10:39, Peter Rosin wrote: Hi Peter, again - thanks for your review. Comments below. +static const struct regmap_config ltc4306_regmap_config = { + .reg_bits = 8, + .val_bits = 8

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 06.04.2017 22:03, Peter Rosin wrote: On 2017-04-06 13:31, Michael Hennerich wrote: On 06.04.2017 10:39, Peter Rosin wrote: Hi Peter, again - thanks for your review. Comments below. +static const struct regmap_config ltc4306_regmap_config = { + .reg_bits = 8, + .val_bits = 8

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 10.04.2017 22:04, Linus Walleij wrote: On Wed, Apr 5, 2017 at 3:07 PM, <michael.henner...@analog.com> wrote: From: Michael Hennerich <michael.henner...@analog.com> This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 10.04.2017 22:04, Linus Walleij wrote: On Wed, Apr 5, 2017 at 3:07 PM, wrote: From: Michael Hennerich This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two general purpose

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

. Cheers, peda On 2017-04-05 15:07, michael.henner...@analog.com wrote: From: Michael Hennerich <michael.henner...@analog.com> This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two g

Re: [PATCH v4 2/2] i2c: mux: ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

. Cheers, peda On 2017-04-05 15:07, michael.henner...@analog.com wrote: From: Michael Hennerich This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two general purpose input/output pins (GPIOs

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 04.04.2017 11:28, Peter Rosin wrote: *snip* *snip* +static int ltc4306_gpio_get(struct gpio_chip *chip, unsigned int offset) +{ + struct ltc4306 *data = gpiochip_get_data(chip); + int ret = 0; + + if (gpiochip_line_is_open_drain(chip, offset) || +

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 04.04.2017 11:28, Peter Rosin wrote: *snip* *snip* +static int ltc4306_gpio_get(struct gpio_chip *chip, unsigned int offset) +{ + struct ltc4306 *data = gpiochip_get_data(chip); + int ret = 0; + + if (gpiochip_line_is_open_drain(chip, offset) || +

Re: question about concurrent regmap i2c usage

On 04.04.2017 14:26, Mark Brown wrote: On Tue, Apr 04, 2017 at 10:28:23AM +0200, Michael Hennerich wrote: A question came up, regarding whether it's recommended to mix regmap_i2c and plain i2c_smbus or direct adapter transfers. In this specific case for the i2c MUX portion we need to avoid

Re: question about concurrent regmap i2c usage

On 04.04.2017 14:26, Mark Brown wrote: On Tue, Apr 04, 2017 at 10:28:23AM +0200, Michael Hennerich wrote: A question came up, regarding whether it's recommended to mix regmap_i2c and plain i2c_smbus or direct adapter transfers. In this specific case for the i2c MUX portion we need to avoid

question about concurrent regmap i2c usage

Hi Mark, During the discussion here: https://lkml.org/lkml/2017/4/4/76 A question came up, regarding whether it's recommended to mix regmap_i2c and plain i2c_smbus or direct adapter transfers. In this specific case for the i2c MUX portion we need to avoid double locks, and therefore use

question about concurrent regmap i2c usage

Hi Mark, During the discussion here: https://lkml.org/lkml/2017/4/4/76 A question came up, regarding whether it's recommended to mix regmap_i2c and plain i2c_smbus or direct adapter transfers. In this specific case for the i2c MUX portion we need to avoid double locks, and therefore use

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

: Michael Hennerich <michael.henner...@analog.com> This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two general purpose input/output pins (GPIOs) that can be configured as logic

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

: Michael Hennerich This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two general purpose input/output pins (GPIOs) that can be configured as logic inputs, opendrain outputs or push-pull

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 03.04.2017 16:20, Peter Rosin wrote: On 2017-04-03 15:36, Michael Hennerich wrote: On 03.04.2017 14:03, Peter Rosin wrote: On 2017-03-31 17:29, Peter Rosin wrote: Hi! Sorry for my incremental reviewing... Another incremental... On 2017-03-29 12:15, michael.henner...@analog.com wrote

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 03.04.2017 16:20, Peter Rosin wrote: On 2017-04-03 15:36, Michael Hennerich wrote: On 03.04.2017 14:03, Peter Rosin wrote: On 2017-03-31 17:29, Peter Rosin wrote: Hi! Sorry for my incremental reviewing... Another incremental... On 2017-03-29 12:15, michael.henner...@analog.com wrote

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 03.04.2017 14:03, Peter Rosin wrote: On 2017-03-31 17:29, Peter Rosin wrote: Hi! Sorry for my incremental reviewing... Another incremental... On 2017-03-29 12:15, michael.henner...@analog.com wrote: + + /* Now create an adapter for each channel */ + for (num = 0; num <

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 03.04.2017 14:03, Peter Rosin wrote: On 2017-03-31 17:29, Peter Rosin wrote: Hi! Sorry for my incremental reviewing... Another incremental... On 2017-03-29 12:15, michael.henner...@analog.com wrote: + + /* Now create an adapter for each channel */ + for (num = 0; num <

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

On 23.03.2017 12:05, Lars-Peter Clausen wrote: Sorry - I missed some of this review feedback ... + +static int ltc2497_wait_conv(struct ltc2497_st *st) +{ + s64 time_elapsed; + + time_elapsed = ktime_ms_delta(ktime_get(), st->time_prev); + + if (time_elapsed <

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

On 23.03.2017 12:05, Lars-Peter Clausen wrote: Sorry - I missed some of this review feedback ... + +static int ltc2497_wait_conv(struct ltc2497_st *st) +{ + s64 time_elapsed; + + time_elapsed = ktime_ms_delta(ktime_get(), st->time_prev); + + if (time_elapsed <

Re: [PATCH] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 24.03.2017 09:01, Peter Rosin wrote: On 2017-03-23 15:22, michael.henner...@analog.com wrote: From: Michael Hennerich <michael.henner...@analog.com> This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The L

Re: [PATCH] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

On 24.03.2017 09:01, Peter Rosin wrote: On 2017-03-23 15:22, michael.henner...@analog.com wrote: From: Michael Hennerich This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two general

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

On 23.03.2017 12:28, Peter Meerwald-Stadler wrote: On Thu, 23 Mar 2017, michael.henner...@analog.com wrote: From: Michael Hennerich <michael.henner...@analog.com> comments below Hi Peter, Thanks for the review - comments inline. Signed-off-by: Michael Hennerich <micha

Re: [PATCH] iio/adc/ltc2497: Driver for Linear Technology LTC2497 ADC

On 23.03.2017 12:28, Peter Meerwald-Stadler wrote: On Thu, 23 Mar 2017, michael.henner...@analog.com wrote: From: Michael Hennerich comments below Hi Peter, Thanks for the review - comments inline. Signed-off-by: Michael Hennerich --- .../devicetree/bindings/iio/adc/ltc2497.txt

Re: [PATCH 2/4] Input: ad7879 - return plain error code from ad7879_probe()

not trigger, but was not correct regardless). Fixes: 381f688eee3d ("Input: ad7879 - use more devm interfaces") Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/input/touchsc

Re: [PATCH 2/4] Input: ad7879 - return plain error code from ad7879_probe()

not trigger, but was not correct regardless). Fixes: 381f688eee3d ("Input: ad7879 - use more devm interfaces") Signed-off-by: Dmitry Torokhov Acked-by: Michael Hennerich --- drivers/input/touchscreen/ad7879-i2c.c | 9 ++--- drivers/input/touchscreen/ad7879-spi.c | 7 +-

Re: [PATCH 3/4] Input: ad7879 - try parsing properties on non-DT systems

On 28.02.2017 23:08, Dmitry Torokhov wrote: We have switched the driver to use generic device properties API, so there is no need to check for presence of DT node before trying parse properties. Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Acked-by: Michael Hen

Re: [PATCH 3/4] Input: ad7879 - try parsing properties on non-DT systems

On 28.02.2017 23:08, Dmitry Torokhov wrote: We have switched the driver to use generic device properties API, so there is no need to check for presence of DT node before trying parse properties. Signed-off-by: Dmitry Torokhov Acked-by: Michael Hennerich --- drivers/input/touchscreen

Re: [PATCH 1/4] Input: ad7879 - make sure we set up drvdata

devm interfaces") Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/input/touchscreen/ad7879-spi.c | 2 -- drivers/input/touchscreen/ad7879.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 1/4] Input: ad7879 - make sure we set up drvdata

devm interfaces") Signed-off-by: Dmitry Torokhov Acked-by: Michael Hennerich --- drivers/input/touchscreen/ad7879-spi.c | 2 -- drivers/input/touchscreen/ad7879.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/t

Re: [PATCH 4/4] Input: ad7879 - do not manipulate capability bits directly

com> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/input/touchscreen/ad7879.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c index c415614ada68..196028c

Re: [PATCH 4/4] Input: ad7879 - do not manipulate capability bits directly

On 28.02.2017 23:08, Dmitry Torokhov wrote: Instead of manipulating capabilities bits of input device directly, let's use input_set_capability() API. Also, stop setting ABS_X/Y bits explicitly as input_set_abs_params() does this for us. Signed-off-by: Dmitry Torokhov Acked-by: Michael

Re: [RFC/RFT PATCH 1/3] Input: ad7879 - convert to use regmap

On 18.02.2017 00:31, Dmitry Torokhov wrote: Instead of rolling our own infrastructure to provide uniform access to I2C and SPI buses, let's switch to using regmap. Signed-off-by: Dmitry Torokhov --- Michael, I am a bit (actually a lot) confused how this driver was

Re: [RFC/RFT PATCH 1/3] Input: ad7879 - convert to use regmap

On 18.02.2017 00:31, Dmitry Torokhov wrote: Instead of rolling our own infrastructure to provide uniform access to I2C and SPI buses, let's switch to using regmap. Signed-off-by: Dmitry Torokhov --- Michael, I am a bit (actually a lot) confused how this driver was working with SPI and

Re: [PATCH] backlight: adp5520: fix error handling in adp5520_bl_probe()

Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/video/backlight/adp5520_bl.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/adp5520_bl.c b/drivers/video/backlight/adp5520_bl.c index dd88ba1d71ce..35373e2

Re: [PATCH] backlight: adp5520: fix error handling in adp5520_bl_probe()

On 09.07.2016 00:19, Alexey Khoroshilov wrote: If adp5520_bl_setup() fails, sysfs group left unremoved. By the way, fix overcomplicated assignement of error code. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Acked-by: Michael Hennerich

Re: [PATCH] iio: dac: fix off-by-one comparison and out-of-bounds write

nical.com> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/iio/dac/ad5592r-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c index 948f600..69bde59 100644 --- a/drivers/iio/dac/ad559

Re: [PATCH] iio: dac: fix off-by-one comparison and out-of-bounds write

On 06/02/2016 12:06 PM, Colin King wrote: From: Colin Ian King The check on reg is off-by-one, it should be >= rather than >. Fix this to stop an out-of-bounds write to st->channel_modes[reg]. Signed-off-by: Colin Ian King Acked-by: Michael Hennerich --- drivers/iio/dac/ad559

Re: [PATCH 1/1] net: ieee802154/adf7242: syntax error ifdef DEBUG

On 05/17/2016 11:58 PM, Heinrich Schuchardt wrote: If DEBUG is defined, a superfluous closing brace is introduced. Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/net/ieee802154/adf7242.c | 1 - 1

Re: [PATCH 1/1] net: ieee802154/adf7242: syntax error ifdef DEBUG

On 05/17/2016 11:58 PM, Heinrich Schuchardt wrote: If DEBUG is defined, a superfluous closing brace is introduced. Signed-off-by: Heinrich Schuchardt Acked-by: Michael Hennerich --- drivers/net/ieee802154/adf7242.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net

Re: [PATCH] ieee802154/adf7242: fix memory leak of firmware

On 04/07/2016 01:16 PM, Sudip Mukherjee wrote: If the firmware upload or the firmware verification fails then we printed the error message and exited but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Acked-by: Michael Hen

Re: [PATCH] ieee802154/adf7242: fix memory leak of firmware

On 04/07/2016 01:16 PM, Sudip Mukherjee wrote: If the firmware upload or the firmware verification fails then we printed the error message and exited but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee Acked-by: Michael Hennerich --- drivers/net/ieee802154/adf7242.c | 2

Re: [PATCH 06/61] gpio: adp5520: Use devm_gpiochip_add_data() for gpio registration

On 02/22/2016 03:07 PM, Laxman Dewangan wrote: Use devm_gpiochip_add_data() for GPIO registration and remove the call for gpiochip_remove() from error path. Also remove the need of driver callback .remove. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Acked-by: Michael Hen

Re: [PATCH 06/61] gpio: adp5520: Use devm_gpiochip_add_data() for gpio registration

On 02/22/2016 03:07 PM, Laxman Dewangan wrote: Use devm_gpiochip_add_data() for GPIO registration and remove the call for gpiochip_remove() from error path. Also remove the need of driver callback .remove. Signed-off-by: Laxman Dewangan Acked-by: Michael Hennerich Cc: Michael Hennerich

Re: [PATCH 07/61] gpio: adp5588: Use devm_gpiochip_add_data() for gpio registration

On 02/22/2016 03:07 PM, Laxman Dewangan wrote: Use devm_gpiochip_add_data() for GPIO registration and remove the call for gpiochip_remove() from remove callback. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Acked-by: Michael Hennerich <michael.henner...@analog.com>

Re: [PATCH 07/61] gpio: adp5588: Use devm_gpiochip_add_data() for gpio registration

On 02/22/2016 03:07 PM, Laxman Dewangan wrote: Use devm_gpiochip_add_data() for GPIO registration and remove the call for gpiochip_remove() from remove callback. Signed-off-by: Laxman Dewangan Acked-by: Michael Hennerich Cc: Michael Hennerich --- drivers/gpio/gpio-adp5588.c | 4

Re: [PATCH] misc: ad525x_dpot: Fix the enabling of the "otpXen" attributes

On 11/19/2015 09:22 AM, Michael Hennerich wrote: On 11/18/2015 05:16 PM, Dan Bogdan Nechita wrote: Currently writing the attributes with "echo" will result in comparing: "enabled\n" with "enabled\0" and attribute is always set to false. Use the sysfs_streq() inst

Re: [PATCH] misc: ad525x_dpot: Fix the enabling of the "otpXen" attributes

On 11/19/2015 09:22 AM, Michael Hennerich wrote: On 11/18/2015 05:16 PM, Dan Bogdan Nechita wrote: Currently writing the attributes with "echo" will result in comparing: "enabled\n" with "enabled\0" and attribute is always set to false. Use the sysfs_streq() inst

Re: [PATCH] regulator: ad5398: Fix return value of ad5398_write_reg

, for example, if the users test if the return value of regulator_set_current_limit() is 0. Fix it by making ad5398_write_reg() return 0 on success. Signed-off-by: Axel Lin Acked-by: Michael Hennerich --- drivers/regulator/ad5398.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH] regulator: ad5398: Fix return value of ad5398_write_reg

, for example, if the users test if the return value of regulator_set_current_limit() is 0. Fix it by making ad5398_write_reg() return 0 on success. Signed-off-by: Axel Lin <axel@ingics.com> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/regulator/ad5398.c |

Re: [PATCH v3 3/3] input: touchscreen: ad7879: add device tree support

, the only exception being GPIO capabilities, which can not be activated through device tree currently. Acked-by: Rob Herring Signed-off-by: Stefan Agner Acked-by: Michael Hennerich --- Changes since v2: - do not free driver data and irq on remove (since we are using devm now) Changes since v1

Re: [PATCH v3 2/3] input: touchscreen: ad7879: fix default x/y axis assignment

the two axis. Signed-off-by: Stefan Agner Acked-by: Michael Hennerich --- Changes since v2: - (none) Changes since v1: - Keep axis swapped by default when using platform data drivers/input/touchscreen/ad7879.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/

Re: [PATCH v3 2/3] input: touchscreen: ad7879: fix default x/y axis assignment

the two axis. Signed-off-by: Stefan Agner <ste...@agner.ch> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- Changes since v2: - (none) Changes since v1: - Keep axis swapped by default when using platform data drivers/input/touchscreen/ad7879.c | 8 +--- 1 f

Re: [PATCH v3 3/3] input: touchscreen: ad7879: add device tree support

, the only exception being GPIO capabilities, which can not be activated through device tree currently. Acked-by: Rob Herring <r...@kernel.org> Signed-off-by: Stefan Agner <ste...@agner.ch> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- Changes since v2: - do no

Re: [PATCH 2/3] input: touchscreen: ad7879: fix default x/y axis assignment

On 01/26/2016 04:04 AM, Stefan Agner wrote: The measurements read from the controller which are temporary stored in conversion_data, are interpreted wrong. The first measurement X+ contains the Y position, and the second measurement Y+ the X position (see also Table 11 Register Table in the data

Re: [PATCH 3/3] input: touchscreen: ad7879: add device tree support

On 01/26/2016 04:04 AM, Stefan Agner wrote: Add device tree support for the I2C variant of AD7879 (AD7879-1). This allows to specify the touchscreen controller as a I2C client node. Most of the options available as platform data are also available as device tree properties. Exporting the GPIO is

Re: [PATCH 3/3] input: touchscreen: ad7879: add device tree support

On 01/26/2016 04:04 AM, Stefan Agner wrote: Add device tree support for the I2C variant of AD7879 (AD7879-1). This allows to specify the touchscreen controller as a I2C client node. Most of the options available as platform data are also available as device tree properties. Exporting the GPIO is

Re: [PATCH 2/3] input: touchscreen: ad7879: fix default x/y axis assignment

On 01/26/2016 04:04 AM, Stefan Agner wrote: The measurements read from the controller which are temporary stored in conversion_data, are interpreted wrong. The first measurement X+ contains the Y position, and the second measurement Y+ the X position (see also Table 11 Register Table in the data

Re: [PATCH] backlight: adp8860: fix another uninitialized variable use

-by: Arnd Bergmann Acked-by: Michael Hennerich Fixes: 6be3a5a9cd91 ("backlight: adp88x0: Fix uninitialized variable use") --- Sorry for missing this third hunk the first time around. diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index f0

Re: [PATCH] backlight: adp8860: fix another uninitialized variable use

-by: Arnd Bergmann <a...@arndb.de> Acked-by: Michael Hennerich <michael.henner...@analog.com> Fixes: 6be3a5a9cd91 ("backlight: adp88x0: Fix uninitialized variable use") --- Sorry for missing this third hunk the first time around. diff --git a/drivers/video/backlight/adp8860

Re: [PATCH] backlight: adp88x0: fix uninitialized variable use

to fix every bug twice. Signed-off-by: Arnd Bergmann Acked-by: Michael Hennerich diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 98ffe71e8af2..f0d4c0324580 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c

Re: [PATCH] backlight: adp88x0: fix uninitialized variable use

to fix every bug twice. Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Michael Hennerich <michael.henner...@analog.com> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 98ffe71e8af2..f0d4c0324580 100644 --- a/drivers/vid

Re: [PATCH] misc: ad525x_dpot: Fix the enabling of the "otpXen" attributes

-then-NUL as equivalent string terminations. Signed-off-by: Dan Bogdan Nechita Acked-by: Michael Hennerich --- drivers/misc/ad525x_dpot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index 15e8807..4230e6a 100644 --

Re: [PATCH] misc: ad525x_dpot: Fix the enabling of the "otpXen" attributes

-then-NUL as equivalent string terminations. Signed-off-by: Dan Bogdan Nechita <dan.bogdan.nech...@gmail.com> Acked-by: Michael Hennerich <michael.henner...@analog.com> --- drivers/misc/ad525x_dpot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/

Re: [PATCH/RFC 09/51] leds: adp5520: Remove work queue

On 07/17/2015 10:46 AM, Jacek Anaszewski wrote: From: Andrew Lunn Now the core implements the work queue, remove it from the driver. Signed-off-by: Andrew Lunn Acked-by: Michael Hennerich Cc: Michael Hennerich --- drivers/leds/leds-adp5520.c | 22 +++--- 1 file

Re: [PATCH/RFC 09/51] leds: adp5520: Remove work queue

On 07/17/2015 10:46 AM, Jacek Anaszewski wrote: From: Andrew Lunn and...@lunn.ch Now the core implements the work queue, remove it from the driver. Signed-off-by: Andrew Lunn and...@lunn.ch Acked-by: Michael Hennerich michael.henner...@analog.com Cc: Michael Hennerich michael.henner

Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path

On 10/07/2014 09:30 AM, Pramod Gurav wrote: This change introduces a label to call cancel_delayed_work_sync in failure path. Cc: Michael Hennerich Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Signed-off-by: Pramod Gurav The interrupt triggers the work queue. adp5588_setup() enable

Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path

On 10/07/2014 09:30 AM, Pramod Gurav wrote: This change introduces a label to call cancel_delayed_work_sync in failure path. Cc: Michael Hennerich michael.henner...@analog.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux-in...@vger.kernel.org Signed-off-by: Pramod Gurav pramod.gu

Re: [PATCH 03/12] backlight: adp8870: Remove unnecessary OOM messages

On 02/06/2014 09:17 AM, Jingoo Han wrote: The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han Acked-by: Michael Hennerich --- drivers/video/backlight/adp8870_bl.c |4 +--- 1 file changed, 1 insertion

Re: [PATCH 03/12] backlight: adp8870: Remove unnecessary OOM messages

On 02/06/2014 09:17 AM, Jingoo Han wrote: The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han jg1@samsung.com Acked-by: Michael Hennerich michael.henner...@analog.com --- drivers/video/backlight

Re: [PATCH 4/5] drivers: misc: Mark functions as static in ad525x_dpot.c

: warning: no previous prototype for ‘ad_dpot_add_files’ [-Wmissing-prototypes] drivers/misc/ad525x_dpot.c:669:13: warning: no previous prototype for ‘ad_dpot_remove_files’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria Acked-by: Michael Hennerich --- drivers/misc/ad525x_dpot.c |4

Re: [PATCH 4/5] drivers: misc: Mark functions as static in ad525x_dpot.c

: warning: no previous prototype for ‘ad_dpot_add_files’ [-Wmissing-prototypes] drivers/misc/ad525x_dpot.c:669:13: warning: no previous prototype for ‘ad_dpot_remove_files’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com Acked-by: Michael Hennerich michael.henner

Re: [PATCH] backlight: adp8860/adp8870: Fix resume

Acked-by: Michael Hennerich --- drivers/video/backlight/adp8860_bl.c | 2 +- drivers/video/backlight/adp8870_bl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 6bb72c0..a77c9ca 100644

Re: [PATCH] mfd:adp5520: Restore mode bits on resume

-by: Michael Hennerich --- drivers/mfd/adp5520.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c index 210dd03..6b40e0c 100644 --- a/drivers/mfd/adp5520.c +++ b/drivers/mfd/adp5520.c @@ -36,6 +36,7 @@ struct adp5520_chip

Re: [PATCH] backlight: adp8860/adp8870: Fix resume

...@metafoo.de Acked-by: Michael Hennerich michael.henner...@analog.com --- drivers/video/backlight/adp8860_bl.c | 2 +- drivers/video/backlight/adp8870_bl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight

Re: [PATCH] mfd:adp5520: Restore mode bits on resume

Acked-by: Michael Hennerich michael.henner...@analog.com --- drivers/mfd/adp5520.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c index 210dd03..6b40e0c 100644 --- a/drivers/mfd/adp5520.c +++ b/drivers/mfd/adp5520.c

Re: [PATCH] mfd: use module_i2c_driver to simplify the code

On 10/08/2012 04:09 PM, Wei Yongjun wrote: From: Wei Yongjun Use the module_i2c_driver() macro to make the code smaller and a bit simpler. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Acked-by: Michael Hennerich

Re: [PATCH] mfd: use module_i2c_driver to simplify the code

...@trendmicro.com.cn Acked-by: Michael Hennerich michael.henner...@analog.com --- drivers/mfd/adp5520.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c index ea8b947..94e7a6d 100644 --- a/drivers/mfd/adp5520.c +++ b