Re: [PATCH resend ftrace] Asynchronous grace period for register_ftrace_direct()

2024-05-02 Thread Paul E. McKenney
On Thu, May 02, 2024 at 05:31:00PM -0400, Steven Rostedt wrote: > On Wed, 1 May 2024 20:31:06 -0700 > "Paul E. McKenney" wrote: > > > On Thu, May 02, 2024 at 11:05:01AM +0900, Masami Hiramatsu wrote: > > > On Wed, 1 May 2024 16:12:37 -0700 > > > "

Re: [PATCH resend ftrace] Asynchronous grace period for register_ftrace_direct()

2024-05-01 Thread Paul E. McKenney
On Thu, May 02, 2024 at 11:05:01AM +0900, Masami Hiramatsu wrote: > On Wed, 1 May 2024 16:12:37 -0700 > "Paul E. McKenney" wrote: > > > Note that the immediate pressure for this patch should be relieved by the > > NAPI patch series [1], but this sort of p

[PATCH resend ftrace] Asynchronous grace period for register_ftrace_direct()

2024-05-01 Thread Paul E. McKenney
registration. Therefore, make the registration-side RCU Tasks grace period be asynchronous via call_rcu_tasks(). [1] https://lore.kernel.org/all/cover.1710877680.git@cloudflare.com/ Reported-by: Jakub Kicinski Reported-by: Alexei Starovoitov Reported-by: Chris Mason Signed-off-by: Paul E

Re: [PATCH v4 2/2] rethook: honor CONFIG_FTRACE_VALIDATE_RCU_IS_WATCHING in rethook_try_get()

2024-04-18 Thread Paul E. McKenney
etprobe (which rely on rethook) runtime throughput > by 2.3%, according to BPF benchmarks ([0]). > > [0] > https://lore.kernel.org/bpf/caef4bzauq2wkmjzdc9s0rbwa01bybgwhn6andxqshyia47p...@mail.gmail.com/ > > Signed-off-by: Andrii Nakryiko Acked-by: Paul E. McKenney > --- &g

Re: [PATCH v2 fs/proc/bootconfig 0/2] remove redundant comments from /proc/bootconfig

2024-04-09 Thread Paul E. McKenney
l drop them from -rcu. Thanx, Paul > On Mon, 8 Apr 2024 21:42:49 -0700 > "Paul E. McKenney" wrote: > > > Hello! > > > > This series removes redundant comments from /proc/bootconfig: > > > > 1. fs/p

[PATCH v2 fs/proc/bootconfig 1/2] fs/proc: remove redundant comments from /proc/bootconfig

2024-04-08 Thread Paul E. McKenney
... Fixes: 717c7c894d4b ("fs/proc: Add boot loader arguments as comment to /proc/bootconfig") Signed-off-by: Zhenhua Huang Signed-off-by: Paul E. McKenney Cc: Cc: Acked-by: Masami Hiramatsu (Google) --- fs/proc/bootconfig.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

[PATCH v2 fs/proc/bootconfig 2/2] fs/proc: Skip bootloader comment if no embedded kernel parameters

2024-04-08 Thread Paul E. McKenney
le. This will cause automation to fall back to the /proc/cmdline file, which will be identical to the comment in this no-embedded-kernel-parameters case. Signed-off-by: Masami Hiramatsu Signed-off-by: Paul E. McKenney --- fs/proc/bootconfig.c | 2 +- include/linux/bootconfig.h | 1 + init/main.

[PATCH v2 fs/proc/bootconfig 0/2] remove redundant comments from /proc/bootconfig

2024-04-08 Thread Paul E. McKenney
Hello! This series removes redundant comments from /proc/bootconfig: 1. fs/proc: remove redundant comments from /proc/bootconfig, courtesy of Zhenhua Huang. 2. fs/proc: Skip bootloader comment if no embedded kernel parameters, courtesy of Masami Hiramatsu.

Re: [PATCH fs/proc/bootconfig] remove redundant comments from /proc/bootconfig

2024-04-08 Thread Paul E. McKenney
On Tue, Apr 09, 2024 at 09:25:40AM +0900, Masami Hiramatsu wrote: > On Mon, 8 Apr 2024 12:18:19 -0700 > "Paul E. McKenney" wrote: > > > On Sat, Apr 06, 2024 at 11:11:08AM +0900, Masami Hiramatsu wrote: > > > On Thu, 4 Apr 2024 21:25:41 -0700 > > > "

Re: [PATCH fs/proc/bootconfig] remove redundant comments from /proc/bootconfig

2024-04-08 Thread Paul E. McKenney
On Sat, Apr 06, 2024 at 11:11:08AM +0900, Masami Hiramatsu wrote: > On Thu, 4 Apr 2024 21:25:41 -0700 > "Paul E. McKenney" wrote: > > > On Fri, Apr 05, 2024 at 11:57:45AM +0900, Masami Hiramatsu wrote: > > > On Fri, 5 Apr 2024 10:23:24 +0900 >

Re: [PATCH fs/proc/bootconfig] remove redundant comments from /proc/bootconfig

2024-04-04 Thread Paul E. McKenney
On Fri, Apr 05, 2024 at 11:57:45AM +0900, Masami Hiramatsu wrote: > On Fri, 5 Apr 2024 10:23:24 +0900 > Masami Hiramatsu (Google) wrote: > > > On Thu, 4 Apr 2024 10:43:14 -0700 > > "Paul E. McKenney" wrote: > > > > > On Thu, Apr 04, 20

Re: [PATCH fs/proc/bootconfig] remove redundant comments from /proc/bootconfig

2024-04-04 Thread Paul E. McKenney
On Thu, Apr 04, 2024 at 08:55:22AM +0900, Masami Hiramatsu wrote: > On Wed, 3 Apr 2024 12:16:28 -0700 > "Paul E. McKenney" wrote: > > > commit 717c7c894d4b ("fs/proc: Add boot loader arguments as comment to > > /proc/bootconfig") adds bootloade

Re: [PATCH RFC ftrace] Asynchronous grace period for register_ftrace_direct()

2024-04-03 Thread Paul E. McKenney
On Wed, Apr 03, 2024 at 03:29:12PM -0400, Steven Rostedt wrote: > On Wed, 3 Apr 2024 11:53:14 -0700 > "Paul E. McKenney" wrote: > > > @@ -5366,6 +5366,13 @@ static void remove_direct_functions_hash(struct > > ftrace_hash *hash, unsigned long > >

[PATCH fs/proc/bootconfig] remove redundant comments from /proc/bootconfig

2024-04-03 Thread Paul E. McKenney
ot;fs/proc: Add boot loader arguments as comment to /proc/bootconfig") Signed-off-by: Zhenhua Huang Signed-off-by: Paul E. McKenney Cc: Masami Hiramatsu Cc: Cc: diff --git a/fs/proc/bootconfig.c b/fs/proc/bootconfig.c index 902b326e1e560..e5635a6b127b0 100644 --- a/fs/proc/bootco

[PATCH RFC ftrace] Asynchronous grace period for register_ftrace_direct()

2024-04-03 Thread Paul E. McKenney
, significantly slowing trace registration. Therefore, make the registration-side RCU Tasks grace period be asynchronous via call_rcu_tasks(). Reported-by: Jakub Kicinski Reported-by: Alexei Starovoitov Reported-by: Chris Mason Signed-off-by: Paul E. McKenney Cc: Steven Rostedt Cc: Masami

Re: [PATCH RFC ftrace] Chose RCU Tasks based on TASKS_RCU rather than PREEMPTION

2024-03-01 Thread Paul E. McKenney
On Fri, Mar 01, 2024 at 03:30:01PM -0500, Steven Rostedt wrote: > On Fri, 1 Mar 2024 12:25:10 -0800 > "Paul E. McKenney" wrote: > > > > That would work for me. If there are no objections, I will make this > > > change. > > > > But I di

Re: [PATCH RFC ftrace] Chose RCU Tasks based on TASKS_RCU rather than PREEMPTION

2024-03-01 Thread Paul E. McKenney
On Wed, Feb 28, 2024 at 01:16:04PM -0800, Paul E. McKenney wrote: > On Wed, Feb 28, 2024 at 03:22:36PM -0500, Steven Rostedt wrote: > > On Wed, 28 Feb 2024 11:38:29 -0800 > > "Paul E. McKenney" wrote: > > > > > The advent of CONFIG_PREEMPT_AUTO, AKA la

Re: [PATCH RFC ftrace] Chose RCU Tasks based on TASKS_RCU rather than PREEMPTION

2024-02-28 Thread Paul E. McKenney
On Wed, Feb 28, 2024 at 03:22:36PM -0500, Steven Rostedt wrote: > On Wed, 28 Feb 2024 11:38:29 -0800 > "Paul E. McKenney" wrote: > > > The advent of CONFIG_PREEMPT_AUTO, AKA lazy preemption, will mean that > > even kernels built with CONFIG_PREEMPT_NONE or CONFIG_

[PATCH RFC ftrace] Chose RCU Tasks based on TASKS_RCU rather than PREEMPTION

2024-02-28 Thread Paul E. McKenney
synchronize_rcu_tasks() based on CONFIG_TASKS_RCU instead of CONFIG_PREEMPTION. Only build tested. Signed-off-by: Paul E. McKenney Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Ankur Arora Cc: Thomas Gleixner Cc: diff --git a/kernel/trace/ftrace.c b/kernel

Re: [PATCH] tracepoints: Use WARN() and not WARN_ON() for warnings

2024-02-28 Thread Paul E. McKenney
; someone to search for exactly where the bug happened. > > Reported-by: Borislav Petkov > Signed-off-by: Steven Rostedt (Google) Reviewed-by: Paul E. McKenney > --- > include/linux/tracepoint.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff

Re: [RFC PATCH] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-02-03 Thread Paul E. McKenney
On Mon, Jan 29, 2024 at 08:58:10AM +0800, Yang Jihong wrote: > Hello, > > On 2024/1/28 3:22, Paul E. McKenney wrote: > > On Tue, Jan 09, 2024 at 07:28:29PM +0800, Yang Jihong wrote: > > > Hello, > > > > > > PING. > > > > > > I had

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-02-01 Thread Paul E. McKenney
On Sat, Jan 27, 2024 at 06:09:05PM +0800, Chen Zhongjin wrote: > On 2024/1/20 23:30, Paul E. McKenney wrote: (Apologies for the delay, despite my attempts to make it otherwise, your email still got dumped into my spam folder.) > Hi Paul, > This patch works for my reproduce test case.

Re: [RFC PATCH] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-27 Thread Paul E. McKenney
l, this is transparently converted > > * to synchronoze_sched() to wait for all interrupts to have completed. > > */ > > - synchronize_rcu_tasks(); > > + synchronize_rcu_tasks_rude(); > > /* Step 3: Optimize kprobes after quiesence period */ >

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-20 Thread Paul E. McKenney
On Fri, Jan 19, 2024 at 06:37:26AM -0800, Paul E. McKenney wrote: > On Thu, Jan 18, 2024 at 02:18:42AM +, Chen Zhongjin wrote: > > There is a deadlock scenario in kprobe_optimizer(): > > > > pid A pid B pid C

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-19 Thread Paul E. McKenney
On Thu, Jan 18, 2024 at 02:18:42AM +, Chen Zhongjin wrote: > There is a deadlock scenario in kprobe_optimizer(): > > pid A pid B pid C > kprobe_optimizer()do_exit() perf_kprobe_init() > mutex_lock(_mutex)

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-19 Thread Paul E. McKenney
On Thu, Jan 18, 2024 at 06:44:54AM -0800, Paul E. McKenney wrote: > On Wed, Jan 17, 2024 at 09:26:46PM -0500, Steven Rostedt wrote: > > On Thu, 18 Jan 2024 02:18:42 + > > Chen Zhongjin wrote: > > > > > There is a deadlock scenario in kprobe

Re: [PATCH v2] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-18 Thread Paul E. McKenney
On Wed, Jan 17, 2024 at 09:26:46PM -0500, Steven Rostedt wrote: > On Thu, 18 Jan 2024 02:18:42 + > Chen Zhongjin wrote: > > > There is a deadlock scenario in kprobe_optimizer(): > > > > pid A pid B pid C > > kprobe_optimizer()

Re: [PATCH] kprobes: Use synchronize_rcu_tasks_rude in kprobe_optimizer

2024-01-18 Thread Paul E. McKenney
On Wed, Jan 17, 2024 at 12:31:33PM -0800, Andrew Morton wrote: > On Wed, 17 Jan 2024 06:16:36 + Chen Zhongjin > wrote: > > > There is a deadlock scenario in kprobe_optimizer(): > > > > pid A pid B pid C > > kprobe_optimizer()

Re: [PATCH 1/1] fs/proc: remove redudant comments from /proc/bootconfig

2024-01-03 Thread Paul E. McKenney
Good catch, and what I get for testing with only a single bootconfig parameter. :-/ Reviewed-by: Paul E. McKenney Tested-by: Paul E. McKenney > --- > fs/proc/bootconfig.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/proc/bootconfig.c b/

[PATCH rcu v2 04/20] drivers/dax: Remove "select SRCU"

2023-01-12 Thread Paul E. McKenney
Now that the SRCU Kconfig option is unconditionally selected, there is no longer any point in selecting it. Therefore, remove the "select SRCU" Kconfig statements. Signed-off-by: Paul E. McKenney Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Acked-by: Dan Williams Reviewe

Re: [PATCH rcu 11/27] drivers/dax: Remove "select SRCU"

2023-01-05 Thread Paul E. McKenney
On Thu, Jan 05, 2023 at 08:48:28AM -0800, Dan Williams wrote: > Paul E. McKenney wrote: > > Now that the SRCU Kconfig option is unconditionally selected, there is > > no longer any point in selecting it. Therefore, remove the "select SRCU" > > Kconfig statements.

[PATCH rcu 11/27] drivers/dax: Remove "select SRCU"

2023-01-04 Thread Paul E. McKenney
Now that the SRCU Kconfig option is unconditionally selected, there is no longer any point in selecting it. Therefore, remove the "select SRCU" Kconfig statements. Signed-off-by: Paul E. McKenney Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: --- drivers/dax/Kconfig | 1

Re: kernel/rcu/tasks.h:1031:6: warning: no previous prototype for 'show_rcu_tasks_gp_kthreads'

2021-04-20 Thread Paul E. McKenney
On Tue, Apr 20, 2021 at 02:56:30PM +0800, kernel test robot wrote: > Hi Paul, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 7af08140979a6e7e12b78c93b8625c8d25b084e2 > commit:

Re: [PATCH 00/13] [RFC] Rust support

2021-04-19 Thread Paul E. McKenney
On Mon, Apr 19, 2021 at 01:35:56PM -0700, Nick Desaulniers wrote: > On Fri, Apr 16, 2021 at 11:47 AM Paul E. McKenney wrote: > > > > On Thu, Apr 15, 2021 at 11:04:37PM -0700, Nick Desaulniers wrote: > > > On Thu, Apr 15, 2021 at 9:27 PM Boqun Feng wrote: > > &g

Re: [PATCH 1/2] srcu: Fix broken node geometry after early ssp init

2021-04-19 Thread Paul E. McKenney
On Mon, Apr 19, 2021 at 02:23:45AM +0200, Frederic Weisbecker wrote: > On Sat, Apr 17, 2021 at 09:46:16PM -0700, Paul E. McKenney wrote: > > On Sat, Apr 17, 2021 at 03:16:49PM +0200, Frederic Weisbecker wrote: > > > On Wed, Apr 14, 2021 at 08:55:38AM -0700, Paul E. McKenney wro

[PATCH v9 clocksource 2/6] clocksource: Retry clock read if long delays detected

2021-04-18 Thread Paul E. McKenney
. ] [ paulmck: Don't reset injectfail per Neeraj Upadhyay feedback. ] [ paulmck: Apply Thomas Gleixner feedback. ] Signed-off-by: Paul E. McKenney --- .../admin-guide/kernel-parameters.txt | 6 +++ kernel/time/clocksource.c | 53 --- 2 files changed, 52

[PATCH v9 clocksource 5/6] clocksource: Limit number of CPUs checked for clock synchronization

2021-04-18 Thread Paul E. McKenney
will be checked at most once. Suggested-by: Thomas Gleixner # For verify_n_cpus=1. Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Jonathan Corbet Cc: Mark Rutland Cc: Marc Zyngier Cc: Andi Kleen Signed-off-by: Paul E. McKenney --- .../admin-guide/kernel-parameters.txt | 10

[PATCH v9 clocksource 6/6] clocksource: Reduce WATCHDOG_THRESHOLD

2021-04-18 Thread Paul E. McKenney
from the current 62.5 milliseconds down to 200 microseconds. Suggested-by: Thomas Gleixner Cc: John Stultz Cc: Stephen Boyd Cc: Jonathan Corbet Cc: Mark Rutland Cc: Marc Zyngier Cc: Andi Kleen [ paulmck: Apply Rik van Riel feedback. ] Reported-by: Chris Mason Signed-off-by: Paul E. McKenney

[PATCH v9 clocksource 4/6] clocksource: Provide a module parameter to fuzz per-CPU clock checking

2021-04-18 Thread Paul E. McKenney
Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Jonathan Corbet Cc: Mark Rutland Cc: Marc Zyngier Cc: Andi Kleen Reported-by: Chris Mason [ paulmck: Apply Randy Dunlap feedback. ] Signed-off-by: Paul E. McKenney --- Documentation/admin-guide/kernel-parameters.txt | 16 kernel

[PATCH v9 clocksource 3/6] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-18 Thread Paul E. McKenney
Andi Kleen Reported-by: Chris Mason [ paulmck: Add "static" to clocksource_verify_one_cpu() per kernel test robot feedback. ] [ paulmck: Apply Thomas Gleixner feedback. ] Signed-off-by: Paul E. McKenney --- arch/x86/kernel/tsc.c | 3 +- include/linux/clocksource.h | 2 +- kerne

[PATCH v9 clocksource 1/6] clocksource: Provide module parameters to inject delays in watchdog

2021-04-18 Thread Paul E. McKenney
feedback. ] Reported-by: Chris Mason Signed-off-by: Paul E. McKenney --- .../admin-guide/kernel-parameters.txt | 16 + kernel/time/clocksource.c | 23 +++ 2 files changed, 39 insertions(+) diff --git a/Documentation/admin-guide/kernel

[PATCH v9 clocksource 0/6] Do not mark clocks unstable due to delays for v5.13

2021-04-18 Thread Paul E. McKenney
Hello! If there is a sufficient delay between reading the watchdog clock and the clock under test, the clock under test will be marked unstable through no fault of its own. This series checks for this, doing limited retries to get a good set of clock reads. If the clock is marked unstable and

Re: [PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-18 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 04:51:36PM -0700, Paul E. McKenney wrote: > On Sat, Apr 17, 2021 at 02:47:18PM +0200, Thomas Gleixner wrote: [ . . . ] > > > + delta = (s64)((csnow_mid - csnow_begin) & cs->mask); > > > + if (delta < 0) > > > +

Re: [PATCH 1/2] srcu: Fix broken node geometry after early ssp init

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 03:16:49PM +0200, Frederic Weisbecker wrote: > On Wed, Apr 14, 2021 at 08:55:38AM -0700, Paul E. McKenney wrote: > > > diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h > > > index 75ed367d5b60..24db97cbf76b 100644 > > > --- a/kernel/rcu/rcu.

Re: [PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:47:18PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:36, Paul E. McKenney wrote: > > Bah, hit send too quick. > > > + cpumask_clear(_ahead); > > + cpumask_clear(_behind); > > + preempt_disable(); > > Daft. Wou

Re: [PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:28:22PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:36, Paul E. McKenney wrote: > > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > > index 1fc0962c89c0..97eeaf164296 100644 > > --- a/arch/x86/kernel/kvmclock

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-17 Thread Paul E. McKenney
On Sun, Apr 18, 2021 at 01:15:26AM +0200, Thomas Gleixner wrote: > On Sat, Apr 17 2021 at 15:54, Paul E. McKenney wrote: > > On Sat, Apr 17, 2021 at 02:24:23PM +0200, Thomas Gleixner wrote: > >> I so wish we could just delete all of this horror instead of making it

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:24:23PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:35, Paul E. McKenney wrote: > > #define WATCHDOG_INTERVAL (HZ >> 1) > > #define WATCHDOG_THRESHOLD (NSEC_PER_SEC >> 4) > > +#define WATCHDOG_MAX_SKEW (NSEC_PER_SEC >&

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-16 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 10:45:28PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:35, Paul E. McKenney wrote: > > #define WATCHDOG_INTERVAL (HZ >> 1) > > #define WATCHDOG_THRESHOLD (NSEC_PER_SEC >> 4) > > Didn't we discuss that the threshold is too

Re: [PATCH v8 clocksource 1/5] clocksource: Provide module parameters to inject delays in watchdog

2021-04-16 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 10:10:51PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:35, Paul E. McKenney wrote: > > > > +static int inject_delay_freq; > > +module_param(inject_delay_freq, int, 0644); > > +static int inject_delay_run = 1; > > +module_

Re: liburcu: LTO breaking rcu_dereference on arm64 and possibly other architectures ?

2021-04-16 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 03:30:53PM -0400, Mathieu Desnoyers wrote: > - On Apr 16, 2021, at 3:02 PM, paulmck paul...@kernel.org wrote: > [...] > > > > If it can be done reasonably, I suggest also having some way for the > > person building userspace RCU to say "I know what I am doing, so do >

Re: liburcu: LTO breaking rcu_dereference on arm64 and possibly other architectures ?

2021-04-16 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 02:40:08PM -0400, Mathieu Desnoyers wrote: > - On Apr 16, 2021, at 12:01 PM, paulmck paul...@kernel.org wrote: > > > On Fri, Apr 16, 2021 at 05:17:11PM +0200, Peter Zijlstra wrote: > >> On Fri, Apr 16, 2021 at 10:52:16AM -0400, Mathieu Desnoyers wrote: > >> > Hi Paul,

Re: [PATCH 00/13] [RFC] Rust support

2021-04-16 Thread Paul E. McKenney
On Thu, Apr 15, 2021 at 11:04:37PM -0700, Nick Desaulniers wrote: > On Thu, Apr 15, 2021 at 9:27 PM Boqun Feng wrote: > > > > [Copy LKMM people, Josh, Nick and Wedson] > > > > On Thu, Apr 15, 2021 at 08:58:16PM +0200, Peter Zijlstra wrote: > > > On Wed, Apr 14, 2021 at 08:45:51PM +0200,

Re: [Qestion] Is preempt_disable/enable needed in non-preemption code path

2021-04-16 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 06:51:10PM +0800, Xu, Yanfei wrote: > > > On 4/16/21 1:07 AM, Paul E. McKenney wrote: > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Fri, Apr 16, 2021 at 12:18:42AM +0800, Xu, Yanfei wrote: > > > >

Re: liburcu: LTO breaking rcu_dereference on arm64 and possibly other architectures ?

2021-04-16 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 05:17:11PM +0200, Peter Zijlstra wrote: > On Fri, Apr 16, 2021 at 10:52:16AM -0400, Mathieu Desnoyers wrote: > > Hi Paul, Will, Peter, > > > > I noticed in this discussion https://lkml.org/lkml/2021/4/16/118 that LTO > > is able to break rcu_dereference. This seems to be

Re: [RFC PATCH] percpu_ref: Make percpu_ref_tryget*() ACQUIRE operations

2021-04-15 Thread Paul E. McKenney
he percpu pointer. > > Signed-off-by: "Huang, Ying" > Cc: Tejun Heo > Cc: Kent Overstreet > Cc: "Paul E. McKenney" > Cc: Roman Gushchin > Cc: Ming Lei > Cc: Al Viro > Cc: Miaohe Lin > --- > include/linux/percpu-refcount.h | 17 ++

Re: [PATCH v2 0/5] kvfree_rcu() miscellaneous fixes

2021-04-15 Thread Paul E. McKenney
On Thu, Apr 15, 2021 at 07:19:55PM +0200, Uladzislau Rezki (Sony) wrote: > This is a v2 of a small series. See the changelog below: > > V1 -> V2: > - document the rcu_delay_page_cache_fill_msec parameter; > - drop the "kvfree_rcu: introduce "flags" variable" patch; > - reword commit messages; > -

Re: [Qestion] Is preempt_disable/enable needed in non-preemption code path

2021-04-15 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 01:01:17AM +0800, Xu, Yanfei wrote: > > > On 4/16/21 12:18 AM, Xu, Yanfei wrote: > > > > > > On 4/15/21 11:43 PM, Paul E. McKenney wrote: > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > >

Re: [Qestion] Is preempt_disable/enable needed in non-preemption code path

2021-04-15 Thread Paul E. McKenney
On Fri, Apr 16, 2021 at 12:18:42AM +0800, Xu, Yanfei wrote: > > > On 4/15/21 11:43 PM, Paul E. McKenney wrote: > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Thu, Apr 15, 2021 at 11:04:05PM +0800, Xu, Yanfei wrote: > > > Hi exp

Re: [Qestion] Is preempt_disable/enable needed in non-preemption code path

2021-04-15 Thread Paul E. McKenney
On Thu, Apr 15, 2021 at 11:04:05PM +0800, Xu, Yanfei wrote: > Hi experts, > > I am learning rcu mechanism and its codes. When looking at the > rcu_blocking_is_gp(), I found there is a pair preemption disable/enable > operation in non-preemption code path. And it has been a long time. I can't >

Re: [tip: core/rcu] softirq: Don't try waking ksoftirqd before it has been spawned

2021-04-14 Thread Paul E. McKenney
On Thu, Apr 15, 2021 at 01:54:18AM +0200, Thomas Gleixner wrote: > Paul, > > On Wed, Apr 14 2021 at 11:11, Paul E. McKenney wrote: > > On Wed, Apr 14, 2021 at 10:57:57AM +0200, Uladzislau Rezki wrote: > >> On Wed, Apr 14, 2021 at 09:13:22AM +0200, Sebastian Andrzej Siewior

Re: Should RCU_BOOST kernels use hrtimers in GP kthread?

2021-04-14 Thread Paul E. McKenney
On Wed, Feb 17, 2021 at 08:43:59PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-02-17 11:19:07 [-0800], Paul E. McKenney wrote: > > > Ah. One nice thing is that you can move the RCU threads to a house > > > keeping CPU - away from the CPU(s) running the RT tasks. Woul

Re: [tip: core/rcu] softirq: Don't try waking ksoftirqd before it has been spawned

2021-04-14 Thread Paul E. McKenney
On Wed, Apr 14, 2021 at 10:57:57AM +0200, Uladzislau Rezki wrote: > On Wed, Apr 14, 2021 at 09:13:22AM +0200, Sebastian Andrzej Siewior wrote: > > On 2021-04-12 11:36:45 [-0700], Paul E. McKenney wrote: > > > > Color me confused. I did not follow the discussion around th

Re: [PATCH 2/2] srcu: Early test SRCU polling start

2021-04-14 Thread Paul E. McKenney
On Wed, Apr 14, 2021 at 03:24:13PM +0200, Frederic Weisbecker wrote: > Test an early call to start_poll_synchronize_srcu() and place it before > the early test to call_srcu() on the same ssp. > > After the later call to srcu_barrier(), we expect the first grace period > completion to be visible

Re: [PATCH 1/2] srcu: Fix broken node geometry after early ssp init

2021-04-14 Thread Paul E. McKenney
n ssp that gets initialized before rcu_init_geometry() and used >afterward will always have stale rdp->mynode references, resulting in >callbacks to be missed in srcu_gp_end(), just like in the previous >scenario. > > Solve this with calling rcu_init_geometry() whenever

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-13 Thread Paul E. McKenney
On Tue, Apr 13, 2021 at 10:49:11PM +0200, Thomas Gleixner wrote: > Paul, > > On Mon, Apr 12 2021 at 16:18, Paul E. McKenney wrote: > > On Mon, Apr 12, 2021 at 10:37:10PM +0200, Thomas Gleixner wrote: > >> On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: > >>

[PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-13 Thread Paul E. McKenney
Andi Kleen Reported-by: Chris Mason [ paulmck: Add "static" to clocksource_verify_one_cpu() per kernel test robot feedback. ] [ paulmck: Apply Thomas Gleixner feedback. ] Signed-off-by: Paul E. McKenney --- arch/x86/kernel/kvmclock.c | 2 +- arch/x86/kernel/tsc.c | 3 +- include

[PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-13 Thread Paul E. McKenney
Gleixner feedback. ] Signed-off-by: Paul E. McKenney --- kernel/time/clocksource.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index 4be4391aa72f..3ac19a7859f5 100644 --- a/kernel/time/clocksource.c

[PATCH v8 clocksource 1/5] clocksource: Provide module parameters to inject delays in watchdog

2021-04-13 Thread Paul E. McKenney
-by: Paul E. McKenney --- .../admin-guide/kernel-parameters.txt | 22 +++ kernel/time/clocksource.c | 27 +++ 2 files changed, 49 insertions(+) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel

[PATCH v8 clocksource 5/5] clocksource: Limit number of CPUs checked for clock synchronization

2021-04-13 Thread Paul E. McKenney
will be checked at most once. Suggested-by: Thomas Gleixner # For verify_n_cpus=1. Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Jonathan Corbet Cc: Mark Rutland Cc: Marc Zyngier Cc: Andi Kleen Signed-off-by: Paul E. McKenney --- .../admin-guide/kernel-parameters.txt | 10

[PATCH v8 clocksource 4/5] clocksource: Provide a module parameter to fuzz per-CPU clock checking

2021-04-13 Thread Paul E. McKenney
Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Jonathan Corbet Cc: Mark Rutland Cc: Marc Zyngier Cc: Andi Kleen Reported-by: Chris Mason [ paulmck: Apply Randy Dunlap feedback. ] Signed-off-by: Paul E. McKenney --- Documentation/admin-guide/kernel-parameters.txt | 16 kernel

[PATCH v8 clocksource] Do not mark clocks unstable due to delays for v5.13

2021-04-13 Thread Paul E. McKenney
Hello! If there is a sufficient delay between reading the watchdog clock and the clock under test, the clock under test will be marked unstable through no fault of its own. This series checks for this, doing limited retries to get a good set of clock reads. If the clock is marked unstable and

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Paul E. McKenney
On Mon, Apr 12, 2021 at 10:37:10PM +0200, Thomas Gleixner wrote: > On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: > > On Mon, Apr 12, 2021 at 08:54:03PM +0200, Thomas Gleixner wrote: > >> > I will send a new series out later today, Pacific Time. > >> > &

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Paul E. McKenney
On Mon, Apr 12, 2021 at 08:54:03PM +0200, Thomas Gleixner wrote: > Paul, > > On Mon, Apr 12 2021 at 11:20, Paul E. McKenney wrote: > > On Mon, Apr 12, 2021 at 03:08:16PM +0200, Thomas Gleixner wrote: > >> The reason for irqsave is again historical AFAICT and nobody both

Re: [tip: core/rcu] softirq: Don't try waking ksoftirqd before it has been spawned

2021-04-12 Thread Paul E. McKenney
> > https://git.kernel.org/tip/1c0c4bc1ceb580851b2d76fdef9712b3bdae134b > > Author:Paul E. McKenney > > AuthorDate:Fri, 12 Feb 2021 16:20:40 -08:00 > > Committer: Paul E. McKenney > > CommitterDate: Mon, 15 Mar 2021 13:51:48 -07:00 > > >

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Paul E. McKenney
On Mon, Apr 12, 2021 at 03:08:16PM +0200, Thomas Gleixner wrote: > On Sun, Apr 11 2021 at 21:21, Paul E. McKenney wrote: > > On Sun, Apr 11, 2021 at 09:46:12AM -0700, Paul E. McKenney wrote: > >> So I need to is inline clocksource_verify_percpu_wq() > >> int

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-11 Thread Paul E. McKenney
On Sun, Apr 11, 2021 at 09:46:12AM -0700, Paul E. McKenney wrote: > On Sun, Apr 11, 2021 at 12:33:44PM +0200, Thomas Gleixner wrote: > > On Sat, Apr 10 2021 at 17:20, Paul E. McKenney wrote: > > > On Sat, Apr 10, 2021 at 11:00:25AM +0200, Thomas Gleixner wrote: > > >>

Re: [PATCH v7 clocksource] Do not mark clocks unstable due to delays for v5.13

2021-04-11 Thread Paul E. McKenney
On Sun, Apr 11, 2021 at 12:58:31PM +0200, Thomas Gleixner wrote: > On Sat, Apr 10 2021 at 16:26, Paul E. McKenney wrote: > > On Sat, Apr 10, 2021 at 10:01:58AM +0200, Thomas Gleixner wrote: > >> On Fri, Apr 02 2021 at 15:48, Paul E. McKenney wrote: > >> I buy the v

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-11 Thread Paul E. McKenney
On Sun, Apr 11, 2021 at 12:33:44PM +0200, Thomas Gleixner wrote: > On Sat, Apr 10 2021 at 17:20, Paul E. McKenney wrote: > > On Sat, Apr 10, 2021 at 11:00:25AM +0200, Thomas Gleixner wrote: > >> > +if (WARN_ON_ONCE(!cs)) > >> > +return;

[tip: core/rcu] rcutorture: Use "all" and "N" in "nohz_full" and "rcu_nocbs"

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: c71c39b344f7eec9d4492913f22126b03bb7b746 Gitweb: https://git.kernel.org/tip/c71c39b344f7eec9d4492913f22126b03bb7b746 Author:Paul E. McKenney AuthorDate:Thu, 21 Jan 2021 15:56:53 -08:00

[tip: locking/core] tools/memory-model: Add access-marking documentation

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the locking/core branch of tip: Commit-ID: 49ab51b01ec6fd837ae3efe2e0cdb41fcf5cf048 Gitweb: https://git.kernel.org/tip/49ab51b01ec6fd837ae3efe2e0cdb41fcf5cf048 Author:Paul E. McKenney AuthorDate:Thu, 11 Feb 2021 15:40:05 -08:00

[tip: core/rcu] kvfree_rcu: Use __GFP_NOMEMALLOC for single-argument kvfree_rcu()

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: b01b405092b7940bd366053a27ed54a87c84e96a Gitweb: https://git.kernel.org/tip/b01b405092b7940bd366053a27ed54a87c84e96a Author:Paul E. McKenney AuthorDate:Wed, 20 Jan 2021 17:21:47 +01:00

[tip: core/rcu] kvfree_rcu: Make krc_this_cpu_unlock() use raw_spin_unlock_irqrestore()

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 7ffc9ec8eac196cbd85669a4d7920cd80f186a51 Gitweb: https://git.kernel.org/tip/7ffc9ec8eac196cbd85669a4d7920cd80f186a51 Author:Paul E. McKenney AuthorDate:Wed, 20 Jan 2021 13:38:08 -08:00

[tip: core/rcu] rcu: Add explicit barrier() to __rcu_read_unlock()

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 7e937220afa3eada0d4611b31e4e3c60770e39b4 Gitweb: https://git.kernel.org/tip/7e937220afa3eada0d4611b31e4e3c60770e39b4 Author:Paul E. McKenney AuthorDate:Fri, 26 Feb 2021 11:25:29 -08:00

[tip: core/rcu] docs: Correctly spell Stephen Hemminger's name

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: e589c7c72315f7e52ebb5cffc19615dc18d0cc50 Gitweb: https://git.kernel.org/tip/e589c7c72315f7e52ebb5cffc19615dc18d0cc50 Author:Paul E. McKenney AuthorDate:Tue, 23 Feb 2021 10:07:09 -08:00

[tip: core/rcu] mm: Don't build mm_dump_obj() on CONFIG_PRINTK=n kernels

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 5bb1bb353cfe343fc3c84faf06f72ba309fde541 Gitweb: https://git.kernel.org/tip/5bb1bb353cfe343fc3c84faf06f72ba309fde541 Author:Paul E. McKenney AuthorDate:Thu, 07 Jan 2021 13:46:11 -08:00

[tip: core/rcu] rcutorture: Add crude tests for mem_dump_obj()

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 0d3dd2c8eadb7d4404b8788f552fb2b824fe2c7e Gitweb: https://git.kernel.org/tip/0d3dd2c8eadb7d4404b8788f552fb2b824fe2c7e Author:Paul E. McKenney AuthorDate:Mon, 07 Dec 2020 21:23:36 -08:00

[tip: core/rcu] rcu: Expedite deboost in case of deferred quiescent state

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 39bbfc62cc90d33f8f5f940464d08075e0275f8a Gitweb: https://git.kernel.org/tip/39bbfc62cc90d33f8f5f940464d08075e0275f8a Author:Paul E. McKenney AuthorDate:Thu, 14 Jan 2021 10:39:31 -08:00

[tip: core/rcu] rcutorture: Fix testing of RCU priority boosting

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 5e59fba573e64cffc3a7a3113fff2336d652f45a Gitweb: https://git.kernel.org/tip/5e59fba573e64cffc3a7a3113fff2336d652f45a Author:Paul E. McKenney AuthorDate:Fri, 15 Jan 2021 13:30:38 -08:00

[tip: core/rcu] torturescript: Don't rerun failed rcutorture builds

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: a519d21480d330918bd522499a323432c31b6ec2 Gitweb: https://git.kernel.org/tip/a519d21480d330918bd522499a323432c31b6ec2 Author:Paul E. McKenney AuthorDate:Tue, 05 Jan 2021 10:50:32 -08:00

[tip: core/rcu] rcu: Make rcu_read_unlock_special() expedite strict grace periods

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 7308e0240410d3644c9d7cc6263079a58e3effeb Gitweb: https://git.kernel.org/tip/7308e0240410d3644c9d7cc6263079a58e3effeb Author:Paul E. McKenney AuthorDate:Wed, 27 Jan 2021 13:57:16 -08:00

[tip: core/rcu] torture: Make jitter.sh handle large systems

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 8126c57f00cea3502a017b7c76df1fac58f89e88 Gitweb: https://git.kernel.org/tip/8126c57f00cea3502a017b7c76df1fac58f89e88 Author:Paul E. McKenney AuthorDate:Wed, 10 Feb 2021 13:25:58 -08:00

[tip: core/rcu] rcutorture: Make TREE03 use real-time tree.use_softirq setting

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: e2b949d54392ad890bb10fb8954d967e2fcd7503 Gitweb: https://git.kernel.org/tip/e2b949d54392ad890bb10fb8954d967e2fcd7503 Author:Paul E. McKenney AuthorDate:Thu, 14 Jan 2021 16:11:04 -08:00

[tip: core/rcu] torture: Allow 1G of memory for torture.sh kvfree testing

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 3d4977b68101b38c3f9d3be3d89e17ef1fdfc1d3 Gitweb: https://git.kernel.org/tip/3d4977b68101b38c3f9d3be3d89e17ef1fdfc1d3 Author:Paul E. McKenney AuthorDate:Thu, 28 Jan 2021 16:38:19 -08:00

[tip: core/rcu] rcu-tasks: Add block comment laying out RCU Tasks Trace design

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: a434dd10cd843c7348e7c54c77eb0fac27beceb4 Gitweb: https://git.kernel.org/tip/a434dd10cd843c7348e7c54c77eb0fac27beceb4 Author:Paul E. McKenney AuthorDate:Thu, 25 Feb 2021 10:26:00 -08:00

[tip: core/rcu] torture: Eliminate jitter_pids file

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 1f922db8eef015f261480347aaf79fa9a25728f2 Gitweb: https://git.kernel.org/tip/1f922db8eef015f261480347aaf79fa9a25728f2 Author:Paul E. McKenney AuthorDate:Thu, 11 Feb 2021 10:56:42 -08:00

[tip: core/rcu] torture: Provide bare-metal modprobe-based advice

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: a8dafbf3a5465bea6d9b45a4f011ba9b56d8b267 Gitweb: https://git.kernel.org/tip/a8dafbf3a5465bea6d9b45a4f011ba9b56d8b267 Author:Paul E. McKenney AuthorDate:Wed, 03 Feb 2021 15:44:29 -08:00

[tip: core/rcu] refscale: Disable verbose torture-test output

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: aebf8c7bf6d508dfb4255db8f7355ca819d9e6c9 Gitweb: https://git.kernel.org/tip/aebf8c7bf6d508dfb4255db8f7355ca819d9e6c9 Author:Paul E. McKenney AuthorDate:Thu, 28 Jan 2021 10:17:26 -08:00

[tip: core/rcu] torture: Reverse jittering and duration parameters for jitter.sh

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: 4cd54518c3d8afadd11ebd6ad4f03b00859f5e85 Gitweb: https://git.kernel.org/tip/4cd54518c3d8afadd11ebd6ad4f03b00859f5e85 Author:Paul E. McKenney AuthorDate:Thu, 11 Feb 2021 11:54:43 -08:00

[tip: core/rcu] torture: Use file-based protocol to mark batch's runs complete

2021-04-11 Thread tip-bot2 for Paul E. McKenney
The following commit has been merged into the core/rcu branch of tip: Commit-ID: b674100e630bf9211d7edce06b5d734b125a74ee Gitweb: https://git.kernel.org/tip/b674100e630bf9211d7edce06b5d734b125a74ee Author:Paul E. McKenney AuthorDate:Wed, 10 Feb 2021 16:28:44 -08:00

  1   2   3   4   5   6   7   8   9   10   >