I was working on some checkpatch fixes for ddk750_dvi.h and ddk750_dvi.c
when I noticed that dviInit function does not seem to be invoked in any
of the files that belong to this driver and can be removed. Am I missing
something?
Thank you,
Pavle
On Wed, Apr 07, 2021 at 10:32:53AM +0200, Greg KH wrote:
> On Wed, Apr 07, 2021 at 09:32:29AM +0200, Greg KH wrote:
> > On Wed, Apr 07, 2021 at 12:15:22AM -0700, Pavle Rohalj wrote:
> > > On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote:
> > > > On Tue, Ap
On Wed, Apr 07, 2021 at 10:31:21AM +0200, Greg KH wrote:
> On Tue, Apr 06, 2021 at 11:35:56PM -0700, Pavle Rohalj wrote:
> > Fix "Avoid CamelCase" checkpatch.pl checks for dvi_ctrl_device structure and
> > its usages.
> >
> > Signed-off-by: Pavle Rohalj
On Wed, Apr 07, 2021 at 09:11:18AM +0200, Fabio Aiuto wrote:
> On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote:
> > Changes in v2:
> > - Removed type information from variable names
> > - Broken up the changes into smaller patches
>
> Hi Pav
On Wed, Apr 07, 2021 at 09:24:07AM +0200, Greg KH wrote:
> On Tue, Apr 06, 2021 at 11:36:16PM -0700, Pavle Rohalj wrote:
> > Fix "Avoid CamelCase" checkpatch.pl checks for values in
> > enum dpms.
> >
> > Signed-off-by: Pavle Rohalj
> > ---
>
On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote:
> On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote:
> > Changes in v2:
> > - Removed type information from variable names
> > - Broken up the changes into smaller patches
>
> Your subject
Fix "Avoid CamelCase" checkpatch.pl checks for the members of
sm750_pnltype structure, in particular sm750_24TFT, sm750_dualTFT,
and sm750_doubleTFT.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 6 +++---
drivers/staging/sm750fb/sm750.h| 6 +++---
drive
Fix "Avoid CamelCase" checkpatch.pl checks for the local variable
fixId in lynxfb_set_fbinfo function.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drive
Fix "Avoid CamelCase" checkpatch.pl check for proc_setBLANK member of
lynxfb_output structure.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c | 4 ++--
drivers/staging/sm750fb/sm750.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl checks for the function parameter
powerUp.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h
b/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl checks for the local variable
Bpp in functions lynxfb_ops_fillrect and lynxfb_ops_copyarea.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
Fix "Avoid CamelCase" checkpatch.pl checks for the function
hw_sm750_crtc_checkMode.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750.h| 2 +-
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 3 insertions(+), 3
Fix "Avoid CamelCase" checkpatch.pl checks for the members of
lynx_accel structure, in particular dprBase and dpPortBase.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.h | 4 ++--
drivers/staging/sm750fb/sm750_accel.c | 6 +++---
drivers/staging/sm750fb/sm750_h
Fix "Avoid CamelCase" checkpatch.pl checks for the functions
hw_sm750le_deWait and hw_sm750_deWait.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750.h| 4 ++--
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
3 files changed, 5
Fix "Avoid CamelCase" checkpatch.pl checks for the function
hw_sm750_init_accel.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.h| 2 +-
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750
Fix "Avoid CamelCase" checkpatch.pl checks for the function
hw_sm750_setColReg.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750.h| 2 +-
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 3 insertions(+), 3 deletion
Fix "Avoid CamelCase" checkpatch.pl checks for the functions
hw_sm750_setBLANK and hw_sm750le_setBLANK.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750.h| 4 ++--
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
3 files
Fix "Avoid CamelCase" checkpatch.pl checks for the function
sm750_hw_cursor_setData2.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
drivers/staging/sm750fb/sm750_cursor.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
Fix "Avoid CamelCase" checkpatch.pl checks for the function
hw_sm750_output_set_mod.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750.h| 2 +-
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 3 insertions(+), 3
Fix "Avoid CamelCase" checkpatch.pl checks for the members of the
struct lynxfb_crtc, in particular vCursor, vScreen, oCursor, and
oScreen.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 44 +++---
drivers/staging/sm750fb/sm750
Fix "Avoid CamelCase" checkpatch.pl checks for the members of
sm750_dev structure, in particular initParam, pvReg, pvMem, and hwCursor.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 36 +++---
drivers/staging/sm750fb/sm750
Fix "Avoid CamelCase" checkpatch.pl checks for the members of the
struct init_status, in particular powerMode, setAllEngOff,
and resetMemory.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c | 6 +++---
drivers/staging/sm750fb/sm750.h | 6 +++---
2 files changed, 6
Fix "Avoid CamelCase" checkpatch.pl checks for the function
hw_sm750_crtc_setMode.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750.h| 2 +-
drivers/staging/sm750fb/sm750_hw.c | 2 +-
3 files changed, 3 insertions(+), 3
Fix "Avoid CamelCase" checkpatch.pl checks for the function
sm750_hw_cursor_setData.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
drivers/staging/sm750fb/sm750_cursor.h | 2 +-
3 files changed, 3 insert
Fix "Avoid CamelCase" checkpatch.pl checks for the function
sm750_hw_cursor_set_color.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
drivers/staging/sm750fb/sm750_cursor.h | 2 +-
3 files changed, 3 insert
Fix "Avoid CamelCase" checkpatch.pl checks for the function
sm750_hw_cursor_set_pos.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
drivers/staging/sm750fb/sm750_cursor.h | 2 +-
3 files changed, 3 insert
Fix "Avoid CamelCase" checkpatch.pl checks for the function
sm750_hw_cursor_setSize.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 2 +-
drivers/staging/sm750fb/sm750_cursor.c | 2 +-
drivers/staging/sm750fb/sm750_cursor.h | 2 +-
3 files changed, 3 insert
Fix "Avoid CamelCase" checkpatch.pl checks for function parameters
in sm750_accel.h, in particular for functions sm750_hw_fillrect,
sm750_hw_copyarea and sm750_hw_imageblit.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_accel.h | 42 +--
1 fi
Fix "Avoid CamelCase" checkpatch.pl checks for the members
of lynx_cursor structure, in particular maxW and maxH.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750.c| 8
drivers/staging/sm750fb/sm750.h| 4 ++--
drivers/staging/sm750fb/sm750_cu
Fix "Avoid CamelCase" checkpoint.pl checks for the function parameter
fColor in the function sm750_hw_imageblit.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_accel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm7
Fix "Avoid CamelCase" checkpatch.pl checks for the function
deGetTransparency in sm750_accel.c.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_accel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c
b/drive
Fix "Avoid CamelCase" checkpoint.pl checks for the local variables
in the function sm750_hw_imageblit.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_accel.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/stagi
Fix "Avoid CamelCase" checkpoint.pl checks for the local variable
deCtrl in the function sm750_hw_fillrect.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_accel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_
Fix "Avoid CamelCase" checkpoint.pl checks for the local variable
nDirection in the function sm750_hw_copyarea.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_accel.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl checks for function
parameter names in sm750_accel.c.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_accel.c | 92 +--
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/sm750fb/sm7
Fix "Avoid CamelCase" checkpatch.pl check for the function
write_dpPort.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/sm750_accel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c
b/drivers/staging/sm750fb/sm7
Fix "Avoid CamelCase" checkpatch.pl check for the function parameter
enable_hot_plug in the prototype of the function
sii164_enable_hot_plug_detection.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Fix "Avoid CamelCase" checkpatch.pl checks for function parameter
names of the function sii164_init_chip.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl checks for local
variables in SII164_FULL_FUNCTIONS block.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.c | 40 -
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl checks for function
parameters in ddk750_sii164.c.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c
Fix "Avoid CamelCase" checkpatch.pl check for the
global variable gDviCtrlChipName.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c
b/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl check for the function
sii164SelectHotPlugDetectionMode in ddk750_sii164.c.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl check for the local
variable vendorID in the function sii164_get_vendor_id.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk
Fix "Avoid CamelCase" checkpatch.pl check for the local
variable deviceID in the function sii164_get_device_id.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk
Fix "Avoid CamelCase" checkpatch.pl checks for i2cWriteReg
and i2cReadReg in ddk750_sii164.c.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_sii164.c | 46 -
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl check for the function
ddk750_setModeTiming.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_mode.c | 2 +-
drivers/staging/sm750fb/ddk750_mode.h | 2 +-
drivers/staging/sm750fb/sm750_hw.c| 2 +-
3 files changed, 3 insert
Fix "Avoid CamelCase" checkpatch.pl check for the function parameter
powerMode of function sm750_set_power_mode.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_power.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_
Fix "Avoid CamelCase" checkpatch.pl checks for values in
enum dpms.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_power.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_power.h
b/drivers/staging/sm750fb/ddk7
Fix "Avoid CamelCase" checkpatch.pl checks for the function
displayControlAdjust_SM750LE, including its name, parameters, and body.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_mode.c | 40 +--
1 file changed, 20 insertions(+), 20 deletion
Fix "Avoid CamelCase" checkpatch.pl check for the function
programModeRegisters, including its name, parameters, and body.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_mode.c | 48 +--
1 file changed, 24 insertions(+), 24 deletions(-)
Fix "Avoid CamelCase" checkpatch.pl check for type definitions
DVICTRL_SETPOWER and DVICTRL_HOTPLUGDETECTION in ddk750_dvi.h.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_dvi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
Fix "Avoid CamelCase" checkpatch.pl checks for parameter names in the
type definition of PFN_DVICTRL_INIT function pointer.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_dvi.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
Remove type names used in variables and type definitions for
dvi_ctrl_device structure.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_dvi.c | 24 -
drivers/staging/sm750fb/ddk750_dvi.h | 40 ++--
2 files changed, 32 insertions(+), 32
Fix "Avoid CamelCase" checkpatch.pl checks for the function dviInit and
its parameter names in ddk750_dvi.h.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_dvi.h | 20 ++--
2 files changed, 11 inserti
Fix "Avoid CamelCase" checkpatch.pl checks for dvi_ctrl_device structure and
its usages.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_dvi.c| 30
drivers/staging/sm750fb/ddk750_dvi.h| 20 +--
drivers/staging/sm750fb/ddk750_sii
Changes in v2:
- Removed type information from variable names
- Broken up the changes into smaller patches
Pavle Rohalj (49):
staging: sm750fb: Update dvi_ctrl_device to snake case
staging: sm750fb: Rename dviInit to dvi_init and update param names
staging: sm750fb: Update param
On Tue, Apr 06, 2021 at 11:36:41AM +0200, Greg KH wrote:
> On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote:
> > - struct dvi_ctrl_device *pCurrentDviCtrl;
> > + struct dvi_ctrl_device *p_current_dvi_ctrl;
>
> Does this change make sense? Why keep the "
Fix "Avoid CamelCase" checkpatch.pl checks for 106 camel case
instances:
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_dvi.c| 32 ++---
drivers/staging/sm750fb/ddk750_dvi.h| 64 +-
drivers/staging/sm750fb/ddk750_mode.c | 88 +++---
drive
58 matches
Mail list logo