sm750fb: Question about dviInit from ddk750_dvi.(c|h)

2021-04-08 Thread Pavle Rohalj
I was working on some checkpatch fixes for ddk750_dvi.h and ddk750_dvi.c when I noticed that dviInit function does not seem to be invoked in any of the files that belong to this driver and can be removed. Am I missing something? Thank you, Pavle

Re: [PATCH v2 00/49] *** SUBJECT HERE ***

2021-04-07 Thread Pavle Rohalj
On Wed, Apr 07, 2021 at 10:32:53AM +0200, Greg KH wrote: > On Wed, Apr 07, 2021 at 09:32:29AM +0200, Greg KH wrote: > > On Wed, Apr 07, 2021 at 12:15:22AM -0700, Pavle Rohalj wrote: > > > On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote: > > > > On Tue, Ap

Re: [PATCH v2 01/49] staging: sm750fb: Update dvi_ctrl_device to snake case

2021-04-07 Thread Pavle Rohalj
On Wed, Apr 07, 2021 at 10:31:21AM +0200, Greg KH wrote: > On Tue, Apr 06, 2021 at 11:35:56PM -0700, Pavle Rohalj wrote: > > Fix "Avoid CamelCase" checkpatch.pl checks for dvi_ctrl_device structure and > > its usages. > > > > Signed-off-by: Pavle Rohalj

Re: [PATCH v2 00/49] *** SUBJECT HERE ***

2021-04-07 Thread Pavle Rohalj
On Wed, Apr 07, 2021 at 09:11:18AM +0200, Fabio Aiuto wrote: > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > Changes in v2: > > - Removed type information from variable names > > - Broken up the changes into smaller patches > > Hi Pav

Re: [PATCH v2 08/49] staging: sm750fb: Update enum values in dpms to snake case

2021-04-07 Thread Pavle Rohalj
On Wed, Apr 07, 2021 at 09:24:07AM +0200, Greg KH wrote: > On Tue, Apr 06, 2021 at 11:36:16PM -0700, Pavle Rohalj wrote: > > Fix "Avoid CamelCase" checkpatch.pl checks for values in > > enum dpms. > > > > Signed-off-by: Pavle Rohalj > > --- >

Re: [PATCH v2 00/49] *** SUBJECT HERE ***

2021-04-07 Thread Pavle Rohalj
On Wed, Apr 07, 2021 at 09:08:07AM +0200, Greg KH wrote: > On Tue, Apr 06, 2021 at 11:35:54PM -0700, Pavle Rohalj wrote: > > Changes in v2: > > - Removed type information from variable names > > - Broken up the changes into smaller patches > > Your subject

[PATCH v2 49/49] staging: sm750fb: Update members of sm750_pnltype struct to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the members of sm750_pnltype structure, in particular sm750_24TFT, sm750_dualTFT, and sm750_doubleTFT. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 6 +++--- drivers/staging/sm750fb/sm750.h| 6 +++--- drive

[PATCH v2 48/49] staging: sm750fb: Rename fixId to fix_id

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the local variable fixId in lynxfb_set_fbinfo function. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drive

[PATCH v2 47/49] staging: sm750fb: Rename proc_setBLANK member of lynxfb_output struct

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for proc_setBLANK member of lynxfb_output structure. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/stagi

[PATCH v2 45/49] staging: sm750fb: Rename sii164_set_power function parameter

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function parameter powerUp. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/stagi

[PATCH v2 46/49] staging: sm750fb: Rename local variable Bpp to bpp in sm750.c

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the local variable Bpp in functions lynxfb_ops_fillrect and lynxfb_ops_copyarea. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH v2 44/49] staging: sm750fb: Rename function hw_sm750_crtc_checkMode to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_crtc_checkMode. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3

[PATCH v2 43/49] staging: sm750fb: Update members of lynx_accel struct to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the members of lynx_accel structure, in particular dprBase and dpPortBase. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.h | 4 ++-- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- drivers/staging/sm750fb/sm750_h

[PATCH v2 42/49] staging: sm750fb: Rename functions *_deWait to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the functions hw_sm750le_deWait and hw_sm750_deWait. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750.h| 4 ++-- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 3 files changed, 5

[PATCH v2 41/49] staging: sm750fb: Rename function hw_sm750_initAccel to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_init_accel. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750

[PATCH v2 38/49] staging: sm750fb: Rename function hw_sm750_setColReg to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_setColReg. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletion

[PATCH v2 39/49] staging: sm750fb: Rename functions *_setBLANK to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the functions hw_sm750_setBLANK and hw_sm750le_setBLANK. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750.h| 4 ++-- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 3 files

[PATCH v2 40/49] staging: sm750fb: Rename function sm750_hw_cursor_setData2 to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_setData2. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v2 37/49] staging: sm750fb: Rename function hw_sm750_output_setMode to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_output_set_mod. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3

[PATCH v2 36/49] staging: sm750fb: Update members of lynxfb_crtc struct to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the members of the struct lynxfb_crtc, in particular vCursor, vScreen, oCursor, and oScreen. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 44 +++--- drivers/staging/sm750fb/sm750

[PATCH v2 35/49] staging: sm750fb: Update members of sm750_dev struct to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the members of sm750_dev structure, in particular initParam, pvReg, pvMem, and hwCursor. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 36 +++--- drivers/staging/sm750fb/sm750

[PATCH v2 34/49] staging: sm750fb: Update members of init_status struct to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the members of the struct init_status, in particular powerMode, setAllEngOff, and resetMemory. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 6 +++--- drivers/staging/sm750fb/sm750.h | 6 +++--- 2 files changed, 6

[PATCH v2 33/49] staging: sm750fb: Rename function hw_sm750_crtc_setMode to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_crtc_setMode. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3

[PATCH v2 32/49] staging: sm750fb: Rename function sm750_hw_cursor_setData to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_setData. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insert

[PATCH v2 31/49] staging: sm750fb: Rename function sm750_hw_cursor_setColor to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_set_color. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insert

[PATCH v2 30/49] staging: sm750fb: Rename function sm750_hw_cursor_setPos to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_set_pos. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insert

[PATCH v2 29/49] staging: sm750fb: Rename function sm750_hw_cursor_setSize to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_setSize. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insert

[PATCH v2 27/49] staging: sm750fb: Rename function params to snake case in sm750_accel.h

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for function parameters in sm750_accel.h, in particular for functions sm750_hw_fillrect, sm750_hw_copyarea and sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.h | 42 +-- 1 fi

[PATCH v2 28/49] staging: sm750fb: Update members of lynx_cursor to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the members of lynx_cursor structure, in particular maxW and maxH. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c| 8 drivers/staging/sm750fb/sm750.h| 4 ++-- drivers/staging/sm750fb/sm750_cu

[PATCH v2 26/49] staging: sm750fb: Update function parameter of sm750_hw_imageblit to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpoint.pl checks for the function parameter fColor in the function sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm7

[PATCH v2 25/49] staging: sm750fb: Rename deGetTransparency to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function deGetTransparency in sm750_accel.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drive

[PATCH v2 23/49] staging: sm750fb: Update local variables in sm750_hw_imageblit to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpoint.pl checks for the local variables in the function sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/stagi

[PATCH v2 24/49] staging: sm750fb: Update local variable in sm750_hw_fillrect to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpoint.pl checks for the local variable deCtrl in the function sm750_hw_fillrect. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_

[PATCH v2 22/49] staging: sm750fb: Update local variable in sm750_hw_copyarea to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpoint.pl checks for the local variable nDirection in the function sm750_hw_copyarea. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/stagi

[PATCH v2 20/49] staging: sm750fb: Update function parameter names to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for function parameter names in sm750_accel.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 92 +-- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/staging/sm750fb/sm7

[PATCH v2 21/49] staging: sm750fb: Rename function write_dpPort to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the function write_dpPort. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm7

[PATCH v2 19/49] staging: sm750fb: Rename function parameter of sii164_enable_hot_plug_detection

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the function parameter enable_hot_plug in the prototype of the function sii164_enable_hot_plug_detection. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 18/49] staging: sm750fb: Rename function params of sii164_init_chip

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for function parameter names of the function sii164_init_chip. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/stagi

[PATCH v2 17/49] staging: sm750fb: Rename local variables to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for local variables in SII164_FULL_FUNCTIONS block. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 40 - 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/stagi

[PATCH v2 16/49] staging: sm750fb: Update function parameter names in ddk750_sii164.c

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for function parameters in ddk750_sii164.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c

[PATCH v2 15/49] staging: sm750fb: Rename gDviCtrlChipName to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the global variable gDviCtrlChipName. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/stagi

[PATCH v2 14/49] staging: sm750fb: Rename sii164SelectHotPlugDetectionMode to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the function sii164SelectHotPlugDetectionMode in ddk750_sii164.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/stagi

[PATCH v2 12/49] staging: sm750fb: Rename vendorID local variable to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the local variable vendorID in the function sii164_get_vendor_id. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk

[PATCH v2 13/49] staging: sm750fb: Rename deviceID local variable to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the local variable deviceID in the function sii164_get_device_id. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk

[PATCH v2 11/49] staging: sm750fb: Rename i2cWriteReg and i2cReadReg to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for i2cWriteReg and i2cReadReg in ddk750_sii164.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 46 - 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/stagi

[PATCH v2 10/49] staging: sm750fb: Rename ddk750_setModeTiming to ddk750_set_mode_timing

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the function ddk750_setModeTiming. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_mode.h | 2 +- drivers/staging/sm750fb/sm750_hw.c| 2 +- 3 files changed, 3 insert

[PATCH v2 09/49] staging: sm750fb: Rename sm750_set_power_mode function parameter

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the function parameter powerMode of function sm750_set_power_mode. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_power.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_

[PATCH v2 08/49] staging: sm750fb: Update enum values in dpms to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for values in enum dpms. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_power.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk7

[PATCH v2 06/49] staging: sm750fb: Update displayControlAdjust_SM750LE to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function displayControlAdjust_SM750LE, including its name, parameters, and body. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_mode.c | 40 +-- 1 file changed, 20 insertions(+), 20 deletion

[PATCH v2 07/49] staging: sm750fb: Update programModeRegisters to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for the function programModeRegisters, including its name, parameters, and body. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_mode.c | 48 +-- 1 file changed, 24 insertions(+), 24 deletions(-)

[PATCH v2 05/49] staging: sm750fb: Remove remaining camel case names in ddk750_dvi.h

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl check for type definitions DVICTRL_SETPOWER and DVICTRL_HOTPLUGDETECTION in ddk750_dvi.h. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH v2 03/49] staging: sm750fb: Update param names of PFN_DVICTRL_INIT function pointer

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for parameter names in the type definition of PFN_DVICTRL_INIT function pointer. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH v2 04/49] staging: sm750fb: Remove type names in variables and type definitions

2021-04-07 Thread Pavle Rohalj
Remove type names used in variables and type definitions for dvi_ctrl_device structure. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c | 24 - drivers/staging/sm750fb/ddk750_dvi.h | 40 ++-- 2 files changed, 32 insertions(+), 32

[PATCH v2 02/49] staging: sm750fb: Rename dviInit to dvi_init and update param names

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for the function dviInit and its parameter names in ddk750_dvi.h. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_dvi.h | 20 ++-- 2 files changed, 11 inserti

[PATCH v2 01/49] staging: sm750fb: Update dvi_ctrl_device to snake case

2021-04-07 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for dvi_ctrl_device structure and its usages. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c| 30 drivers/staging/sm750fb/ddk750_dvi.h| 20 +-- drivers/staging/sm750fb/ddk750_sii

[PATCH v2 00/49] *** SUBJECT HERE ***

2021-04-07 Thread Pavle Rohalj
Changes in v2: - Removed type information from variable names - Broken up the changes into smaller patches Pavle Rohalj (49): staging: sm750fb: Update dvi_ctrl_device to snake case staging: sm750fb: Rename dviInit to dvi_init and update param names staging: sm750fb: Update param

Re: [PATCH] staging: sm750fb: Convert camel case to snake case

2021-04-06 Thread Pavle Rohalj
On Tue, Apr 06, 2021 at 11:36:41AM +0200, Greg KH wrote: > On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote: > > - struct dvi_ctrl_device *pCurrentDviCtrl; > > + struct dvi_ctrl_device *p_current_dvi_ctrl; > > Does this change make sense? Why keep the "

[PATCH] staging: sm750fb: Convert camel case to snake case

2021-04-06 Thread Pavle Rohalj
Fix "Avoid CamelCase" checkpatch.pl checks for 106 camel case instances: Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c| 32 ++--- drivers/staging/sm750fb/ddk750_dvi.h| 64 +- drivers/staging/sm750fb/ddk750_mode.c | 88 +++--- drive