Re: [PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

On Thu, Jun 30, 2016 at 1:05 PM, Amitkumar Karwar <akar...@marvell.com> wrote: > Hi Prasun, > >> From: Prasun Maiti [mailto:prasunmait...@gmail.com] >> Sent: Friday, June 24, 2016 12:27 PM >> To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo >> Cc: Linu

Re: [PATCH v2] mwifiex: Fix endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

On Thu, Jun 30, 2016 at 2:07 PM, Amitkumar Karwar wrote: > Hi Prasun, > Updated change looks fine to me. > > Acked-by: Amitkumar Karwar > > Regards, > Amitkumar Hi AmitKumar, Thanks for your verification. -- Thanks, Prasun

Re: [PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

On Thu, Jun 30, 2016 at 1:05 PM, Amitkumar Karwar wrote: > Hi Prasun, > >> From: Prasun Maiti [mailto:prasunmait...@gmail.com] >> Sent: Friday, June 24, 2016 12:27 PM >> To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo >> Cc: Linux Wireless; Linux Next; Linux

Re: [PATCH v2] mwifiex: Fix endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

On Thu, Jun 30, 2016 at 2:07 PM, Amitkumar Karwar wrote: > Hi Prasun, > Updated change looks fine to me. > > Acked-by: Amitkumar Karwar > > Regards, > Amitkumar Hi AmitKumar, Thanks for your verification. -- Thanks, Prasun

[PATCH v2] mwifiex: Fix endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

the values into cpu's byte order before assigning them into the local members. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- Changes in v2: - Fixed the following sparse compilation warnings: * sta_event.c:477:55: warning: cast to restricted __le16 * sta_event.c

[PATCH v2] mwifiex: Fix endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

the values into cpu's byte order before assigning them into the local members. Signed-off-by: Prasun Maiti --- Changes in v2: - Fixed the following sparse compilation warnings: * sta_event.c:477:55: warning: cast to restricted __le16 * sta_event.c:478:55: warning: cast to restric

[PATCH v4] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- Changes in v3: - Fixed the following warnings: * sta_ioctl.c:1339:34: warning:

[PATCH v4] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti --- Changes in v3: - Fixed the following warnings: * sta_ioctl.c:1339:34: warning: comparison of distinct pointe

Re: [PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

On Thu, Jun 16, 2016 at 9:49 AM, Prasun Maiti <prasunmait...@gmail.com> wrote: > The two members min_scan_time and max_scan_time of structure > "mwifiex_ie_types_btcoex_scan_time" are of two bytes each. The values > are assigned directtly from firmware without endian

Re: [PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

On Thu, Jun 16, 2016 at 9:49 AM, Prasun Maiti wrote: > The two members min_scan_time and max_scan_time of structure > "mwifiex_ie_types_btcoex_scan_time" are of two bytes each. The values > are assigned directtly from firmware without endian conversion handling. > So, wron

[PATCH v3] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- Changes in v3: - Fixed the following warnings: * sta_ioctl.c:1339:34: warning:

[PATCH v3] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti --- Changes in v3: - Fixed the following warnings: * sta_ioctl.c:1339:34: warning: comparison of distinct pointe

[PATCH v3] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- Changes in v3: - Fixed the following warnings: * sta_ioctl.c:1339:34: warning:

[PATCH v3] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti --- Changes in v3: - Fixed the following warnings: * sta_ioctl.c:1339:34: warning: comparison of distinct pointe

[PATCH] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 28 +++- drivers/net/wireles

[PATCH] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 28 +++- drivers/net/wireless/marv

Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands

> If you send a new version of the patch mark it as [PATCH v2] and always > include a change log so that people don't need to guess what has > changed: > > http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb > > So now you should send a v3 and include a

Re: [PATCH] mwifiex: Reduce endian conversion for REG Host Commands

> If you send a new version of the patch mark it as [PATCH v2] and always > include a change log so that people don't need to guess what has > changed: > > http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb > > So now you should send a v3 and include a

[PATCH] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 28 - drivers/net/wireles

[PATCH] mwifiex: Reduce endian conversion for REG Host Commands

rsion without saving "cpu_to_leX" converted values in driver. This will convert endianness in prepare command and command response path. Signed-off-by: Prasun Maiti --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 28 - drivers/net/wireless/marv

Re: [Query] mwifiex: few observations to reduce number of endian conversions

Hi Amitkumar, On Tue, Jun 21, 2016 at 3:47 PM, Amitkumar Karwar wrote: > I agree with your observations. We'll prepare a cleanup patch to address this. > > Regards, > Amitkumar I have already made some changes. I will send you a patch for this. -- Thanks, Prasun

Re: [Query] mwifiex: few observations to reduce number of endian conversions

Hi Amitkumar, On Tue, Jun 21, 2016 at 3:47 PM, Amitkumar Karwar wrote: > I agree with your observations. We'll prepare a cleanup patch to address this. > > Regards, > Amitkumar I have already made some changes. I will send you a patch for this. -- Thanks, Prasun

[Query] mwifiex: few observations to reduce number of endian conversions

Hi Amitkumar, I have two observations: 1. I have found that in the command response path for host command "HostCmd_CMD_802_11_EEPROM_ACCESS", a "0" value has been endian converted. It can only be a safe futuristic approach for any non-zero value there however! Otherwise, the endian conversion

[Query] mwifiex: few observations to reduce number of endian conversions

Hi Amitkumar, I have two observations: 1. I have found that in the command response path for host command "HostCmd_CMD_802_11_EEPROM_ACCESS", a "0" value has been endian converted. It can only be a safe futuristic approach for any non-zero value there however! Otherwise, the endian conversion

[PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

the values into cpu's byte order before assigning them into the local members. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- drivers/net/wireless/marvell/mwifiex/sta_event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ev

[PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

the values into cpu's byte order before assigning them into the local members. Signed-off-by: Prasun Maiti --- drivers/net/wireless/marvell/mwifiex/sta_event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wirele

[PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns

, it makes warning. To remove this warning, add .set_antenna callback in ath6kl driver which is unimplemented. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wi

[PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns

, it makes warning. To remove this warning, add .set_antenna callback in ath6kl driver which is unimplemented. Signed-off-by: Prasun Maiti --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

this solution is acceptable. Thanks, Prasun On Thu, Jun 9, 2016 at 5:35 AM, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Prasun, > > On Thu, Jun 9, 2016 at 1:20 AM, Prasun Maiti <prasunmait...@gmail.com> wrote: >> I am not sure it works fine. Like ath6kl driver sen

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

this solution is acceptable. Thanks, Prasun On Thu, Jun 9, 2016 at 5:35 AM, Julian Calaby wrote: > Hi Prasun, > > On Thu, Jun 9, 2016 at 1:20 AM, Prasun Maiti wrote: >> I am not sure it works fine. Like ath6kl driver send another cmd to >> firmare, I have just fil

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Please help me how to test this one?? It will be great to me if you help me. On Wed, Jun 8, 2016 at 9:21 PM, Ben Greear <gree...@candelatech.com> wrote: > On 06/08/2016 08:46 AM, Prasun Maiti wrote: >> >> Please tell me if I mention that this code is untested in commit l

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Please help me how to test this one?? It will be great to me if you help me. On Wed, Jun 8, 2016 at 9:21 PM, Ben Greear wrote: > On 06/08/2016 08:46 AM, Prasun Maiti wrote: >> >> Please tell me if I mention that this code is untested in commit log, >> then could you

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Please tell me if I mention that this code is untested in commit log, then could you check the code kindly and also help me to fix this type of warning? On Wed, Jun 8, 2016 at 9:00 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote: > Prasun Maiti <prasunmait...@gmail.com> writes: >

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Please tell me if I mention that this code is untested in commit log, then could you check the code kindly and also help me to fix this type of warning? On Wed, Jun 8, 2016 at 9:00 PM, Valo, Kalle wrote: > Prasun Maiti writes: > >> I am not sure it works fine. Like ath6kl driver

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

ors in the previous patch. Let me know if any modifications are needed? On Wed, Jun 8, 2016 at 8:16 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote: > Prasun Maiti <prasunmait...@gmail.com> writes: > >> No. I did not any test for that case. >> This driver create a n

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

ors in the previous patch. Let me know if any modifications are needed? On Wed, Jun 8, 2016 at 8:16 PM, Valo, Kalle wrote: > Prasun Maiti writes: > >> No. I did not any test for that case. >> This driver create a new wiphy for use with cfg80211 through >> "wip

[PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns

, it makes warning. To remove this warning, add .set_antenna callback in ath6kl driver and also send a cmd to firmware with it's values. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 24 drivers/net/wirele

[PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns

, it makes warning. To remove this warning, add .set_antenna callback in ath6kl driver and also send a cmd to firmware with it's values. Signed-off-by: Prasun Maiti --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 24 drivers/net/wireless/ath/ath6kl/wmi.c | 18

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

ing comes during creation of a new wiphy. That's why It is needed. On Wed, Jun 8, 2016 at 7:53 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote: > Prasun Maiti <prasunmait...@gmail.com> writes: > >> Since add more warnings for inconsistent ops in cfg80211, the wireles

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

ing comes during creation of a new wiphy. That's why It is needed. On Wed, Jun 8, 2016 at 7:53 PM, Valo, Kalle wrote: > Prasun Maiti writes: > >> Since add more warnings for inconsistent ops in cfg80211, the wireless >> core warns if a driver implements a cfg80211 call

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

, it makes warning. To remove this warning, add .set_antenna callback in ath6kl driver and also send a cmd to firmware with it's values. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 24 drivers/net/wirele

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

, it makes warning. To remove this warning, add .set_antenna callback in ath6kl driver and also send a cmd to firmware with it's values. Signed-off-by: Prasun Maiti --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 24 drivers/net/wireless/ath/ath6kl/wmi.c | 18

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

, it makes warning. To remove this warning, add .set_antenna callback in ath6kl driver and also send a cmd to firmware with it's values. Signed-off-by: Prasun Maiti <prasunmait...@gmail.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 24 drivers/net/wirele

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

, it makes warning. To remove this warning, add .set_antenna callback in ath6kl driver and also send a cmd to firmware with it's values. Signed-off-by: Prasun Maiti --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 24 drivers/net/wireless/ath/ath6kl/wmi.c | 18