r_len()
> __assign_rel_str()
> __assign_rel_str_len()
>
> I tested this with both an allmodconfig and an allyesconfig (build only for
> both).
>
> [1]
> https://lore.kernel.org/linux-trace-kernel/2024011442.634192...@goodmis.org/
>
> Cc: Masami Hiramatsu
> Cc: Mathieu Desnoyers
> Cc: Linus Torvalds
> Cc: Julia Lawall
> Signed-off-by: Steven Rostedt (Google)
Acked-by: Rafael J. Wysocki # for thermal
On Wed, Feb 21, 2024 at 8:49 PM Vilas Bhat wrote:
>
> Existing runtime PM ftrace events (`rpm_suspend`, `rpm_resume`,
> `rpm_return_int`) offer limited visibility into the exact timing of device
> runtime power state transitions, particularly when asynchronous operations
> are involved. When the
On Fri, Feb 2, 2024 at 4:49 PM Andy Shevchenko
wrote:
>
> On Mon, Nov 20, 2023 at 07:19:44PM +0200, Andy Shevchenko wrote:
> > On Mon, Nov 20, 2023 at 04:11:54PM +0100, Rafael J. Wysocki wrote:
> > > On Mon, Nov 20, 2023 at 4:03 PM Andy Shevchenko
> > > wrote:
>
On Thu, Dec 21, 2023 at 8:57 PM Rafael J. Wysocki wrote:
>
> On Thu, Dec 21, 2023 at 4:24 PM Vincent Guittot
> wrote:
> >
> > Provide to the scheduler a feedback about the temporary max available
> > capacity. Unlike arch_update_thermal_pressure, this does
policy)
> +{
> + unsigned long max_capacity, capped_freq, pressure;
> + u32 max_freq;
> + int cpu;
> +
> + cpu = cpumask_first(policy->related_cpus);
> + pressure = max_capacity = arch_scale_cpu_capacity(cpu);
I would prefer two separate state
On Thu, Dec 14, 2023 at 10:07 AM Lukasz Luba wrote:
>
> On 12/14/23 07:57, Vincent Guittot wrote:
> > On Thu, 14 Dec 2023 at 06:43, Viresh Kumar wrote:
> >>
> >> On 12-12-23, 15:27, Vincent Guittot wrote:
> >>> @@ -2618,6 +2663,9 @@ static int cpufreq_set_policy(struct cpufreq_policy
> >>>
On Mon, Nov 20, 2023 at 4:03 PM Andy Shevchenko
wrote:
>
> On Thu, Oct 19, 2023 at 06:03:28PM -0700, Dan Williams wrote:
> > Andy Shevchenko wrote:
> > > The acpi_evaluate_dsm_typed() provides a way to check the type of the
> > > object evaluated by _DSM call. Use it instead of open coded
Hi Linus,
Please pull from the tag
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
acpi-6.6-rc8
with top-most commit 9b311b7313d6c104dd4a2d43ab54536dce07f960
ACPI: NFIT: Install Notify() handler before getting NFIT table
on top of commit
On Fri, Oct 13, 2023 at 2:22 PM Kuan-Wei Chiu wrote:
>
> The original code used conditional branching in the nfit_mem_cmp
> function to compare two values and return -1, 1, or 0 based on the
> result. However, the list_sort comparison function only needs results
> <0, >0, or =0. This patch
On Wed, Oct 18, 2023 at 6:28 AM Dan Williams wrote:
>
> Michal Wilczynski wrote:
> > The new cleanup.h facilities that arrived in v6.5-rc1 can replace the
> > the usage of devm semantics in acpi_nfit_init_interleave_set(). That
> > routine appears to only be using devm to avoid goto statements.
tioning of the whole devm_*() family of
> functions, since the lifecycle of the device stays the same. It is still
> being created during the enumeration, and destroyed on platform device
> removal.
>
> Suggested-by: Rafael J. Wysocki
> Signed-off-by: Mic
On Wed, Oct 11, 2023 at 10:34 AM Michal Wilczynski
wrote:
>
> Since transformation from ACPI driver to platform driver there are two
> devices on which the driver operates - ACPI device and platform device.
> For the sake of reader this calls for the distinction in their naming,
> to avoid
FIT driver uses devm_*() family of functions extensively. This change
> > has no impact on correct functioning of the whole devm_*() family of
> > functions, since the lifecycle of the device stays the same. It is still
> > being created during the enumeration, and destroyed
On Wed, Oct 11, 2023 at 10:34 AM Michal Wilczynski
wrote:
>
> Use modern string_choices API instead of manually determining the
> output using ternary operator.
>
> Suggested-by: Andy Shevchenko
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Michal Wilczynski
> ---
> drivers/acpi/ac.c | 5
On Wed, Oct 11, 2023 at 10:34 AM Michal Wilczynski
wrote:
>
> Remove unnecessary checks for NULL for variables that can't be NULL at
> the point they're checked for it. Defensive programming is discouraged
> in the kernel.
>
> Signed-off-by: Michal Wilczynski
> ---
> drivers/acpi/ac.c | 27
On Mon, Oct 9, 2023 at 3:04 PM Wilczynski, Michal
wrote:
>
>
>
> On 10/9/2023 2:27 PM, Rafael J. Wysocki wrote:
> > On Mon, Oct 9, 2023 at 10:40 AM Wilczynski, Michal
> > wrote:
> >>
[cut]
> >> Yeah we could add platform device without removing acpi
On Mon, Oct 9, 2023 at 10:40 AM Wilczynski, Michal
wrote:
>
>
> Hi !
>
> Thanks a lot for a review, to both of you ! :-)
>
> On 10/7/2023 12:43 PM, Rafael J. Wysocki wrote:
> > On Sat, Oct 7, 2023 at 12:41 PM Rafael J. Wysocki wrote:
> >> On Sat, Oc
On Sat, Oct 7, 2023 at 12:41 PM Rafael J. Wysocki wrote:
>
> On Sat, Oct 7, 2023 at 9:56 AM Andy Shevchenko
> wrote:
> >
> > On Fri, Oct 06, 2023 at 09:47:57PM +0200, Rafael J. Wysocki wrote:
> > > On Fri, Oct 6, 2023 at 8:33 PM Michal Wilczynski
> > >
On Sat, Oct 7, 2023 at 9:56 AM Andy Shevchenko
wrote:
>
> On Fri, Oct 06, 2023 at 09:47:57PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Oct 6, 2023 at 8:33 PM Michal Wilczynski
> > wrote:
>
> ...
>
> > > struct acpi_ac {
> > > struc
lank line to distinguish pdev API vs local ACPI notify function.
>
> Suggested-by: Rafael J. Wysocki
> Signed-off-by: Michal Wilczynski
> ---
> drivers/acpi/ac.c | 70 +--
> 1 file changed, 37 insertions(+), 33 deletions(-)
&g
On Thu, Oct 5, 2023 at 10:39 PM Wilczynski, Michal
wrote:
>
>
>
> On 10/5/2023 8:28 PM, Wilczynski, Michal wrote:
> >
> > On 10/5/2023 7:57 PM, Rafael J. Wysocki wrote:
> >> On Monday, September 25, 2023 4:48:35 PM CEST Michal Wilczynski wrote:
> >>>
On Thu, Oct 5, 2023 at 8:27 PM Wilczynski, Michal
wrote:
>
>
>
> On 10/5/2023 7:03 PM, Rafael J. Wysocki wrote:
> > On Thursday, October 5, 2023 5:30:59 PM CEST Rafael J. Wysocki wrote:
> >> On Thu, Oct 5, 2023 at 2:05 PM Wilczynski, Michal
> >> wrote:
&
device interfaces with the FW, and the platform device with the rest of
> +the system.
> +
> DMA support
> ===
I rewrote the above entirely, so here's a new patch to replace this one:
---
From: Rafael J. Wysocki
Subject: [PATCH v2 2/9] ACPI: docs: enumeration: Clarify ACPI bus conc
On Thursday, October 5, 2023 5:30:59 PM CEST Rafael J. Wysocki wrote:
> On Thu, Oct 5, 2023 at 2:05 PM Wilczynski, Michal
> wrote:
> > On 10/5/2023 12:57 PM, Rafael J. Wysocki wrote:
> > > On Thu, Oct 5, 2023 at 10:10 AM Wilczynski, Michal
> > > wrote:
>
>
On Thu, Oct 5, 2023 at 2:05 PM Wilczynski, Michal
wrote:
> On 10/5/2023 12:57 PM, Rafael J. Wysocki wrote:
> > On Thu, Oct 5, 2023 at 10:10 AM Wilczynski, Michal
> > wrote:
[cut]
> >>>
> >>> That said, why exactly is it better to use acpi_handle instea
On Thu, Oct 5, 2023 at 10:10 AM Wilczynski, Michal
wrote:
>
> Hi,
>
> Thanks for your review !
>
> On 10/4/2023 9:09 PM, Rafael J. Wysocki wrote:
> > On Mon, Sep 25, 2023 at 6:31 PM Michal Wilczynski
> > wrote:
> >> acpi_dev_install_notify_handl
On Mon, Sep 25, 2023 at 6:31 PM Michal Wilczynski
wrote:
>
> acpi_dev_install_notify_handler() and acpi_dev_remove_notify_handler()
> are wrappers around ACPICA installers. They are meant to save some
> duplicated code from drivers. However as we're moving towards drivers
> operating on
On Mon, Jul 3, 2023 at 10:03 AM Michal Wilczynski
wrote:
>
> *** IMPORTANT ***
> This is part 1 - only drivers in acpi directory to ease up review
> process. Rest of the drivers will be handled in separate patchsets.
>
> Currently drivers support ACPI event handlers by defining .notify
> callback
On Mon, Jul 3, 2023 at 10:03 AM Michal Wilczynski
wrote:
>
> Nfit driver doesn't use .remove() callback and provide an empty function
> as it's .remove() callback. Remove empty acpi_nfit_remove() and
> initialization of callback.
>
> Suggested-by: Dan Williams
> Signed-off-by: Michal Wilczynski
gt; Move acpi_nfit_notify() upwards in the file, so it can be used inside
> acpi_nfit_add() and acpi_nfit_remove_notify_handler().
Dan, any objections?
> Suggested-by: Rafael J. Wysocki
> Signed-off-by: Michal Wilczynski
> ---
> drivers/acpi/nfit/core.c | 41 +++
On Mon, Jul 3, 2023 at 3:01 PM Ben Dooks wrote:
>
> Some of the fields in struct acpi_nfit_control_region are used in big
> endian format, and thus are generatng warnings from spare where the
> member is passed to one of the conversion functions.
>
> Fix the following sparse warnings by changing
On Fri, Jun 30, 2023 at 1:04 PM Rafael J. Wysocki wrote:
>
> On Fri, Jun 30, 2023 at 11:52 AM Wilczynski, Michal
> wrote:
> >
> >
> >
> > On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote:
> > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
> > >
On Fri, Jun 30, 2023 at 11:52 AM Wilczynski, Michal
wrote:
>
>
>
> On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote:
> > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
> > wrote:
> >> Currently terminator line contains redunant characters.
> > Well, they a
On Fri, Jun 30, 2023 at 11:55 AM Wilczynski, Michal
wrote:
>
>
>
> On 6/29/2023 6:18 PM, Rafael J. Wysocki wrote:
> > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
> > wrote:
> >> Currently logic for installing notifications from ACPI devices is
>
On Fri, Jun 30, 2023 at 11:48 AM Wilczynski, Michal
wrote:
>
>
>
> On 6/29/2023 6:06 PM, Rafael J. Wysocki wrote:
> > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
> > wrote:
> >> To use new style of installing event handlers acpi_nfit_notify() needs
>
On Fri, Jun 30, 2023 at 11:41 AM Rafael J. Wysocki wrote:
>
> On Fri, Jun 30, 2023 at 11:39 AM Wilczynski, Michal
> wrote:
> >
> >
> >
> > On 6/29/2023 5:55 PM, Rafael J. Wysocki wrote:
> > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
> >
On Fri, Jun 30, 2023 at 11:39 AM Wilczynski, Michal
wrote:
>
>
>
> On 6/29/2023 5:55 PM, Rafael J. Wysocki wrote:
> > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
> > wrote:
> >> Currently logic for installing notifications from ACPI devices is
>
() at the beginning of .remove()
> callback. Change arguments passed to the notify function to match with
> what's required by acpi_install_notify_handler(). Remove .notify
> callback initialization in acpi_driver.
>
> Suggested-by: Rafael J. Wysocki
> Signed-off-by: Michal Wi
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
wrote:
>
> Currently terminator line contains redunant characters.
Well, they are terminating the list properly AFAICS, so they aren't
redundant and the size of it before and after the change is actually
the same, isn't it?
> Remove them and
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski
wrote:
>
> To use new style of installing event handlers acpi_nfit_notify() needs
> to be known inside acpi_nfit_add(). Move acpi_nfit_notify() upwards in
> the file, so it can be used inside acpi_nfit_add().
>
> Signed-off-by: Michal Wilczynski
() at the beginning of .remove()
> callback. Change arguments passed to the notify function to match with
> what's required by acpi_install_notify_handler(). Remove .notify
> callback initialization in acpi_driver.
>
> While at it, fix lack of whitespaces in .remove() callback.
>
> Sugge
() at the beginning of .remove()
> callback. Change arguments passed to the notify function to match with
> what's required by acpi_install_notify_handler(). Remove .notify
> callback initialization in acpi_driver.
>
> Suggested-by: Rafael J. Wysocki
> Signed-off-by: Michal Wil
() at the beginning of .remove()
> callback. Change arguments passed to the notify function to match with
> what's required by acpi_install_notify_handler(). Remove .notify
> callback initialization in acpi_driver.
>
> Suggested-by: Rafael J. Wysocki
> Signed-off-by: Mi
On Mon, May 22, 2023 at 5:22 PM Dave Jiang wrote:
>
>
>
> On 5/16/23 1:14 PM, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > The nfit_intel_shutdown_status() function has a __weak defintion
> > in nfit.c and an override in acpi_nfit_test.c for testing
> > purposes. This works without an
the
nodemask, decoupling it from the overloaded initiator_cmp() comparision
callback. This prevents the singular list corner case naturally, and
makes the code easier to follow as well.
Cc:
Cc: Rafael J. Wysocki
Cc: Liu Shixin
Cc: Dan Williams
Cc: Kirill A. Shutemov
Reported-by: Chris Piper
Signed-off
:
> ACPI: HMAT: remove unnecessary variable initialization
> ACPI: HMAT: Fix initiator registration for single-initiator systems
Acked-by: Rafael J. Wysocki
for both and please feel free to ask Dan to take them.
Alternatively, if you want me to apply them, please let me know.
&g
On Wed, Mar 2, 2022 at 4:50 PM Andy Shevchenko
wrote:
>
> On Fri, Feb 11, 2022 at 01:04:23PM +0200, Andy Shevchenko wrote:
> > Since we got list_entry_is_head() helper in the generic header,
> > we may switch the ACPI modules to use it. This eliminates the
> > need in additional variable. In some
On Mon, Dec 13, 2021 at 9:46 PM Andy Shevchenko
wrote:
>
> Strictly speaking the comparison between guid_t and raw buffer
> is not correct. Import GUID to variable of guid_t type and then
> compare.
>
> Signed-off-by: Andy Shevchenko
Dan, are you going to take care of this or should I?
> ---
>
On Sun, Apr 18, 2021 at 11:22 AM Joe Perches wrote:
>
> On Sun, 2021-04-18 at 09:11 +, Sebastian Fricke wrote:
> > Hey Joe,
>
> Hi Sebastian.
>
> > On 18.04.2021 00:09, Joe Perches wrote:
> > > On Sun, 2021-04-18 at 06:08 +, Sebastian Fricke wrote:
> > > > Remove a redundant space to
On Mon, Apr 19, 2021 at 11:08 AM Kai-Heng Feng
wrote:
>
> HP EliteBook 840 G8 reboots on s2idle resume, and HP EliteBook 845 G8
> wakes up immediately on s2idle. Both are caused by the XMM7360 WWAN PCI
> card.
>
> There's a WWAN specific method to really turn off the WWAN via EC:
> Method
On Wed, Apr 14, 2021 at 2:53 PM Andy Shevchenko
wrote:
>
> We have open coded dev_set_name() implementation, replace that
> with a direct call.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/base/power/wakeup_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
d434405aaab7d0ebc516b68a8fc4100922d7f5ef
Linux 5.12-rc7
to receive an ACPI fix for 5.12-rc8.
This restores the initrd-based ACPI table override functionality
broken by one of the recent fixes.
Thanks!
---
Rafael J. Wysocki (1):
ACPI: x86: Call acpi_boot_table_init() after acpi_table_upgrade
On Wed, Apr 14, 2021 at 3:22 PM w4v3 wrote:
>
> Hi Thorsten,
>
> Thanks for the quick and illuminating response :)
>
> > Links to your bug report and the thread on the mailing list would have
> > helped here to understand better what's going on, but whatever, they are
> > not that important.
>
>
On Wed, Apr 14, 2021 at 10:13 AM Mike Rapoport wrote:
>
> On Wed, Apr 14, 2021 at 09:42:01AM +0200, David Hildenbrand wrote:
> > On 13.04.21 19:53, Rafael J. Wysocki wrote:
> > > On Tue, Apr 13, 2021 at 7:43 PM David Hildenbrand
> > > wrote:
> > > >
&g
s was
> in November 2015 and has gone unnoticed for over 5 year.
>
> It is now clear that this code is of no interest to anyone and therefore
> should be removed.
>
> Signed-off-by: Boris Ostrovsky
Acked-by: Rafael J. Wysocki
Thanks for doing this!
> ---
&g
On Tue, Apr 13, 2021 at 7:43 PM David Hildenbrand wrote:
>
> On 13.04.21 16:01, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki
> >
> > Commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by
> > ACPI tables") attempted to address an issu
From: Rafael J. Wysocki
Commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by
ACPI tables") attempted to address an issue with reserving the memory
occupied by ACPI tables, but it broke the initrd-based table override
mechanism relied on by multiple users.
To restore
On Tue, Apr 13, 2021 at 1:21 AM Andy Shevchenko
wrote:
>
> The DSDT and ACPI should be capitalized.
>
> Signed-off-by: Andy Shevchenko
> ---
> v2: split from patch 1 as per Rafael's request
> drivers/acpi/utils.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On Tue, Apr 13, 2021 at 12:24 AM Andy Shevchenko
wrote:
>
> Introduce acpi_dev_get() to have a symmetrical API with acpi_dev_put()
> and reuse both in ACPI code under drivers/acpi folder.
>
> While at it, use acpi_bus_put_acpi_device() in one place rather than above.
>
> Signed-off-by: Andy
On Mon, Apr 12, 2021 at 8:10 PM Andy Shevchenko
wrote:
>
> On Mon, Apr 12, 2021 at 9:05 PM Rafael J. Wysocki wrote:
> >
> > On Mon, Apr 12, 2021 at 7:47 PM Andy Shevchenko
> > wrote:
> > >
> > > On Mon, Apr 12, 2021 at 8:32 PM Rafael J. Wysocki
>
On Mon, Apr 12, 2021 at 7:47 PM Andy Shevchenko
wrote:
>
> On Mon, Apr 12, 2021 at 8:32 PM Rafael J. Wysocki wrote:
> > On Sat, Apr 10, 2021 at 3:47 PM Andy Shevchenko
> > wrote:
>
> ...
>
> > > static void get_acpi_device(void
On Sat, Apr 10, 2021 at 4:02 PM Andy Shevchenko
wrote:
>
> We have already an API to match a string in the array of strings.
> Utilize it instead of open coded analogues.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/acpi/scan.c | 22 ++
> 1 file changed, 10
On Sat, Apr 10, 2021 at 3:47 PM Andy Shevchenko
wrote:
>
> Introduce acpi_dev_get() to have a symmetrical API with acpi_dev_put()
> and reuse both in ACPI code under drivers/acpi folder.
>
> While at it, use acpi_bus_put_acpi_device() in one place rather than above.
>
> Signed-off-by: Andy
On Sat, Apr 10, 2021 at 3:29 PM Andy Shevchenko
wrote:
>
> The macro requires to call acpi_dev_put() on each iteration.
> Due to this it doesn't tolerate sudden disappearence of the devices.
>
> Document all these nuances to prevent users blindly call it without
> understanding the possible
Hi Linus,
Please pull from the tag
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
acpi-5.12-rc7
with top-most commit fa26d0c778b432d3d9814ea82552e813b33eeb5c
ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m
on top of commit
On Fri, Apr 9, 2021 at 10:36 AM Chunfeng Yun wrote:
>
> On Fri, 2021-04-09 at 08:39 +0300, Tony Lindgren wrote:
> > * Chunfeng Yun [210409 01:54]:
> > > On Thu, 2021-04-08 at 19:41 +0200, Rafael J. Wysocki wrote:
> > > > On Thu, Apr 8, 2021 at 11:3
On Thu, Apr 8, 2021 at 8:02 PM Daniel Lezcano wrote:
>
> On 08/04/2021 19:24, Rafael J. Wysocki wrote:
> > On Thu, Apr 8, 2021 at 5:10 PM Daniel Lezcano
> > wrote:
> >>
> >>
> >> Hi Rafael,
> >>
> >> please consider pul
On Wed, Apr 7, 2021 at 11:32 PM Nathan Chancellor wrote:
>
> All of the CPPC sysfs show functions are called via indirect call in
> kobj_attr_show(), where they should be of type
>
> ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr, char *buf);
>
> because that is the type of the
On Thu, Apr 8, 2021 at 11:35 AM Chunfeng Yun wrote:
>
> When the dedicated wake irq is level trigger, enable it before
> calling runtime_suspend, will trigger an interrupt.
>
> e.g.
> for a low level trigger type, it's low level at running time (0),
> and becomes high level when enters suspend
On Thu, Apr 8, 2021 at 10:14 AM Lu Jialin wrote:
>
> Change occured to occurred in kernel/power/autosleep.c.
> Change consiting to consisting in kernel/power/snapshot.c.
> Change avaiable to available in kernel/power/swap.c.
> No functionality changed.
>
> Signed-off-by: Lu Jialin
> ---
>
On Thu, Apr 8, 2021 at 8:12 AM Chanwoo Choi wrote:
>
> Dear Rafael,
>
> This is devfreq-next pull request for v5.13-rc1. I add detailed description of
> this pull request on the following tag. Please pull devfreq with following
> updates.
> - tag name : devfreq-next-for-5.12
>
> This pull
On Thu, Apr 8, 2021 at 5:10 PM Daniel Lezcano wrote:
>
>
> Hi Rafael,
>
> please consider pulling the following change for cpuidle on ARM for
> v5.13-rc1
>
> Thanks
>
> -- Daniel
>
>
> The following changes since commit dde8740bd9b505c58ec8b2277d5d55c6951b7e42:
>
> Merge branch
On Fri, Apr 2, 2021 at 8:14 AM YueHaibing wrote:
>
> commit 9a7875461fd0 ("PM: runtime: Replace pm_runtime_callbacks_present()")
> forget to change the inline version.
>
> Fixes: 9a7875461fd0 ("PM: runtime: Replace pm_runtime_callbacks_present()")
> Signed-off-by: YueHaibing
> ---
>
On Thu, Apr 1, 2021 at 7:58 PM YueHaibing wrote:
>
> There is no caller in tree, so can remove it.
>
> Signed-off-by: YueHaibing
> ---
> include/linux/freezer.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> index
On Tue, Mar 30, 2021 at 8:40 AM Wan Jiabing wrote:
>
> struct rapl_package is declared twice. One has been declared
> at 80th line.
> By reviewing the code, it should declare struct rapl_domain
> rather than rapl_package. Modify it.
>
> Signed-off-by: Wan Jiabing
> ---
>
On Thu, Apr 8, 2021 at 5:26 PM Eric Biggers wrote:
>
> On Thu, Apr 08, 2021 at 03:32:38PM +0200, Rafael J. Wysocki wrote:
> > On Thu, Apr 8, 2021 at 3:15 PM Chris von Recklinghausen
> > wrote:
> > >
> > > Suspend fails on a system in fips mode because md5
On Thu, Apr 8, 2021 at 5:18 PM Andy Shevchenko
wrote:
>
> On Thu, Apr 08, 2021 at 05:04:32PM +0200, Rafael J. Wysocki wrote:
> > On Thu, Apr 8, 2021 at 4:50 PM Andy Shevchenko
> > wrote:
> > > On Thu, Apr 08, 2021 at 04:15:37PM +0200, Rafael J. Wysocki wrote:
> >
returns a PCI device.
>
> Signed-off-by: Feilong Lin
> Signed-off-by: Zhiqiang Liu
> --
> v2: rewrite subject and commit log as suggested by Bjorn Helgaas.
The fix is correct AFAICS, so
Reviewed-by: Rafael J. Wysocki
Bjorn, has this been applied already? If not, do you want me
On Thu, Apr 8, 2021 at 4:50 PM Andy Shevchenko
wrote:
>
> On Thu, Apr 08, 2021 at 04:15:37PM +0200, Rafael J. Wysocki wrote:
> > On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus
> > wrote:
> > >
> > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevche
On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan wrote:
>
> Fix some coding style issues reported by checkpatch.pl.
> Only cleanup and no function changes.
>
> Differences from v2 to v3:
> - Remove the modifications that may cause function change.
>
> Differences from v1 to v2:
> - Add subsystem and
On Sat, Mar 27, 2021 at 4:50 AM Xiaofei Tan wrote:
>
> Fix some coding style issues reported by checkpatch.pl, including
> following types:
>
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: code indent should use tabs where possible
> WARNING: Block comments use a trailing */ on a separate
On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus
wrote:
>
> On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevchenko wrote:
> > Currently we have a slightly twisted logic in swnode_register().
> > It frees resources that it doesn't allocate on error path and
> > in once case it relies on the
On Thu, Apr 8, 2021 at 3:15 PM Chris von Recklinghausen
wrote:
>
> Suspend fails on a system in fips mode because md5 is used for the e820
> integrity check and is not available. Use crc32 instead.
>
> This patch changes the integrity check algorithm from md5 to
> crc32. This integrity check is
On Mon, Mar 29, 2021 at 8:38 PM Rafael J. Wysocki wrote:
>
> Hi All,
>
> As follows from the discussion triggered by the patch at
>
> https://lore.kernel.org/lkml/20210311123708.23501-2-frede...@kernel.org/
>
> the cpuidle governors using tick_nohz_get_sleep_length() assu
On Thu, Apr 1, 2021 at 4:13 PM Pierre-Louis Bossart
wrote:
>
>
>
> On 4/1/21 8:40 AM, Rafael J. Wysocki wrote:
> > On Thu, Apr 1, 2021 at 1:26 AM Pierre-Louis Bossart
> > wrote:
> >>
> >> remove make W=1 warnings
> >>
> >> d
On Wed, Mar 24, 2021 at 8:30 AM Wan Jiabing wrote:
>
> struct device is declared twice.So remove the duplicate.
>
> Signed-off-by: Wan Jiabing
> ---
> include/linux/pm.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index
n into a
> new function and exporting it instead is better.
>
> Reported-by: kernel test robot
> Fixes: 8c182bd7 ("CPI: processor: Fix CPU0 wakeup in
> acpi_idle_play_dead()")
> Cc: # 5.10+
> Signed-off-by: Vitaly Kuznetsov
Applied as 5.12-rc material, thanks!
Hi,
This series simplifies acpi_bus_check_add() and related code.
It mostly is not expected to alter functionality, except for patch [4/5] that
unifies the handling of device and processor objects.
Please refer to the patch changelogs for details.
Thanks!
From: Rafael J. Wysocki
There is only one caller of acpi_bus_type_and_status() which is
acpi_bus_check_add(), so fold the former into the latter and use
the observation that the initial status of the device is
ACPI_STA_DEFAULT in all cases except for ACPI_BUS_TYPE_PROCESSOR
to simplify the code
From: Rafael J. Wysocki
Rearrange the checks in acpi_bus_check_add() to avoid checking
the "type" twice and take "check_dep" into account only for
ACPI_TYPE_DEVICE objects.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki
---
driver
From: Rafael J. Wysocki
Move the initial status check for ACPI_BUS_TYPE_PROCESSOR objects
into acpi_add_single_object() so it is not necessary to pass the
"sta" argument to it, get rid of that argument from there and update
the callers of that function accordingly.
No intentional
From: Rafael J. Wysocki
Use the observation that the initial status check for
ACPI_BUS_TYPE_PROCESSOR objects can be carried out in the same way
as for ACPI_BUS_TYPE_DEVICE objects and it is not necessary to fail
acpi_add_single_object() if acpi_bus_get_status_handle() returns an
error
From: Rafael J. Wysocki
Notice that it is not necessary to call acpi_get_object_info() from
acpi_add_single_object() in order to pass the pointer returned by it
to acpi_init_device_object() and from there to acpi_set_pnp_ids().
It is more straightforward to call acpi_get_object_info() from
From: Rafael J. Wysocki
Because pstate.max_freq is always equal to the product of
pstate.max_pstate and pstate.scaling and, analogously,
pstate.turbo_freq is always equal to the product of
pstate.turbo_pstate and pstate.scaling, the result of the
max_policy_perf computation
On Wed, Apr 7, 2021 at 1:01 PM Angela Czubak wrote:
>
> On Tue, Mar 30, 2021 at 5:50 PM Mika Westerberg
> wrote:
> >
> > Hi,
> >
> > On Tue, Mar 30, 2021 at 05:09:42PM +0200, Rafael J. Wysocki wrote:
> > > On 3/29/2021 9:52 PM, Angela Czubak wrote:
On Tue, Apr 6, 2021 at 5:51 PM John Garry wrote:
>
> Hi guys,
>
> On next-20210406, I enabled CONFIG_DEBUG_KMEMLEAK and
> CONFIG_DEBUG_TEST_DRIVER_REMOVE for my arm64 system, and see this:
Why exactly do you think that acpi_ev_install_space_handler() leaks memory?
> root@debian:/home/john# more
On Tue, Apr 6, 2021 at 5:39 PM Vitaly Kuznetsov wrote:
>
> "Rafael J. Wysocki" writes:
>
> > On Tue, Apr 6, 2021 at 4:01 PM Vitaly Kuznetsov wrote:
> >>
> >> Commit 8c182bd7 ("ACPI: processor: Fix CPU0 wakeup in
> >> acpi_idle_pl
me wakeup_cpu0() to cond_wakeup_cpu0() and fold wakeup_cpu0() in
> as it has no other users [Rafael J. Wysocki]
> ---
> arch/x86/include/asm/smp.h| 2 +-
> arch/x86/kernel/smpboot.c | 24 ++--
> drivers/acpi/processor_idle.c | 4 +---
> 3 files ch
On Tue, Apr 6, 2021 at 2:50 PM Vitaly Kuznetsov wrote:
>
> Commit 8c182bd7 ("ACPI: processor: Fix CPU0 wakeup in
> acpi_idle_play_dead()") tried to fix CPU0 hotplug breakage by copying
> wakeup_cpu0() + start_cpu0() logic from hlt_play_dead()//mwait_play_dead()
> into acpi_idle_play_dead().
On Wednesday, March 31, 2021 8:22:54 AM CEST Vitaly Kuznetsov wrote:
> Stephen Rothwell writes:
>
> > Hi all,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/acpi/processor_idle.c: In function 'acpi_idle_play_dead':
> >
1 - 100 of 29241 matches
Mail list logo
