Re: [PATCH] ionic: Remove unused function pointer typedef ionic_reset_cb

-by: Shannon Nelson

Re: [PATCH net-next] drivers: net: ionic: simplify the return expression of ionic_set_rxfh()

On 12/8/20 5:53 AM, Zheng Yongjun wrote: Simplify the return expression. Signed-off-by: Zheng Yongjun Acked-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/pensando

Re: [PATCH 1/1] fix possible array overflow on receiving too many fragments for a packet

On 12/7/20 8:06 PM, Xiaohui Zhang wrote: From: Zhang Xiaohui If the hardware receives an oversized packet with too many rx fragments, skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. This becomes especially visible if it corrupts the freelist pointer of a slab page. I

Re: [PATCH 1/1] ionic: fix array overflow on receiving too many fragments for a packet

On 12/6/20 5:51 PM, Jesse Brandeburg wrote: Xiaohui Zhang wrote: From: Zhang Xiaohui If the hardware receives an oversized packet with too many rx fragments, skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. This becomes especially visible if it corrupts the freelist

Re: [patch V2 11/36] net: ionic: Replace in_interrupt() usage.

like #define can_sleep true so the code can be a little more readable. Yes, I know we have this problem already in the call to ionic_lif_addr(), which I'm annoyed with but haven't addressed yet. So, if you want to deal with this now, fine, otherwise I'll take care of them both later. Meanw

Re: [patch 11/35] net: ionic: Replace in_interrupt() usage.

On 9/28/20 10:24 AM, Shannon Nelson wrote: On 9/27/20 12:48 PM, Thomas Gleixner wrote: From: Sebastian Andrzej Siewior The in_interrupt() usage in this driver tries to figure out which context may sleep and which context may not sleep. in_interrupt() is not really suitable as it misses both

Re: [patch 12/35] net: ionic: Remove WARN_ON(in_interrupt()).

of checks (always enabled or debug option dependent) which cover all invalid conditions already, there is no point in having inconsistent warnings in those drivers. Just remove them. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Shannon Nelson Cc: Pensando Drivers

Re: [patch 11/35] net: ionic: Replace in_interrupt() usage.

ain fully preemptible task context Add 'can_sleep' arguments to the affected functions and let the callers provide the context instead of letting the functions deduce it. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Shannon Nelson Cc: Pensando Drivers Cc: "

Re: [PATCH] ionic_lif: Use devm_kcalloc() in ionic_qcq_alloc()

On 8/9/20 7:38 PM, Xu Wang wrote: A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". Signed-off-by: Xu Wang Acked-by: Shannon Nelson --- drivers/ne

Re: [PATCH] ionic_lif: Use devm_kcalloc() in ionic_qcq_alloc()

On 8/9/20 8:20 PM, Joe Perches wrote: On Mon, 2020-08-10 at 02:38 +, Xu Wang wrote: A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". [] diff --git

Re: drivers/net/ethernet/pensando/ionic/ionic_lif.c:2004:3-9: preceding lock on line 1998 (fwd)

.01.org Cc: l...@intel.com, Julia Lawall Subject: drivers/net/ethernet/pensando/ionic/ionic_lif.c:2004:3-9: preceding lock on line 1998 CC: kbuild-...@lists.01.org CC: linux-kernel@vger.kernel.org TO: Shannon Nelson tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Re: [PATCH][next] ionic: fix memory leak of object 'lid'

return ERR_PTR(err); Thanks! Acked-by: Shannon Nelson

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

On 5/9/20 6:58 PM, Andrew Lunn wrote: On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote: On 5/8/20 9:35 PM, Luis Chamberlain wrote: Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless

Re: [PATCH 00/15] net: taint when the device driver firmware crashes

On 5/8/20 9:35 PM, Luis Chamberlain wrote: Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecting this by inspecting /proc/sys/kernel/tainted instead of scraping some magical words from the kernel

Re: [PATCH 5/5] ionic: Use debugfs_create_bool() to export bool

-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c index bc03cecf80cc9eb4..5beba915f69d12dd

Re: drivers/net/ethernet/pensando/ionic/ionic_lif.c:333:2: error: implicit declaration of function 'dynamic_hex_dump'; did you mean 'seq_hex_dump'?

On 10/12/19 10:45 AM, kbuild test robot wrote: Hi Shannon, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a commit: 77ceb68e29ccd25d923b6af59e74ecaf736cc4b7 ionic: Add

Re: [PATCH] ionic: select CONFIG_NET_DEVLINK

et adapters. More specific information on this driver can be Thanks! Acked-by: Shannon Nelson

Re: [PATCH] dynamic_debug: provide dynamic_hex_dump stub

refix_type, \ + rowsize, groupsize, buf, len, ascii); \ + } while (0) #endif #endif Thanks, I hadn't had a chance to look into that one yet. Acked-by: Shannon Nelson

Re: [PATCH] ionic: remove useless return code

fops) ? 0 : -EOPNOTSUPP; + ionic, _fops); } void ionic_debugfs_add_sizes(struct ionic *ionic) This has just recently been addressed by Nathan Chancellor Either way, Acked-by: Shannon Nelson sln

Re: [PATCH] ionic: Remove unnecessary ternary operator in ionic_debugfs_add_ident

: Add hardware init and device commands") Link: https://github.com/ClangBuiltLinux/linux/issues/658 Signed-off-by: Nathan Chancellor Acked-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH v2 net-next 02/15] MIPS: SGI-IP27: restructure ioc3 register access

On 8/29/19 8:50 AM, Thomas Bogendoerfer wrote: Break up the big ioc3 register struct into functional pieces to make use in sub-function drivers more straightforward. And while doing that get rid of all volatile access by using readX/writeX. Signed-off-by: Thomas Bogendoerfer --- diff --git

Re: [RFC PATCH 5/5] PTP: Add support for Intel PMC Timed GPIO Controller

On 7/16/19 12:20 AM, Felipe Balbi wrote: Add a driver supporting Intel Timed GPIO controller available as part of some Intel PMCs. Signed-off-by: Felipe Balbi Hi Felipe, just a couple of quick comments: There are several places where a line is continued on the next line, but should be

Re: [PATCH] ixgbe: Avoid NULL pointer dereference with VF on non-IPsec hw

Acked-by: Shannon Nelson Thanks! sln On Wed, May 22, 2019 at 4:25 PM dann frazier wrote: > > An ipsec structure will not be allocated if the hardware does not support > offload. Fixes the following Oops: > > [ 191.045452] Unable to handle kernel NULL pointer dereference at vir

Re: [PATCH] net: sun: cassini: Cleanup license conflict

; > Fix up the SPDX identifier and remove the boiler plate text as it is > redundant. > > Fixes: c861ef83d771 ("sun: Add SPDX license tags to Sun network drivers") > Signed-off-by: Thomas Gleixner > Cc: Shannon Nelson > Cc: Zhu Yanjun > Cc: David S. Miller > Cc: net...@vger.k

Re: [PATCH] ethernet: (niu) fix missing checks of niu_pci_eeprom_read

; + for (i = 0; i < prop_len; i++) { > + err = niu_pci_eeprom_read(np, off + i); > + if (err >= 0) > + *prop_buf = err; > + ++prop_buf;

Re: [PATCH] ixgbe: fix memory leak on ipsec allocation

he failed allocation of ipsec. Detected by CoverityScan, CID#146424 ("Resource Leak") Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA") Signed-off-by: Colin Ian King <colin.k...@canonical.com> Yep, thanks, good catch. Acked-by: Shannon Nelson <shannon.n

Re: [PATCH] ixgbe: fix memory leak on ipsec allocation

ted by CoverityScan, CID#146424 ("Resource Leak") Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA") Signed-off-by: Colin Ian King Yep, thanks, good catch. Acked-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +- 1 file cha

Re: [PATCH] ethtool: fix a potential missing-check bug

On 4/29/2018 6:31 PM, Wenwen Wang wrote: In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has

Re: [PATCH] ethtool: fix a potential missing-check bug

On 4/29/2018 6:31 PM, Wenwen Wang wrote: In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has

Re: [PATCH] sparc: vio: use put_device() instead of kfree()

Oh, yes, there it is, and the pointer to vio_dev_release() was already set up a little earlier in this function. Sorry for the noise. sln On Wed, Apr 25, 2018 at 8:59 AM, arvindY <arvind.yadav...@gmail.com> wrote: > > > On Wednesday 25 April 2018 09:14 PM, Shannon Nelson wrote

Re: [PATCH] sparc: vio: use put_device() instead of kfree()

Oh, yes, there it is, and the pointer to vio_dev_release() was already set up a little earlier in this function. Sorry for the noise. sln On Wed, Apr 25, 2018 at 8:59 AM, arvindY wrote: > > > On Wednesday 25 April 2018 09:14 PM, Shannon Nelson wrote: >> >> On 4/25/2018

Re: [PATCH] sparc: vio: use put_device() instead of kfree()

On 4/25/2018 7:56 AM, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- arch/sparc/kernel/vio.c | 2 +- 1 file

Re: [PATCH] sparc: vio: use put_device() instead of kfree()

On 4/25/2018 7:56 AM, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- arch/sparc/kernel/vio.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net-next v3] xfrm: Add ESN support for IPSec HW offload

1: - Added documentation Changes from v2: - Due to Shannon Nelson's request, xfrm_dev_state_add() fails if ESN is requested and xdo_dev_state_advance_esn() is not implemented This works for me - thanks! Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- Documentation/networki

Re: [PATCH net-next v3] xfrm: Add ESN support for IPSec HW offload

to Shannon Nelson's request, xfrm_dev_state_add() fails if ESN is requested and xdo_dev_state_advance_esn() is not implemented This works for me - thanks! Signed-off-by: Shannon Nelson --- Documentation/networking/xfrm_device.txt | 3 +++ include/linux/netdevice.h| 1 + include

Re: [PATCH net-next v2] xfrm: Add ESN support for IPSec HW offload

On 1/11/2018 5:51 AM, Aviad Yehezkel wrote: On 1/11/2018 10:28 AM, Yossi Kuperman wrote: From: Shannon Nelson [mailto:shannon.nel...@oracle.com] Sent: Thursday, January 11, 2018 5:21 AM On 1/10/2018 3:09 PM, Yossi Kuperman wrote: On 10 Jan 2018, at 19:36, Shannon Nelson <shannon.

Re: [PATCH net-next v2] xfrm: Add ESN support for IPSec HW offload

On 1/11/2018 5:51 AM, Aviad Yehezkel wrote: On 1/11/2018 10:28 AM, Yossi Kuperman wrote: From: Shannon Nelson [mailto:shannon.nel...@oracle.com] Sent: Thursday, January 11, 2018 5:21 AM On 1/10/2018 3:09 PM, Yossi Kuperman wrote: On 10 Jan 2018, at 19:36, Shannon Nelson wrote: On 1/10

Re: [PATCH net-next v2] xfrm: Add ESN support for IPSec HW offload

On 1/10/2018 3:09 PM, Yossi Kuperman wrote: On 10 Jan 2018, at 19:36, Shannon Nelson <shannon.nel...@oracle.com> wrote: On 1/10/2018 2:34 AM, yoss...@mellanox.com wrote: From: Yossef Efraim <yoss...@mellanox.com> This patch adds ESN support to IPsec device offload. Adding new

Re: [PATCH net-next v2] xfrm: Add ESN support for IPSec HW offload

On 1/10/2018 3:09 PM, Yossi Kuperman wrote: On 10 Jan 2018, at 19:36, Shannon Nelson wrote: On 1/10/2018 2:34 AM, yoss...@mellanox.com wrote: From: Yossef Efraim This patch adds ESN support to IPsec device offload. Adding new xfrm device operation to synchronize device ESN. Signed-off

Re: [PATCH net-next v2] xfrm: Add ESN support for IPSec HW offload

On 1/10/2018 2:34 AM, yoss...@mellanox.com wrote: From: Yossef Efraim This patch adds ESN support to IPsec device offload. Adding new xfrm device operation to synchronize device ESN. Signed-off-by: Yossef Efraim --- Changes from v1: - Added

Re: [PATCH net-next v2] xfrm: Add ESN support for IPSec HW offload

On 1/10/2018 2:34 AM, yoss...@mellanox.com wrote: From: Yossef Efraim This patch adds ESN support to IPsec device offload. Adding new xfrm device operation to synchronize device ESN. Signed-off-by: Yossef Efraim --- Changes from v1: - Added documentation ---

Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload

On 11/28/2017 1:49 AM, yoss...@mellanox.com wrote: From: Yossef Efraim This patch adds ESN support to IPsec device offload. Adding new xfrm device operation to synchronize device ESN. Signed-off-by: Yossef Efraim --- include/linux/netdevice.h |

Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload

On 11/28/2017 1:49 AM, yoss...@mellanox.com wrote: From: Yossef Efraim This patch adds ESN support to IPsec device offload. Adding new xfrm device operation to synchronize device ESN. Signed-off-by: Yossef Efraim --- include/linux/netdevice.h | 1 + include/net/xfrm.h| 12

Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload

On 11/30/2017 10:23 PM, Steffen Klassert wrote: On Tue, Nov 28, 2017 at 11:49:30AM +0200, yoss...@mellanox.com wrote: From: Yossef Efraim This patch adds ESN support to IPsec device offload. Adding new xfrm device operation to synchronize device ESN. Signed-off-by:

Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload

On 11/30/2017 10:23 PM, Steffen Klassert wrote: On Tue, Nov 28, 2017 at 11:49:30AM +0200, yoss...@mellanox.com wrote: From: Yossef Efraim This patch adds ESN support to IPsec device offload. Adding new xfrm device operation to synchronize device ESN. Signed-off-by: Yossef Efraim ---

Re: [PATCH] sparc64: convert mdesc_handle.refcnt from atomic_t to refcount_t

org> Reviewed-by: David Windsor <dwind...@gmail.com> Reviewed-by: Hans Liljestrand <ishkam...@gmail.com> Signed-off-by: Elena Reshetova <elena.reshet...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@oracle.com> Thank you Shannon! Would you be able to take this

Re: [PATCH] sparc64: convert mdesc_handle.refcnt from atomic_t to refcount_t

Windsor Reviewed-by: Hans Liljestrand Signed-off-by: Elena Reshetova Acked-by: Shannon Nelson Thank you Shannon! Would you be able to take this patch into the respective tree to propagate normally from there? Best Regards, Elena. Hi Elena, Dave Miller takes good care of the sparclinux tree

Re: [PATCH] sparc64: convert mdesc_handle.refcnt from atomic_t to refcount_t

gmail.com> Reviewed-by: Hans Liljestrand <ishkam...@gmail.com> Signed-off-by: Elena Reshetova <elena.reshet...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@oracle.com> --- arch/sparc/kernel/mdesc.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-)

Re: [PATCH] sparc64: convert mdesc_handle.refcnt from atomic_t to refcount_t

-by: Elena Reshetova Acked-by: Shannon Nelson --- arch/sparc/kernel/mdesc.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/sparc/kernel/mdesc.c b/arch/sparc/kernel/mdesc.c index fa466ce..821a724 100644 --- a/arch/sparc/kernel/mdesc.c +++ b/arch/sparc

Re: [PATCH 44/58] net: ethernet: sun: Convert timers to use timer_setup()

Philippe Reynes <trem...@gmail.com> Cc: Jarod Wilson <ja...@redhat.com> Cc: Shannon Nelson <shannon.nel...@oracle.com> Cc: Rob Herring <r...@kernel.org> Cc: chris hyser <chris.hy...@oracle.com> Cc: Tushar Dave <tushar.n.d...@oracle.com> Cc: Tobias Klauser <tkl

Re: [PATCH 44/58] net: ethernet: sun: Convert timers to use timer_setup()

Wilson Cc: Shannon Nelson Cc: Rob Herring Cc: chris hyser Cc: Tushar Dave Cc: Tobias Klauser Cc: net...@vger.kernel.org Signed-off-by: Kees Cook Acked-by: Shannon Nelson --- drivers/net/ethernet/sun/cassini.c| 7 --- drivers/net/ethernet/sun/ldmvsw.c | 3 +-- d

Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe()

Thanks Markus. Acked-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/char/hw_random/n2-drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c index 31cbdbbaebfc..92dd4e925315 100644 --- a/dri

Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()

urce code places. Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Thanks Markus. Acked-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/char/hw_random/n2-drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/hw_ra

Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe()

alloc". * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring Thanks Markus. Acked-by: Shannon Nelson --- drivers/char/hw_random/n2

Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()

us Elfring Thanks Markus. Acked-by: Shannon Nelson --- drivers/char/hw_random/n2-drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c index 92dd4e925315..f3e67c768101 100644 --- a/drivers/char/hw

Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

On 3/15/2017 1:50 AM, David Laight wrote: From: Shannon Nelson Sent: 14 March 2017 17:25 ... + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) + dev->stats.multicast++; I'd guess that: dev->stats.multicast += is_multicast_ether_addr(et

Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

On 3/15/2017 1:50 AM, David Laight wrote: From: Shannon Nelson Sent: 14 March 2017 17:25 ... + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) + dev->stats.multicast++; I'd guess that: dev->stats.multicast += is_multicast_ether_addr(et

[PATCH v2 net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

the underlying LDC protocol. Similarly, we take the link down when we see the LDC_EVENT_RESET. Now when we see the ndo_open(), we reset the link to get things talking again. Orabug: 25525312 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c

[PATCH v2 net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

the underlying LDC protocol. Similarly, we take the link down when we see the LDC_EVENT_RESET. Now when we see the ndo_open(), we reset the link to get things talking again. Orabug: 25525312 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/ldmvsw.c | 27

[PATCH v2 net-next 0/5] sunvnet: better connection management

These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. v2: - added ldmvsw ndo_open to reset the LDC channel - updated copyrights Shannon

[PATCH v2 net-next 3/5] sunvnet: track port queues correctly

Track our used and unused queue indexies correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v2 net-next 0/5] sunvnet: better connection management

These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. v2: - added ldmvsw ndo_open to reset the LDC channel - updated copyrights Shannon

[PATCH v2 net-next 3/5] sunvnet: track port queues correctly

Track our used and unused queue indexies correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Orabug: 25190537 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c | 24 drivers/net

[PATCH v2 net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

dual queue/port stats. This patch breaks out the traffic counts for the individual ports and gives us a little view into the state of those connections. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet

[PATCH v2 net-next 5/5] sunvnet: xoff not needed when removing port link

e driver's tx_timeout handler. Simply removing these takes care of the problem. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH v2 net-next 4/5] sunvnet: count multicast packets

Make sure multicast packets get counted in the device. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_commo

[PATCH v2 net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

dual queue/port stats. This patch breaks out the traffic counts for the individual ports and gives us a little view into the state of those connections. Orabug: 25190537 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet.c| 116 - drivers/net/et

[PATCH v2 net-next 5/5] sunvnet: xoff not needed when removing port link

e driver's tx_timeout handler. Simply removing these takes care of the problem. Orabug: 25190537 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/d

[PATCH v2 net-next 4/5] sunvnet: count multicast packets

Make sure multicast packets get counted in the device. Orabug: 25190537 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun

Re: [PATCH net-next 0/5] sunvnet: better connection management

On 3/6/2017 3:15 PM, Shannon Nelson wrote: These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Further testing shows a problem in one

Re: [PATCH net-next 0/5] sunvnet: better connection management

On 3/6/2017 3:15 PM, Shannon Nelson wrote: These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Further testing shows a problem in one

Re: [PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

On 3/6/2017 3:53 PM, Florian Fainelli wrote: On 03/06/2017 03:15 PM, Shannon Nelson wrote: When an ldom VM is bound, the network vswitch infrastructure is set up for it, but was being forced 'UP' by the userland switch configuration script. When 'UP' but not actually connected to a running VM

Re: [PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

On 3/6/2017 3:53 PM, Florian Fainelli wrote: On 03/06/2017 03:15 PM, Shannon Nelson wrote: When an ldom VM is bound, the network vswitch infrastructure is set up for it, but was being forced 'UP' by the userland switch configuration script. When 'UP' but not actually connected to a running VM

[PATCH net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

dual queue/port stats. This patch breaks out the traffic counts for the individual ports and gives us a little view into the state of those connections. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet.c| 114 ++

[PATCH net-next 2/5] sunvnet: add stats to track ldom to ldom packets and bytes

dual queue/port stats. This patch breaks out the traffic counts for the individual ports and gives us a little view into the state of those connections. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet.c| 114 + drivers/net/ethernet/sun/sunvne

[PATCH net-next 0/5] sunvnet: better connection management

These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Shannon Nelson (5): ldmvsw: better use of link up and down on ldom vswitch

[PATCH net-next 0/5] sunvnet: better connection management

These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Shannon Nelson (5): ldmvsw: better use of link up and down on ldom vswitch

[PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

the underlying LDC protocol. Similarly, we take the link down when we see the LDC_EVENT_RESET. Orabug: 25525312 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 10 +++--- drivers/net/ethernet/sun/sunvnet_common.c | 14 +++

[PATCH net-next 1/5] ldmvsw: better use of link up and down on ldom vswitch

the underlying LDC protocol. Similarly, we take the link down when we see the LDC_EVENT_RESET. Orabug: 25525312 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/ldmvsw.c | 10 +++--- drivers/net/ethernet/sun/sunvnet_common.c | 14 ++ 2 files changed, 21 insertions

[PATCH net-next 5/5] sunvnet: xoff not needed when removing port link

e driver's tx_timeout handler. Simply removing these takes care of the problem. Orabug: 25190537 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH net-next 5/5] sunvnet: xoff not needed when removing port link

e driver's tx_timeout handler. Simply removing these takes care of the problem. Orabug: 25190537 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/d

[PATCH net-next 4/5] sunvnet: count multicast packets

Make sure multicast packets get counted in the device. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drive

[PATCH net-next 4/5] sunvnet: count multicast packets

Make sure multicast packets get counted in the device. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c

[PATCH net-next 3/5] sunvnet: track port queues correctly

Track our used and unused queue indices correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH net-next 3/5] sunvnet: track port queues correctly

Track our used and unused queue indices correctly. Otherwise, as ports dropped out and returned, they all eventually ended up with the same queue index. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c | 24 drivers/net/ethernet/sun

Re: [PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic

On 2/13/2017 11:06 AM, Joe Perches wrote: On Mon, 2017-02-13 at 10:57 -0800, Shannon Nelson wrote: The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson

Re: [PATCH v4 net-next 5/8] sunvnet: straighten up message event handling logic

On 2/13/2017 11:06 AM, Joe Perches wrote: On Mon, 2017-02-13 at 10:57 -0800, Shannon Nelson wrote: The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson

[PATCH v4 net-next 0/8] sunvnet driver updates

module doesn't need module_init or _exit v4: - dropped the statistics patch - fixed up "default" tag for SUNVNET_COMMON Shannon Nelson (7): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add memory barrier before ch

[PATCH v4 net-next 0/8] sunvnet driver updates

module doesn't need module_init or _exit v4: - dropped the statistics patch - fixed up "default" tag for SUNVNET_COMMON Shannon Nelson (7): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add memory barrier before ch

[PATCH v4 net-next 1/8] sunvnet: make sunvnet common code dynamically loadable

in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/Kconfig |8 ++-- drive

[PATCH v4 net-next 1/8] sunvnet: make sunvnet common code dynamically loadable

in kernels that aren't running the LDoms. This patch makes the sunvnet_common into a dynamically loadable module and makes sunvnet and ldmvsw dependent on sunvnet_common. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/Kconfig |8 ++-- drivers/net/ethernet/sun/sunvnet_common.c

[PATCH v4 net-next 2/8] sunvnet: remove unused variable in maybe_tx_wakeup

nother START message at the next TX and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed,

[PATCH v4 net-next 2/8] sunvnet: remove unused variable in maybe_tx_wakeup

and trigger the consumer to drain the dring. Signed-off-by: Sowmini Varadhan Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet

[PATCH v4 net-next 3/8] sunvnet: update version and version printing

There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sun

[PATCH v4 net-next 3/8] sunvnet: update version and version printing

There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet.c | 14 -- 1

[PATCH v4 net-next 8/8] ldmvsw: disable tso and gso for bridge operations

by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethern

[PATCH v4 net-next 8/8] ldmvsw: disable tso and gso for bridge operations

by delayed packets, enough to begin triggering retransmits and affecting overall throughput. By turning off advertised support for TSO and GSO we restore stable traffic flow through the bridge. Orabug: 23293104 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/ldmvsw.c |5

[PATCH v4 net-next 6/8] sunvnet: remove extra rcu_read_unlocks

ahe...@oracle.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c i

[PATCH v4 net-next 6/8] sunvnet: remove extra rcu_read_unlocks

-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/sun/sunvnet_common.c b/drivers/net/ethernet/sun/sunvnet_common.c index d124bde..65f7038 100644 --- a/drivers/net/ethernet/sun

[PATCH v4 net-next 7/8] ldmvsw: update and simplify version string

New version and simplify the print code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ld

  1   2   3   4   >