Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings

On 2019/10/11 22:16, Soeren Moch wrote: On 11.10.19 15:00, Robin Murphy wrote: On 11/10/2019 12:40, Soeren Moch wrote: On 11.10.19 10:22, Jonas Karlman wrote: On 2019-10-04 19:24, Sören Moch wrote: On 04.10.19 17:33, Shawn Lin wrote: On 2019/10/4 22:20, Robin Murphy wrote: On 04/10/2019

Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意，邮件由linux-rockchip-bounces+shawn.lin=rock-chips....@lists.infradead.org代发】

On 2019/10/4 22:20, Robin Murphy wrote: On 04/10/2019 04:39, Soeren Moch wrote: On 04.10.19 04:13, Shawn Lin wrote: On 2019/10/4 8:53, Soeren Moch wrote: On 04.10.19 02:01, Robin Murphy wrote: On 2019-10-03 10:50 pm, Soeren Moch wrote: According to the RockPro64 schematic [1] the rk3399

Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意，邮件由linux-rockchip-bounces+shawn.lin=rock-chips....@lists.infradead.org代发】

ists.infradead.org/mailman/listinfo/linux-rockchip ___ Linux-rockchip mailing list linux-rockc...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Best Regards Shawn Lin

Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume【请注意，邮件由linux-rockchip-bounces+shawn.lin=rock-chips....@lists.infradead.org代发】

d by that patch. [1] https://lkml.kernel.org/r/20190404040106.40519-1-diand...@chromium.org [2] https://crrev.com/c/230765 Sorry for late, but FWIW: Reviewed-by: Shawn Lin Cc: # 4.14.x Signed-off-by: Douglas Anderson --- I didn't put any "Fixes" tag here, but presumably this co

Re: [PATCH] PCI: rockchip: fix bitwise operations on status and ROCKCHIP_PCIE_EP_CMD_STATUS_IS

ged, 1 insertion(+), 1 deletion(-) Shawn, I need your ACK on this patch, thanks. Acked-by: Shawn Lin Lorenzo diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c index a5d799e2dff2..d743b0a48988 100644 --- a/drivers/pci/controller/pcie-rockchip-ep

Re: [PATCH 2/2] mmc: dw_mmc-rockchip: fix transfer hangs on rk3188【请注意，邮件由linux-mmc-ow...@vger.kernel.org代发】

+ Caesar Wang On 2019/3/21 1:48, Alexander Kochetkov wrote: I've found that sometimes dw_mmc in my rk3188 based board stop transfer any data with error: kernel: dwmmc_rockchip 1021c000.dwmmc: Unexpected command timeout, state 3 Further digging into problem showed that sometimes one of

Re: [PATCH] mmc: dw_mmc: Fix to avoid potential NULL pointer dereference【请注意，邮件由linux-mmc-ow...@vger.kernel.org代发】

On 2019/3/19 8:19, Aditya Pakki wrote: of_match_node can fail and return NULL in case no matching structure. The patches checks for such a scenario and returns -ENXIO. Signed-off-by: Aditya Pakki --- drivers/mmc/host/dw_mmc-exynos.c | 2 ++ drivers/mmc/host/dw_mmc-k3.c | 2 ++

Re: ulfh/next boot bisection: v5.1-rc1-22-gb3725d97ba75 on rk3399-gru-kevin【请注意，邮件由linux-mmc-ow...@vger.kernel.org代发】

arch: arm64 Lab:lab-collabora Compiler: gcc-7 Config: defconfig Test suite: boot Breaking commit found: --- commit d6a6d722481f357eafe7b798fe6fdadd2f5ac6bd Author: Shawn Lin Date: Tue Mar 12 15

Re: [PATCH 3/3] arm64: dts: rockchip: Disable DCMDs on RK3399's eMMC controller.【请注意，邮件由linux-mmc-ow...@vger.kernel.org代发】

On 2019/3/2 0:43, Christoph Muellner wrote: When using direct commands (DCMDs) on an RK3399, we get spurious CQE completion interrupts for the DCMD transaction slot (#31): I didn't see it. Do you try any newer code, for instance, linux-next? [ 931.196520] [ cut here

Re: [PATCH] ARM: dts: rockchip: remove disable-wp from rv1108-elgin-r1 emmc node【请注意，邮件由linux-rockchip-bounces+shawn.lin=rock-chips....@lists.infradead.org代发】

t;8>; cap-mmc-highspeed; - disable-wp; Reviewed-by: Shawn Lin no-sd; no-sdio; non-removable;

Re: [PATCH v2 00/15] PCI: endpoint: Cleanup EPC features

tly. 8<- drivers/pci/controller/pcie-rockchip-ep.c | 16 +++- Acked-by: Shawn Lin

Re: [PATCH v2 1/3] mmc: sdhci: add support for using external DMA devices

On 2018/11/29 17:59, Chunyan Zhang wrote: Hi Adrian, On Thu, 29 Nov 2018 at 15:36, Adrian Hunter wrote: On 29/11/18 8:22 AM, Chunyan Zhang wrote: On Tue, 20 Nov 2018 at 21:41, Adrian Hunter wrote: On 12/11/18 9:26 AM, Chunyan Zhang wrote: Some standard SD host controllers can support

Re: [PATCH v2 1/3] mmc: sdhci: add support for using external DMA devices

On 2018/11/29 17:59, Chunyan Zhang wrote: Hi Adrian, On Thu, 29 Nov 2018 at 15:36, Adrian Hunter wrote: On 29/11/18 8:22 AM, Chunyan Zhang wrote: On Tue, 20 Nov 2018 at 21:41, Adrian Hunter wrote: On 12/11/18 9:26 AM, Chunyan Zhang wrote: Some standard SD host controllers can support

Re: [PATCH v3] arm64: dts: rockchip: Add DT for nanopc-t4

On 2018/11/27 7:48, Heiko Stuebner wrote: Hi Tomeu, Am Montag, 26. November 2018, 15:47:49 CET schrieb Tomeu Vizoso: This adds a device tree for the NanoPC-T4 SBC, which is based on the Rockchip RK3399 SoC and marketed by FriendlyELEC. Known working: - Serial - Ethernet - HDMI - USB 2.0 All

Re: [PATCH v3] arm64: dts: rockchip: Add DT for nanopc-t4

On 2018/11/27 7:48, Heiko Stuebner wrote: Hi Tomeu, Am Montag, 26. November 2018, 15:47:49 CET schrieb Tomeu Vizoso: This adds a device tree for the NanoPC-T4 SBC, which is based on the Rockchip RK3399 SoC and marketed by FriendlyELEC. Known working: - Serial - Ethernet - HDMI - USB 2.0 All

Re: dw_mmc: IDMAC Invalidate cache after read

On 2018/11/23 23:29, Robin Murphy wrote: Hi Jan, [repeating some of the discussion from your other thread for the benefit of the MMC audience] On 21/11/2018 07:42, JABLONSKY Jan wrote: CPU may not see most up-to-date and correct copy of DMA buffer, when internal DMA controller is in use.

Re: dw_mmc: IDMAC Invalidate cache after read

On 2018/11/23 23:29, Robin Murphy wrote: Hi Jan, [repeating some of the discussion from your other thread for the benefit of the MMC audience] On 21/11/2018 07:42, JABLONSKY Jan wrote: CPU may not see most up-to-date and correct copy of DMA buffer, when internal DMA controller is in use.

Re: [PATCH] ARM64: dts: rockchip: add some pins to rk3399

<4 24 RK_FUNC_GPIO _pull_none>; }; }; -- 2.14.4 Could we actually use RK_Pxx for all new pin definitions? Would increase readability a lot. Thanks, Klaus -- Best Regards Shawn Lin

Re: [PATCH] ARM64: dts: rockchip: add some pins to rk3399

<4 24 RK_FUNC_GPIO _pull_none>; }; }; -- 2.14.4 Could we actually use RK_Pxx for all new pin definitions? Would increase readability a lot. Thanks, Klaus -- Best Regards Shawn Lin

Re: [PATCH] mmc: Move the mmc driver init earlier

mc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Shawn Lin

Re: [PATCH] mmc: Move the mmc driver init earlier

mc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Shawn Lin

Re: [PATCH] mmc: dw_mmc: fix card threshold control configuration

On 2018/6/11 20:20, Ulf Hansson wrote: + Shawn Lin, Evgeniy Didin, Doug Andersson On 29 May 2018 at 12:38, Qing Xia wrote: From: x00270170 Card write threshold control is supposed to be set since controller version 2.80a for data write in HS400 mode and data read in HS200/HS400/SDR104 mode

Re: [PATCH] mmc: dw_mmc: fix card threshold control configuration

On 2018/6/11 20:20, Ulf Hansson wrote: + Shawn Lin, Evgeniy Didin, Doug Andersson On 29 May 2018 at 12:38, Qing Xia wrote: From: x00270170 Card write threshold control is supposed to be set since controller version 2.80a for data write in HS400 mode and data read in HS200/HS400/SDR104 mode

Re: [PATCH] mmc: block: propagate correct returned value in mmc_rpmb_ioctl

On 2018/5/17 14:16, Mathieu Malaterre wrote: On Thu, May 17, 2018 at 4:45 AM, Shawn Lin <shawn@rock-chips.com> wrote: On 2018/5/17 3:20, Mathieu Malaterre wrote: In commit 97548575bef3 ("mmc: block: Convert RPMB to a character device") a new function `mmc_rpmb_ioctl` was

Re: [PATCH] mmc: block: propagate correct returned value in mmc_rpmb_ioctl

On 2018/5/17 14:16, Mathieu Malaterre wrote: On Thu, May 17, 2018 at 4:45 AM, Shawn Lin wrote: On 2018/5/17 3:20, Mathieu Malaterre wrote: In commit 97548575bef3 ("mmc: block: Convert RPMB to a character device") a new function `mmc_rpmb_ioctl` was added. The final return

Re: [PATCH] mmc: block: propagate correct returned value in mmc_rpmb_ioctl

warn about this. And it's worth backporting to stable. Reviewed-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Mathieu Malaterre <ma...@debian.org> --- drivers/mmc/core/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/block.c b/drivers/

Re: [PATCH] mmc: block: propagate correct returned value in mmc_rpmb_ioctl

warn about this. And it's worth backporting to stable. Reviewed-by: Shawn Lin Signed-off-by: Mathieu Malaterre --- drivers/mmc/core/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 9e923cd1d80e..38a7586b00cc 100644 ---

Re: [PATCH] ethernet: stmmac: dwmac-rk: Add GMAC support for px30

Hi David, On 2018/5/16 11:38, David Wu wrote: Add constants and callback functions for the dwmac on px30 soc. s/soc/SoC The base structure is the same, but registers and the bits in them moved slightly, and add the clk_mac_speed for the select s/moved/are moved of mac speed. for

Re: [PATCH] ethernet: stmmac: dwmac-rk: Add GMAC support for px30

Hi David, On 2018/5/16 11:38, David Wu wrote: Add constants and callback functions for the dwmac on px30 soc. s/soc/SoC The base structure is the same, but registers and the bits in them moved slightly, and add the clk_mac_speed for the select s/moved/are moved of mac speed. for

Re: [PATCH v7 1/3] mmc: dw_mmc-bluefield: Add driver extension

On 2018/5/9 2:46, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Reviewed-by: Shawn Lin <shawn@rock-chips.com>

Re: [PATCH v7 1/3] mmc: dw_mmc-bluefield: Add driver extension

On 2018/5/9 2:46, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Reviewed-by: Shawn Lin

Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

On 2018/5/2 20:45, Liming Sun wrote: Please see response inline. Thanks, Liming -Original Message- From: Shawn Lin [mailto:shawn@rock-chips.com] Sent: Tuesday, May 1, 2018 9:02 PM To: Liming Sun <l...@mellanox.com>; Mark Rutland <mark.rutl...@arm.com>; Jaehoon Ch

Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

On 2018/5/2 20:45, Liming Sun wrote: Please see response inline. Thanks, Liming -Original Message- From: Shawn Lin [mailto:shawn@rock-chips.com] Sent: Tuesday, May 1, 2018 9:02 PM To: Liming Sun ; Mark Rutland ; Jaehoon Chung ; Catalin Marinas ; Will Deacon Cc: Ulf Hansson ; Rob

Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

On 2018/5/2 2:19, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Cc: sta...@kernel.org Why? Signed-off-by: Liming Sun Reviewed-by: David Woods

Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

On 2018/5/2 2:19, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Cc: sta...@kernel.org Why? Signed-off-by: Liming Sun Reviewed-by: David Woods ---

Re: [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension

Hi Liming, On 2018/4/23 23:32, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun --- drivers/mmc/host/Kconfig| 9

Re: [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension

Hi Liming, On 2018/4/23 23:32, Liming Sun wrote: This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun --- drivers/mmc/host/Kconfig| 9 +

Re: clk: bulk: silently error out on EPROBE_DEFER

finally probed fine. But probably it came from clk_bulk_get, Reviewed-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Jerome Brunet <jbru...@baylibre.com> --- drivers/clk/clk-bulk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-bulk

Re: clk: bulk: silently error out on EPROBE_DEFER

finally probed fine. But probably it came from clk_bulk_get, Reviewed-by: Shawn Lin Signed-off-by: Jerome Brunet --- drivers/clk/clk-bulk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c index 4c10456f8a32..6904ed6da504

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

On 2018/4/6 21:41, Ryan Grachek wrote: On Wed, Apr 4, 2018 at 7:51 PM, Shawn Lin <shawn@rock-chips.com> wrote: [+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin <shawn@rock-chips.com <mailto:sh

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

On 2018/4/6 21:41, Ryan Grachek wrote: On Wed, Apr 4, 2018 at 7:51 PM, Shawn Lin wrote: [+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin mailto:shawn@rock-chips.com>> wrote: On 2018/3/3

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

[+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin <shawn@rock-chips.com <mailto:shawn@rock-chips.com>> wrote: On 2018/3/30 2:24, oscardagrach wrote: Need at least one line

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

[+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin <mailto:shawn@rock-chips.com>> wrote: On 2018/3/30 2:24, oscardagrach wrote: Need at least one line commit body. Signed-off-by: osc

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

On 2018/3/30 2:24, oscardagrach wrote: Need at least one line commit body. Signed-off-by: oscardagrach --- drivers/mmc/host/dw_mmc-k3.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

On 2018/3/30 2:24, oscardagrach wrote: Need at least one line commit body. Signed-off-by: oscardagrach --- drivers/mmc/host/dw_mmc-k3.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c index

Re: [PATCH] [mmc_block] Prevent bus reference leak in mmc_blk_init

unregister(_rpmb_bus_type); Reviewed-by: Shawn Lin <shawn@rock-chips.com> } module_init(mmc_blk_init);

Re: [PATCH] [mmc_block] Prevent bus reference leak in mmc_blk_init

ock.c @@ -3087,6 +3087,7 @@ static void __exit mmc_blk_exit(void) mmc_unregister_driver(_driver); unregister_blkdev(MMC_BLOCK_MAJOR, "mmc"); unregister_chrdev_region(mmc_rpmb_devt, MAX_DEVICES); + bus_unregister(_rpmb_bus_type); Reviewed-by: Shawn L

Re: [RFC PATCH] sdhci: arasan: Add runtime PM support

On 2018/3/29 13:48, naraniman...@gmail.com wrote: From: Manish Narani This patch adds runtime PM support in Arasan SD driver. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 83 +- 1 file

Re: [RFC PATCH] sdhci: arasan: Add runtime PM support

On 2018/3/29 13:48, naraniman...@gmail.com wrote: From: Manish Narani This patch adds runtime PM support in Arasan SD driver. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 83 +- 1 file changed, 81 insertions(+), 2 deletions(-)

Re: [PATCH] mmc: Export card RCA register to sysfs.

quot;, card->rca); MMC_DEV_ATTR(cmdq_en, "%d\n", card->ext_csd.cmdq_en); Just a nit that I tried to find some convention here, as RCA is a 16-bit register, so perhaps "0x%04x\n"? Otherwise, Reviewed-by: Shawn Lin <shawn@rock-chips.com> static ssize_t mmc_fwrev

Re: [PATCH] mmc: Export card RCA register to sysfs.

mdq_en, "%d\n", card->ext_csd.cmdq_en); Just a nit that I tried to find some convention here, as RCA is a 16-bit register, so perhaps "0x%04x\n"? Otherwise, Reviewed-by: Shawn Lin static ssize_t mmc_fwrev_show(struct device *dev, @@ -848,6 +849,7 @@ static ssi

Re: [PATCH v5] mmc: Export host capabilities to debugfs.

BUTE instead? :) -- Best Regards Shawn Lin

Re: [PATCH v5] mmc: Export host capabilities to debugfs.

-by: Harish Jenny K N --- Changes in v5: - Added parser logic in kernel by using debugfs_create_file for caps and caps2 instead of debugfs_create_x32 I'm fine with your method if Ulf likes it, but could you use DEFINE_SHOW_ATTRIBUTE instead? :) -- Best Regards Shawn Lin

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

On 2018/3/6 0:47, Phil Edworthy wrote: Hi Shawn, On 28 February 2018 01:53, Shawn Lin wrote: On 2018/2/27 23:05, Phil Edworthy wrote: On 27 February 2018 14:42, Shawn Lin wrote: On 2018/2/27 22:31, Phil Edworthy wrote: On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

On 2018/3/6 0:47, Phil Edworthy wrote: Hi Shawn, On 28 February 2018 01:53, Shawn Lin wrote: On 2018/2/27 23:05, Phil Edworthy wrote: On 27 February 2018 14:42, Shawn Lin wrote: On 2018/2/27 22:31, Phil Edworthy wrote: On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil

Re: [PATCH v3] mmc: Export host capabilities to debugfs.

Reviewed-by: Shawn Lin <shawn@rock-chips.com>

Re: [PATCH v3] mmc: Export host capabilities to debugfs.

Reviewed-by: Shawn Lin

Re: [PATCH] soc: rockchip: power-domain: Add a sanity check on pd->num_clks

ain: use clk_bulk APIs") Reported-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Tested-by: Shawn Lin <shawn@rock-chips.com>

Re: [PATCH] soc: rockchip: power-domain: Add a sanity check on pd->num_clks

ain: use clk_bulk APIs") Reported-by: Shawn Lin Signed-off-by: Jeffy Chen Tested-by: Shawn Lin

Re: [PATCH] soc: rockchip: power-domain: use clk_bulk APIs

Hi Heiko, On 2018/3/2 23:43, Heiko Stuebner wrote: Hi Jeffy, Am Mittwoch, 28. Februar 2018, 13:41:43 CET schrieb Jeffy Chen: Use clk_bulk APIs, and also add error handling for clk enable. Signed-off-by: Jeffy Chen [...] - for (i = 0; i < clk_cnt; i++) {

Re: [PATCH] soc: rockchip: power-domain: use clk_bulk APIs

Hi Heiko, On 2018/3/2 23:43, Heiko Stuebner wrote: Hi Jeffy, Am Mittwoch, 28. Februar 2018, 13:41:43 CET schrieb Jeffy Chen: Use clk_bulk APIs, and also add error handling for clk enable. Signed-off-by: Jeffy Chen [...] - for (i = 0; i < clk_cnt; i++) { - clk =

Re: [PATCH v2] mmc: Export host capabilities to debugfs.

On 2018/3/5 12:24, Harish Jenny K N wrote: From: Abbas Raza This patch exports the host capabilities to debugfs Signed-off-by: Abbas Raza Signed-off-by: Andrew Gabbasov Signed-off-by: Harish Jenny K N

Re: [PATCH v2] mmc: Export host capabilities to debugfs.

On 2018/3/5 12:24, Harish Jenny K N wrote: From: Abbas Raza This patch exports the host capabilities to debugfs Signed-off-by: Abbas Raza Signed-off-by: Andrew Gabbasov Signed-off-by: Harish Jenny K N --- Changes in v2: - Changed Author drivers/mmc/core/debugfs.c | 3 +++ 1 file

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

On 2018/2/27 23:05, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:42, Shawn Lin wrote: On 2018/2/27 22:31, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil Edworthy 写道: Since the controller does not support the end-of-busy IRQ

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

On 2018/2/27 23:05, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:42, Shawn Lin wrote: On 2018/2/27 22:31, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil Edworthy 写道: Since the controller does not support the end-of-busy IRQ

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

On 2018/2/27 22:31, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil Edworthy 写道: Since the controller does not support the end-of-busy IRQ, don't use it. Otherwise, on older SD cards you will get lots of these messages: "mmc0: Got

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

On 2018/2/27 22:31, Phil Edworthy wrote: Hi Shawn, On 27 February 2018 14:28, Shawn Lin wrote: 在 2018/2/27 21:55, Phil Edworthy 写道: Since the controller does not support the end-of-busy IRQ, don't use it. Otherwise, on older SD cards you will get lots of these messages: "mmc0: Got

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

QUIRK2_PRESET_VALUE_BROKEN | - SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN, + SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN | + SDHCI_QUIRK2_STOP_WITH_TC, }; static u32 sdhci_arasan_cqhci_irq(struct sdhci_host *host, u32 intmask) -- Best Regards Shawn Lin

Re: [PATCH] mmc: sdhci-of-arasan: Add quirk to avoid erroneous msg

LOCK_DIV_ZERO_BROKEN, + SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN | + SDHCI_QUIRK2_STOP_WITH_TC, }; static u32 sdhci_arasan_cqhci_irq(struct sdhci_host *host, u32 intmask) -- Best Regards Shawn Lin

Re: [PATCH] mmc: card: Don't show eMMC RPMB and BOOT areas in /proc/partitions

| GENHD_FL_SUPPRESS_PARTITION_INFO; I would prefer using GENHD_FL_HIDDEN instead of adding all these two flags. /* * As discussed on lkml, GENHD_FL_REMOVABLE should: -- Best Regards Shawn Lin

Re: [PATCH] mmc: card: Don't show eMMC RPMB and BOOT areas in /proc/partitions

f adding all these two flags. /* * As discussed on lkml, GENHD_FL_REMOVABLE should: -- Best Regards Shawn Lin

Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

Tested-by: Vineet Gupta Fixes: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files Signed-off-by: Evgeniy Didin CC: Alexey Brodkin CC: Eugeniy Paltsev CC: Douglas Anderson

Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

Tested-by: Vineet Gupta Fixes: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files Signed-off-by: Evgeniy Didin CC: Alexey Brodkin CC: Eugeniy Paltsev CC: Douglas Anderson CC: Ulf Hansson CC: linux-kernel@vger.kernel.org CC: linux-snps-...@lists.infradead.org Cc: #

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

aining that property 3) remove the functionality of the deprecated property from the driver but still leave some warning there 4) remove the left warning finally And for the ABI breakage, we should add something in Documentation/ABI /obsolete or Documentation/ABI/removed ? -- Best Regards Shawn Lin

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

the functionality of the deprecated property from the driver but still leave some warning there 4) remove the left warning finally And for the ABI breakage, we should add something in Documentation/ABI /obsolete or Documentation/ABI/removed ? -- Best Regards Shawn Lin

Re: [PATCH v2] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias

On 2018/2/23 20:44, Geert Uytterhoeven wrote: The hs_timing_cfg[] array is indexed using a value derived from the "mshcN" alias in DT, which may lead to an out-of-bounds access. Reviewed-by: Shawn Lin <shawn@rock-chips.com> -- Best Regards Shawn Lin

Re: [PATCH v2] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias

On 2018/2/23 20:44, Geert Uytterhoeven wrote: The hs_timing_cfg[] array is indexed using a value derived from the "mshcN" alias in DT, which may lead to an out-of-bounds access. Reviewed-by: Shawn Lin -- Best Regards Shawn Lin

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

to it description, so no one could miss this slightest detail. Couple of code style fixes as a bonus. Thanks for updating these. Reviewed-by: Shawn Lin <shawn@rock-chips.com> Signed-off-by: Alexey Roslyakov <alexey.roslya...@gmail.com> --- drivers/mmc/host/d

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

to it description, so no one could miss this slightest detail. Couple of code style fixes as a bonus. Thanks for updating these. Reviewed-by: Shawn Lin Signed-off-by: Alexey Roslyakov --- drivers/mmc/host/dw_mmc.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions

Re: [PATCH 2/5] mmc: add stm32 sdmmc controller driver

PED, + COOKIE_PRE_MAPPED, /* mapped by pre_req() of stm32 */ + COOKIE_MAPPED, /* mapped by prepare_data() of stm32 */ +}; + +struct sdmmc_stat { + unsigned long n_req; + unsigned long n_datareq; + unsigned long n_ctimeout; + unsigned long n_ccrcfail; + unsigned long n_dtimeout; + unsigned long n_dcrcfail; + unsigned long n_txunderrun; + unsigned long n_rxoverrun; + unsigned long nb_dma_err; +}; + +struct sdmmc_host { + void __iomem*base; + struct mmc_host *mmc; + struct clk *clk; + struct reset_control*rst; + + u32 clk_reg_add; + u32 pwr_reg_add; + + struct mmc_request *mrq; + struct mmc_command *cmd; + struct mmc_data *data; + struct mmc_command stop_abort; + booldpsm_abort; + + /* protect host registers access */ + spinlock_t lock; + + unsigned intsdmmcclk; + unsigned intsdmmc_ck; + + u32 size; + + u32 ip_ver; + struct sdmmc_stat stat; +}; -- Best Regards Shawn Lin

Re: [PATCH 2/5] mmc: add stm32 sdmmc controller driver

/* mapped by prepare_data() of stm32 */ +}; + +struct sdmmc_stat { + unsigned long n_req; + unsigned long n_datareq; + unsigned long n_ctimeout; + unsigned long n_ccrcfail; + unsigned long n_dtimeout; + unsigned long n_dcrcfail; + unsigned long n_txunderrun; + unsigned long n_rxoverrun; + unsigned long nb_dma_err; +}; + +struct sdmmc_host { + void __iomem*base; + struct mmc_host *mmc; + struct clk *clk; + struct reset_control*rst; + + u32 clk_reg_add; + u32 pwr_reg_add; + + struct mmc_request *mrq; + struct mmc_command *cmd; + struct mmc_data *data; + struct mmc_command stop_abort; + booldpsm_abort; + + /* protect host registers access */ + spinlock_t lock; + + unsigned intsdmmcclk; + unsigned intsdmmc_ck; + + u32 size; + + u32 ip_ver; + struct sdmmc_stat stat; +}; -- Best Regards Shawn Lin

[PATCH v2 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chromium.org> Tested-by: Caesar Wang <w...@rock-chips.com> Tested-by: Ziyuan Xu <xzy...@rock-chips.co

[PATCH v2 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin Reviewed-by: Brian Norris Tested-by: Caesar Wang Tested-by: Ziyuan Xu --- Changes in v2: - propagate the error and print it - avoid using busy wait drivers/phy/rockchip/phy-rockchip-emmc.c

[PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin <shawn@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chromium.org> Tested-by: Caesar Wang <w...@rock-chips.com> Tested-by: Ziyuan Xu <

[PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin Reviewed-by: Brian Norris Tested-by: Caesar Wang Tested-by: Ziyuan Xu --- Changes in v2: - propagate the error and print it drivers/phy/rockchip/phy-rockchip

[PATCH 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin <shawn@rock-chips.com> --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/phy/rockch

[PATCH 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy

[PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin <shawn@rock-chips.com> --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff

[PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/phy/rockchip/phy

Re: [PATCH] MAINTAINERS: Add Lorenzo Pieralisi for PCI host bridge drivers

Hi Bjorn, On 2017/11/9 23:05, Bjorn Helgaas wrote: On Thu, Nov 09, 2017 at 11:28:36AM +0530, Kishon Vijay Abraham I wrote: Hi Bjorn, On Thursday 09 November 2017 01:56 AM, Bjorn Helgaas wrote: On Wed, Nov 08, 2017 at 02:15:10PM -0600, Bjorn Helgaas wrote: From: Bjorn Helgaas

Re: [PATCH] MAINTAINERS: Add Lorenzo Pieralisi for PCI host bridge drivers

Hi Bjorn, On 2017/11/9 23:05, Bjorn Helgaas wrote: On Thu, Nov 09, 2017 at 11:28:36AM +0530, Kishon Vijay Abraham I wrote: Hi Bjorn, On Thursday 09 November 2017 01:56 AM, Bjorn Helgaas wrote: On Wed, Nov 08, 2017 at 02:15:10PM -0600, Bjorn Helgaas wrote: From: Bjorn Helgaas Add Lorenzo

Re: [PATCH v2 0/5] mmc: dw_mmc: Fix the CTO timer patch, plus the DTO timer

Hi Ulf, On 2017/10/30 19:40, Ulf Hansson wrote: On 12 October 2017 at 22:11, Douglas Anderson wrote: Recently we landed 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme"). I found a bunch of problems with that patch, so this series

Re: [PATCH v2 0/5] mmc: dw_mmc: Fix the CTO timer patch, plus the DTO timer

Hi Ulf, On 2017/10/30 19:40, Ulf Hansson wrote: On 12 October 2017 at 22:11, Douglas Anderson wrote: Recently we landed 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme"). I found a bunch of problems with that patch, so this series attempts to solve some of

Re: [PATCH v2 5/5] mmc: dw_mmc: Cleanup the DTO timer like the CTO one

On 2017/10/17 13:05, Doug Anderson wrote: Hi, On Mon, Oct 16, 2017 at 6:17 PM, Shawn Lin <shawn@rock-chips.com> wrote: Hi Doug On 2017/10/13 4:11, Douglas Anderson wrote: The recent CTO timer introduced in commit 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken comma

Re: [PATCH v2 5/5] mmc: dw_mmc: Cleanup the DTO timer like the CTO one

On 2017/10/17 13:05, Doug Anderson wrote: Hi, On Mon, Oct 16, 2017 at 6:17 PM, Shawn Lin wrote: Hi Doug On 2017/10/13 4:11, Douglas Anderson wrote: The recent CTO timer introduced in commit 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme") w

Re: [PATCH 0/9] Enable dw-mmc multi-card support

On 2017/10/7 3:21, Liming Sun wrote: This series of commits enables the multi-card support for the dw-mmc controller. It includes two parts as below. The first part (patches 1-7) reverts the series of recent commits that removed the multi-card support with comments saying there was no such use

Re: [PATCH 0/9] Enable dw-mmc multi-card support

On 2017/10/7 3:21, Liming Sun wrote: This series of commits enables the multi-card support for the dw-mmc controller. It includes two parts as below. The first part (patches 1-7) reverts the series of recent commits that removed the multi-card support with comments saying there was no such use

Re: [PATCH v2 5/5] mmc: dw_mmc: Cleanup the DTO timer like the CTO one

Hi Doug On 2017/10/13 4:11, Douglas Anderson wrote: The recent CTO timer introduced in commit 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme") was causing observable problems due to race conditions. Previous patches have fixed those race conditions. It can

Re: [PATCH v2 5/5] mmc: dw_mmc: Cleanup the DTO timer like the CTO one

Hi Doug On 2017/10/13 4:11, Douglas Anderson wrote: The recent CTO timer introduced in commit 03de19212ea3 ("mmc: dw_mmc: introduce timer for broken command transfer over scheme") was causing observable problems due to race conditions. Previous patches have fixed those race conditions. It can

Re: [PATCH v2 3/5] mmc: dw_mmc: Add locking to the CTO timer

Hi Doug On 2017/10/13 12:20, Doug Anderson wrote: Shawn, On Thu, Oct 12, 2017 at 6:32 PM, Shawn Lin <shawn@rock-chips.com> wrote: On 2017/10/13 4:11, Douglas Anderson wrote: This attempts to instill a bit of paranoia to the code dealing with the CTO timer. It's be

  1   2   3   4   5   6   7   8   9   10   >