Re: [RFC PATCH 1/2] autofs: set compat flag on sbi when daemon uses 32bit addressation

14.09.2017 13:45, Ian Kent пишет: > On 14/09/17 19:39, Stanislav Kinsburskiy wrote: >> >> >> 14.09.2017 13:29, Ian Kent пишет: >>> On 14/09/17 17:24, Stanislav Kinsburskiy wrote: >>>> >>>> >>>> 14.09.2017 02:38, Ian Kent пишет: &

Re: [RFC PATCH 1/2] autofs: set compat flag on sbi when daemon uses 32bit addressation

14.09.2017 13:45, Ian Kent пишет: > On 14/09/17 19:39, Stanislav Kinsburskiy wrote: >> >> >> 14.09.2017 13:29, Ian Kent пишет: >>> On 14/09/17 17:24, Stanislav Kinsburskiy wrote: >>>> >>>> >>>> 14.09.2017 02:38, Ian Kent пишет: &

Re: [RFC PATCH 1/2] autofs: set compat flag on sbi when daemon uses 32bit addressation

14.09.2017 13:29, Ian Kent пишет: > On 14/09/17 17:24, Stanislav Kinsburskiy wrote: >> >> >> 14.09.2017 02:38, Ian Kent пишет: >>> On 01/09/17 19:21, Stanislav Kinsburskiy wrote: >>>> Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com&

Re: [RFC PATCH 1/2] autofs: set compat flag on sbi when daemon uses 32bit addressation

14.09.2017 13:29, Ian Kent пишет: > On 14/09/17 17:24, Stanislav Kinsburskiy wrote: >> >> >> 14.09.2017 02:38, Ian Kent пишет: >>> On 01/09/17 19:21, Stanislav Kinsburskiy wrote: >>>> Signed-off-by: Stanislav Kinsburskiy >>>> --- >&g

Re: [RFC PATCH 1/2] autofs: set compat flag on sbi when daemon uses 32bit addressation

14.09.2017 02:38, Ian Kent пишет: > On 01/09/17 19:21, Stanislav Kinsburskiy wrote: >> Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> >> --- >> fs/autofs4/autofs_i.h |3 +++ >> fs/autofs4/dev-ioctl.c |3 +++ >> fs/autofs4/inode.c

Re: [RFC PATCH 1/2] autofs: set compat flag on sbi when daemon uses 32bit addressation

14.09.2017 02:38, Ian Kent пишет: > On 01/09/17 19:21, Stanislav Kinsburskiy wrote: >> Signed-off-by: Stanislav Kinsburskiy >> --- >> fs/autofs4/autofs_i.h |3 +++ >> fs/autofs4/dev-ioctl.c |3 +++ >> fs/autofs4/inode.c |4 +++- >> 3 fil

[RFC PATCH 1/2] autofs: set compat flag on sbi when daemon uses 32bit addressation

Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> --- fs/autofs4/autofs_i.h |3 +++ fs/autofs4/dev-ioctl.c |3 +++ fs/autofs4/inode.c |4 +++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index 4

[RFC PATCH 1/2] autofs: set compat flag on sbi when daemon uses 32bit addressation

Signed-off-by: Stanislav Kinsburskiy --- fs/autofs4/autofs_i.h |3 +++ fs/autofs4/dev-ioctl.c |3 +++ fs/autofs4/inode.c |4 +++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index 4737615..3da105f 100644 --- a/fs

[RFC PATCH 2/2] autofs: sent 32-bit sized packet for 32-bit process

The structure autofs_v5_packet (except name) is not aligned by 8 bytes, which leads to different sizes in 32 and 64-bit architectures. Let's form 32-bit compatible packet when daemon has 32-bit addressation. Suggested-by: Dmitry V. Levin <l...@altlinux.org> Signed-off-by: Stanislav Kinsb

[RFC PATCH 2/2] autofs: sent 32-bit sized packet for 32-bit process

The structure autofs_v5_packet (except name) is not aligned by 8 bytes, which leads to different sizes in 32 and 64-bit architectures. Let's form 32-bit compatible packet when daemon has 32-bit addressation. Suggested-by: Dmitry V. Levin Signed-off-by: Stanislav Kinsburskiy --- fs/autofs4

[RFC PATCH 0/2] autofs: fix autofs_v5_packet dlivery in compat mode

now clear, what to do if "pgrp" option is specified. The following series implements... --- Stanislav Kinsburskiy (2): autofs: set compat flag on sbi when daemon uses 32bit addressation autofs: sent 32-bit sized packet for 32-bit process fs/autofs4/autofs_i.h |3 +++

[RFC PATCH 0/2] autofs: fix autofs_v5_packet dlivery in compat mode

now clear, what to do if "pgrp" option is specified. The following series implements... --- Stanislav Kinsburskiy (2): autofs: set compat flag on sbi when daemon uses 32bit addressation autofs: sent 32-bit sized packet for 32-bit process fs/autofs4/autofs_i.h |3 +++

Re: [PATCH v2] prctl: remove one-shot limitation for changing exe link

and solid. 27.09.2016 17:39, Stanislav Kinsburskiy пишет: This limitation came with the reason to remove "another way for malicious code to obscure a compromised program and masquerade as a benign process" by allowing "security-concious program can use this prctl once d

Re: [PATCH v2] prctl: remove one-shot limitation for changing exe link

and solid. 27.09.2016 17:39, Stanislav Kinsburskiy пишет: This limitation came with the reason to remove "another way for malicious code to obscure a compromised program and masquerade as a benign process" by allowing "security-concious program can use this prctl once d

[PATCH v2] prctl: remove one-shot limitation for changing exe link

tion of NFS mount point, which is not accessible during restore and replaced by other file system. Because of this exe link has to be changed twice. v2: Rebased on current linux-next Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> Acked-by: Oleg Nesterov <o...@redha

[PATCH v2] prctl: remove one-shot limitation for changing exe link

tion of NFS mount point, which is not accessible during restore and replaced by other file system. Because of this exe link has to be changed twice. v2: Rebased on current linux-next Signed-off-by: Stanislav Kinsburskiy Acked-by: Oleg Nesterov Acked-by: Cyrill Gorcunov --- include/linux/sch

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

30.07.2016 19:31, Eric W. Biederman пишет: Cyrill Gorcunov writes: On Mon, Jul 25, 2016 at 02:56:43PM -0500, Eric W. Biederman wrote: ... Also there is a big fat bug in prctl_set_mm_exe_file. It doesn't validate that the new file is a actually mmaped executable. We

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

30.07.2016 19:31, Eric W. Biederman пишет: Cyrill Gorcunov writes: On Mon, Jul 25, 2016 at 02:56:43PM -0500, Eric W. Biederman wrote: ... Also there is a big fat bug in prctl_set_mm_exe_file. It doesn't validate that the new file is a actually mmaped executable. We would definitely need

Re: [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

04.08.2016 15:16, Jeff Layton пишет: On Thu, 2016-08-04 at 12:55 +0200, Stanislav Kinsburskiy wrote: 03.08.2016 19:36, Jeff Layton пишет: On Wed, 2016-08-03 at 20:54 +0400, Stanislav Kinsburskiy wrote: Otherwise freezer cgroup state might never become "FROZEN". Here is a deadl

Re: [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

04.08.2016 15:16, Jeff Layton пишет: On Thu, 2016-08-04 at 12:55 +0200, Stanislav Kinsburskiy wrote: 03.08.2016 19:36, Jeff Layton пишет: On Wed, 2016-08-03 at 20:54 +0400, Stanislav Kinsburskiy wrote: Otherwise freezer cgroup state might never become "FROZEN". Here is a deadl

Re: [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

03.08.2016 19:36, Jeff Layton пишет: On Wed, 2016-08-03 at 20:54 +0400, Stanislav Kinsburskiy wrote: Otherwise freezer cgroup state might never become "FROZEN". Here is a deadlock scheme for 2 processes in one freezer cgroup, which is freezing: CPU 0

Re: [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

03.08.2016 19:36, Jeff Layton пишет: On Wed, 2016-08-03 at 20:54 +0400, Stanislav Kinsburskiy wrote: Otherwise freezer cgroup state might never become "FROZEN". Here is a deadlock scheme for 2 processes in one freezer cgroup, which is freezing: CPU 0

[RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

cbff18ec385c6ab4d58f33b100192a96a. 3) This patch is not aimed to fix the issue, but to show the problem root. Look like this problem moght be applicable to other hunks from the commit, mentioned above. Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> --- net/sunrpc/sched.c |1 -

[RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

cbff18ec385c6ab4d58f33b100192a96a. 3) This patch is not aimed to fix the issue, but to show the problem root. Look like this problem moght be applicable to other hunks from the commit, mentioned above. Signed-off-by: Stanislav Kinsburskiy --- net/sunrpc/sched.c |1 - 1 file changed, 1 deletion(-) d

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

25.07.2016 20:21, Eric W. Biederman пишет: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> writes: Gentlemen, Looks like there are no objections to this patch. There has been objection. The only justification for the change that has been put forward is someone doing a restore lazi

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

25.07.2016 20:21, Eric W. Biederman пишет: Stanislav Kinsburskiy writes: Gentlemen, Looks like there are no objections to this patch. There has been objection. The only justification for the change that has been put forward is someone doing a restore lazily. I don't see a reason why you

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

18.07.2016 22:11, One Thousand Gnomes пишет: 1) Attach to process via ptrace (protected by CAP_SYS_PTRACE) 2) Unmap all the process file mappings, related to "exe" file. 3) Change exe link (protected by CAP_SYS_RESOURCE). IOW, some other process already has an access to process internals (and

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

18.07.2016 22:11, One Thousand Gnomes пишет: 1) Attach to process via ptrace (protected by CAP_SYS_PTRACE) 2) Unmap all the process file mappings, related to "exe" file. 3) Change exe link (protected by CAP_SYS_RESOURCE). IOW, some other process already has an access to process internals (and

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

12.07.2016 18:52, Eric W. Biederman пишет: Cyrill Gorcunov <gorcu...@gmail.com> writes: On Tue, Jul 12, 2016 at 07:30:29PM +0400, Stanislav Kinsburskiy wrote: This limitation came with the reason to remove "another way for malicious code to obscure a compromised program and

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

12.07.2016 18:52, Eric W. Biederman пишет: Cyrill Gorcunov writes: On Tue, Jul 12, 2016 at 07:30:29PM +0400, Stanislav Kinsburskiy wrote: This limitation came with the reason to remove "another way for malicious code to obscure a compromised program and masquerade as a benign pr

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

12.07.2016 18:42, Oleg Nesterov пишет: On 07/12, Stanislav Kinsburskiy wrote: --- a/kernel/sys.c +++ b/kernel/sys.c @@ -1696,16 +1696,6 @@ static int prctl_set_mm_exe_file(struct mm_struct *mm, unsigned int fd) fput(exe_file); } - /* -* The symlink can

Re: [PATCH] prctl: remove one-shot limitation for changing exe link

12.07.2016 18:42, Oleg Nesterov пишет: On 07/12, Stanislav Kinsburskiy wrote: --- a/kernel/sys.c +++ b/kernel/sys.c @@ -1696,16 +1696,6 @@ static int prctl_set_mm_exe_file(struct mm_struct *mm, unsigned int fd) fput(exe_file); } - /* -* The symlink can

[PATCH] prctl: remove one-shot limitation for changing exe link

le system (FUSE-based) is used. Then opened files replaced by the proper ones NFS is remounted. Thus exe link replace has to be done twice: first on restore stage and second - when actual NFS was remounted. Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> --- include/lin

[PATCH] prctl: remove one-shot limitation for changing exe link

le system (FUSE-based) is used. Then opened files replaced by the proper ones NFS is remounted. Thus exe link replace has to be done twice: first on restore stage and second - when actual NFS was remounted. Signed-off-by: Stanislav Kinsburskiy --- include/linux/sched.h |4 +++- kernel/sys.c

[PATCH] prctl: remove one-shot limitation for changing exe link

le system (FUSE-based) is used. Then opened files replaced by the proper ones NFS is remounted. Thus exe link replace has to be done twice: first on restore stage and second - when actual NFS was remounted. Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> --- include/lin

[PATCH] prctl: remove one-shot limitation for changing exe link

le system (FUSE-based) is used. Then opened files replaced by the proper ones NFS is remounted. Thus exe link replace has to be done twice: first on restore stage and second - when actual NFS was remounted. Signed-off-by: Stanislav Kinsburskiy --- include/linux/sched.h |4 +++- kernel/sys.c

Re: call_usermodehelper in containers

13.02.2016 00:39, Ian Kent пишет: On Fri, 2013-11-15 at 15:54 +0400, Stanislav Kinsbursky wrote: 15.11.2013 15:03, Eric W. Biederman пишет: Stanislav Kinsbursky writes: 12.11.2013 17:30, Jeff Layton пишет: On Tue, 12 Nov 2013 17:02:36 +0400 Stanislav Kinsbursky wrote: 12.11.2013

Re: call_usermodehelper in containers

13.02.2016 00:39, Ian Kent пишет: On Fri, 2013-11-15 at 15:54 +0400, Stanislav Kinsbursky wrote: 15.11.2013 15:03, Eric W. Biederman пишет: Stanislav Kinsbursky writes: 12.11.2013 17:30, Jeff Layton пишет: On Tue, 12 Nov 2013 17:02:36 +0400 Stanislav Kinsbursky

[PATCH v2] autofs: show pipe inode in mount options

options list. 2) Option is printed only if CONFIG_CHECKPOINT_RESTORE is set. Signed-off-by: Stanislav Kinsburskiy --- fs/autofs4/inode.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index a3ae0b2..4320faa 100644 --- a/fs/

Re: [PATCH] autofs: show pipe inode in mount options

23.01.2016 01:30, Ian Kent пишет: On Fri, 2016-01-22 at 12:34 +0100, Stanislav Kinsburskiy wrote: Hi again, I would like to ask about any progress with this patch? Any other requirements to make it able to merge? Sorry for the delay. Since there haven't been any comments from Al or Stephen

[PATCH v2] autofs: show pipe inode in mount options

options list. 2) Option is printed only if CONFIG_CHECKPOINT_RESTORE is set. Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> --- fs/autofs4/inode.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index a3

Re: [PATCH] autofs: show pipe inode in mount options

23.01.2016 01:30, Ian Kent пишет: On Fri, 2016-01-22 at 12:34 +0100, Stanislav Kinsburskiy wrote: Hi again, I would like to ask about any progress with this patch? Any other requirements to make it able to merge? Sorry for the delay. Since there haven't been any comments from Al or Stephen

Re: [PATCH] autofs: show pipe inode in mount options

Hi again, I would like to ask about any progress with this patch? Any other requirements to make it able to merge?

Re: [PATCH] autofs: show pipe inode in mount options

Hi again, I would like to ask about any progress with this patch? Any other requirements to make it able to merge?

Re: [PATCH] autofs: show pipe inode in mount options

Good day, gentlemen. Could you update, what's the status with this patch? Without it it's impossible to match process pipe with kernel pipe, while this is "must have" to be able to migrate AutoFS via CRIU. 16.12.2015 13:02, Stanislav Kinsburskiy пишет: This is required for CRIU

Re: [PATCH] autofs: show pipe inode in mount options

Good day, gentlemen. Could you update, what's the status with this patch? Without it it's impossible to match process pipe with kernel pipe, while this is "must have" to be able to migrate AutoFS via CRIU. 16.12.2015 13:02, Stanislav Kinsburskiy пишет: This is required for CRIU

[PATCH] autofs: show pipe inode in mount options

This is required for CRIU to migrate a mount point, when write end in user space is closed. To be able to migrate such mount, read end of the pipe have to be searched within autofs master process, and pipe inode will be used as a key. Signed-off-by: Stanislav Kinsburskiy --- fs/autofs4/inode.c

[PATCH] autofs: show pipe inode in mount options

This is required for CRIU to migrate a mount point, when write end in user space is closed. To be able to migrate such mount, read end of the pipe have to be searched within autofs master process, and pipe inode will be used as a key. Signed-off-by: Stanislav Kinsburskiy <skins

[PATCH RFC 2/3] splice: new SPLICE_F_PACKET flag introduced

This flag is used by kernel only to represent pipe packetized mode for splice engine. Signed-off-by: Stanislav Kinsburskiy --- include/linux/splice.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/splice.h b/include/linux/splice.h index da2751d..13ca14d 100644

[PATCH RFC 0/3] Fix splice for packetized pipes

. It's supposed to be used only in kernel and set, when write pipe is in packetized mode. In splice_to_pipe() it's converted into created pipe buffer PIPE_BUF_FLAG_PACKET flag. The following series implements... --- Stanislav Kinsburskiy (3): pipe: make is_packetized() non-static and declare

[PATCH RFC 1/3] pipe: make is_packetized() non-static and declare in pipe_fs_i.h

With introduction of packetized pipe mode, represented by O_DIRECT flag, splice stopped working correctly with a pipe in this mode. To be able to fix them, this helper have to exposed. Signed-off-by: Stanislav Kinsburskiy --- fs/pipe.c |2 +- include/linux/pipe_fs_i.h |2

[PATCH RFC 3/3] splice: add support of splicing to packetized pipe

This patch uses SPLICE_F_PACKET as a flag, representing packetized pipe. In splice_to_pipe() this flag is converted into PIPE_BUF_FLAG_PACKET on pipe buffer. Signed-off-by: Stanislav Kinsburskiy --- fs/splice.c |8 1 file changed, 8 insertions(+) diff --git a/fs/splice.c b/fs

[PATCH] fcntl: allow to set O_DIRECT flag on pipe

With packetized mode for pipes, it's not possible to set O_DIRECT on pipe file via sys_fcntl, because of unsupported (by pipes) sanity checks. Ability to set this flag will be used by CRIU to migrate packetized pipes. Signed-off-by: Stanislav Kinsburskiy --- fs/fcntl.c |3 ++- 1 file

[PATCH v2] fcntl: allow to set O_DIRECT flag on pipe

With packetized mode for pipes, it's not possible to set O_DIRECT on pipe file via sys_fcntl, because of unsupported sanity checks. Ability to set this flag will be used by CRIU to migrate packetized pipes. v2: Fixed typos and mode variable to check. Signed-off-by: Stanislav Kinsburskiy --- fs

[PATCH RFC 3/3] splice: add support of splicing to packetized pipe

This patch uses SPLICE_F_PACKET as a flag, representing packetized pipe. In splice_to_pipe() this flag is converted into PIPE_BUF_FLAG_PACKET on pipe buffer. Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> --- fs/splice.c |8 1 file changed, 8 insertions(+)

[PATCH RFC 0/3] Fix splice for packetized pipes

. It's supposed to be used only in kernel and set, when write pipe is in packetized mode. In splice_to_pipe() it's converted into created pipe buffer PIPE_BUF_FLAG_PACKET flag. The following series implements... --- Stanislav Kinsburskiy (3): pipe: make is_packetized() non-static and declare

[PATCH RFC 2/3] splice: new SPLICE_F_PACKET flag introduced

This flag is used by kernel only to represent pipe packetized mode for splice engine. Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> --- include/linux/splice.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/splice.h b/include/linux/splice.h

[PATCH RFC 1/3] pipe: make is_packetized() non-static and declare in pipe_fs_i.h

With introduction of packetized pipe mode, represented by O_DIRECT flag, splice stopped working correctly with a pipe in this mode. To be able to fix them, this helper have to exposed. Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> --- fs/pipe.c

[PATCH] fcntl: allow to set O_DIRECT flag on pipe

With packetized mode for pipes, it's not possible to set O_DIRECT on pipe file via sys_fcntl, because of unsupported (by pipes) sanity checks. Ability to set this flag will be used by CRIU to migrate packetized pipes. Signed-off-by: Stanislav Kinsburskiy <skinsbur...@virtuozzo.com> -

[PATCH v2] fcntl: allow to set O_DIRECT flag on pipe

With packetized mode for pipes, it's not possible to set O_DIRECT on pipe file via sys_fcntl, because of unsupported sanity checks. Ability to set this flag will be used by CRIU to migrate packetized pipes. v2: Fixed typos and mode variable to check. Signed-off-by: Stanislav Kinsburskiy