Re: [PATCH 2/3] dt-bindings: clock: ti: remove unstable remark

2024-02-28 Thread Tony Lindgren
clock"). It was enough of time to consider them stable > > and expect usual ABI rules. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > Acked-by: Stephen Boyd Makes sense to me: Acked-by: Tony Lindgren

Re: droid4 -- weird behaviour when attempting to use usb host

2023-09-26 Thread Tony Lindgren
* Pavel Machek [230925 14:36]: > Hi! > > I'm having some fun with usb host. Good news is it works with > externally powered hub... after a while. I get some error messages > about inability to go host mode, but with enough patience it > eventually does enter host mode and I see my

Re: [PATCH 0/2] fdt: translate address if #size-cells = <0>

2021-04-17 Thread Tony Lindgren
* Dario Binacchi [210414 20:40]: > > Il 12/04/2021 09:41 Tero Kristo ha scritto: > > The change on the DT itself would be pretty large, removing all clock > > nodes and modifying any existing handles towards the clock nodes, and > > this would impact all OMAP architectures. > > > > Anyways,

[PATCH] clocksource/drivers/timer-ti-dm: Save and restore timer TIOCP_CFG

2021-04-15 Thread Tony Lindgren
ifier for context save and restore") Cc: Aaro Koskinen Cc: Adam Ford Cc: Andreas Kemnade Cc: Lokesh Vutla Cc: Peter Ujfalusi Signed-off-by: Tony Lindgren --- drivers/clocksource/timer-ti-dm.c | 6 ++ include/clocksource/timer-ti-dm.h | 1 + 2 files changed, 7 insertions(+) diff --git

[tip: timers/core] clocksource/drivers/timer-ti-dm: Add missing set_state_oneshot_stopped

2021-04-09 Thread tip-bot2 for Tony Lindgren
The following commit has been merged into the timers/core branch of tip: Commit-ID: ac4daf737674b4d29e19b7c300caff3bcf7160d8 Gitweb: https://git.kernel.org/tip/ac4daf737674b4d29e19b7c300caff3bcf7160d8 Author:Tony Lindgren AuthorDate:Thu, 04 Mar 2021 09:21:35 +02:00

[tip: timers/core] clocksource/drivers/timer-ti-dm: Fix posted mode status check order

2021-04-09 Thread tip-bot2 for Tony Lindgren
The following commit has been merged into the timers/core branch of tip: Commit-ID: 212709926c5493a566ca4086ad4f4b0d4e66b553 Gitweb: https://git.kernel.org/tip/212709926c5493a566ca4086ad4f4b0d4e66b553 Author:Tony Lindgren AuthorDate:Thu, 04 Mar 2021 09:21:33 +02:00

[tip: timers/core] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

2021-04-09 Thread tip-bot2 for Tony Lindgren
The following commit has been merged into the timers/core branch of tip: Commit-ID: 3efe7a878a11c13b5297057bfc1e5639ce1241ce Gitweb: https://git.kernel.org/tip/3efe7a878a11c13b5297057bfc1e5639ce1241ce Author:Tony Lindgren AuthorDate:Tue, 23 Mar 2021 09:43:25 +02:00

[tip: timers/core] clocksource/drivers/timer-ti-dm: Handle dra7 timer wrap errata i940

2021-04-09 Thread tip-bot2 for Tony Lindgren
The following commit has been merged into the timers/core branch of tip: Commit-ID: 25de4ce5ed02994aea8bc111d133308f6fd62566 Gitweb: https://git.kernel.org/tip/25de4ce5ed02994aea8bc111d133308f6fd62566 Author:Tony Lindgren AuthorDate:Tue, 23 Mar 2021 09:43:26 +02:00

Re: [PATCH 1/6] PM: runtime: enable wake irq after runtime_suspend hook called

2021-04-08 Thread Tony Lindgren
* Ikjoon Jang [210409 05:33]: > Hi Chunfeng, > > On Thu, Apr 8, 2021 at 5:35 PM Chunfeng Yun wrote: > > > > When the dedicated wake irq is level trigger, enable it before > > calling runtime_suspend, will trigger an interrupt. > > > > e.g. > > for a low level trigger type, it's low level at

Re: [PATCH 1/6] PM: runtime: enable wake irq after runtime_suspend hook called

2021-04-08 Thread Tony Lindgren
* Chunfeng Yun [210409 01:54]: > On Thu, 2021-04-08 at 19:41 +0200, Rafael J. Wysocki wrote: > > On Thu, Apr 8, 2021 at 11:35 AM Chunfeng Yun > > wrote: > > > > > > When the dedicated wake irq is level trigger, enable it before > > > calling runtime_suspend, will trigger an interrupt. > > > > >

Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-07 Thread Tony Lindgren
* Vignesh Raghavendra [210407 07:46]: > Hi, > > On 4/7/21 11:57 AM, Tony Lindgren wrote: > > * Vignesh Raghavendra [210407 06:20]: > >> Do we need a Fixes: tag to enable stable backports? > > > > Well pm_runtime_resume_and_get() was introduced quite

Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-07 Thread Tony Lindgren
* Vignesh Raghavendra [210407 06:20]: > Do we need a Fixes: tag to enable stable backports? Well pm_runtime_resume_and_get() was introduced quite recently, and we already handle the error and bail out. And likely after an error not much works anyways :) So it might be better to add just a stable

Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-07 Thread Tony Lindgren
> PM counter on error. > > Signed-off-by: Dinghao Liu Reviewed-by: Tony Lindgren > --- > drivers/i2c/busses/i2c-omap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c >

Re: [PATCH] Input: gpio-keys - fix crash when disabliing GPIO-less buttons

2021-04-07 Thread Tony Lindgren
t: gpio-keys - use hrtimer for software debounce, > if possible") > Reported-by: Tony Lindgren > Signed-off-by: Dmitry Torokhov > --- > > Tony, could you please try this patch and see if it fixes the crash you > observed? Yes great, thanks this works for me: Tested-by: Tony Lindgren

Re: [PATCH v3 3/3] input: gpio-keys: Use hrtimer for software debounce, if possible

2021-04-06 Thread Tony Lindgren
Hi, * Dmitry Torokhov [700101 02:00]: > On Sun, Mar 07, 2021 at 10:22:40PM +, Paul Cercueil wrote: > > We want to be able to report the input event as soon as the debounce > > delay elapsed. However, the current code does not really ensure that, > > as it uses the jiffies-based

Re: [PATCH] MAINTAINERS: remove obsolete OMAP HWMOD DATA FOR OMAP4-BASED DEVICES

2021-03-31 Thread Tony Lindgren
* Lukas Bulwahn [210318 19:26]: > Commit 2584d7e7f87a ("ARM: OMAP2+: Drop legacy platform data for omap4 > hwmod") drops the file ./arch/arm/mach-omap2/omap_hwmod_44xx_data.c, but > misses to drop the now obsolete OMAP HWMOD DATA FOR OMAP4-BASED DEVICES > section in MAINTAINERS, which refers to

Re: arch/arm/mach-omap2/sr_device.c:207:51: warning: variable 'sr_inst' is uninitialized when used here

2021-03-31 Thread Tony Lindgren
* kernel test robot [210327 05:06]: > >> arch/arm/mach-omap2/sr_device.c:207:51: warning: variable 'sr_inst' is > >> uninitialized when used here [-Wuninitialized] >name = kasprintf(GFP_KERNEL, "smartreflex_%s", > sr_inst[i]); >

Re: [PATCH 03/12] ARM: omap1: osk: Constify the software node

2021-03-31 Thread Tony Lindgren
* Heikki Krogerus [210329 10:51]: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus > Cc: Aaro Koskinen > Cc: Tony Lindgren P

Re: [PATCH] ARM: OMAP2+: fix incorrect kernel-doc comment syntax in file

2021-03-31 Thread Tony Lindgren
* Aditya Srivastava [210331 00:00]: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > The header for arch/arm/mach-omap2/omap_twl.c follows this syntax, but the > content inside does not comply with kernel-doc. > > This line was probably not

Re: [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file

2021-03-31 Thread Tony Lindgren
* Aditya Srivastava [210330 23:54]: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > The header for arch/arm/mach-omap1/timer.c follows this syntax, but the > content inside does not comply with kernel-doc. > > This line was probably not meant

Re: [PATCH -next] ARM: OMAP: Use DEFINE_SPINLOCK() for spinlock

2021-03-31 Thread Tony Lindgren
* Chen Lifu [210327 11:53]: > From: Lifu Chen > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). Thanks applying into omap-for-v5.13/soc. Tony

Re: [PATCH] ARM: dts: am335x-boneblack.dts: unique gpio-line-names

2021-03-30 Thread Tony Lindgren
* Drew Fustini [210325 00:25]: > Based on linux-gpio discussion [1], it is best practice to make the > gpio-line-names unique. Generic names like "[ethernet]" are replaced > with the name of the unique signal on the AM3358 SoC ball corresponding > to the gpio line. "[NC]" is also renamed to the

Re: [PATCH v3 0/4] clk: ti: add am33xx spread spectrum clock support

2021-03-30 Thread Tony Lindgren
* Stephen Boyd [210330 02:25]: > Quoting Dario Binacchi (2021-03-29 09:42:17) > > > > As reported by the TI spruh73x RM, MPU and LCD modules support spread > > spectrum clocking (SSC) on their output clocks. SSC is used to spread > > the spectral peaking of the clock to reduce any

Re: [PATCH v4 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero

2021-03-24 Thread Tony Lindgren
bits_per_mux is not zero. In addition move > offset calculation and pin offset in register to common function. Reviewed-by: Tony Lindgren

Re: [PATCH v4 2/3] pinctrl: pinctrl-single: remove unused parameter

2021-03-24 Thread Tony Lindgren
* Hanna Hawa [700101 02:00]: > Remove unused parameter 'pin_pos' from pcs_add_pin(). Reviewed-by: Tony Lindgren

Re: [PATCH v4 1/3] pinctrl: pinctrl-single: remove unused variable

2021-03-24 Thread Tony Lindgren
* Hanna Hawa [700101 02:00]: > Remove unused parameter 'num_pins_in_register' from > pcs_allocate_pin_table(). Reviewed-by: Tony Lindgren

Re: [PATCH] ARM: OMAP2+: use true and false for bool variable

2021-03-24 Thread Tony Lindgren
* Yang Li [210315 09:06]: > fixed the following coccicheck: > ./arch/arm/mach-omap2/powerdomain.c:1205:9-10: WARNING: return of 0/1 in > function 'pwrdm_can_ever_lose_context' with return type bool Thanks applying into omap-for-v5.13/soc. Tony

Re: [PATCH v2 3/4] ARM: dts: am33xx-clocks: add spread spectrum support

2021-03-24 Thread Tony Lindgren
* Dario Binacchi [210318 17:28]: > Registers for adjusting the spread spectrum clocking (SSC) have been > added. As reported by the TI spruh73x RM, SSC is supported only for > LCD and MPU PLLs. Probably best to keep the series together: Acked-by: Tony Lindgren

Re: [RESEND PATCH] ARM: dts: am33xx-l4: fix tscadc@0 node indentation

2021-03-24 Thread Tony Lindgren
* Dario Binacchi [210314 17:17]: > Fix the broken indentation of tscadc@0 node. Applying into omap-for-v5.13/dt thanks. Tony

Re: [PATCH 1/2] ARM: dts: omap3-echo: Update LED configuration

2021-03-24 Thread Tony Lindgren
* André Hentschel [210130 14:29]: > Changes made in 54212f5a1ba3123281877e54c1e5f672bf7563d8 and previous commits > broke with the way > the LED drivers were described in device-trees before. These adjustments fix > that. Thanks applying both into omap-for-v5.13/dt. Tony

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

2021-03-24 Thread Tony Lindgren
Hi, * Drew Fustini [210127 02:04]: > Based on linux-gpio discussion [1], it is best practice to make the > gpio-line-names unique. Generic names like "[ethernet]" are replaced > with the name of the unique signal on the AM3358 SoC ball corresponding > to the gpio line. "[NC]" is also renamed to

Re: [PATCH -next] bus: ti-sysc: Use kzalloc for allocating only one thing

2021-03-24 Thread Tony Lindgren
* Zheng Yongjun [201229 15:51]: > Use kzalloc rather than kcalloc(1,...) Thanks applying into omap-for-v5.13/ti-sysc. Tony

Re: [PATCH] ARM: OMAP2+: add missing call to of_node_put()

2021-03-24 Thread Tony Lindgren
* Yang Li [210225 10:55]: > In one of the error paths of the for_each_child_of_node() loop, > add missing call to of_node_put(). Thanks applying into omap-for-v5.13/soc. Tony

Re: [PATCH] bus: ti-sysc: remove unneeded semicolon

2021-03-24 Thread Tony Lindgren
* Yang Li [210202 09:00]: > Eliminate the following coccicheck warning: > ./drivers/bus/ti-sysc.c:1595:2-3: Unneeded semicolon > ./drivers/bus/ti-sysc.c:2833:3-4: Unneeded semicolon Thanks applying into omap-for-v5.13/ti-sysc. Tony

Re: [PATCH] arm: omap2: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-03-24 Thread Tony Lindgren
* Jiapeng Chong [210202 05:43]: > Fix the following coccicheck warning: > > ./arch/arm/mach-omap2/pm-debug.c:171:0-23: WARNING: pwrdm_suspend_fops > should be defined with DEFINE_DEBUGFS_ATTRIBUTE. Thanks applying into omap-for-v5.13/soc. Tony

Re: arch/arm/mach-omap2/board-generic.c:36:28: warning: no previous prototype for 'omap_init_time_of'

2021-03-24 Thread Tony Lindgren
Hi, * kernel test robot [210226 13:11]: > Hi Tony, > > FYI, the error/warning still remains. Thanks for the report and sorry for the delay in responding. I've posted a fix for this at: https://lore.kernel.org/linux-omap/20210324105102.7286-1-t...@atomide.com/T/#u Regards, Tony > tree:

Re: [PATCHv2 01/38] ARM: dts: motorola-cpcap-mapphone: Prepare for dtbs_check parsing

2021-03-23 Thread Tony Lindgren
* Sebastian Reichel [210323 12:52]: > Hi Tony, > > On Wed, Mar 17, 2021 at 04:29:19PM +0200, Tony Lindgren wrote: > > * Sebastian Reichel [210317 13:50]: > > > '< parameters parameters>' and '< parameters>, > > > < parameters>' result in the

[PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

2021-03-23 Thread Tony Lindgren
dmtimer_clkevt_init_common() and call it from dmtimer_clockevent_init(). This patch makes no intentional functional changes. Signed-off-by: Tony Lindgren --- drivers/clocksource/timer-ti-dm-systimer.c | 66 ++ 1 file changed, 43 insertions(+), 23 deletions(-) diff --git a/drivers/clocksource

[PATCH 2/2] clocksource/drivers/timer-ti-dm: Handle dra7 timer wrap errata i940

2021-03-23 Thread Tony Lindgren
Tero Kristo Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/dra7-l4.dtsi | 4 +- arch/arm/boot/dts/dra7.dtsi| 20 ++ drivers/clocksource/timer-ti-dm-systimer.c | 76 ++ include/linux/cpuhotplug.h | 1 + 4 files changed,

[PATCHv2 0/2] Fixes for for dra7 timer wrap errata i940

2021-03-23 Thread Tony Lindgren
ti-dm systimer posted mode" for the write status register check fix. Also the spurious timer interrupt fix is good to have from that series. Regards, Tony Changes since v1: - Drop pointless irqflags and IRQF_NOBALANCING as noted by Daniel Tony Lindgren (2): clocksource/drivers/timer-ti-d

Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

2021-03-23 Thread Tony Lindgren
* Daniel Lezcano [210322 18:24]: > On 22/03/2021 17:33, Tony Lindgren wrote: > > Hi, > > > > * Daniel Lezcano [210322 15:56]: > >> On 04/03/2021 08:37, Tony Lindgren wrote: > >>> There is a timer wrap issue on dra7 for the ARM architected timer. > &

Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

2021-03-22 Thread Tony Lindgren
Hi, * Daniel Lezcano [210322 15:56]: > On 04/03/2021 08:37, Tony Lindgren wrote: > > There is a timer wrap issue on dra7 for the ARM architected timer. > > In a typical clock configuration the timer fails to wrap after 388 days. > > > > To work around the issue,

Re: [PATCH 2/2] clocksource/drivers/timer-ti-dm: Handle dra7 timer wrap errata i940

2021-03-22 Thread Tony Lindgren
Hi, * Daniel Lezcano [210322 10:16]: > On 04/03/2021 08:37, Tony Lindgren wrote: > > There is a timer wrap issue on dra7 for the ARM architected timer. > > In a typical clock configuration the timer fails to wrap after 388 days. > > > > To work around the issue,

Re: [PATCHv2 03/38] dt-bindings: power: supply: cpcap-charger: Convert to DT schema format

2021-03-19 Thread Tony Lindgren
* Sebastian Reichel [210317 13:50]: > Convert the binding to DT schema format. I also added the missing bits > used by the only in-tree user and implemented in the driver. Reviewed-by: Tony Lindgren

Re: [PATCHv2 02/38] dt-bindings: power: supply: cpcap-battery: Convert to DT schema format

2021-03-19 Thread Tony Lindgren
* Sebastian Reichel [210317 13:50]: > Convert the binding to DT schema format. I also added the missing bits > used by the only in-tree user and implemented in the driver. Reviewed-by: Tony Lindgren

Re: [PATCHv2 01/38] ARM: dts: motorola-cpcap-mapphone: Prepare for dtbs_check parsing

2021-03-17 Thread Tony Lindgren
cified, so using > this syntax is needed to successfully verify the devicetree source > against a DT schema format. Looks good to me: Acked-by: Tony Lindgren

[PATCH 0/2] Few clean-up patches after dropping legacy data

2021-03-12 Thread Tony Lindgren
-legacy Tony Lindgren (2): ARM: OMAP2+: Stop building legacy code for dra7 and omap4/5 bus: ti-sysc: Warn about old dtb for dra7 and omap4/5 arch/arm/mach-omap2/Makefile | 8 arch/arm/mach-omap2/io.c | 7 ++- arch/arm/mach-omap2/omap_hwmod.h | 13

[PATCH 2/2] bus: ti-sysc: Warn about old dtb for dra7 and omap4/5

2021-03-12 Thread Tony Lindgren
Let's warn if an old incomplete dtb is detected. We now assume the dtb is complete and does not depend on the legacy platform data. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c

[PATCH 1/2] ARM: OMAP2+: Stop building legacy code for dra7 and omap4/5

2021-03-12 Thread Tony Lindgren
With the recent changes we are now booting am3/4, dra7, and omap4/5 without legacy data using devicetree, simple-pm-bus and genpd. Let's not initialize and build the legacy data unless CONFIG_OMAP_HWMOD is selected based on the SoCs enabled in .config. Signed-off-by: Tony Lindgren --- arch/arm

Re: [PATCH] ARM: omap1: fix building with clang IAS

2021-03-09 Thread Tony Lindgren
clang IAS makes nonsensical suggestions for how to fix it > is great. Fortunately there is an easy fix, which is to #include > the header that contains the definition. Acked-by: Tony Lindgren

Re: [RFT PATCH v3 06/27] dt-bindings: timer: arm,arch_timer: Add interrupt-names support

2021-03-08 Thread Tony Lindgren
an arbitrary set of available interrupts, so > the timer code can pick the right one. > > This also adds the hyp-virt timer/interrupt, which was previously not > expressed in the fixed 4-interrupt form. I like this one too: Reviewed-by: Tony Lindgren

Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()

2021-03-08 Thread Tony Lindgren
Hi, * Tony Lindgren [210305 07:58]: > * Grygorii Strashko [210304 20:56]: > > > > > > On 04/03/2021 09:21, Tony Lindgren wrote: > > > We have of_translate_address() already do of_node_put() as needed. > > > I probably looked at __of_

[PATCH 3/4] clk: ti: omap5: Add missing gpmc and ocmc clkctrl

2021-03-08 Thread Tony Lindgren
The gpmc clock is needed to update omap5 to boot with genpd with the related devicetree patches. The ocmc clock is currently not used but let's add it so we have all the clocks for the l3main2 defined. Cc: Stephen Boyd Cc: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/clk/ti/clk-54xx.c

[PATCH 1/4] ARM: OMAP2+: Init both prm and prcm nodes early for clocks

2021-03-08 Thread Tony Lindgren
We need to probe both prm and prcm nodes early for clocks as they are needed by system timers. Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/pdata-quirks.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-omap2/pdata

[PATCH 2/4] soc: ti: omap-prm: Allow hardware supported retention when idle

2021-03-08 Thread Tony Lindgren
retention on WFI when none of the devices on the domain block autoidle in the hardware. This follows what we are already currently doing. Cc: Santosh Shilimkar Cc: Tero Kristo Signed-off-by: Tony Lindgren --- drivers/soc/ti/omap_prm.c | 16 1 file changed, 12 insertions(+), 4

[PATCH 4/4] bus: ti-sysc: Check for old incomplete dtb

2021-03-08 Thread Tony Lindgren
Let's be nice and show an error on the SoCs about old imcomplete devicetree if the dtb is still using "simple-bus" instead of "simple-pm-bus" for the root OCP node. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 16 1 file changed, 16 inser

[PATCH 0/4] ti-sysc changes for dropping omap4/5 legacy data

2021-03-08 Thread Tony Lindgren
Hi all, Here are few ti-sysc related changes that are needed to drop legacy data for omap4/5. The last patch also starts warning users about old incomplete dtb, we do that initially only for am3/4 that no longer have the legacy data. Regards, Tony Tony Lindgren (4): ARM: OMAP2+: Init both

Re: [PATCH 1/3] clocksource/drivers/timer-ti-dm: Fix posted mode status check order

2021-03-04 Thread Tony Lindgren
* Grygorii Strashko [210304 20:58]: > On 04/03/2021 09:21, Tony Lindgren wrote: > > When the timer is configured in posted mode, we need to check the write- > > posted status register (TWPS) before writing to the register. ... > > --- a/drivers/clocksource/timer-ti-dm

Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()

2021-03-04 Thread Tony Lindgren
* Grygorii Strashko [210304 20:56]: > > > On 04/03/2021 09:21, Tony Lindgren wrote: > > We have of_translate_address() already do of_node_put() as needed. > > I probably looked at __of_translate_address() earlier by accident > > that of_translate_address() uses. &g

[PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

2021-03-03 Thread Tony Lindgren
dmtimer_clkevt_init_common() and call it from dmtimer_clockevent_init(). This patch makes no intentional functional changes. Signed-off-by: Tony Lindgren --- drivers/clocksource/timer-ti-dm-systimer.c | 72 +++--- 1 file changed, 49 insertions(+), 23 deletions(-) diff --git a/drivers/clocksource

[PATCH 2/2] clocksource/drivers/timer-ti-dm: Handle dra7 timer wrap errata i940

2021-03-03 Thread Tony Lindgren
Tero Kristo Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/dra7-l4.dtsi | 4 +- arch/arm/boot/dts/dra7.dtsi| 20 ++ drivers/clocksource/timer-ti-dm-systimer.c | 76 ++ include/linux/cpuhotplug.h | 1 + 4 files changed,

[PATCH 0/2] Fixes for for dra7 timer wrap errata i940

2021-03-03 Thread Tony Lindgren
osted mode" for the write status register check fix. Also the spurious timer interrupt fix is good to have from that series. Regards, Tony Tony Lindgren (2): clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue clocksource/drivers/timer-ti-dm: Handle dra7 timer w

[PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()

2021-03-03 Thread Tony Lindgren
We have of_translate_address() already do of_node_put() as needed. I probably looked at __of_translate_address() earlier by accident that of_translate_address() uses. Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support") Signed-off-by: Ton

[PATCH 0/3] Fixes for timer-ti-dm systimer posted mode

2021-03-03 Thread Tony Lindgren
Hi all, Here are few timer-ti-dm fixes. The first fix corrects the status bit check order for posted mode. The other two are minor fixes noticed while reviewing and testing the code. Regards, Tony Tony Lindgren (3): clocksource/drivers/timer-ti-dm: Fix posted mode status check order

[PATCH 3/3] clocksource/drivers/timer-ti-dm: Add missing set_state_oneshot_stopped

2021-03-03 Thread Tony Lindgren
vents: Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state") and commit cf8c5009ee37 ("clockevents/drivers/arm_arch_timer: Implement ->set_state_oneshot_stopped()"). Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support") Signed-of

[PATCH 1/3] clocksource/drivers/timer-ti-dm: Fix posted mode status check order

2021-03-03 Thread Tony Lindgren
omap_dm_timer_load_start(). We have__omap_dm_timer_load_start() check the TWPS status correctly using __omap_dm_timer_write(). Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support") Signed-off-by: Tony Lindgren --- drivers/clocksource/timer-ti-dm-systimer.c | 12 ++--

Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

2021-02-25 Thread Tony Lindgren
re, it just taking the > > addresses. But the patch is also harmless and improves readability. > > Hm, in the second line indeed the compiler will just calculate the > offset of "mem" field against the "gpmc_cs+cs" and return it's probable > address. > > To me still the code is a little bit non-obvious or obfuscated - first > you play with the array[index] and then you check the validity of index. To me it seems the fixes tag is not ideal.. Seems this issue was there earlier too before moving the code. In any case: Reviewed-by: Tony Lindgren

Re: Droid 4 charging

2021-02-21 Thread Tony Lindgren
* Pavel Machek [210219 21:58]: > > > If I turn off charging with echo 0 > input_current_limit, 0.2 to 0.4A > > > is drawn from USB, and battery is not discharged: > > > > > > root@devuan-droid4:/sys/class/power_supply/usb# echo 0 > > > > input_current_limit > > >

Re: [PATCH] soc: ti: omap-prm: Fix occasional abort on reset deassert for dra7 iva

2021-02-19 Thread Tony Lindgren
* Yongqin Liu [210219 05:02]: > Thanks for the fix, Tony! > Tested with x15 android build, and it resolves the boot failures problem. OK great. May I add your Tested-by: to the patch? Regards, Tony

[PATCH] soc: ti: omap-prm: Fix occasional abort on reset deassert for dra7 iva

2021-02-18 Thread Tony Lindgren
to limit the list to the know affected devices if needed. Fixes: d30cd83f6853 ("soc: ti: omap-prm: add support for denying idle for reset clockdomain") Reported-by: Yongqin Liu Signed-off-by: Tony Lindgren --- drivers/soc/ti/omap_prm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletio

[PATCH] bus: ti-sysc: Fix warning on unbind if reset is not deasserted

2021-02-18 Thread Tony Lindgren
[] (__device_release_driver+0x154/0x214) (__device_release_driver) from [] (device_driver_detach+0x3c/0x8c) (device_driver_detach) from [] (unbind_store+0x60/0xd4) (unbind_store) from [] (kernfs_fop_write_iter+0x10c/0x1cc) Let's fix it by checking the reset status. Signed-off-by: Tony Lindgren

Re: [PATCH v6 0/3] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-17 Thread Tony Lindgren
; will cause the function and group to be activated on the pin controller. Nice to see this happening! Reviewed-by: Tony Lindgren

Re: [PATCH v2 06/25] arm64: arch_timer: implement support for interrupt-names

2021-02-15 Thread Tony Lindgren
ng timers :) Similar approach might help other SoCs too. And clocksources never really had similar issues. With Marc's comments addressed, please feel free to add: Reviewed-by: Tony Lindgren

Re: Droid 4 charging

2021-02-14 Thread Tony Lindgren
Hi, * Pavel Machek [210206 13:14]: > Hi! > > (I'm using Leste 5.10 kernel here). > > When battery is full, green light is off and 0.00A being drawn from > USB. > > But that means that phone is now powered from battery, discharging > it... And soon charging starts again. (Pretty much

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Tony Lindgren
* Krzysztof Kozlowski [210210 12:56]: > On Wed, Feb 10, 2021 at 01:34:50PM +0200, Tony Lindgren wrote: > > * Hector Martin [210210 11:14]: > > > On 10/02/2021 19.19, Tony Lindgren wrote: > > > > * Hector Martin 'marcan' [210208 12:05]: > > > > > O

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Tony Lindgren
* Daniel Palmer [210210 12:24]: > Hi Hector, > > On Wed, 10 Feb 2021 at 20:49, Hector Martin wrote: > > > > Yeah, just don't use an imaginary dummy index for the reg. Use a real > > > register offset from a clock controller instance base, and a register > > > bit offset too if needed. > > > >

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Tony Lindgren
* Hector Martin [210210 11:14]: > On 10/02/2021 19.19, Tony Lindgren wrote: > > * Hector Martin 'marcan' [210208 12:05]: > > > On 08/02/2021 20.04, Krzysztof Kozlowski wrote: > > ... > > > > > > > + clk24: clk24 { > > >

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-10 Thread Tony Lindgren
* Hector Martin 'marcan' [210208 12:05]: > On 08/02/2021 20.04, Krzysztof Kozlowski wrote: ... > > > + clk24: clk24 { > > > > Just "clock". Node names should be generic. > > Really? Almost every other device device tree uses unique clock node names. Yeah please just use generic node name

[PATCH] soc: ti: omap-prm: Fix reboot issue with invalid pcie reset map for dra7

2021-02-10 Thread Tony Lindgren
I Reported-by: Yongqin Liu Signed-off-by: Tony Lindgren --- drivers/soc/ti/omap_prm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c --- a/drivers/soc/ti/omap_prm.c +++ b/drivers/soc/ti/omap_prm.c @@ -332,7 +33

Re: [GIT PULL 2/3] ARM: dts: samsung: DTS for v5.12

2021-02-08 Thread Tony Lindgren
* Geert Uytterhoeven [210206 19:48]: > On Sat, Feb 6, 2021 at 3:36 PM Arnd Bergmann wrote: > > What do others think about this? Should we generally assume > > that breaking old kernels with new dtbs is acceptable, or should > > we try to avoid it if possible, the same way we try to avoid > >

[PATCH 3/4] thermal: ti-soc-thermal: Simplify polling with iopoll

2021-02-05 Thread Tony Lindgren
and we can use 1ms timeout. Cc: Adam Ford Cc: Carl Philipp Klemm Cc: Eduardo Valentin Cc: H. Nikolaus Schaller Cc: Merlijn Wajer Cc: Pavel Machek Cc: Peter Ujfalusi Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/thermal/ti-soc-thermal/ti-bandgap.c | 30 ++--- 1

[PATCH 4/4] thermal: ti-soc-thermal: Use non-inverted define for omap4

2021-02-05 Thread Tony Lindgren
Machek Cc: Peter Ujfalusi Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/thermal/ti-soc-thermal/omap4-thermal-data.c | 4 ++-- drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/ti-soc-thermal

[PATCH 1/4] thermal: ti-soc-thermal: Skip pointless register access for dra7

2021-02-05 Thread Tony Lindgren
. Nikolaus Schaller Cc: Merlijn Wajer Cc: Pavel Machek Cc: Peter Ujfalusi Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/thermal/ti-soc-thermal/ti-bandgap.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/ti-soc-thermal/ti

[PATCH 2/4] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430

2021-02-05 Thread Tony Lindgren
to use iopoll in the following clean-up patch. Cc: Adam Ford Cc: Carl Philipp Klemm Cc: Eduardo Valentin Cc: H. Nikolaus Schaller Cc: Merlijn Wajer Cc: Pavel Machek Cc: Peter Ujfalusi Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- drivers/thermal/ti-soc-thermal/omap4-thermal-data.c

[PATCHv2 0/4] Thermal fixes for omaps for single mode read

2021-02-05 Thread Tony Lindgren
- Fix issues for omap3 as noted by Adam - Fix handling for dra7 Tony Lindgren (4): thermal: ti-soc-thermal: Skip pointless register access for dra7 thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430 thermal: ti-soc-thermal: Simplify polling with iopoll thermal: ti-soc

Re: [PATCH] bus: omap_l3_noc: mark l3 irqs as IRQF_NO_THREAD

2021-02-03 Thread Tony Lindgren
* Grygorii Strashko [210128 21:16]: > The main purpose of l3 IRQs is to catch OCP bus access errors and identify > corresponding code places by showing call stack, so it's important to > handle L3 interconnect errors as fast as possible. On RT these IRQs will > became threaded and will be

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

2021-02-03 Thread Tony Lindgren
* Drew Fustini [210127 02:04]: > Based on linux-gpio discussion [1], it is best practice to make the > gpio-line-names unique. Generic names like "[ethernet]" are replaced > with the name of the unique signal on the AM3358 SoC ball corresponding > to the gpio line. "[NC]" is also renamed to the

Re: [PATCH] ARM: dts: am33xx: add aliases for mmc interfaces

2021-02-03 Thread Tony Lindgren
* Måns Rullgård [210129 11:40]: > Tony Lindgren writes: > > > * Mans Rullgard [210128 18:09]: > >> Without DT aliases, the numbering of mmc interfaces is unpredictable. > >> Adding them makes it possible to refer to devices consistently. The > >> po

Re: [PATCHv1] ASoC: cpcap: fix microphone timeslot mask

2021-01-30 Thread Tony Lindgren
only see the header and no data.. DEV=0 won't produce anything, maybe I have the alsamixer settings wrong. Let me know if you want me to try something else. I do have the pending voice call patches applied on top, voice calls work just fine with your patch. So as it looks correct to me: Reviewed-by: Tony Lindgren

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-28 Thread Tony Lindgren
* Geert Uytterhoeven [210128 09:32]: > It wasn't. The regression is that the driver no longer probes at first > try, because its dependencies are now probed later. The question is: > why are the dependencies now probed later? How to fix that? I'm afraid that may be unfixable.. It depends on

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-28 Thread Tony Lindgren
Hi, * Michael Walle [210125 19:52]: > Although I do have the changes for the builtin_platform_driver_probe() > ready, I don't think it makes much sense to send these unless we agree > on the increased memory footprint. While there are just a few > builtin_platform_driver_probe() and memory

Re: [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card

2021-01-27 Thread Tony Lindgren
* Péter Ujfalusi [210126 06:00]: > On 1/24/21 11:27 AM, Pavel Machek wrote: > > From: Tony Lindgren > > + for (i = 0; i < mcbsp->dai_count; i++) { > > + struct snd_soc_dai_driver *dai = >dais[i]; > > + > > + dai->name = dev

[PATCH 3/3] bus: ti-sysc: Detect more modules for debugging

2021-01-26 Thread Tony Lindgren
We want to see what the interconnect target module names are for debugging. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c

[PATCH 0/3] Few ti-sysc changes for v5.12 merge window

2021-01-26 Thread Tony Lindgren
Hi, Here are few ti-sysc changes to mostly to have l4_wkup and l4_cfg interconnects before l4_per interconnects. Regards, Tony Tony Lindgren (3): bus: ti-sysc: Fix initializing module_pa for modules without sysc register bus: ti-sysc: Probe for l4_wkup and l4_cfg interconnect devices

[PATCH 2/3] bus: ti-sysc: Probe for l4_wkup and l4_cfg interconnect devices first

2021-01-26 Thread Tony Lindgren
We want to probe l4_wkup and l4_cfg interconnect devices first to avoid issues with missing resources. Otherwise we attempt to probe l4_per devices first causing pointless deferred probe and also annoyingh renumbering of the MMC devices for example. Signed-off-by: Tony Lindgren --- drivers/bus

[PATCH 1/3] bus: ti-sysc: Fix initializing module_pa for modules without sysc register

2021-01-26 Thread Tony Lindgren
pport modules without control registers") Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -856,15 +856,15

Re: [PATCH] ARM: dts: omap3-igep: Change email address in copyright notice

2021-01-26 Thread Tony Lindgren
* Javier Martinez Canillas [210118 10:17]: > I've switched employer a long time ago and the mentioned email address no > longer exists. Use my personal address to prevent the issue in the future. Thanks applying into omap-for-v5.12/dt. Tony

Re: [PATCH] arm/mach-omap2: fix spellint typo

2021-01-26 Thread Tony Lindgren
* Wang Qing [200917 10:49]: > Change the comment typo: "ununsed" -> "unused". Sorry looks like this is still pending, applying into omap-for-v5.12/soc. Thanks, Tony

Re: [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants

2021-01-26 Thread Tony Lindgren
* Adam Ford [210109 19:01]: > Previously, the 1GHz variants were marked as a turbo, > because that variant has reduced thermal operating range. > > Now that the thermal throttling is in place, it should be > safe to remove the turbo-mode from the 1GHz variants, because > the CPU will

Re: [PATCH] ARM: dts: omap3-echo: Add speaker sound card support

2021-01-26 Thread Tony Lindgren
* André Hentschel [201227 19:18]: > This adds audio playback to the first generation Amazon Echo > > Signed-off-by: André Hentschel > --- > > It took me by far too long to get this working as the codec sets one > important bit based on the > combination of provided supplies. That was just too

  1   2   3   4   5   6   7   8   9   10   >