Re: [Outreachy kernel] Re: [PATCH 1/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

On Thu, Apr 8, 2021 at 7:41 PM ascordeiro wrote: > > Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu: > > Ola Aline, > Ola Ezequiel, > > > Welcome to the kernel community. Hope you enjoy some of this > > Outreachy adventures. > Thank you! > > > Normally, when you submit a v2, we want

Re: [Outreachy kernel] [PATCH v3] staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h

On Wed, Apr 7, 2021 at 10:49 AM Fabio M. De Francesco wrote: > > On Wednesday, April 7, 2021 10:18:13 AM CEST Greg KH wrote: > > On Tue, Apr 06, 2021 at 06:00:37PM +0200, Fabio M. De Francesco wrote: > > > Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols > > > are not used

Re: [Outreachy kernel] [PATCH] staging: iio: cdc: remove repeated word

On Mon, Apr 5, 2021 at 12:24 AM David Villasana Jiménez wrote: > > Fix checkpatch warning: > WARNING: Possible repeated word: 'from' You don't need to include the checkpatch warning in the commit log. Your commit log should just be able to give enough information about why you're doing this

Re: [PATCH v2] soc: qcom: socinfo: Annotate switch cases with fall through

custom attributes") > Reported-by: Stephen Rothwell > Signed-off-by: Bjorn Andersson Acked-by: Vaishali Thakkar > --- > drivers/soc/qcom/socinfo.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.

[PATCH v6 3/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struct, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v5: -No code changes, fix diff.context setting for formatting patches. Version 5 was adding context at the bottom of the file

[PATCH v6 5/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v5: - No code changes, fix diff.context setting for formatting patches. Version 5

[PATCH v6 2/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd Reviewed-by: Bjorn Andersson --- Changes since v5: - No code changes, fix

[PATCH v6 4/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v5: - No code changes, fix my diff.context setting for formatting patches. Version 5

[PATCH v6 1/5] base: soc: Add serial_number attribute to soc

le standardized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd --- Changes since v5: - No code changes, fix diff.context setting for formatting patches. Version 5 was adding c

[PATCH v6 0/5] soc: qcom: Add SoC info driver

ing patches. Version 4 was adding context at the bottom of the file with 'git am'. Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc base: soc: Export soc_device_register/unregister APIs soc: qcom: Add socinfo driver soc: qcom: socinfo: Expose custom attribu

[PATCH v5 0/5] soc: qcom: Add SoC info driver

nch of nitpick fixes in patch 3 - Major refactoring for using core debugfs functions and eliminating duplicate code in patch 4 and 5 [detailed info can be found under --- in each patch] Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc base: soc: Exp

[PATCH v5 5/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v4: - Reduce number of duplicate image macros and functions - Introduce array

[PATCH v5 2/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd Reviewed-by: Bjorn Andersson --- Changes since v4: - Add Bjorn and Stephen's

[PATCH v5 3/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struct, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v4: - Return PTR_ERR in qcom_socinfo_probe instead of error value - Return PTR_ERR in smem probe to print proper error message

[PATCH v5 4/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v4: - Introduce socinfo_params and use create_debugfs_{u32,x32} instead of driver

[PATCH v5 1/5] base: soc: Add serial_number attribute to soc

le standardized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman Reviewed-by: Stephen Boyd --- Changes since v4: - Add Stephen's reviewed-by Changes since v3: - Add Greg's Reviewed-by Changes since v2: - N

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

On Mon, 25 Mar 2019 at 21:31, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-03-24 10:42:36) > > On Sat, 23 Mar 2019 at 05:31, Stephen Boyd wrote: > > > > > debugfs_create_devm_seqfile() which may work to print a string from some > > > struct m

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

On Sat, 23 Mar 2019 at 05:31, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-03-20 22:51:20) > > On Thu, 14 Mar 2019 at 21:28, Stephen Boyd wrote: > > > > > > Quoting Vaishali Thakkar (2019-03-14 04:25:16) > > > > On Fri

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

On Thu, 14 Mar 2019 at 21:28, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-03-14 04:25:16) > > On Fri, 1 Mar 2019 at 03:02, Stephen Boyd wrote: > > > > > > Why can't we use the debugfs_create_u32 function? It would make things > > > clearer if

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

On Fri, 1 Mar 2019 at 03:02, Stephen Boyd wrote: > > Quoting Vaishali Thakkar (2019-02-24 22:50:43) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > > index 02078049fac7..ccadeba69a81 100644 > > --- a/drivers/soc/qcom/socinfo.c > > ++

[PATCH v4 0/5] soc: qcom: Add SoC info driver

: - Reorder patches [patch five -> patch two] Changes since v3: - Add reviewed-bys from Greg - Fix build warning when debugfs is disabled - Remove extra checks for dir creations in patch 5 Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc base:

[PATCH v4 2/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman --- Changes since v3: - Add Greg's reviewed-by Changes since v2: - Reorder patches [patch 5

[PATCH v4 5/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v3: - Remove extra debugfs directory creation checks Changes since v2: - None

[PATCH v4 3/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struc, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v3: - None Changes since v2: - Fix typo in the work log under signed off by s Changes since v1: - None --- drivers/soc/qcom

[PATCH v4 1/5] base: soc: Add serial_number attribute to soc

le standardized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar Reviewed-by: Greg Kroah-Hartman --- Changes since v3: - Add Greg's Reviewed-by Changes since v2: - None Changes since v1: - Make comment more clear for the case when ser

[PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v3: - Fix compilation error in function signatures when debugfs is disabled Changes

Re: [PATCH v3 5/5] soc: qcom: socinfo: Expose image information

On Thu, 21 Feb 2019 at 22:04, Greg KH wrote: > > On Thu, Feb 21, 2019 at 09:54:19PM +0530, Vaishali Thakkar wrote: > > static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo) > > { > > + struct smem_image_version *smem_image_versio

[PATCH v3 0/5] soc: qcom: Add SoC info driver

: - Reorder patches [patch five -> patch two] Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc base: soc: Export soc_device_register/unregister APIs soc: qcom: Add socinfo driver soc: qcom: socinfo: Expose custom attributes soc: qcom: socinfo: Expose image informat

[PATCH v3 5/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v2: - None Changes since v1: - None --- drivers/soc/qcom/socinfo.c | 210

[PATCH v3 3/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struct, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v2: - Fix typo in the work log under signed off by s Changes since v1: - None --- drivers/soc/qcom/Kconfig | 8 ++ drivers/soc/qcom

[PATCH v3 2/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar --- Changes since v2: - Reordered patches [patch 5->patch 2] Changes since v1: - None --- drivers/base/soc.c | 2 ++ 1 f

[PATCH v3 4/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v2: - None Changes since v1: - Remove unnecessary debugfs dir creation check

[PATCH v3 1/5] base: soc: Add serial_number attribute to soc

le standardized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar --- Changes since v2: - None Changes since v1: - Make comment more clear for the case when serial number is not available --- Documentation/ABI/testing/sysfs-devices-soc | 7 +++

Re: [PATCH v2 5/5] base: soc: Export soc_device_register/unregister APIs

On Wed, 20 Feb 2019 at 12:25, Greg KH wrote: > > On Wed, Feb 20, 2019 at 10:29:46AM +0530, Vaishali Thakkar wrote: > > From: Vinod Koul > > > > Qcom Socinfo driver can be built as a module, so > > export these two APIs. > > > > Signed-off-by: Vinod

[PATCH v2 5/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar --- Changes since v1: - None --- drivers/base/soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/soc.c b/drivers

[PATCH v2 2/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struc, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- Changes since v1: - None --- drivers/soc/qcom/Kconfig | 8 ++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/smem.c| 8 ++ drivers/soc/qcom

[PATCH v2 3/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Changes since v1: - Remove unnecessary debugfs dir creation check - Align ifdefs to left - Fix

[PATCH v2 4/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- Changes since v1: - None --- drivers/soc/qcom/socinfo.c | 210 + 1

[PATCH v2 0/5] soc: qcom: Add SoC info driver

cleanly applies on top of v5.0-rc6. Changes since v1: - Align ifdefs to left, remove unnecessary debugfs dir creation check and fix function signatures in patch 3 - Fix comment for teh case when serial number is not available in patch 1 Vaishali Thakkar (5

[PATCH v2 1/5] base: soc: Add serial_number attribute to soc

le standardized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar --- Changes since v1: - Make comment more clear for the case when serial number is not available --- Documentation/ABI/testing/sysfs-devices-soc | 7 +++ drivers/base/soc.c

Re: [Outreachy kernel] [PATCH] net: dsa: add missing of_node_put

On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote: > Hi Himadri, Thanks for the patch! For the scope of Outreachy, we prefer that you send patches in staging directory as Greg makes sure to pick them during the application period. Of course, you're very much encouraged to contribute to

[PATCH 5/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul Qcom Socinfo driver can be built as a module, so export these two APIs. Signed-off-by: Vinod Koul Signed-off-by: Vaishali Thakkar --- drivers/base/soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/soc.c b/drivers/base/soc.c index b0933b9fe67f

[PATCH 1/5] base: soc: Add serial_number attribute to soc

le standardized name for this property. Signed-off-by: Bjorn Andersson Signed-off-by: Vaishali Thakkar --- Documentation/ABI/testing/sysfs-devices-soc | 7 +++ drivers/base/soc.c | 7 +++ include/linux/sys_soc.h | 1 + 3 files changed, 15 inser

[PATCH 4/5] soc: qcom: socinfo: Expose image information

The socinfo driver provides information about version of the various images loaded in the system. Expose this to user space for debugging purpose. Signed-off-by: Vaishali Thakkar --- drivers/soc/qcom/socinfo.c | 210 + 1 file changed, 210 insertions(+) diff

[PATCH 3/5] soc: qcom: socinfo: Expose custom attributes

The Qualcomm socinfo provides a number of additional attributes, add these to the socinfo driver and expose them via debugfs functionality. Signed-off-by: Vaishali Thakkar --- Note that this may have some 80 char checkpatch warnings as fixing them makes code less readable. --- drivers/soc/qcom

[PATCH 2/5] soc: qcom: Add socinfo driver

, introduce qcom_socinfo struc, Fix memory leak, Remove extra code and Misc code refactoring] Signed-off-by: Vaishali Thakkar --- drivers/soc/qcom/Kconfig | 8 ++ drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/smem.c| 8 ++ drivers/soc/qcom/socinfo.c | 197

[PATCH 0/5] soc: qcom: Add SoC info driver

cleanly applies on top of v5.0-rc6. Vaishali Thakkar (5): base: soc: Add serial_number attribute to soc soc: qcom: Add socinfo driver soc: qcom: socinfo: Expose custom attributes soc: qcom: socinfo: Expose image information base: soc: Export soc_device_register/unregister APIs

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

On Thu, Apr 26, 2018 at 6:15 PM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Daniel, > > On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote: >> On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote: >> > It's been a while s

Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

On Thu, Apr 26, 2018 at 6:15 PM, Laurent Pinchart wrote: > Hi Daniel, > > On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote: >> On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote: >> > It's been a while since we introduced drm_dev{get/put} f

[PATCH] drm/core: Remove drm_dev_unref() and it's uses

for mass-patching. Signed-off-by: Vaishali Thakkar <vthakkar1...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 4 ++-- drivers/gpu/drm/arc/arcpgu_drv.c | 4 ++-- drivers/gpu/drm/armada/armada_drv.c| 6 +++--- drivers/gpu/drm/atmel

[PATCH] drm/core: Remove drm_dev_unref() and it's uses

for mass-patching. Signed-off-by: Vaishali Thakkar --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 4 ++-- drivers/gpu/drm/arc/arcpgu_drv.c | 4 ++-- drivers/gpu/drm/armada/armada_drv.c| 6 +++--- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4

Re: [PATCH] drm: rcar-du: Use drm_dev_put

On Wed, Apr 25, 2018 at 7:02 PM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Vaishali, > > Thank you for the patch. > > On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote: >> As specified in drm_drv.c, drm_dev_unref is a compatibili

Re: [PATCH] drm: rcar-du: Use drm_dev_put

On Wed, Apr 25, 2018 at 7:02 PM, Laurent Pinchart wrote: > Hi Vaishali, > > Thank you for the patch. > > On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote: >> As specified in drm_drv.c, drm_dev_unref is a compatibility alias >> for drm_dev_put and should

[PATCH] drm: rcar-du: Use drm_dev_put

As specified in drm_drv.c, drm_dev_unref is a compatibility alias for drm_dev_put and shouldn't be used in new code. So, use drm_dev_put instead. Signed-off-by: Vaishali Thakkar <vthakkar1...@gmail.com> --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] drm: rcar-du: Use drm_dev_put

As specified in drm_drv.c, drm_dev_unref is a compatibility alias for drm_dev_put and shouldn't be used in new code. So, use drm_dev_put instead. Signed-off-by: Vaishali Thakkar --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] drm/vc4: make function vc4_allocate_bin_bo static

Sparse complains with following warning: drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol 'vc4_allocate_bin_bo' was not declared. Should it be static? Make vc4_allocate_bin static as it is not used outside of vc4_v3d.c. Signed-off-by: Vaishali Thakkar <vthakkar1...@gmail.com> --- d

[PATCH] drm/vc4: make function vc4_allocate_bin_bo static

Sparse complains with following warning: drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol 'vc4_allocate_bin_bo' was not declared. Should it be static? Make vc4_allocate_bin static as it is not used outside of vc4_v3d.c. Signed-off-by: Vaishali Thakkar --- drivers/gpu/drm/vc4/vc4_v3d.c | 3

[PATCH v2] Coccinelle: api: Add offset_in_page.cocci

Use of offset_in_page is preferable instead of open coding. This patch adds coccinelle script for suggesting the use of macro offset_in_page. Signed-off-by: Vaishali Thakkar <vaishali.thak...@oracle.com> --- Changes since v1: - Add parenthesis around rule for patch mode to

[PATCH v2] Coccinelle: api: Add offset_in_page.cocci

Use of offset_in_page is preferable instead of open coding. This patch adds coccinelle script for suggesting the use of macro offset_in_page. Signed-off-by: Vaishali Thakkar --- Changes since v1: - Add parenthesis around rule for patch mode to avoid extra parenthesis in end

[PATCH] Coccinelle: api: Add offset_in_page.cocci

Use of offset_in_page is preferable instead of open coding. This patch adds coccinelle script for suggesting the use of macro offset_in_page. Signed-off-by: Vaishali Thakkar <vaishali.thak...@oracle.com> --- scripts/coccinelle/api/offset_in_page.cocci | 77 +

[PATCH] Coccinelle: api: Add offset_in_page.cocci

Use of offset_in_page is preferable instead of open coding. This patch adds coccinelle script for suggesting the use of macro offset_in_page. Signed-off-by: Vaishali Thakkar --- scripts/coccinelle/api/offset_in_page.cocci | 77 + 1 file changed, 77 insertions

Re: [Outreachy kernel] Re: [PATCH v2 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

On Sun, Mar 5, 2017 at 10:10 AM, SIMRAN SINGHAL wrote: > On Sun, Mar 5, 2017 at 5:36 AM, Alison Schofield wrote: >> On Thu, Mar 02, 2017 at 02:26:37PM +0100, Noralf Trønnes wrote: >>> >>> Den 02.03.2017 14.04, skrev simran singhal: >>> >This patch

Re: [Outreachy kernel] Re: [PATCH v2 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

On Sun, Mar 5, 2017 at 10:10 AM, SIMRAN SINGHAL wrote: > On Sun, Mar 5, 2017 at 5:36 AM, Alison Schofield wrote: >> On Thu, Mar 02, 2017 at 02:26:37PM +0100, Noralf Trønnes wrote: >>> >>> Den 02.03.2017 14.04, skrev simran singhal: >>> >This patch fixes the following sparse warnings: >>> > >>>

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

On Wednesday 11 January 2017 05:34 AM, Kees Cook wrote: On Tue, Jan 10, 2017 at 1:14 PM, Julia Lawall wrote: OK, I have the impression that what you are looking for is the following, that currently does not seem to work well. Still maybe it gives an idea. The basic

Re: [Cocci] [RFC] coccicheck: add a test for repeat memory fetches

On Wednesday 11 January 2017 05:34 AM, Kees Cook wrote: On Tue, Jan 10, 2017 at 1:14 PM, Julia Lawall wrote: OK, I have the impression that what you are looking for is the following, that currently does not seem to work well. Still maybe it gives an idea. The basic pattern is the following

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

On Tuesday 10 January 2017 02:32 PM, Pengfei Wang wrote: 在 2017年1月10日，下午4:40，Vaishali Thakkar <vaishali.thak...@oracle.com> 写道： On Tuesday 10 January 2017 01:51 PM, Pengfei Wang wrote: 在 2017年1月10日，上午1:05，Vaishali Thakkar <vaishali.thak...@oracle.com> 写道： On Tuesday 27 Decembe

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

On Tuesday 10 January 2017 02:32 PM, Pengfei Wang wrote: 在 2017年1月10日，下午4:40，Vaishali Thakkar 写道： On Tuesday 10 January 2017 01:51 PM, Pengfei Wang wrote: 在 2017年1月10日，上午1:05，Vaishali Thakkar 写道： On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

On Tuesday 10 January 2017 01:51 PM, Pengfei Wang wrote: 在 2017年1月10日，上午1:05，Vaishali Thakkar <vaishali.thak...@oracle.com> 写道： On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball on this. Many thanks to Vaishali for resurrecting it. Some c

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

On Tuesday 10 January 2017 01:51 PM, Pengfei Wang wrote: 在 2017年1月10日，上午1:05，Vaishali Thakkar 写道： On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball on this. Many thanks to Vaishali for resurrecting it. Some changes are suggested below. On Tue, 26 Apr

Re: [RFC] coccicheck: add a test for repeat memory fetches

On Tue, Jan 10, 2017 at 1:31 PM, Julia Lawall wrote: > > > On Tue, 10 Jan 2017, Pengfei Wang wrote: > >> >> > 在 2017年1月10日，下午2:06，Julia Lawall 写道： >> > >> > >> > >> > On Mon, 9 Jan 2017, Kees Cook wrote: >> > >> >> Okay, this adds a few tests, for

Re: [RFC] coccicheck: add a test for repeat memory fetches

On Tue, Jan 10, 2017 at 1:31 PM, Julia Lawall wrote: > > > On Tue, 10 Jan 2017, Pengfei Wang wrote: > >> >> > 在 2017年1月10日，下午2:06，Julia Lawall 写道： >> > >> > >> > >> > On Mon, 9 Jan 2017, Kees Cook wrote: >> > >> >> Okay, this adds a few tests, for people to examine. >> >> >> >>

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball on this. Many thanks to Vaishali for resurrecting it. Some changes are suggested below. On Tue, 26 Apr 2016, Kees Cook wrote: This is usually a sign of a resized request. This adds a check for potential

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball on this. Many thanks to Vaishali for resurrecting it. Some changes are suggested below. On Tue, 26 Apr 2016, Kees Cook wrote: This is usually a sign of a resized request. This adds a check for potential

[PATCH v4 1/3] Coccinelle: misc: Improve the matching of rules

. Signed-off-by: Vaishali Thakkar <vaishali.thak...@oracle.com> --- Changes since v3: - Few more changes in the script to avoid some possible false positives - Moved initialization of all expressions in a single line Changes since v2: - No change in this

[PATCH v4 1/3] Coccinelle: misc: Improve the matching of rules

. Signed-off-by: Vaishali Thakkar --- Changes since v3: - Few more changes in the script to avoid some possible false positives - Moved initialization of all expressions in a single line Changes since v2: - No change in this patch Changes since v1

[PATCH v4 0/3] Coccinelle: misc: Improve the script for more accurate results

patch in to the patchset Vaishali Thakkar (3): Coccinelle: misc: Improve the matching of rules Coccinelle: misc: Improve the result given by context mode Coccinelle: misc: Add support for devm variant in all modes scripts/coccinelle/misc/irqf_oneshot.cocci | 52

[PATCH v4 0/3] Coccinelle: misc: Improve the script for more accurate results

patch in to the patchset Vaishali Thakkar (3): Coccinelle: misc: Improve the matching of rules Coccinelle: misc: Improve the result given by context mode Coccinelle: misc: Add support for devm variant in all modes scripts/coccinelle/misc/irqf_oneshot.cocci | 52

[PATCH v4 2/3] Coccinelle: misc: Improve the result given by context mode

To eliminate false positives given by the context mode, add necessary arguments for the function request_threaded_irq. Signed-off-by: Vaishali Thakkar <vaishali.thak...@oracle.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> --- Changes since v3: - No changes in this patch C

[PATCH v4 2/3] Coccinelle: misc: Improve the result given by context mode

To eliminate false positives given by the context mode, add necessary arguments for the function request_threaded_irq. Signed-off-by: Vaishali Thakkar Acked-by: Julia Lawall --- Changes since v3: - No changes in this patch Changes since v2: - Add missing declaration

[PATCH v4 3/3] Coccinelle: misc: Add support for devm variant in all modes

Add missing support for the devm_request_threaded_irq in the rules of context, report and org modes. Misc: To be consistent with other scripts, change confidence level of the script to 'Moderate'. Signed-off-by: Vaishali Thakkar <vaishali.thak...@oracle.com> Acked-by: Julia

[PATCH v4 3/3] Coccinelle: misc: Add support for devm variant in all modes

Add missing support for the devm_request_threaded_irq in the rules of context, report and org modes. Misc: To be consistent with other scripts, change confidence level of the script to 'Moderate'. Signed-off-by: Vaishali Thakkar Acked-by: Julia Lawall --- Changes since v3

Re: [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules

On Saturday 12 November 2016 11:36 PM, Julia Lawall wrote: > > > On Mon, 24 Oct 2016, Vaishali Thakkar wrote: > >> Currently because of the left associativity of the operators, pattern >> IRQF_ONESHOT | flags does not match with the pattern when we have mor

Re: [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules

On Saturday 12 November 2016 11:36 PM, Julia Lawall wrote: > > > On Mon, 24 Oct 2016, Vaishali Thakkar wrote: > >> Currently because of the left associativity of the operators, pattern >> IRQF_ONESHOT | flags does not match with the pattern when we have mor

Re: Failing of the script get_maintainer.pl

On Wednesday 02 November 2016 10:28 PM, Joe Perches wrote: > On Wed, 2016-11-02 at 22:07 +0530, Vaishali Thakkar wrote: >> Hi, >> >> The script get_maintainer.pl fails with the following message/warning: >> >> Unrecognized character \xA0; marked by <

Re: Failing of the script get_maintainer.pl

On Wednesday 02 November 2016 10:28 PM, Joe Perches wrote: > On Wed, 2016-11-02 at 22:07 +0530, Vaishali Thakkar wrote: >> Hi, >> >> The script get_maintainer.pl fails with the following message/warning: >> >> Unrecognized character \xA0; marked by <

Failing of the script get_maintainer.pl

Hi, The script get_maintainer.pl fails with the following message/warning: Unrecognized character \xA0; marked by <-- HERE after <-- HERE near column 1 at scripts/get_maintainer.pl line 277. This seems to be because of the commit b67071653d3fc9f9b73aab3e7978f060728bf392. Any idea about the

Failing of the script get_maintainer.pl

Hi, The script get_maintainer.pl fails with the following message/warning: Unrecognized character \xA0; marked by <-- HERE after <-- HERE near column 1 at scripts/get_maintainer.pl line 277. This seems to be because of the commit b67071653d3fc9f9b73aab3e7978f060728bf392. Any idea about the

[PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules

. Signed-off-by: Vaishali Thakkar <vaishali.thak...@oracle.com> --- Changes since v2: - No change in this patch Changes since v1: - Splitted patch in the patchset --- scripts/coccinelle/misc/irqf_oneshot.cocci | 30 -- 1 file changed, 24 insertions

[PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules

. Signed-off-by: Vaishali Thakkar --- Changes since v2: - No change in this patch Changes since v1: - Splitted patch in the patchset --- scripts/coccinelle/misc/irqf_oneshot.cocci | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git

[PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes

Add missing support for the devm_request_threaded_irq in the rules of context, report and org modes. Misc: To be consistent with other scripts, change confidence level of the script to 'Moderate'. Signed-off-by: Vaishali Thakkar <vaishali.thak...@oracle.com> --- Changes si

[PATCH v3 3/3] Coccinelle: misc: Add support for devm variant in all modes

Add missing support for the devm_request_threaded_irq in the rules of context, report and org modes. Misc: To be consistent with other scripts, change confidence level of the script to 'Moderate'. Signed-off-by: Vaishali Thakkar --- Changes since v2: - Add missing initialization

[PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode

To eliminate false positives given by the context mode, add necessary arguments for the function request_threaded_irq. Signed-off-by: Vaishali Thakkar <vaishali.thak...@oracle.com> --- Changes since v2: - Add missing declaration of metavariable irq Changes since v1: - Split

[PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode

To eliminate false positives given by the context mode, add necessary arguments for the function request_threaded_irq. Signed-off-by: Vaishali Thakkar --- Changes since v2: - Add missing declaration of metavariable irq Changes since v1: - Split patch in to the patch set

[PATCH v3 0/3] Coccinelle: misc: Improve the script for more accurate results

and org mode Changes since v2: - Add missing initialization of metavariables Changes since v1: - Split patch in to the patchset Vaishali Thakkar (3): Coccinelle: misc: Improve the matching of rules Coccinelle: misc: Improve the result given by context mode Coccinelle: misc

[PATCH v3 0/3] Coccinelle: misc: Improve the script for more accurate results

and org mode Changes since v2: - Add missing initialization of metavariables Changes since v1: - Split patch in to the patchset Vaishali Thakkar (3): Coccinelle: misc: Improve the matching of rules Coccinelle: misc: Improve the result given by context mode Coccinelle: misc

Re: [PATCH v2 3/3] Coccinelle: misc: Add support for devm variant in all modes

On Tuesday 18 October 2016 10:40 PM, Julia Lawall wrote: > > > On Tue, 18 Oct 2016, Vaishali Thakkar wrote: > >> >> >> On Sunday 16 October 2016 10:37 PM, Vaishali Thakkar wrote: >>> Add missing support for the devm_request_threaded_irq in >>

Re: [PATCH v2 3/3] Coccinelle: misc: Add support for devm variant in all modes

On Tuesday 18 October 2016 10:40 PM, Julia Lawall wrote: > > > On Tue, 18 Oct 2016, Vaishali Thakkar wrote: > >> >> >> On Sunday 16 October 2016 10:37 PM, Vaishali Thakkar wrote: >>> Add missing support for the devm_request_threaded_irq in >>

Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results

On Tuesday 18 October 2016 10:31 PM, Julia Lawall wrote: > > > On Tue, 18 Oct 2016, Vaishali Thakkar wrote: > >> >> >> On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote: >>> I get the following in patch mode that I don't get in context mode: >

Re: [PATCH v2 0/3] Coccinelle: misc: Improve the script for more accurate results

On Tuesday 18 October 2016 10:31 PM, Julia Lawall wrote: > > > On Tue, 18 Oct 2016, Vaishali Thakkar wrote: > >> >> >> On Tuesday 18 October 2016 10:04 PM, Julia Lawall wrote: >>> I get the following in patch mode that I don't get in context mode: >

Re: [PATCH v2 3/3] Coccinelle: misc: Add support for devm variant in all modes

On Sunday 16 October 2016 10:37 PM, Vaishali Thakkar wrote: > Add missing support for the devm_request_threaded_irq in > the rules of context, report and org modes. > > Misc: > > To be consistent with other scripts, change confidence level > of the script to 'Moder

  1   2   3   4   5   6   >