[PATCH] net: korina: cast KSEG0 address to pointer in kfree

Fixes gcc warning: passing argument 1 of 'kfree' makes pointer from integer without a cast Fixes: 3af5f0f5c74e ("net: korina: fix kfree of rx/tx descriptor array") Reported-by: kernel test robot Signed-off-by: Valentin Vidic --- drivers/net/ethernet/korina.c | 4 ++-- 1 file

[PATCH v2] net: korina: fix kfree of rx/tx descriptor array

kmalloc returns KSEG0 addresses so convert back from KSEG1 in kfree. Also make sure array is freed when the driver is unloaded from the kernel. Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") Signed-off-by: Valentin Vidic --- v2: convert kfree address bac

[PATCH] net: korina: free array used for rx/tx descriptors

Memory was not freed when driver is unloaded from the kernel. Signed-off-by: Valentin Vidic --- drivers/net/ethernet/korina.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 03e034918d14..99146145f020 100644 --- a/drivers

[PATCH] coding-style.rst: cleanup new text

Remove doubled word: "...than the parent and are are placed..." Signed-off-by: Valentin Vidic --- Documentation/process/coding-style.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding

[PATCH] s390/sclp_vt220: Fix console name to match device

Console name reported in /proc/consoles: ttyS1-W- (EC p )4:65 does not match device name: crw--w1 root root4, 65 May 17 12:18 /dev/ttysclp0 so debian-installer gets confused and fails to start. Signed-off-by: Valentin Vidic Cc: sta

[PATCH] net: usb: sr9800: fix uninitialized local variable

Make sure res does not contain random value if the call to sr_read_cmd fails for some reason. Reported-by: syzbot+f1842130bbcfb335b...@syzkaller.appspotmail.com Signed-off-by: Valentin Vidic --- drivers/net/usb/sr9800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] media: cxusb: fix uninitialized local variable

Make sure ircode does not contain random values if the call to cxusb_ctrl_msg fails for some reason. Reported-by: syzbot+98730b985cad4931a...@syzkaller.appspotmail.com Signed-off-by: Valentin Vidic --- drivers/media/usb/dvb-usb/cxusb.c | 8 1 file changed, 4 insertions(+), 4 deletions

[PATCH] usb: iowarrior: fix access to freed data structure

-off-by: Valentin Vidic --- drivers/usb/misc/iowarrior.c | 35 +++ 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index f5bed9f29e56..0492ea76c4bf 100644 --- a/drivers/usb/misc/iowarrior.c

[PATCH v3 4/4] staging: exfat: add millisecond support

Use create_time_ms and modify_time_ms fields to store the millisecond part of the file timestamp with the precision of 10 ms. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/staging

[PATCH v3 2/4] staging: exfat: drop duplicate date_time_t struct

Use timestamp_t for everything and cleanup duplicate code. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 35 +++--- drivers/staging/exfat/exfat_super.c | 158 2 files changed, 55 insertions(+), 138 deletions(-) diff --git a/drivers

[PATCH v3 1/4] staging: exfat: drop unused function parameter

sbi parameter not used inside the function so remove it. Also cleanup unused variables generated by this change. Signed-off-by: Valentin Vidic --- v2: split up into multiple patches v3: split up some more fix if statement braces add utc offset fields drivers/staging/exfat/exfat_super.c

[PATCH v3 3/4] staging: exfat: drop unused field access_time_ms

Spec defines that UtcOffset fields should start in this position instead. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 6 -- drivers/staging/exfat/exfat_core.c | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b

[PATCH v2 3/3] staging: exfat: add millisecond support

Use create_time_ms modify_time_ms fields to store the millisecond part of the file timestamp with the precision of 10 ms. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/staging

[PATCH v2 2/3] staging: exfat: drop unused field access_time_ms

Not used in the exfat-fuse implementation and spec defines this position should hold the value for CreateUtcOffset. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 3 +-- drivers/staging/exfat/exfat_core.c | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct

Use timestamp_t for everything and cleanup duplicate code. Signed-off-by: Valentin Vidic --- v2: split up into multiple patches drivers/staging/exfat/exfat.h | 35 +++--- drivers/staging/exfat/exfat_super.c | 174 2 files changed, 61 insertions(+), 148

[PATCH v3 1/3] staging: exfat: cleanup spacing for operators

Fixes checkpatch.pl warnings: CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Valentin Vidic --- v2: Use constants where

[PATCH v3 2/3] staging: exfat: cleanup spacing for casts

Fix checkpatch.pl warnings: CHECK: No space is necessary after a cast Signed-off-by: Valentin Vidic --- v2: Use constants where possible v3: Split up changes of constants drivers/staging/exfat/exfat_core.c | 88 ++--- drivers/staging/exfat/exfat_super.c | 66

[PATCH v3 3/3] staging: exfat: use integer constants

Replace manually generated values with predefined constants. Signed-off-by: Valentin Vidic --- v2: Use constants where possible v3: Split up changes of constants drivers/staging/exfat/exfat_core.c | 18 +- drivers/staging/exfat/exfat_super.c | 8 2 files changed, 13

[PATCH] staging: exfat: add millisecond support

Drop duplicated date_time_t struct and add millisecond handling for create and modify time. Also drop millisecond field for access time since it is not defined in the the spec. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 38 +++--- drivers/staging/exfat/exfat_core.c

[PATCH 2/2 v2] staging: exfat: cleanup casts

Use constants and fix checkpatch.pl warnings: CHECK: No space is necessary after a cast Signed-off-by: Valentin Vidic --- v2: Use constants where possible drivers/staging/exfat/exfat_core.c | 94 ++--- drivers/staging/exfat/exfat_super.c | 66 ++-- 2

[PATCH 1/2] staging: exfat: cleanup spacing for operators

Fixes checkpatch.pl warnings: CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '*' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Valentin Vidic --- drivers/staging/exfat

[PATCH 2/2] staging: exfat: cleanup spacing for casts

Fixes checkpatch.pl warnings: CHECK: No space is necessary after a cast Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 88 ++--- drivers/staging/exfat/exfat_super.c | 66 +++--- 2 files changed, 77 insertions(+), 77 deletions

[PATCH v2] staging: exfat: cleanup explicit comparisons to NULL

Fixes checkpatch.pl warnings: CHECK: Comparison to NULL could be written "expr" CHECK: Comparison to NULL could be written "!expr" Signed-off-by: Valentin Vidic --- v2: fix gcc warning in strsep call drivers/staging/exfat/exfat_core.c | 34 - d

[PATCH] staging: exfat: drop local TRUE/FALSE defines

Replace with bool where it makes sense. Also drop unused local variable lossy in fat_find_dir_entry. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 3 -- drivers/staging/exfat/exfat_core.c | 81 +++-- drivers/staging/exfat/exfat_nls.c | 2

[PATCH] staging: exfat: cleanup explicit comparisons to NULL

Fixes checkpatch.pl warnings: CHECK: Comparison to NULL could be written "expr" CHECK: Comparison to NULL could be written "!expr" Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 34 - drivers/staging/exfa

[PATCH] staging: exfat: fix spelling errors in comments

Fixes checkpatch.pl warnings: CHECK: 'consistancy' may be misspelled - perhaps 'consistency'? CHECK: 'stuct' may be misspelled - perhaps 'struct'? Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 2 +- drivers/staging/exfat/exfat_super.c | 2 +- 2 files changed, 2

[PATCH] staging: exfat: cleanup braces for if/else statements

Fixes checkpatch.pl warnings: CHECK: Unbalanced braces around else statement CHECK: braces {} should be used on all arms of this statement Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 12 ++-- drivers/staging/exfat/exfat_super.c | 16 +--- 2

[PATCH] staging: exfat: cleanup blank line warnings

Fixes checkpatch.pl warnings: CHECK: Please don't use multiple blank lines CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h

[PATCH] staging: exfat: use BIT macro for defining sizes

Fixes checkpatch.pl warning: CHECK: Prefer using the BIT macro Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index bae180e10609

Re: [PATCH] n_tty: update comment for WAKEUP_CHARS define

On Wed, Jan 02, 2019 at 07:48:42AM +0100, Jiri Slaby wrote: > On 29. 12. 18, 13:48, Valentin Vidic wrote: > > Give a better descriptions of what WAKEUP_CHARS represents. > > > > Signed-off-by: Valentin Vidic > > I am not a native speaker, but this is much b

[PATCH] n_tty: update comment for WAKEUP_CHARS define

Give a better descriptions of what WAKEUP_CHARS represents. Signed-off-by: Valentin Vidic --- drivers/tty/n_tty.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index 3ad460219fd6..1dfbd45746da 100644 --- a/drivers/tty/n_tty.c

Re: [PATCH] xen-blkback: Switch to closed state after releasing the backing device

On Wed, Sep 05, 2018 at 01:35:15PM +0200, Valentin Vidic wrote: > > AFAICT, this will cause the backend to never switch to 'Closed' state > > until the toolstack sets online to 0, which is not good IMO. > > > > If for example a frontend decides to close a device, t

Re: [PATCH] xen-blkback: Switch to closed state after releasing the backing device

On Wed, Sep 05, 2018 at 01:35:15PM +0200, Valentin Vidic wrote: > > AFAICT, this will cause the backend to never switch to 'Closed' state > > until the toolstack sets online to 0, which is not good IMO. > > > > If for example a frontend decides to close a device, t

[PATCH] staging: pi433: cleanup comments in rf69.h

Fixes checkpatch warning: WARNING: line over 80 characters Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h index c131ffbdc2db..d80c41966d39

[PATCH] staging: pi433: cleanup comments in rf69.h

Fixes checkpatch warning: WARNING: line over 80 characters Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h index c131ffbdc2db..d80c41966d39

[PATCH] staging: pi433: add SPDX-License-Identifier tag

Use GPL-2.0+ based on the license text in each of the files. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 1 + drivers/staging/pi433/pi433_if.h | 3 ++- drivers/staging/pi433/rf69.c | 1 + drivers/staging/pi433/rf69.h | 3 ++- drivers

[PATCH] staging: pi433: add SPDX-License-Identifier tag

Use GPL-2.0+ based on the license text in each of the files. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 1 + drivers/staging/pi433/pi433_if.h | 3 ++- drivers/staging/pi433/rf69.c | 1 + drivers/staging/pi433/rf69.h | 3 ++- drivers

[PATCH v3] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays v3: add missing static keyword for af_map drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions

[PATCH v3] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays v3: add missing static keyword for af_map drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions

[PATCH v2] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions(-) diff --git a/drivers/staging/pi433/rf69.c

[PATCH v2] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions(-) diff --git a/drivers/staging/pi433/rf69.c

[PATCH] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index

[PATCH] staging: pi433: replace simple switch statements

Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 233 ++- 1 file changed, 93 insertions(+), 140 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index

Re: rf69_set_deviation in rf69.c (pi433 driver)

On Thu, Jun 21, 2018 at 10:03:45PM -0400, Hugo Lefeuvre wrote: > I'll prepare a patch addressing both issues. However I don't own test devices > so it would be really great if you could test it ! I have two pi433 devices now so I should be able to tests things, just let me know... -- Valentin

Re: rf69_set_deviation in rf69.c (pi433 driver)

On Thu, Jun 21, 2018 at 10:03:45PM -0400, Hugo Lefeuvre wrote: > I'll prepare a patch addressing both issues. However I don't own test devices > so it would be really great if you could test it ! I have two pi433 devices now so I should be able to tests things, just let me know... -- Valentin

[PATCH v2] staging: pi433: cleanup tx_fifo locking

not require locking after kfifo_reset is removed. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: print a warning if partial fifo write happens drivers/staging/pi433/pi433_if.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/d

[PATCH v2] staging: pi433: cleanup tx_fifo locking

not require locking after kfifo_reset is removed. Signed-off-by: Valentin Vidic --- v2: print a warning if partial fifo write happens drivers/staging/pi433/pi433_if.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Thu, Apr 19, 2018 at 11:25:19AM +0200, Marcus Wolf wrote: > let me know, what you like to have. For sure with just one station and > no other 433MHz equipment, options for testing are quite limited. I can get Rpi3 and with two shields test 433MHz communication between Rpi2 and Rpi3. --

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Thu, Apr 19, 2018 at 11:25:19AM +0200, Marcus Wolf wrote: > let me know, what you like to have. For sure with just one station and > no other 433MHz equipment, options for testing are quite limited. I can get Rpi3 and with two shields test 433MHz communication between Rpi2 and Rpi3. --

[PATCH] staging: pi433: use help in Kconfig description

Fixes checkpatch warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/Kconfig b/drivers/s

[PATCH] staging: pi433: use help in Kconfig description

Fixes checkpatch warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/Kconfig b/drivers/staging/pi433/Kconfig index

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Apr 08, 2018 at 05:22:46PM +0200, Marcus Wolf wrote: > Regarding your patch, I did not understand, why you did not remove > the mutex_lock in pi433_write. Wasn't it the goal to remove it? Is it possible for more than one userspace program to open the pi433 device and send messages? In

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Apr 08, 2018 at 05:22:46PM +0200, Marcus Wolf wrote: > Regarding your patch, I did not understand, why you did not remove > the mutex_lock in pi433_write. Wasn't it the goal to remove it? Is it possible for more than one userspace program to open the pi433 device and send messages? In

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Apr 08, 2018 at 04:15:30PM +0200, Marcus Wolf wrote: > The hardware of Pi433 is working with every Raspberry Pi (on zero, you > need to solder the GPIO-pins) and with several other fruits like banana > pi. The only thing is, that you need different versions of the driver, > according to

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Apr 08, 2018 at 04:15:30PM +0200, Marcus Wolf wrote: > The hardware of Pi433 is working with every Raspberry Pi (on zero, you > need to solder the GPIO-pins) and with several other fruits like banana > pi. The only thing is, that you need different versions of the driver, > according to

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Mar 25, 2018 at 03:12:52PM +0200, Marcus Wolf wrote: > I am not at home the next two weeks. So I can do a codereading on > Easter, but testing will not take place earlier then mid/end of April :-( > > If you are interested, I can provide you an engineering sample of Pi433. Sure, let me

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Mar 25, 2018 at 03:12:52PM +0200, Marcus Wolf wrote: > I am not at home the next two weeks. So I can do a codereading on > Easter, but testing will not take place earlier then mid/end of April :-( > > If you are interested, I can provide you an engineering sample of Pi433. Sure, let me

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: > Unfortunaly I can't find the time to have a closer look on the code this > weekend - still busy with tax stuff :-( > > Idea sounds great. I'll try to look at the code and think about it > during Easter hollidays. No problem, there is

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: > Unfortunaly I can't find the time to have a closer look on the code this > weekend - still busy with tax stuff :-( > > Idea sounds great. I'll try to look at the code and think about it > during Easter hollidays. No problem, there is

[PATCH] staging: pi433: cleanup tx_fifo locking

so it does not require locking after kfifo_reset is also removed. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/d

[PATCH] staging: pi433: cleanup tx_fifo locking

so it does not require locking after kfifo_reset is also removed. Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index

[PATCH] kfifo: fix comment

Cleanup unusual formatting in the note about locking. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- include/linux/kfifo.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index e251533a5939..89fc8d

[PATCH] kfifo: fix comment

Cleanup unusual formatting in the note about locking. Signed-off-by: Valentin Vidic --- include/linux/kfifo.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index e251533a5939..89fc8dc7bf38 100644 --- a/include/linux

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 07:00:27PM +0100, Valentin Vidic wrote: > You are right, here is what kfifo.h says: > > /* > * Note about locking : There is no locking required until only * one reader > * and one writer is using the fifo and no kfifo_reset() will be * called > * kfi

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 07:00:27PM +0100, Valentin Vidic wrote: > You are right, here is what kfifo.h says: > > /* > * Note about locking : There is no locking required until only * one reader > * and one writer is using the fifo and no kfifo_reset() will be * called > * kfi

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 04:38:50PM +0100, Marcus Wolf wrote: > I had no time to work on the code for monthes now and the memorisation > of my thoughts when I was programming that (approx. one year ago) is > quite pale. > > As far as I remember, I read something, that the fifo has an integrated >

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 04:38:50PM +0100, Marcus Wolf wrote: > I had no time to work on the code for monthes now and the memorisation > of my thoughts when I was programming that (approx. one year ago) is > quite pale. > > As far as I remember, I read something, that the fifo has an integrated >

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 11:22:39AM +0100, Marcus Wolf wrote: > could you please decribe in short words, why you think, that hte lock > isn't obsolete? > > I wasn't sure, but close to remove the lock. That's why I putted the > comment. Sure, if pi433_tx_thread runs on one CPU it might be possible

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Fri, Mar 23, 2018 at 11:22:39AM +0100, Marcus Wolf wrote: > could you please decribe in short words, why you think, that hte lock > isn't obsolete? > > I wasn't sure, but close to remove the lock. That's why I putted the > comment. Sure, if pi433_tx_thread runs on one CPU it might be possible

[PATCH] staging: pi433: add descriptions for mutex locks

Removes TODO for tx_fifo_lock as tx_fifo is modified from both pi433_tx_thread and pi433_write. Fixes checkpatch warning: CHECK: struct mutex definition without comment Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file chan

[PATCH] staging: pi433: add descriptions for mutex locks

Removes TODO for tx_fifo_lock as tx_fifo is modified from both pi433_tx_thread and pi433_write. Fixes checkpatch warning: CHECK: struct mutex definition without comment Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH] staging: pi433: cleanup local variable

Rename temporary local variable and add required blank line. Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 7 --- 1 file changed, 4 insertions(+), 3 del

[PATCH] staging: pi433: cleanup local variable

Rename temporary local variable and add required blank line. Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 3/7] staging: pi433: fix CamelCase for syncSize variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index b2c549

[PATCH 3/7] staging: pi433: fix CamelCase for syncSize variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index b2c54999b022..b57d3f4e9321 100644

[PATCH 7/7] staging: pi433: fix CamelCase for dagc enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_

[PATCH 6/7] staging: pi433: fix CamelCase for lnaGain enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH 7/7] staging: pi433: fix CamelCase for dagc enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_enum.h | 4 ++-- 3 files

[PATCH 6/7] staging: pi433: fix CamelCase for lnaGain enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH 5/7] staging: pi433: fix CamelCase for DIONumber variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/d

[PATCH 5/7] staging: pi433: fix CamelCase for DIONumber variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index

[PATCH 2/7] staging: pi433: fix CamelCase for preambleLength variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 6 +++--- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/d

[PATCH 2/7] staging: pi433: fix CamelCase for preambleLength variable

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 6 +++--- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index

[PATCH 1/7] staging: pi433: fix CamelCase for GPIO functions

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_

[PATCH 1/7] staging: pi433: fix CamelCase for GPIO functions

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c

[PATCH 4/7] staging: pi433: fix CamelCase for bitRate variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 16 drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 9 insertions

[PATCH 4/7] staging: pi433: fix CamelCase for bitRate variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 16 drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH 2/6] staging: pi433: fix CamelCase for flag enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin

[PATCH 2/6] staging: pi433: fix CamelCase for flag enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin

[PATCH 5/6] staging: pi433: fix CamelCase for Address variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 4/6] staging: pi433: fix CamelCase for address_filtering enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 12 ++-- drivers/staging/pi433/pi433_if.c

[PATCH 5/6] staging: pi433: fix CamelCase for Address variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b

[PATCH 4/6] staging: pi433: fix CamelCase for address_filtering enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 12 ++-- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c

[PATCH 3/6] staging: pi433: fix CamelCase for afterSyncInterrupt

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 3/6] staging: pi433: fix CamelCase for afterSyncInterrupt

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 1/6 v2] staging: pi433: fix CamelCase for packetFormat enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: order patches so they apply correctly drivers/staging/pi433/pi433_if.c | 8 drivers/staging/pi433/

[PATCH 6/6] staging: pi433: fix CamelCase for paRamp enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH 6/6] staging: pi433: fix CamelCase for paRamp enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH 1/6 v2] staging: pi433: fix CamelCase for packetFormat enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- v2: order patches so they apply correctly drivers/staging/pi433/pi433_if.c | 8 drivers/staging/pi433/rf69.c | 8 drivers

[PATCH] staging: pi433: fix CamelCase for afterSyncInterrupt

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

  1   2   3   >