Re: [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is non-null

en assigning dsaf_dev. Fix this > by moving the initialisation of dsaf_dev once we know > ppe_cb->ppe_common_cb is OK to dereference. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Yisen Zhuang <yisen.zhu...@huawei.com>

Re: [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is non-null

Fix this > by moving the initialisation of dsaf_dev once we know > ppe_cb->ppe_common_cb is OK to dereference. > > Signed-off-by: Colin Ian King Acked-by: Yisen Zhuang

Re: [PATCH 1/1 linux-next] net: hns: fix typo in g_gmac_stats_string[]

Hi Fabian, This patch is fine to me, many thanks. Yisen 在 2016/8/10 23:48, Fabian Frederick 写道: > s/gamc/gmac/ > > Signed-off-by: Fabian Frederick > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 1/1 linux-next] net: hns: fix typo in g_gmac_stats_string[]

Hi Fabian, This patch is fine to me, many thanks. Yisen 在 2016/8/10 23:48, Fabian Frederick 写道: > s/gamc/gmac/ > > Signed-off-by: Fabian Frederick > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH v3 net-next 6/9] net: hns: normalize two different loop

From: Daode Huang <huangda...@hisilicon.com> There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zh

[PATCH v3 net-next 6/9] net: hns: normalize two different loop

From: Daode Huang There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 18 +- 1

[PATCH v3 net-next 4/9] net: hns: delete redundant parenthese

From: Daode Huang <huangda...@hisilicon.com> According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/

[PATCH v3 net-next 4/9] net: hns: delete redundant parenthese

From: Daode Huang According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v3 net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

he mac mode is obviously redundant. Reported-by: Jinchuan Tian <tianjinchu...@huawei.com> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 15 --- 1 file change

[PATCH v3 net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

redundant. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon

[PATCH v3 net-next 1/9] MAINTAINERS: add maintainers for hns driver

From: Daode Huang <huangda...@hisilicon.com> This patch adds maintainers for hisilicon network subsystem driver Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- change log: v3: match all files in and below dr

[PATCH v3 net-next 1/9] MAINTAINERS: add maintainers for hns driver

From: Daode Huang This patch adds maintainers for hisilicon network subsystem driver Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- change log: v3: match all files in and below drivers/net/ethernet/hisilicon/ v2: the same as v1 v1: first submit Link: https://lkml.org/lkml

[PATCH v3 net-next 2/9] net: hns: fix code style about hns driver

From: Daode Huang <huangda...@hisilicon.com> This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +

[PATCH v3 net-next 0/9] net: hns: fix the typo of hns

This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, as below: > from Daode: adds the maintainer for hns driver; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get

[PATCH v3 net-next 2/9] net: hns: fix code style about hns driver

From: Daode Huang This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/net

[PATCH v3 net-next 0/9] net: hns: fix the typo of hns

This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, as below: > from Daode: adds the maintainer for hns driver; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get

[PATCH v3 net-next 5/9] net: hns: add a space before "*/"

From: Daode Huang <huangda...@hisilicon.com> In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/

[PATCH v3 net-next 8/9] net: hns: add media-type property for hns

Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.h | 9 drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 + drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 26 +++ driver

[PATCH v3 net-next 5/9] net: hns: add a space before "*/"

From: Daode Huang In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 net-next 8/9] net: hns: add media-type property for hns

From: Kejian Yan It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon

[PATCH v3 net-next 9/9] net: hns: get reset registers from DT

From: Kejian Yan <yankej...@huawei.com> Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> -

[PATCH v3 net-next 9/9] net: hns: get reset registers from DT

From: Kejian Yan Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang --- change log: v2: fix the wrong indentations v1: first submit link: https

[PATCH v3 net-next 3/9] net: hns: change code style from a = a + x to a += x

ned-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_

[PATCH v3 net-next 3/9] net: hns: change code style from a = a + x to a += x

From: Daode Huang This patch fixes the code style in hns driver. Change it from "buff = buff + xxx" to "buff += xxx". The reveiw comments is from andy. Reviewed-by: Andriy Shevchenko Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/et

[PATCH v2 net-next 5/9] net: hns: add a space before "*/"

From: Daode Huang In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 net-next 5/9] net: hns: add a space before "*/"

From: Daode Huang In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 net-next 9/9] net: hns: get reset registers from DT

From: Kejian Yan Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan --- change log: v2: fix the wrong indentations v1: first submit link:

[PATCH v2 net-next 8/9] net: hns: add media-type property for hns

From: Kejian Yan It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan

[PATCH v2 net-next 9/9] net: hns: get reset registers from DT

From: Kejian Yan Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan --- change log: v2: fix the wrong indentations v1: first submit link: https://lkml.org/lkml/2016/6/27/182 ---

[PATCH v2 net-next 8/9] net: hns: add media-type property for hns

From: Kejian Yan It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan --- drivers/net/ethernet/hisilicon/hns/hnae.h | 9

[PATCH v2 net-next 3/9] net: hns: change code style from a = a + x to a += x

From: Daode Huang This patch fixes the code style in hns driver. Change it from "buff = buff + xxx" to "buff += xxx". The reveiw comments is from andy. Reviewed-by: Andriy Shevchenko Signed-off-by: Daode Huang

[PATCH v2 net-next 3/9] net: hns: change code style from a = a + x to a += x

From: Daode Huang This patch fixes the code style in hns driver. Change it from "buff = buff + xxx" to "buff += xxx". The reveiw comments is from andy. Reviewed-by: Andriy Shevchenko Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 32 +++---

[PATCH v2 net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

From: Kejian Yan The sequence of hns_mac_dev_to_enet_if() is the same as hns_get_enet_interface(), and hns_get_enet_interface() is called by initialization to get the mac mode. And the mode is not changed anywhere. Thus add hns_mac_dev_to_enet_if() function to get the mac

[PATCH v2 net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

From: Kejian Yan The sequence of hns_mac_dev_to_enet_if() is the same as hns_get_enet_interface(), and hns_get_enet_interface() is called by initialization to get the mac mode. And the mode is not changed anywhere. Thus add hns_mac_dev_to_enet_if() function to get the mac mode is obviously

[PATCH v2 net-next 1/9] MAINTAINERS: add maintainers for hns driver

1a9..c819659 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5421,6 +5421,15 @@ F: include/uapi/linux/if_hippi.h F: net/802/hippi.c F: drivers/net/hippi/ +HISILICON NETWORK SUBSYSTEM DRIVER +M: Yisen Zhuang <yisen.zhu...@huawei.com> +M: Salil Mehta <salil.me...@hu

[PATCH v2 net-next 0/9] net: hns: fix the typo of hns

This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, as below: > from Daode: adds the maintainer for hns driver; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get

[PATCH v2 net-next 1/9] MAINTAINERS: add maintainers for hns driver

+5421,15 @@ F: include/uapi/linux/if_hippi.h F: net/802/hippi.c F: drivers/net/hippi/ +HISILICON NETWORK SUBSYSTEM DRIVER +M: Yisen Zhuang +M: Salil Mehta +L: net...@vger.kernel.org +W: http://www.hisilicon.com +S: Maintained +F: drivers/net/ethernet

[PATCH v2 net-next 0/9] net: hns: fix the typo of hns

This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, as below: > from Daode: adds the maintainer for hns driver; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get

[PATCH v2 net-next 2/9] net: hns: fix code style about hns driver

From: Daode Huang This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff

[PATCH v2 net-next 2/9] net: hns: fix code style about hns driver

From: Daode Huang This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

[PATCH v2 net-next 6/9] net: hns: normalize two different loop

From: Daode Huang There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 18

[PATCH v2 net-next 6/9] net: hns: normalize two different loop

From: Daode Huang There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 18 +- 1 file changed, 9 insertions(+), 9

[PATCH v2 net-next 4/9] net: hns: delete redundant parenthese

From: Daode Huang According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 4 ++-- 1 file changed, 2

[PATCH v2 net-next 4/9] net: hns: delete redundant parenthese

From: Daode Huang According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH net-next 0/9] net: hns: fix the typo of hns

This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, > adds the maintainer for hns driver from Daode; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get configuration from

[PATCH net-next 1/9] MAINTAINERS: add maintainers for hns driver

1a9..c819659 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5421,6 +5421,15 @@ F: include/uapi/linux/if_hippi.h F: net/802/hippi.c F: drivers/net/hippi/ +HISILICON NETWORK SUBSYSTEM DRIVER +M: Yisen Zhuang <yisen.zhu...@huawei.com> +M: Salil Mehta <salil.me...@hu

[PATCH net-next 0/9] net: hns: fix the typo of hns

This series includes typo fixes which review by Andy, adding the hns maintainer to MAINTAINERS, > adds the maintainer for hns driver from Daode; > from Daode: fix the typo of hns reviewed by Andy Shevchenko; > from Kejian: one remove redundant function and two fix to get configuration from

[PATCH net-next 1/9] MAINTAINERS: add maintainers for hns driver

+5421,15 @@ F: include/uapi/linux/if_hippi.h F: net/802/hippi.c F: drivers/net/hippi/ +HISILICON NETWORK SUBSYSTEM DRIVER +M: Yisen Zhuang +M: Salil Mehta +L: net...@vger.kernel.org +W: http://www.hisilicon.com +S: Maintained +F: drivers/net/ethernet

[PATCH net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

From: Kejian Yan The sequence of hns_mac_dev_to_enet_if() is the same as hns_get_enet_interface(), and hns_get_enet_interface() is called by initialization to get the mac mode. And the mode is not changed anywhere. Thus add hns_mac_dev_to_enet_if() function to get the mac

[PATCH net-next 3/9] net: hns: change code style from a = a + x to a += x

From: Daode Huang This patch fixes the code style in hns driver. Change it from "buff = buff + xxx" to "buff += xxx". The reveiw comments is from andy. Reviewed-by: Andriy Shevchenko Signed-off-by: Daode Huang

[PATCH net-next 4/9] net: hns: delete redundant parens

From: Daode Huang According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 4 ++-- 1 file changed, 2

[PATCH net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if()

From: Kejian Yan The sequence of hns_mac_dev_to_enet_if() is the same as hns_get_enet_interface(), and hns_get_enet_interface() is called by initialization to get the mac mode. And the mode is not changed anywhere. Thus add hns_mac_dev_to_enet_if() function to get the mac mode is obviously

[PATCH net-next 3/9] net: hns: change code style from a = a + x to a += x

From: Daode Huang This patch fixes the code style in hns driver. Change it from "buff = buff + xxx" to "buff += xxx". The reveiw comments is from andy. Reviewed-by: Andriy Shevchenko Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 32 +++---

[PATCH net-next 4/9] net: hns: delete redundant parens

From: Daode Huang According to the previous review comments from Andy, this patch deletes the redundant parens in the patch. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH net-next 2/9] net: hns: fix code style about hns driver

From: Daode Huang This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff

[PATCH net-next 2/9] net: hns: fix code style about hns driver

From: Daode Huang This patch fixes code sytle of hns driver to make it simple. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

[PATCH net-next 9/9] net: hns: get reset registers from DT

From: Kejian Yan Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan --- drivers/net/ethernet/hisilicon/hns_mdio.c | 80

[PATCH net-next 9/9] net: hns: get reset registers from DT

From: Kejian Yan Since the registers of subctrl may be different, it is better to mv the registers from hns mdio driver routine to device tree node. Signed-off-by: Kejian Yan --- drivers/net/ethernet/hisilicon/hns_mdio.c | 80 +-- 1 file changed, 66 insertions(+),

[PATCH net-next 5/9] net: hns: add a space before "*/"

From: Daode Huang In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH net-next 6/9] net: hns: normalize two different loop

From: Daode Huang There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 18

[PATCH net-next 5/9] net: hns: add a space before "*/"

From: Daode Huang In comment line, some time miss a space before */, so this patch adds a space before */. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH net-next 6/9] net: hns: normalize two different loop

From: Daode Huang There are two approaches to assign data, one does 2 loops, another does 1 loop. This patch normalize the different methods to 1 loop. Signed-off-by: Daode Huang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 18 +- 1 file changed, 9 insertions(+), 9

[PATCH net-next 8/9] net: hns: add media-type property for hns

From: Kejian Yan It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan

[PATCH net-next 8/9] net: hns: add media-type property for hns

From: Kejian Yan It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type. Reported-by: Jinchuan Tian Signed-off-by: Kejian Yan --- drivers/net/ethernet/hisilicon/hns/hnae.h | 9

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

在 2016/6/22 17:41, Andy Shevchenko 写道: > On Wed, 2016-06-22 at 09:43 +0800, Yisen Zhuang wrote: >> >> 在 2016/6/21 18:32, Andy Shevchenko 写道: >>> On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >>>> From: Daode Huang <huangda...@hisilicon.com>

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

在 2016/6/22 17:41, Andy Shevchenko 写道: > On Wed, 2016-06-22 at 09:43 +0800, Yisen Zhuang wrote: >> >> 在 2016/6/21 18:32, Andy Shevchenko 写道: >>> On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >>>> From: Daode Huang >>>> >>>> Fo

Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

在 2016/6/21 21:25, Sergei Shtylyov 写道: > Hello. > > On 6/21/2016 6:56 AM, Yisen Zhuang wrote: > >> From: Jun He <hjat2...@huawei.com> >> >> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and >> read new fbd_num to start

Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

在 2016/6/21 21:25, Sergei Shtylyov 写道: > Hello. > > On 6/21/2016 6:56 AM, Yisen Zhuang wrote: > >> From: Jun He >> >> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and >> read new fbd_num to start new receive cycle. It reco

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

在 2016/6/21 18:32, Andy Shevchenko 写道: > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >> From: Daode Huang <huangda...@hisilicon.com> >> >> For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, >> so change the statistics of pfc pause in dsa

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

在 2016/6/21 18:32, Andy Shevchenko 写道: > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >> From: Daode Huang >> >> For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, >> so change the statistics of pfc pause in dsaf and remove the old &g

Re: [PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

在 2016/6/21 18:35, Andy Shevchenko 写道: > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >> From: Qianqian Xie <xieqianq...@huawei.com> >> >> The bit fileds of PPE reset register are different between HNS v1 and >> HNS v2, but the current proce

Re: [PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

在 2016/6/21 18:35, Andy Shevchenko 写道: > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: >> From: Qianqian Xie >> >> The bit fileds of PPE reset register are different between HNS v1 and >> HNS v2, but the current procedure just only match HNS v1

[PATCH net-next 17/19] net: hns: fix sbm default parameters config error

; Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 40 ++ drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 16 +++-- 2 files changed, 39 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethe

[PATCH net-next 19/19] net: hns: bug fix about TSO on|off when there is traffic

riptor. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ene

[PATCH net-next 17/19] net: hns: fix sbm default parameters config error

From: Daode Huang The default sbm config parameter leaves little buffer when there is heavy traffic, which will cause packets drop. This patch changes them to make enough buffers for handling packets. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon

[PATCH net-next 19/19] net: hns: bug fix about TSO on|off when there is traffic

Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index c0ce37b..d5297ec 100644 --- a/drivers

[PATCH net-next 06/19] net: hns: fix the error info when dma_set_mask_and_coherent fail

From: Qianqian Xie <xieqianq...@huawei.com> The error info should be printed as "set mask to 64bit fail!" instead of "set mask to 32bit fail!" in dma_set_mask_and_coherent(). Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yi

[PATCH net-next 05/19] net: hns: Remove unnecessary device resource free

From: Qianqian Xie <xieqianq...@huawei.com> The driver uses devm_ioremap_resource, it will unmap the map automatically, remove the unnecessary the resource free. Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Reported-by: Kefeng Wang <wangkefeng.w...@huawei.com> Signed-of

[PATCH net-next 06/19] net: hns: fix the error info when dma_set_mask_and_coherent fail

From: Qianqian Xie The error info should be printed as "set mask to 64bit fail!" instead of "set mask to 32bit fail!" in dma_set_mask_and_coherent(). Signed-off-by: Qianqian Xie Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +- 1 file

[PATCH net-next 05/19] net: hns: Remove unnecessary device resource free

From: Qianqian Xie The driver uses devm_ioremap_resource, it will unmap the map automatically, remove the unnecessary the resource free. Signed-off-by: Qianqian Xie Reported-by: Kefeng Wang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 39

[PATCH net-next 04/19] net: hns: typo fix of annotation info for hns_nic_reset_subtask()

From: Qianqian Xie <xieqianq...@huawei.com> The annotation info for hns_nic_reset_subtask() should be "for resetting subtask" instead of "for resetting suntask". Signed-off-by: Qianqian Xie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@hu

[PATCH net-next 04/19] net: hns: typo fix of annotation info for hns_nic_reset_subtask()

From: Qianqian Xie The annotation info for hns_nic_reset_subtask() should be "for resetting subtask" instead of "for resetting suntask". Signed-off-by: Qianqian Xie Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +- 1 file change

[PATCH net-next 08/19] net: hns: fix ethtool loopback fail bug

right status. Reported-by: hejun <hjat2...@huawei.com> Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 35 ++-- 1 file changed, 14 insertions(+), 21

[PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

about the port unavailable. So we will goto out when alloc skb fail to fix this bug. Signed-off-by: Jun He <hjat2...@huawei.com> Signed-off-by: Ding Tianhong <dingtianh...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_

[PATCH net-next 08/19] net: hns: fix ethtool loopback fail bug

-by: hejun Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 35 ++-- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns

[PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

we will goto out when alloc skb fail to fix this bug. Signed-off-by: Jun He Signed-off-by: Ding Tianhong Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns

[PATCH net-next 14/19] net: hns: delete redundancy ring enable operations

t;huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.c | 1 - drivers/net/ethernet/hisilicon/hns/hnae.h | 1 - drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 22 +- dr

[PATCH net-next 02/19] net: hns: fix hns dsaf v1 dont support tx_pause close

From: Qianqian Xie <xieqiaq...@huawei.com> For service port, hns dsaf v1 support to close tx_pause. However, the port will be invalid when it run command ethtool to close tx_pause. This patch will fix it. Signed-off-by: Qianqian Xie <xieqiaq...@huawei.com> Signed-off-by: Yisen Zhuan

[PATCH net-next 03/19] net: hns: add skb_reset_mac_header() after skb being alloc

From: Kejian Yan <yankej...@huawei.com> HNS receives a packet without doing anything, but it should call skb_reset_mac_header() to initialize the header before using eth_hdr(). Fixes: 0d6b425a3773c3445b0f51b2f333821beaacb619 Signed-off-by: Kejian Yan <yankej...@huawei.com> Signed-o

[PATCH net-next 02/19] net: hns: fix hns dsaf v1 dont support tx_pause close

From: Qianqian Xie For service port, hns dsaf v1 support to close tx_pause. However, the port will be invalid when it run command ethtool to close tx_pause. This patch will fix it. Signed-off-by: Qianqian Xie Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c

[PATCH net-next 03/19] net: hns: add skb_reset_mac_header() after skb being alloc

From: Kejian Yan HNS receives a packet without doing anything, but it should call skb_reset_mac_header() to initialize the header before using eth_hdr(). Fixes: 0d6b425a3773c3445b0f51b2f333821beaacb619 Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon

[PATCH net-next 14/19] net: hns: delete redundancy ring enable operations

From: Daode Huang When network interface is enabled, the ring enable operation is conducted twice. This patch deletes the redundancy code of ring enable, and integrates hnae_ae_ops.toggle_queue_status other functions to hns_ae_start. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang

[PATCH net-next 15/19] net: hns: bug fix about led control logic when link down

blink frequece other than the driver itself. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff -

[PATCH net-next 15/19] net: hns: bug fix about led control logic when link down

the driver itself. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns

[PATCH net-next 18/19] net: hns: change the default coalesce usecs

t;huangda...@hisilicon.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns

[PATCH net-next 00/19] net: hns: fix some bugs in hns driver

This series includes some bugs fixed. All these patches needs to be applied after the patchset about ACPI support, so this series is floated to net-next list. The patches are: > from Daode, fixes about pfc pause frame, getting coaslesce, led control logic, TSO on|off and tcam table

[PATCH net-next 18/19] net: hns: change the default coalesce usecs

From: Daode Huang The default coalesce timeout is 3us, which is will cause CPU usage is too high. This patch change it to 50us in order to reduce CPU usage and the value makes sure network latency also meets requirement. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net

[PATCH net-next 00/19] net: hns: fix some bugs in hns driver

This series includes some bugs fixed. All these patches needs to be applied after the patchset about ACPI support, so this series is floated to net-next list. The patches are: > from Daode, fixes about pfc pause frame, getting coaslesce, led control logic, TSO on|off and tcam table

[PATCH net-next 01/19] net: hns: bug fix of ge reset sequence

ie <xieqianq...@huawei.com> Signed-off-by: Yisen Zhuang <yisen.zhu...@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/h

[PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

From: Daode Huang <huangda...@hisilicon.com> For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, so change the statistics of pfc pause in dsaf and remove the old pfc pause frame statistics. Signed-off-by: Daode Huang <huangda...@hisilicon.com> Signed-off-by: Yisen Zhuan

  1   2   3   >