Re: [PATCH] MAINTAINERS: drop akarwar from mwifiex

[amit karwar]

On Thu, Apr 13, 2017 at 6:47 PM, Kalle Valo  wrote:
> Brian Norris  writes:
>
>> His email is bouncing, and I expect he's not doing this work any more.
>>
>> Cc: Amitkumar Karwar 
>> Cc: Nishant Sarmukadam 
>> Cc: Ganapathi Bhat 
>> Cc: Xinming Hu 
>> Signed-off-by: Brian Norris 
>> ---
>> Or alternatively, we can update his email address. I just don't want to keep
>> seeing bounced emails :)
>
> Me neither :) So Amitkumar, which one do you prefer?
>

Updating email address would be fine. Please replace
akar...@marvell.com with amitkar...@gmail.com

Regards,
Amitkumar Karwar

Re: [PATCH] MAINTAINERS: drop akarwar from mwifiex

[amit karwar]

On Thu, Apr 13, 2017 at 6:47 PM, Kalle Valo  wrote:
> Brian Norris  writes:
>
>> His email is bouncing, and I expect he's not doing this work any more.
>>
>> Cc: Amitkumar Karwar 
>> Cc: Nishant Sarmukadam 
>> Cc: Ganapathi Bhat 
>> Cc: Xinming Hu 
>> Signed-off-by: Brian Norris 
>> ---
>> Or alternatively, we can update his email address. I just don't want to keep
>> seeing bounced emails :)
>
> Me neither :) So Amitkumar, which one do you prefer?
>

Updating email address would be fine. Please replace
akar...@marvell.com with amitkar...@gmail.com

Regards,
Amitkumar Karwar

Re: [RFC PATCH] Revert "mwifiex: fix system hang problem after resume"

[amit karwar]

On Sat, Apr 1, 2017 at 1:51 AM, Brian Norris  wrote:
> This reverts commit 437322ea2a36d112e20aa7282c869bf924b3a836.
>
> This above-mentioned "fix" does not actually do anything to prevent a
> race condition. It simply papers over it so that the issue doesn't
> appear.
>
> If this is a real problem, it should be explained better than the above
> commit does, and an alternative, non-racy solution should be found.
>
> For further reason to revert this: there's ot reason we can't try
> resetting the card when it's *actually* stuck in host-sleep mode. So
> instead, this is unnecessarily creating scenarios where we can't recover
> Wifi.
>
> Cc: Amitkumar Karwar 
> Signed-off-by: Brian Norris 
> ---
> Amit, please take a look. AIUI, your "fix" is wrong, and quite racy. If you
> still think it's needed, can you please propose an alternative? Or at least
> explain more why this is needed? Thanks.
>

I agree. Fix just covers the issue. We need to investigate why system
hangs when card reset is attempted in host sleep activated scenario.

Acked-by: Amitkumar Karwar 

Regards,
Amitkumar Karwar

Re: [RFC PATCH] Revert "mwifiex: fix system hang problem after resume"

[amit karwar]

On Sat, Apr 1, 2017 at 1:51 AM, Brian Norris  wrote:
> This reverts commit 437322ea2a36d112e20aa7282c869bf924b3a836.
>
> This above-mentioned "fix" does not actually do anything to prevent a
> race condition. It simply papers over it so that the issue doesn't
> appear.
>
> If this is a real problem, it should be explained better than the above
> commit does, and an alternative, non-racy solution should be found.
>
> For further reason to revert this: there's ot reason we can't try
> resetting the card when it's *actually* stuck in host-sleep mode. So
> instead, this is unnecessarily creating scenarios where we can't recover
> Wifi.
>
> Cc: Amitkumar Karwar 
> Signed-off-by: Brian Norris 
> ---
> Amit, please take a look. AIUI, your "fix" is wrong, and quite racy. If you
> still think it's needed, can you please propose an alternative? Or at least
> explain more why this is needed? Thanks.
>

I agree. Fix just covers the issue. We need to investigate why system
hangs when card reset is attempted in host sleep activated scenario.

Acked-by: Amitkumar Karwar 

Regards,
Amitkumar Karwar