Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-02-01 Thread Jason Gunthorpe
On Sat, Jan 27, 2018 at 09:15:09PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 27 Jan 2018 21:10:12 +0100 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete two error

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-02-01 Thread Jason Gunthorpe
On Sat, Jan 27, 2018 at 09:15:09PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 27 Jan 2018 21:10:12 +0100 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete two error messages for a failed memory

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-29 Thread Jonathan Toppins
On 01/27/2018 03:15 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 27 Jan 2018 21:10:12 +0100 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete two error messages for a

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-29 Thread Jonathan Toppins
On 01/27/2018 03:15 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 27 Jan 2018 21:10:12 +0100 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete two error messages for a failed memory allocation > Use

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-29 Thread Devesh Sharma
On Mon, Jan 29, 2018 at 3:01 PM, SF Markus Elfring wrote: >> You don't need 2 patches when changing same lines of code. > > Are these really the same? > > >> Could you squash both and send your changes in a single patch. > > I prefer to keep the deletion of

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-29 Thread Devesh Sharma
On Mon, Jan 29, 2018 at 3:01 PM, SF Markus Elfring wrote: >> You don't need 2 patches when changing same lines of code. > > Are these really the same? > > >> Could you squash both and send your changes in a single patch. > > I prefer to keep the deletion of questionable error messages separate >

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-29 Thread SF Markus Elfring
> You don't need 2 patches when changing same lines of code. Are these really the same? > Could you squash both and send your changes in a single patch. I prefer to keep the deletion of questionable error messages separate from the refactoring for a bit of exception handling. > The patches

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-29 Thread SF Markus Elfring
> You don't need 2 patches when changing same lines of code. Are these really the same? > Could you squash both and send your changes in a single patch. I prefer to keep the deletion of questionable error messages separate from the refactoring for a bit of exception handling. > The patches

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-28 Thread Devesh Sharma
On Sun, Jan 28, 2018 at 1:45 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 27 Jan 2018 21:10:12 +0100 > > Two update suggestions were taken into account > from static source code analysis. You don't need 2 patches

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-28 Thread Devesh Sharma
On Sun, Jan 28, 2018 at 1:45 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 27 Jan 2018 21:10:12 +0100 > > Two update suggestions were taken into account > from static source code analysis. You don't need 2 patches when changing same lines of code. Could you squash both and

[PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 21:10:12 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Use common error handling code

[PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 21:10:12 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Use common error handling code drivers/infiniband/hw/bnxt_re/qplib_res.c