Re: [3/5] Bluetooth: btmrvl: One check less in btmrvl_sdio_card_to_host()

2018-03-13 Thread SF Markus Elfring
>> @@ -797,12 +792,18 @@ static int btmrvl_sdio_card_to_host(struct >> btmrvl_private *priv) >> break; >> } >> >> -exit: >> -if (ret) { >> -hdev->stat.err_rx++; >> -kfree_skb(skb); >> -} >> +return 0; >> + >> +free_skb: >> +kfree_skb(skb);

Re: [3/5] Bluetooth: btmrvl: One check less in btmrvl_sdio_card_to_host()

2018-03-13 Thread SF Markus Elfring
>> @@ -797,12 +792,18 @@ static int btmrvl_sdio_card_to_host(struct >> btmrvl_private *priv) >> break; >> } >> >> -exit: >> -if (ret) { >> -hdev->stat.err_rx++; >> -kfree_skb(skb); >> -} >> +return 0; >> + >> +free_skb: >> +kfree_skb(skb);

Re: [PATCH 3/5] Bluetooth: btmrvl: One check less in btmrvl_sdio_card_to_host() after error detection

2018-03-12 Thread Marcel Holtmann
Hi Markus, > One check could be repeated by the btmrvl_sdio_card_to_host() function > during error handling even if the relevant properties can be determined > for the involved variables before by source code analysis. > > * Adjust jump targets so that an extra check can be omitted at the end. >

Re: [PATCH 3/5] Bluetooth: btmrvl: One check less in btmrvl_sdio_card_to_host() after error detection

2018-03-12 Thread Marcel Holtmann
Hi Markus, > One check could be repeated by the btmrvl_sdio_card_to_host() function > during error handling even if the relevant properties can be determined > for the involved variables before by source code analysis. > > * Adjust jump targets so that an extra check can be omitted at the end. >

[PATCH 3/5] Bluetooth: btmrvl: One check less in btmrvl_sdio_card_to_host() after error detection

2018-03-12 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 12 Mar 2018 11:13:00 +0100 One check could be repeated by the btmrvl_sdio_card_to_host() function during error handling even if the relevant properties can be determined for the involved variables before by source code analysis. *

[PATCH 3/5] Bluetooth: btmrvl: One check less in btmrvl_sdio_card_to_host() after error detection

2018-03-12 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 12 Mar 2018 11:13:00 +0100 One check could be repeated by the btmrvl_sdio_card_to_host() function during error handling even if the relevant properties can be determined for the involved variables before by source code analysis. * Adjust jump targets so that an