>> @@ -797,12 +792,18 @@ static int btmrvl_sdio_card_to_host(struct
>> btmrvl_private *priv)
>> break;
>> }
>>
>> -exit:
>> -if (ret) {
>> -hdev->stat.err_rx++;
>> -kfree_skb(skb);
>> -}
>> +return 0;
>> +
>> +free_skb:
>> +kfree_skb(skb);
>> @@ -797,12 +792,18 @@ static int btmrvl_sdio_card_to_host(struct
>> btmrvl_private *priv)
>> break;
>> }
>>
>> -exit:
>> -if (ret) {
>> -hdev->stat.err_rx++;
>> -kfree_skb(skb);
>> -}
>> +return 0;
>> +
>> +free_skb:
>> +kfree_skb(skb);
Hi Markus,
> One check could be repeated by the btmrvl_sdio_card_to_host() function
> during error handling even if the relevant properties can be determined
> for the involved variables before by source code analysis.
>
> * Adjust jump targets so that an extra check can be omitted at the end.
>
Hi Markus,
> One check could be repeated by the btmrvl_sdio_card_to_host() function
> during error handling even if the relevant properties can be determined
> for the involved variables before by source code analysis.
>
> * Adjust jump targets so that an extra check can be omitted at the end.
>
From: Markus Elfring
Date: Mon, 12 Mar 2018 11:13:00 +0100
One check could be repeated by the btmrvl_sdio_card_to_host() function
during error handling even if the relevant properties can be determined
for the involved variables before by source code analysis.
*
From: Markus Elfring
Date: Mon, 12 Mar 2018 11:13:00 +0100
One check could be repeated by the btmrvl_sdio_card_to_host() function
during error handling even if the relevant properties can be determined
for the involved variables before by source code analysis.
* Adjust jump targets so that an
6 matches
Mail list logo