Re: [NEED TESTERS] remove swapin_readahead Re: shmem_getpage_locked() / swapin_readahead() race in 2.4.4-pre3

2001-04-18 Thread Christoph Rohland
Hi Stephen, On Tue, 17 Apr 2001, Stephen C. Tweedie wrote: > I don't see the problem. shmem_getpage_locked appears to back off > correctly if it encounters a swap-cached page already existing if > swapin_readahead has installed the page first, at least with the > code in 2.4.3-ac5. But the

Re: [NEED TESTERS] remove swapin_readahead Re: shmem_getpage_locked() / swapin_readahead() race in 2.4.4-pre3

2001-04-18 Thread Christoph Rohland
Hi Stephen, On Tue, 17 Apr 2001, Stephen C. Tweedie wrote: I don't see the problem. shmem_getpage_locked appears to back off correctly if it encounters a swap-cached page already existing if swapin_readahead has installed the page first, at least with the code in 2.4.3-ac5. But the swap

Re: [NEED TESTERS] remove swapin_readahead Re: shmem_getpage_locked() / swapin_readahead() race in 2.4.4-pre3

2001-04-17 Thread Stephen C. Tweedie
Hi, On Sat, Apr 14, 2001 at 08:31:07PM -0300, Marcelo Tosatti wrote: > On Sat, 14 Apr 2001, Rik van Riel wrote: > > On Sat, 14 Apr 2001, Marcelo Tosatti wrote: > > > > > There is a nasty race between shmem_getpage_locked() and > > > swapin_readahead() with the new shmem code (introduced in > >

[NEED TESTERS] remove swapin_readahead Re: shmem_getpage_locked()/ swapin_readahead() race in 2.4.4-pre3

2001-04-14 Thread Marcelo Tosatti
On Sat, 14 Apr 2001, Rik van Riel wrote: > On Sat, 14 Apr 2001, Marcelo Tosatti wrote: > > > There is a nasty race between shmem_getpage_locked() and > > swapin_readahead() with the new shmem code (introduced in > > 2.4.3-ac3 and merged in the main tree in 2.4.4-pre3): > > > I don't see any

[NEED TESTERS] remove swapin_readahead Re: shmem_getpage_locked()/ swapin_readahead() race in 2.4.4-pre3

2001-04-14 Thread Marcelo Tosatti
On Sat, 14 Apr 2001, Rik van Riel wrote: On Sat, 14 Apr 2001, Marcelo Tosatti wrote: There is a nasty race between shmem_getpage_locked() and swapin_readahead() with the new shmem code (introduced in 2.4.3-ac3 and merged in the main tree in 2.4.4-pre3): I don't see any clean fix