Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread David Howells
> If you want to change the vma ops table you can replace the f_ops > table with your own one. SYSV ipc uses this also to be able to catch > unmaps. I'd thought of that, but that means I need to concoct an f_ops table of my own for every f_ops table I might have to override. All I want to do is

Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread Christoph Rohland
Hi David, On Wed, 13 Dec 2000, David Howells wrote: > Looks interesting. > > There looks to be a logical mapping between CreateFileMapping() + > MEM_SHARED and your shmem_file_setup(), as long as anonymously named > sections are catered for (not difficult). Yup. > There also looks to be a

Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread David Howells
> There will be a > > struct file *shmem_file_setup(char * name, loff_t size) > > which gives you an open sruct file to an unlinked file of size > size. You can then do > > down(>mm->mmap_sem); > user_addr = (void *) do_mmap (file, addr, size, prot, flags, 0); > up(>mm->mmap_sem); > > with

Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread Christoph Rohland
Hi David, On Wed, 13 Dec 2000, David Howells wrote: >>> I'm currently writing a Win32 emulation kernel module to help >>> speed Wine up, >^ >> fd = shm_open ("xxx",...) >> ptr = mmap (NULL, size, ..., fd, offset); > > I am doing this from

Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread David Howells
>> I'm currently writing a Win32 emulation kernel module to help speed Wine up, ^ > fd = shm_open ("xxx",...) > ptr = mmap (NULL, size, ..., fd, offset); I am doing this from within kernel space. I'd like to avoid doing the full open and

Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread David Howells
I'm currently writing a Win32 emulation kernel module to help speed Wine up, ^ fd = shm_open ("xxx",...) ptr = mmap (NULL, size, ..., fd, offset); I am doing this from within kernel space. I'd like to avoid doing the full open and mmap if

Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread Christoph Rohland
Hi David, On Wed, 13 Dec 2000, David Howells wrote: I'm currently writing a Win32 emulation kernel module to help speed Wine up, ^ fd = shm_open ("xxx",...) ptr = mmap (NULL, size, ..., fd, offset); I am doing this from within kernel

Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread Christoph Rohland
Hi David, On Wed, 13 Dec 2000, David Howells wrote: Looks interesting. There looks to be a logical mapping between CreateFileMapping() + MEM_SHARED and your shmem_file_setup(), as long as anonymously named sections are catered for (not difficult). Yup. There also looks to be a logical

Re: [PATCH,preliminary] cleanup shm handling

2000-12-13 Thread David Howells
If you want to change the vma ops table you can replace the f_ops table with your own one. SYSV ipc uses this also to be able to catch unmaps. I'd thought of that, but that means I need to concoct an f_ops table of my own for every f_ops table I might have to override. All I want to do is

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Christoph Rohland
Hi Linus, Linus Torvalds <[EMAIL PROTECTED]> writes: > On 8 Dec 2000, Christoph Rohland wrote: > > > > here is my first shot for cleaning up the shm handling. It did > > survive some basic testing but is not ready for inclusion. > > The only comment I have right now is that you probably should

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Linus Torvalds
On 8 Dec 2000, Christoph Rohland wrote: > > Linus Torvalds <[EMAIL PROTECTED]> writes: > > On 8 Dec 2000, Christoph Rohland wrote: > > > > > > here is my first shot for cleaning up the shm handling. It did > > > survive some basic testing but is not ready for inclusion. > > > > The only

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Christoph Rohland
David Howells <[EMAIL PROTECTED]> writes: > Can you help me with an SHM related problem? > > I'm currently writing a Win32 emulation kernel module to help speed Wine up, > and I'm writing the file mapping support stuff at the moment > (CreateFileMapping and MapViewOfFile). These two calls were

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Linus Torvalds
On 8 Dec 2000, Christoph Rohland wrote: > > here is my first shot for cleaning up the shm handling. It did survive > some basic testing but is not ready for inclusion. The only comment I have right now is that you probably should not mark the page dirty in "nopage" - theoretically somebody

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread David Howells
> here is my first shot for cleaning up the shm handling. It did survive > some basic testing but is not ready for inclusion. Can you help me with an SHM related problem? I'm currently writing a Win32 emulation kernel module to help speed Wine up, and I'm writing the file mapping support

[PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Christoph Rohland
Hi Linus, here is my first shot for cleaning up the shm handling. It did survive some basic testing but is not ready for inclusion. The smp locking needs some review, shmem_file_setup needs cleanup, we probably want to have triple indirect blocks... But the basic concept seems to work. Oh,

[PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Christoph Rohland
Hi Linus, here is my first shot for cleaning up the shm handling. It did survive some basic testing but is not ready for inclusion. The smp locking needs some review, shmem_file_setup needs cleanup, we probably want to have triple indirect blocks... But the basic concept seems to work. Oh,

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread David Howells
here is my first shot for cleaning up the shm handling. It did survive some basic testing but is not ready for inclusion. Can you help me with an SHM related problem? I'm currently writing a Win32 emulation kernel module to help speed Wine up, and I'm writing the file mapping support stuff

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Linus Torvalds
On 8 Dec 2000, Christoph Rohland wrote: here is my first shot for cleaning up the shm handling. It did survive some basic testing but is not ready for inclusion. The only comment I have right now is that you probably should not mark the page dirty in "nopage" - theoretically somebody

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Christoph Rohland
David Howells [EMAIL PROTECTED] writes: Can you help me with an SHM related problem? I'm currently writing a Win32 emulation kernel module to help speed Wine up, and I'm writing the file mapping support stuff at the moment (CreateFileMapping and MapViewOfFile). These two calls were

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Linus Torvalds
On 8 Dec 2000, Christoph Rohland wrote: Linus Torvalds [EMAIL PROTECTED] writes: On 8 Dec 2000, Christoph Rohland wrote: here is my first shot for cleaning up the shm handling. It did survive some basic testing but is not ready for inclusion. The only comment I have right

Re: [PATCH,preliminary] cleanup shm handling

2000-12-08 Thread Christoph Rohland
Hi Linus, Linus Torvalds [EMAIL PROTECTED] writes: On 8 Dec 2000, Christoph Rohland wrote: here is my first shot for cleaning up the shm handling. It did survive some basic testing but is not ready for inclusion. The only comment I have right now is that you probably should not mark