Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-20 Thread Arnd Bergmann
On Friday 18 March 2016 14:16:23 Vineet Gupta wrote: > diff --git a/arch/arc/Makefile b/arch/arc/Makefile > index fed12f39d8ce..aeb101e8e674 100644 > --- a/arch/arc/Makefile > +++ b/arch/arc/Makefile > @@ -48,9 +48,14 @@ endif > upto_gcc44:= $(call cc-ifversion, -le, 0404, y) >

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-20 Thread Arnd Bergmann
On Friday 18 March 2016 14:16:23 Vineet Gupta wrote: > diff --git a/arch/arc/Makefile b/arch/arc/Makefile > index fed12f39d8ce..aeb101e8e674 100644 > --- a/arch/arc/Makefile > +++ b/arch/arc/Makefile > @@ -48,9 +48,14 @@ endif > upto_gcc44:= $(call cc-ifversion, -le, 0404, y) >

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Vineet Gupta
On Friday 18 March 2016 03:59 PM, Arnd Bergmann wrote: > On Friday 18 March 2016 15:50:11 Vineet Gupta wrote: >> Sure, but I prefer this to be only for gcc 4.8 as this warning seems to be >> healthy in small doses At least it keeps the door open for future discussion >> with gcc guys ! > > FWIW,

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Vineet Gupta
On Friday 18 March 2016 03:59 PM, Arnd Bergmann wrote: > On Friday 18 March 2016 15:50:11 Vineet Gupta wrote: >> Sure, but I prefer this to be only for gcc 4.8 as this warning seems to be >> healthy in small doses At least it keeps the door open for future discussion >> with gcc guys ! > > FWIW,

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 16:13:28 Vineet Gupta wrote: > On Friday 18 March 2016 03:59 PM, Arnd Bergmann wrote: > > On Friday 18 March 2016 15:50:11 Vineet Gupta wrote: > >> Sure, but I prefer this to be only for gcc 4.8 as this warning seems to be > >> healthy in small doses At least it keeps the

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 16:13:28 Vineet Gupta wrote: > On Friday 18 March 2016 03:59 PM, Arnd Bergmann wrote: > > On Friday 18 March 2016 15:50:11 Vineet Gupta wrote: > >> Sure, but I prefer this to be only for gcc 4.8 as this warning seems to be > >> healthy in small doses At least it keeps the

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 18:31:53 Vineet Gupta wrote: > > > On a related note, I have submitted a patch that turns > > CONFIG_CC_OPTIMIZE_FOR_SIZE > > into a choice statement, so we actually get the -Wmaybe-uninitialized > > warnings > > in an allyesconfig or allmodconfig build. It would be

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 18:31:53 Vineet Gupta wrote: > > > On a related note, I have submitted a patch that turns > > CONFIG_CC_OPTIMIZE_FOR_SIZE > > into a choice statement, so we actually get the -Wmaybe-uninitialized > > warnings > > in an allyesconfig or allmodconfig build. It would be

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 15:50:11 Vineet Gupta wrote: > Sure, but I prefer this to be only for gcc 4.8 as this warning seems to be > healthy in small doses At least it keeps the door open for future discussion > with gcc guys ! FWIW, testing on ARM with gcc-6.0 -O3, I also get tons of

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 15:50:11 Vineet Gupta wrote: > Sure, but I prefer this to be only for gcc 4.8 as this warning seems to be > healthy in small doses At least it keeps the door open for future discussion > with gcc guys ! FWIW, testing on ARM with gcc-6.0 -O3, I also get tons of

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Vineet Gupta
On Friday 18 March 2016 05:43 PM, Arnd Bergmann wrote: > I think it's dangerous to use -O3 in one architecture when nothing else > uses it. If you don't have a strong reason to use -O3, maybe just drop that > use the default -O2 -Wmaybe-uninitialized like everyone else does. I know what u mean.

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Vineet Gupta
On Friday 18 March 2016 05:43 PM, Arnd Bergmann wrote: > I think it's dangerous to use -O3 in one architecture when nothing else > uses it. If you don't have a strong reason to use -O3, maybe just drop that > use the default -O2 -Wmaybe-uninitialized like everyone else does. I know what u mean.

[PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Vineet Gupta
linux-next has been reporting gazillion warnings for ARC build and I finally decided to take a bite: http://kisskb.ellerman.id.au/kisskb/buildresult/12638735/ Most of the them are due to -Wmaybe-uninitialized | ../kernel/sysctl.c: In function '__do_proc_doulongvec_minmax': |

[PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Vineet Gupta
linux-next has been reporting gazillion warnings for ARC build and I finally decided to take a bite: http://kisskb.ellerman.id.au/kisskb/buildresult/12638735/ Most of the them are due to -Wmaybe-uninitialized | ../kernel/sysctl.c: In function '__do_proc_doulongvec_minmax': |

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Vineet Gupta
On Friday 18 March 2016 03:22 PM, Arnd Bergmann wrote: > On Friday 18 March 2016 14:16:23 Vineet Gupta wrote: >> diff --git a/arch/arc/Makefile b/arch/arc/Makefile >> index fed12f39d8ce..aeb101e8e674 100644 >> --- a/arch/arc/Makefile >> +++ b/arch/arc/Makefile >> @@ -48,9 +48,14 @@ endif >>

Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8

2016-03-19 Thread Vineet Gupta
On Friday 18 March 2016 03:22 PM, Arnd Bergmann wrote: > On Friday 18 March 2016 14:16:23 Vineet Gupta wrote: >> diff --git a/arch/arc/Makefile b/arch/arc/Makefile >> index fed12f39d8ce..aeb101e8e674 100644 >> --- a/arch/arc/Makefile >> +++ b/arch/arc/Makefile >> @@ -48,9 +48,14 @@ endif >>