Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Tue, Oct 27, 2015 at 03:44:24PM +, Will Deacon wrote: > On Fri, Oct 16, 2015 at 11:37:29AM +0100, Catalin Marinas wrote: > > On Fri, Oct 16, 2015 at 08:52:24AM +0100, Vladimir Murzin wrote: > > > > On 15/10/15 14:02, Will Deacon wrote: > > > >> diff --git

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Tue, Oct 27, 2015 at 03:44:24PM +, Will Deacon wrote: > On Fri, Oct 16, 2015 at 11:37:29AM +0100, Catalin Marinas wrote: > > On Fri, Oct 16, 2015 at 08:52:24AM +0100, Vladimir Murzin wrote: > > > > On 15/10/15 14:02, Will Deacon wrote: > > > >> diff --git

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Fri, Oct 16, 2015 at 11:37:29AM +0100, Catalin Marinas wrote: > On Fri, Oct 16, 2015 at 08:52:24AM +0100, Vladimir Murzin wrote: > > > On 15/10/15 14:02, Will Deacon wrote: > > >> diff --git a/arch/arm64/kernel/armv8_deprecated.c > > >> b/arch/arm64/kernel/armv8_deprecated.c > > >> index

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Fri, Oct 16, 2015 at 11:37:29AM +0100, Catalin Marinas wrote: > On Fri, Oct 16, 2015 at 08:52:24AM +0100, Vladimir Murzin wrote: > > > On 15/10/15 14:02, Will Deacon wrote: > > >> diff --git a/arch/arm64/kernel/armv8_deprecated.c > > >> b/arch/arm64/kernel/armv8_deprecated.c > > >> index

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Fri, Oct 16, 2015 at 08:52:24AM +0100, Vladimir Murzin wrote: > > On 15/10/15 14:02, Will Deacon wrote: > >> diff --git a/arch/arm64/kernel/armv8_deprecated.c > >> b/arch/arm64/kernel/armv8_deprecated.c > >> index bcee7abac68e..6039d1eb5912 100644 > >> ---

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On 15/10/15 14:25, Vladimir Murzin wrote: > On 15/10/15 14:02, Will Deacon wrote: >> On Thu, Oct 15, 2015 at 10:17:47AM +0100, Vladimir Murzin wrote: >>> We might need the same change for arm64 counterpart (see >>> arch/arm64/kernel/armv8_deprecated.c). >> >> Something like below? > > Looks good.

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On 15/10/15 14:25, Vladimir Murzin wrote: > On 15/10/15 14:02, Will Deacon wrote: >> On Thu, Oct 15, 2015 at 10:17:47AM +0100, Vladimir Murzin wrote: >>> We might need the same change for arm64 counterpart (see >>> arch/arm64/kernel/armv8_deprecated.c). >> >> Something like below? > > Looks good.

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Fri, Oct 16, 2015 at 08:52:24AM +0100, Vladimir Murzin wrote: > > On 15/10/15 14:02, Will Deacon wrote: > >> diff --git a/arch/arm64/kernel/armv8_deprecated.c > >> b/arch/arm64/kernel/armv8_deprecated.c > >> index bcee7abac68e..6039d1eb5912 100644 > >> ---

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On 15/10/15 14:02, Will Deacon wrote: > On Thu, Oct 15, 2015 at 10:17:47AM +0100, Vladimir Murzin wrote: >> We might need the same change for arm64 counterpart (see >> arch/arm64/kernel/armv8_deprecated.c). > > Something like below? Looks good. Should these two go to stable? Vladimir > > Will

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Thu, Oct 15, 2015 at 10:17:47AM +0100, Vladimir Murzin wrote: > We might need the same change for arm64 counterpart (see > arch/arm64/kernel/armv8_deprecated.c). Something like below? Will >From 63c3e83073cfac2e011adf0ed6f335275cc977a7 Mon Sep 17 00:00:00 2001 From: Will Deacon Date: Thu,

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On 15/10/15 09:57, Russell King - ARM Linux wrote: > On Thu, Oct 15, 2015 at 04:36:31PM +0800, Shengjiu Wang wrote: >> On Thu, Oct 15, 2015 at 09:24:17AM +0100, Russell King - ARM Linux wrote: >>> On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: __user_swpX_asm maybe failed in

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Thu, Oct 15, 2015 at 04:36:31PM +0800, Shengjiu Wang wrote: > On Thu, Oct 15, 2015 at 09:24:17AM +0100, Russell King - ARM Linux wrote: > > On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: > > > __user_swpX_asm maybe failed in first STREX operation, emulate_swpX > > > will try

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Thu, Oct 15, 2015 at 09:24:17AM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: > > __user_swpX_asm maybe failed in first STREX operation, emulate_swpX > > will try again, but the *data has been changed in first time. which > > cause the

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: > __user_swpX_asm maybe failed in first STREX operation, emulate_swpX > will try again, but the *data has been changed in first time. which > cause the result is wrong. So need to recover the *data when failed. > > Signed-off-by:

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Thu, Oct 15, 2015 at 10:17:47AM +0100, Vladimir Murzin wrote: > We might need the same change for arm64 counterpart (see > arch/arm64/kernel/armv8_deprecated.c). Something like below? Will >From 63c3e83073cfac2e011adf0ed6f335275cc977a7 Mon Sep 17 00:00:00 2001 From: Will Deacon

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Thu, Oct 15, 2015 at 09:24:17AM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: > > __user_swpX_asm maybe failed in first STREX operation, emulate_swpX > > will try again, but the *data has been changed in first time. which > > cause the

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On 15/10/15 09:57, Russell King - ARM Linux wrote: > On Thu, Oct 15, 2015 at 04:36:31PM +0800, Shengjiu Wang wrote: >> On Thu, Oct 15, 2015 at 09:24:17AM +0100, Russell King - ARM Linux wrote: >>> On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: __user_swpX_asm maybe failed in

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Thu, Oct 15, 2015 at 04:36:31PM +0800, Shengjiu Wang wrote: > On Thu, Oct 15, 2015 at 09:24:17AM +0100, Russell King - ARM Linux wrote: > > On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: > > > __user_swpX_asm maybe failed in first STREX operation, emulate_swpX > > > will try

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: > __user_swpX_asm maybe failed in first STREX operation, emulate_swpX > will try again, but the *data has been changed in first time. which > cause the result is wrong. So need to recover the *data when failed. > > Signed-off-by:

Re: [PATCH] ARM: SWP emulation: Restore original *data when failed

On 15/10/15 14:02, Will Deacon wrote: > On Thu, Oct 15, 2015 at 10:17:47AM +0100, Vladimir Murzin wrote: >> We might need the same change for arm64 counterpart (see >> arch/arm64/kernel/armv8_deprecated.c). > > Something like below? Looks good. Should these two go to stable? Vladimir > > Will

[PATCH] ARM: SWP emulation: Restore original *data when failed

__user_swpX_asm maybe failed in first STREX operation, emulate_swpX will try again, but the *data has been changed in first time. which cause the result is wrong. So need to recover the *data when failed. Signed-off-by: Shengjiu Wang --- arch/arm/kernel/swp_emulate.c | 1 + 1 file changed, 1

[PATCH] ARM: SWP emulation: Restore original *data when failed

__user_swpX_asm maybe failed in first STREX operation, emulate_swpX will try again, but the *data has been changed in first time. which cause the result is wrong. So need to recover the *data when failed. Signed-off-by: Shengjiu Wang ---