Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-21 Thread Christoph Lameter
On Mon, 19 Nov 2007, Dave Hansen wrote: > Which comes from: > > config OUT_OF_LINE_PFN_TO_PAGE > def_bool X86_64 > depends on DISCONTIGMEM > > and only on x86_64. Perhaps it can go away with the > discontig->sparsemem-vmemmap conversion.

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-21 Thread Christoph Lameter
On Mon, 19 Nov 2007, Dave Hansen wrote: Which comes from: config OUT_OF_LINE_PFN_TO_PAGE def_bool X86_64 depends on DISCONTIGMEM and only on x86_64. Perhaps it can go away with the discontig-sparsemem-vmemmap conversion. The

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-20 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: > On Mon, 19 Nov 2007 15:20:23 -0500 > Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > > * Dave Hansen ([EMAIL PROTECTED]) wrote: > > > The only thing I might suggest doing differently is actually using the > > > page_to_pfn() definition itself: > > >

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-20 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Mon, 19 Nov 2007 15:20:23 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: * Dave Hansen ([EMAIL PROTECTED]) wrote: The only thing I might suggest doing differently is actually using the page_to_pfn() definition itself:

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-19 Thread Dave Hansen
On Mon, 2007-11-19 at 13:19 -0800, Dave Hansen wrote: > On Mon, 2007-11-19 at 13:08 -0800, Andrew Morton wrote: > > Heaven knows why though - why does __pfn_to_page() even exist? > Perhaps it can go away with the > discontig->sparsemem-vmemmap conversion. In fact, Christoph Lameter's

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-19 Thread Dave Hansen
On Mon, 2007-11-19 at 13:08 -0800, Andrew Morton wrote: > > > #else > > -#define page_to_pfn __page_to_pfn > > +#define page_to_pfn ((unsigned long)__page_to_pfn) > > #define pfn_to_page __pfn_to_page > > #endif /* CONFIG_OUT_OF_LINE_PFN_TO_PAGE */ > > I'd have thought that __pfn_to_page()

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-19 Thread Andrew Morton
On Mon, 19 Nov 2007 15:20:23 -0500 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > * Dave Hansen ([EMAIL PROTECTED]) wrote: > > The only thing I might suggest doing differently is actually using the > > page_to_pfn() definition itself: > > > > memory_model.h:#define page_to_pfn __page_to_pfn > >

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-19 Thread Mathieu Desnoyers
* Dave Hansen ([EMAIL PROTECTED]) wrote: > The only thing I might suggest doing differently is actually using the > page_to_pfn() definition itself: > > memory_model.h:#define page_to_pfn __page_to_pfn > > The full inline function version should do this already, and we > shouldn't have any real

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-19 Thread Mathieu Desnoyers
* Dave Hansen ([EMAIL PROTECTED]) wrote: The only thing I might suggest doing differently is actually using the page_to_pfn() definition itself: memory_model.h:#define page_to_pfn __page_to_pfn The full inline function version should do this already, and we shouldn't have any real direct

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-19 Thread Andrew Morton
On Mon, 19 Nov 2007 15:20:23 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: * Dave Hansen ([EMAIL PROTECTED]) wrote: The only thing I might suggest doing differently is actually using the page_to_pfn() definition itself: memory_model.h:#define page_to_pfn __page_to_pfn The full

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-19 Thread Dave Hansen
On Mon, 2007-11-19 at 13:08 -0800, Andrew Morton wrote: #else -#define page_to_pfn __page_to_pfn +#define page_to_pfn ((unsigned long)__page_to_pfn) #define pfn_to_page __pfn_to_page #endif /* CONFIG_OUT_OF_LINE_PFN_TO_PAGE */ I'd have thought that __pfn_to_page() was the place

Re: [PATCH] Cast page_to_pfn to unsigned long in CONFIG_SPARSEMEM

2007-11-19 Thread Dave Hansen
On Mon, 2007-11-19 at 13:19 -0800, Dave Hansen wrote: On Mon, 2007-11-19 at 13:08 -0800, Andrew Morton wrote: Heaven knows why though - why does __pfn_to_page() even exist? Perhaps it can go away with the discontig-sparsemem-vmemmap conversion. In fact, Christoph Lameter's