Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On Fri, 2017-05-19 at 11:15 +0800, Yanjun Zhu wrote: > >> Suggesting to remove kernel oops from commit log message, fix is > trivial. > > Please don't, they are useful. > Can we explain this in commit log message? > > The patch "IB/IPoIB: Support acceleration options callbacks" makes  >

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On Fri, 2017-05-19 at 11:15 +0800, Yanjun Zhu wrote: > >> Suggesting to remove kernel oops from commit log message, fix is > trivial. > > Please don't, they are useful. > Can we explain this in commit log message? > > The patch "IB/IPoIB: Support acceleration options callbacks" makes  >

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On Fri, May 19, 2017 at 11:15:32AM +0800, Yanjun Zhu wrote: > > > On 2017/5/11 20:40, Leon Romanovsky wrote: > > On Thu, May 11, 2017 at 03:31:10PM +0300, Yuval Shaia wrote: > > > On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: > > > > From: Honggang Li > > > > > >

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On Fri, May 19, 2017 at 11:15:32AM +0800, Yanjun Zhu wrote: > > > On 2017/5/11 20:40, Leon Romanovsky wrote: > > On Thu, May 11, 2017 at 03:31:10PM +0300, Yuval Shaia wrote: > > > On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: > > > > From: Honggang Li > > > > > > > > ipoib_dev_init

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On 2017/5/11 20:40, Leon Romanovsky wrote: On Thu, May 11, 2017 at 03:31:10PM +0300, Yuval Shaia wrote: On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv.

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On 2017/5/11 20:40, Leon Romanovsky wrote: On Thu, May 11, 2017 at 03:31:10PM +0300, Yuval Shaia wrote: On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv. ipoib_get_link_ksettings

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On 2017/5/11 20:14, Honggang LI wrote: From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. Otherwise kernel panic. [ 27.271938] IPv6: ADDRCONF(NETDEV_CHANGE):

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On 2017/5/11 20:14, Honggang LI wrote: From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. Otherwise kernel panic. [ 27.271938] IPv6: ADDRCONF(NETDEV_CHANGE): mlx5_ib0.8006: link becomes

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On Thu, May 11, 2017 at 03:31:10PM +0300, Yuval Shaia wrote: > On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: > > From: Honggang Li > > > > ipoib_dev_init accesses the private data for IPoIB net_device with > > ipoib_priv. ipoib_get_link_ksettings should do as

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On Thu, May 11, 2017 at 03:31:10PM +0300, Yuval Shaia wrote: > On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: > > From: Honggang Li > > > > ipoib_dev_init accesses the private data for IPoIB net_device with > > ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. > >

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: > From: Honggang Li > > ipoib_dev_init accesses the private data for IPoIB net_device with > ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. > Otherwise kernel panic. > > [ 27.271938] IPv6:

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: > From: Honggang Li > > ipoib_dev_init accesses the private data for IPoIB net_device with > ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. > Otherwise kernel panic. > > [ 27.271938] IPv6: ADDRCONF(NETDEV_CHANGE):

[PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. Otherwise kernel panic. [ 27.271938] IPv6: ADDRCONF(NETDEV_CHANGE): mlx5_ib0.8006: link becomes ready [ 28.156790] BUG:

[PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. Otherwise kernel panic. [ 27.271938] IPv6: ADDRCONF(NETDEV_CHANGE): mlx5_ib0.8006: link becomes ready [ 28.156790] BUG: unable to handle