Re: [PATCH] Introduced new tracing mode KCOV_MODE_UNIQUE.

2021-03-23 Thread Alexander Lochmann
On 23.03.21 08:23, Dmitry Vyukov wrote: >> diff --git a/kernel/kcov.c b/kernel/kcov.c >> index 80bfe71bbe13..1f727043146a 100644 >> --- a/kernel/kcov.c >> +++ b/kernel/kcov.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include > > Is this for __always_inline? >

Re: [PATCH] Introduced new tracing mode KCOV_MODE_UNIQUE.

2021-03-23 Thread Dmitry Vyukov
On Sun, Mar 21, 2021 at 7:44 PM Alexander Lochmann wrote: > > It simply stores the executed PCs. > The execution order is discarded. > Each bit in the shared buffer represents every fourth > byte of the text segment. > Since a call instruction on every supported > architecture is at least four

Re: [PATCH] Introduced new tracing mode KCOV_MODE_UNIQUE.

2021-03-22 Thread Alexander Lochmann
On 22.03.21 13:17, Miguel Ojeda wrote: > Hi Alexander, > > On Sun, Mar 21, 2021 at 8:14 PM Alexander Lochmann > wrote: >> >> diff --git a/Documentation/dev-tools/kcov.rst >> b/Documentation/dev-tools/kcov.rst >> index d2c4c27e1702..e105ffe6b6e3 100644 >> ---

Re: [PATCH] Introduced new tracing mode KCOV_MODE_UNIQUE.

2021-03-22 Thread Miguel Ojeda
Hi Alexander, On Sun, Mar 21, 2021 at 8:14 PM Alexander Lochmann wrote: > > diff --git a/Documentation/dev-tools/kcov.rst > b/Documentation/dev-tools/kcov.rst > index d2c4c27e1702..e105ffe6b6e3 100644 > --- a/Documentation/dev-tools/kcov.rst > +++ b/Documentation/dev-tools/kcov.rst > @@ -127,6

[PATCH] Introduced new tracing mode KCOV_MODE_UNIQUE.

2021-03-21 Thread Alexander Lochmann
It simply stores the executed PCs. The execution order is discarded. Each bit in the shared buffer represents every fourth byte of the text segment. Since a call instruction on every supported architecture is at least four bytes, it is safe to just store every fourth byte of the text segment. In