Re: [PATCH] PM / devfreq: Move struct devfreq_governor to devfreq directory

[Chanwoo Choi]

Hi,

On 2017년 04월 07일 15:41, MyungJoo Ham wrote:
>> This patch moves the struct devfreq_governor from header file
>> to the devfreq directory because this structure is private data
>> and it have to be only accessed by the devfreq core.
>>
>> Signed-off-by: Chanwoo Choi 
>> ---
>>  drivers/devfreq/governor.h | 29 +
>>  include/linux/devfreq.h| 30 +-
>>  2 files changed, 30 insertions(+), 29 deletions(-)
>>
> 
> Where have you based on the commit?
> It's not appliable to 4.11-rc5.

When I applied it to 4.11-rc5, there is no any conflict.

I used the 'git am' command. Also, As I knew,
after releasing the 4.11-rc1, there was no patches
related to both drivers/devfreq/governor.h and include/linux/devfreq.h

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCH] PM / devfreq: Move struct devfreq_governor to devfreq directory

[Chanwoo Choi]

Hi,

On 2017년 04월 07일 15:41, MyungJoo Ham wrote:
>> This patch moves the struct devfreq_governor from header file
>> to the devfreq directory because this structure is private data
>> and it have to be only accessed by the devfreq core.
>>
>> Signed-off-by: Chanwoo Choi 
>> ---
>>  drivers/devfreq/governor.h | 29 +
>>  include/linux/devfreq.h| 30 +-
>>  2 files changed, 30 insertions(+), 29 deletions(-)
>>
> 
> Where have you based on the commit?
> It's not appliable to 4.11-rc5.

When I applied it to 4.11-rc5, there is no any conflict.

I used the 'git am' command. Also, As I knew,
after releasing the 4.11-rc1, there was no patches
related to both drivers/devfreq/governor.h and include/linux/devfreq.h

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

RE: [PATCH] PM / devfreq: Move struct devfreq_governor to devfreq directory

[MyungJoo Ham]

> This patch moves the struct devfreq_governor from header file
> to the devfreq directory because this structure is private data
> and it have to be only accessed by the devfreq core.
> 
> Signed-off-by: Chanwoo Choi 
> ---
>  drivers/devfreq/governor.h | 29 +
>  include/linux/devfreq.h| 30 +-
>  2 files changed, 30 insertions(+), 29 deletions(-)
> 

Where have you based on the commit?
It's not appliable to 4.11-rc5.


Cheers,
MyungJoo

RE: [PATCH] PM / devfreq: Move struct devfreq_governor to devfreq directory

[MyungJoo Ham]

> This patch moves the struct devfreq_governor from header file
> to the devfreq directory because this structure is private data
> and it have to be only accessed by the devfreq core.
> 
> Signed-off-by: Chanwoo Choi 
> ---
>  drivers/devfreq/governor.h | 29 +
>  include/linux/devfreq.h| 30 +-
>  2 files changed, 30 insertions(+), 29 deletions(-)
> 

Where have you based on the commit?
It's not appliable to 4.11-rc5.


Cheers,
MyungJoo

[PATCH] PM / devfreq: Move struct devfreq_governor to devfreq directory

[Chanwoo Choi]

This patch moves the struct devfreq_governor from header file
to the devfreq directory because this structure is private data
and it have to be only accessed by the devfreq core.

Signed-off-by: Chanwoo Choi 
---
 drivers/devfreq/governor.h | 29 +
 include/linux/devfreq.h| 30 +-
 2 files changed, 30 insertions(+), 29 deletions(-)

diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
index 71576b8bdfef..a4f2fa1091e4 100644
--- a/drivers/devfreq/governor.h
+++ b/drivers/devfreq/governor.h
@@ -25,6 +25,35 @@
 #define DEVFREQ_GOV_SUSPEND0x4
 #define DEVFREQ_GOV_RESUME 0x5
 
+/**
+ * struct devfreq_governor - Devfreq policy governor
+ * @node:  list node - contains registered devfreq governors
+ * @name:  Governor's name
+ * @immutable: Immutable flag for governor. If the value is 1,
+ * this govenror is never changeable to other governor.
+ * @get_target_freq:   Returns desired operating frequency for the device.
+ * Basically, get_target_freq will run
+ * devfreq_dev_profile.get_dev_status() to get the
+ * status of the device (load = busy_time / total_time).
+ * If no_central_polling is set, this callback is called
+ * only with update_devfreq() notified by OPP.
+ * @event_handler:  Callback for devfreq core framework to notify events
+ *  to governors. Events include per device governor
+ *  init and exit, opp changes out of devfreq, suspend
+ *  and resume of per device devfreq during device idle.
+ *
+ * Note that the callbacks are called with devfreq->lock locked by devfreq.
+ */
+struct devfreq_governor {
+   struct list_head node;
+
+   const char name[DEVFREQ_NAME_LEN];
+   const unsigned int immutable;
+   int (*get_target_freq)(struct devfreq *this, unsigned long *freq);
+   int (*event_handler)(struct devfreq *devfreq,
+   unsigned int event, void *data);
+};
+
 /* Caution: devfreq->lock must be locked before calling update_devfreq */
 extern int update_devfreq(struct devfreq *devfreq);
 
diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
index e0acb0e5243b..6c220e4ebb6b 100644
--- a/include/linux/devfreq.h
+++ b/include/linux/devfreq.h
@@ -27,6 +27,7 @@
 #define DEVFREQ_POSTCHANGE (1)
 
 struct devfreq;
+struct devfreq_governor;
 
 /**
  * struct devfreq_dev_status - Data given from devfreq user device to
@@ -101,35 +102,6 @@ struct devfreq_dev_profile {
 };
 
 /**
- * struct devfreq_governor - Devfreq policy governor
- * @node:  list node - contains registered devfreq governors
- * @name:  Governor's name
- * @immutable: Immutable flag for governor. If the value is 1,
- * this govenror is never changeable to other governor.
- * @get_target_freq:   Returns desired operating frequency for the device.
- * Basically, get_target_freq will run
- * devfreq_dev_profile.get_dev_status() to get the
- * status of the device (load = busy_time / total_time).
- * If no_central_polling is set, this callback is called
- * only with update_devfreq() notified by OPP.
- * @event_handler:  Callback for devfreq core framework to notify events
- *  to governors. Events include per device governor
- *  init and exit, opp changes out of devfreq, suspend
- *  and resume of per device devfreq during device idle.
- *
- * Note that the callbacks are called with devfreq->lock locked by devfreq.
- */
-struct devfreq_governor {
-   struct list_head node;
-
-   const char name[DEVFREQ_NAME_LEN];
-   const unsigned int immutable;
-   int (*get_target_freq)(struct devfreq *this, unsigned long *freq);
-   int (*event_handler)(struct devfreq *devfreq,
-   unsigned int event, void *data);
-};
-
-/**
  * struct devfreq - Device devfreq structure
  * @node:  list node - contains the devices with devfreq that have been
  * registered.
-- 
1.9.1

[PATCH] PM / devfreq: Move struct devfreq_governor to devfreq directory

[Chanwoo Choi]

This patch moves the struct devfreq_governor from header file
to the devfreq directory because this structure is private data
and it have to be only accessed by the devfreq core.

Signed-off-by: Chanwoo Choi 
---
 drivers/devfreq/governor.h | 29 +
 include/linux/devfreq.h| 30 +-
 2 files changed, 30 insertions(+), 29 deletions(-)

diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
index 71576b8bdfef..a4f2fa1091e4 100644
--- a/drivers/devfreq/governor.h
+++ b/drivers/devfreq/governor.h
@@ -25,6 +25,35 @@
 #define DEVFREQ_GOV_SUSPEND0x4
 #define DEVFREQ_GOV_RESUME 0x5
 
+/**
+ * struct devfreq_governor - Devfreq policy governor
+ * @node:  list node - contains registered devfreq governors
+ * @name:  Governor's name
+ * @immutable: Immutable flag for governor. If the value is 1,
+ * this govenror is never changeable to other governor.
+ * @get_target_freq:   Returns desired operating frequency for the device.
+ * Basically, get_target_freq will run
+ * devfreq_dev_profile.get_dev_status() to get the
+ * status of the device (load = busy_time / total_time).
+ * If no_central_polling is set, this callback is called
+ * only with update_devfreq() notified by OPP.
+ * @event_handler:  Callback for devfreq core framework to notify events
+ *  to governors. Events include per device governor
+ *  init and exit, opp changes out of devfreq, suspend
+ *  and resume of per device devfreq during device idle.
+ *
+ * Note that the callbacks are called with devfreq->lock locked by devfreq.
+ */
+struct devfreq_governor {
+   struct list_head node;
+
+   const char name[DEVFREQ_NAME_LEN];
+   const unsigned int immutable;
+   int (*get_target_freq)(struct devfreq *this, unsigned long *freq);
+   int (*event_handler)(struct devfreq *devfreq,
+   unsigned int event, void *data);
+};
+
 /* Caution: devfreq->lock must be locked before calling update_devfreq */
 extern int update_devfreq(struct devfreq *devfreq);
 
diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
index e0acb0e5243b..6c220e4ebb6b 100644
--- a/include/linux/devfreq.h
+++ b/include/linux/devfreq.h
@@ -27,6 +27,7 @@
 #define DEVFREQ_POSTCHANGE (1)
 
 struct devfreq;
+struct devfreq_governor;
 
 /**
  * struct devfreq_dev_status - Data given from devfreq user device to
@@ -101,35 +102,6 @@ struct devfreq_dev_profile {
 };
 
 /**
- * struct devfreq_governor - Devfreq policy governor
- * @node:  list node - contains registered devfreq governors
- * @name:  Governor's name
- * @immutable: Immutable flag for governor. If the value is 1,
- * this govenror is never changeable to other governor.
- * @get_target_freq:   Returns desired operating frequency for the device.
- * Basically, get_target_freq will run
- * devfreq_dev_profile.get_dev_status() to get the
- * status of the device (load = busy_time / total_time).
- * If no_central_polling is set, this callback is called
- * only with update_devfreq() notified by OPP.
- * @event_handler:  Callback for devfreq core framework to notify events
- *  to governors. Events include per device governor
- *  init and exit, opp changes out of devfreq, suspend
- *  and resume of per device devfreq during device idle.
- *
- * Note that the callbacks are called with devfreq->lock locked by devfreq.
- */
-struct devfreq_governor {
-   struct list_head node;
-
-   const char name[DEVFREQ_NAME_LEN];
-   const unsigned int immutable;
-   int (*get_target_freq)(struct devfreq *this, unsigned long *freq);
-   int (*event_handler)(struct devfreq *devfreq,
-   unsigned int event, void *data);
-};
-
-/**
  * struct devfreq - Device devfreq structure
  * @node:  list node - contains the devices with devfreq that have been
  * registered.
-- 
1.9.1