Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

[ ... ] > About the error handling... you advised against panic() > because there might be other clock sources. > > Does it makes sense to give up registering sched_clock > and delay_timer when the clocksource registration fails? Actually, all the problem is coming from the

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

[ ... ] > About the error handling... you advised against panic() > because there might be other clock sources. > > Does it makes sense to give up registering sched_clock > and delay_timer when the clocksource registration fails? Actually, all the problem is coming from the

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On 19/04/2016 19:31, Daniel Lezcano wrote: > On Tue, Apr 19, 2016 at 07:21:20PM +0200, Mason wrote: >> On 19/04/2016 16:59, Daniel Lezcano wrote: >>> On Tue, Apr 19, 2016 at 04:05:19PM +0200, Mason wrote: On 19/04/2016 15:13, Daniel Lezcano wrote: > On Tue, Apr 19, 2016 at 02:15:15PM

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On 19/04/2016 19:31, Daniel Lezcano wrote: > On Tue, Apr 19, 2016 at 07:21:20PM +0200, Mason wrote: >> On 19/04/2016 16:59, Daniel Lezcano wrote: >>> On Tue, Apr 19, 2016 at 04:05:19PM +0200, Mason wrote: On 19/04/2016 15:13, Daniel Lezcano wrote: > On Tue, Apr 19, 2016 at 02:15:15PM

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On Tue, Apr 19, 2016 at 07:21:20PM +0200, Mason wrote: > On 19/04/2016 16:59, Daniel Lezcano wrote: > > On Tue, Apr 19, 2016 at 04:05:19PM +0200, Mason wrote: > >> On 19/04/2016 15:13, Daniel Lezcano wrote: > >> > >>> On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: > >>> > From: Marc

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On Tue, Apr 19, 2016 at 07:21:20PM +0200, Mason wrote: > On 19/04/2016 16:59, Daniel Lezcano wrote: > > On Tue, Apr 19, 2016 at 04:05:19PM +0200, Mason wrote: > >> On 19/04/2016 15:13, Daniel Lezcano wrote: > >> > >>> On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: > >>> > From: Marc

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On 19/04/2016 16:59, Daniel Lezcano wrote: > On Tue, Apr 19, 2016 at 04:05:19PM +0200, Mason wrote: >> On 19/04/2016 15:13, Daniel Lezcano wrote: >> >>> On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: >>> From: Marc Gonzalez Commit

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On 19/04/2016 16:59, Daniel Lezcano wrote: > On Tue, Apr 19, 2016 at 04:05:19PM +0200, Mason wrote: >> On 19/04/2016 15:13, Daniel Lezcano wrote: >> >>> On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: >>> From: Marc Gonzalez Commit 0881841f7e78 changed "if (ret != 0)" to "if

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On Tue, Apr 19, 2016 at 04:05:19PM +0200, Mason wrote: > On 19/04/2016 15:13, Daniel Lezcano wrote: > > > On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: > > > >> From: Marc Gonzalez > >> > >> Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)" > >>

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On Tue, Apr 19, 2016 at 04:05:19PM +0200, Mason wrote: > On 19/04/2016 15:13, Daniel Lezcano wrote: > > > On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: > > > >> From: Marc Gonzalez > >> > >> Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)" > >> > >> Fixes: 0881841f7e78

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On 19/04/2016 15:13, Daniel Lezcano wrote: > On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: > >> From: Marc Gonzalez >> >> Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)" >> >> Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init") >>

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On 19/04/2016 15:13, Daniel Lezcano wrote: > On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: > >> From: Marc Gonzalez >> >> Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)" >> >> Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init") >> Signed-off-by: Marc Gonzalez >>

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: > From: Marc Gonzalez > > Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)" > > Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init") > Signed-off-by: Marc Gonzalez

Re: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

On Tue, Apr 19, 2016 at 02:15:15PM +0200, Mason wrote: > From: Marc Gonzalez > > Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)" > > Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init") > Signed-off-by: Marc Gonzalez > --- Please resend the patch with the fix only, without

[PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

From: Marc Gonzalez Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)" Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init") Signed-off-by: Marc Gonzalez --- drivers/clocksource/tango_xtal.c | 6 +++--- 1 file

[PATCH] clocksource/drivers/tango-xtal: Fix incorrect test

From: Marc Gonzalez Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)" Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init") Signed-off-by: Marc Gonzalez --- drivers/clocksource/tango_xtal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git