Re: [PATCH] crypto: algif_skcipher: replace sg++ with sg_next()

2016-05-03 Thread Herbert Xu
Muhammad Falak R Wani wrote: > Never use sg++, always use sg = sg_next(sg). Scatterlist entries can > be combined if the memory is contiguous but sg++ won't know about > that. It sure would run on the slower side. > But regardless, sg++ should never be used, only sg_next is

Re: [PATCH] crypto: algif_skcipher: replace sg++ with sg_next()

2016-05-03 Thread Herbert Xu
Muhammad Falak R Wani wrote: > Never use sg++, always use sg = sg_next(sg). Scatterlist entries can > be combined if the memory is contiguous but sg++ won't know about > that. It sure would run on the slower side. > But regardless, sg++ should never be used, only sg_next is safe. > >

[PATCH] crypto: algif_skcipher: replace sg++ with sg_next()

2016-05-03 Thread Muhammad Falak R Wani
Never use sg++, always use sg = sg_next(sg). Scatterlist entries can be combined if the memory is contiguous but sg++ won't know about that. It sure would run on the slower side. But regardless, sg++ should never be used, only sg_next is safe. Signed-off-by: Muhammad Falak R Wani

[PATCH] crypto: algif_skcipher: replace sg++ with sg_next()

2016-05-03 Thread Muhammad Falak R Wani
Never use sg++, always use sg = sg_next(sg). Scatterlist entries can be combined if the memory is contiguous but sg++ won't know about that. It sure would run on the slower side. But regardless, sg++ should never be used, only sg_next is safe. Signed-off-by: Muhammad Falak R Wani ---