Re: [PATCH] dmaengine: device must have at least one channel

2016-08-22 Thread Vinod Koul
On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > The DMA device can't be registered if it doesn't have any channels > registered at all. Moreover, it leads to memory leak and is reported by > kmemleak as (on 3.10 kernel, and same shall happen on mainline): > > unreferenced object

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-22 Thread Vinod Koul
On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > The DMA device can't be registered if it doesn't have any channels > registered at all. Moreover, it leads to memory leak and is reported by > kmemleak as (on 3.10 kernel, and same shall happen on mainline): > > unreferenced object

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-08 Thread Viresh Kumar
On 08-08-16, 19:06, Greg Kroah-Hartman wrote: > So only the drivers that are out-of-tree are broken with this patch? > > I like it :) I know that and I like it too :) But yeah its only the *hacky* out of tree drivers are going to be broken with this. -- viresh

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-08 Thread Viresh Kumar
On 08-08-16, 19:06, Greg Kroah-Hartman wrote: > So only the drivers that are out-of-tree are broken with this patch? > > I like it :) I know that and I like it too :) But yeah its only the *hacky* out of tree drivers are going to be broken with this. -- viresh

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-08 Thread Greg Kroah-Hartman
On Mon, Aug 08, 2016 at 08:24:49AM -0700, Viresh Kumar wrote: > On 08-08-16, 13:47, Vinod Koul wrote: > > On Fri, Aug 05, 2016 at 09:30:50AM -0700, Viresh Kumar wrote: > > > On 03-08-16, 21:34, Greg Kroah-Hartman wrote: > > > > > > To follow up on this, as you found out, this patch breaks working

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-08 Thread Greg Kroah-Hartman
On Mon, Aug 08, 2016 at 08:24:49AM -0700, Viresh Kumar wrote: > On 08-08-16, 13:47, Vinod Koul wrote: > > On Fri, Aug 05, 2016 at 09:30:50AM -0700, Viresh Kumar wrote: > > > On 03-08-16, 21:34, Greg Kroah-Hartman wrote: > > > > > > To follow up on this, as you found out, this patch breaks working

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-08 Thread Viresh Kumar
On 08-08-16, 13:47, Vinod Koul wrote: > On Fri, Aug 05, 2016 at 09:30:50AM -0700, Viresh Kumar wrote: > > On 03-08-16, 21:34, Greg Kroah-Hartman wrote: > > > > To follow up on this, as you found out, this patch breaks working > > > hardware, so please don't apply it anywhere. It needs more

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-08 Thread Viresh Kumar
On 08-08-16, 13:47, Vinod Koul wrote: > On Fri, Aug 05, 2016 at 09:30:50AM -0700, Viresh Kumar wrote: > > On 03-08-16, 21:34, Greg Kroah-Hartman wrote: > > > > To follow up on this, as you found out, this patch breaks working > > > hardware, so please don't apply it anywhere. It needs more

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-08 Thread Vinod Koul
On Fri, Aug 05, 2016 at 09:30:50AM -0700, Viresh Kumar wrote: > On 03-08-16, 21:34, Greg Kroah-Hartman wrote: > > To follow up on this, as you found out, this patch breaks working > > hardware, so please don't apply it anywhere. It needs more debugging to > > figure out exactly what is going on

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-08 Thread Vinod Koul
On Fri, Aug 05, 2016 at 09:30:50AM -0700, Viresh Kumar wrote: > On 03-08-16, 21:34, Greg Kroah-Hartman wrote: > > To follow up on this, as you found out, this patch breaks working > > hardware, so please don't apply it anywhere. It needs more debugging to > > figure out exactly what is going on

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-05 Thread Viresh Kumar
On 03-08-16, 21:34, Greg Kroah-Hartman wrote: > On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > > The DMA device can't be registered if it doesn't have any channels > > registered at all. Moreover, it leads to memory leak and is reported by > > kmemleak as (on 3.10 kernel, and same

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-05 Thread Viresh Kumar
On 03-08-16, 21:34, Greg Kroah-Hartman wrote: > On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > > The DMA device can't be registered if it doesn't have any channels > > registered at all. Moreover, it leads to memory leak and is reported by > > kmemleak as (on 3.10 kernel, and same

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-03 Thread Greg Kroah-Hartman
On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > The DMA device can't be registered if it doesn't have any channels > registered at all. Moreover, it leads to memory leak and is reported by > kmemleak as (on 3.10 kernel, and same shall happen on mainline): > > unreferenced object

Re: [PATCH] dmaengine: device must have at least one channel

2016-08-03 Thread Greg Kroah-Hartman
On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > The DMA device can't be registered if it doesn't have any channels > registered at all. Moreover, it leads to memory leak and is reported by > kmemleak as (on 3.10 kernel, and same shall happen on mainline): > > unreferenced object

Re: [PATCH] dmaengine: device must have at least one channel

2016-07-27 Thread Viresh Kumar
On 28-07-16, 09:18, Vinod Koul wrote: > On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > > The DMA device can't be registered if it doesn't have any channels > > registered at all. Moreover, it leads to memory leak and is reported by > > kmemleak as (on 3.10 kernel, and same shall

Re: [PATCH] dmaengine: device must have at least one channel

2016-07-27 Thread Viresh Kumar
On 28-07-16, 09:18, Vinod Koul wrote: > On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > > The DMA device can't be registered if it doesn't have any channels > > registered at all. Moreover, it leads to memory leak and is reported by > > kmemleak as (on 3.10 kernel, and same shall

Re: [PATCH] dmaengine: device must have at least one channel

2016-07-27 Thread Vinod Koul
On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > The DMA device can't be registered if it doesn't have any channels > registered at all. Moreover, it leads to memory leak and is reported by > kmemleak as (on 3.10 kernel, and same shall happen on mainline): > > unreferenced object

Re: [PATCH] dmaengine: device must have at least one channel

2016-07-27 Thread Vinod Koul
On Wed, Jul 27, 2016 at 02:32:58PM -0700, Viresh Kumar wrote: > The DMA device can't be registered if it doesn't have any channels > registered at all. Moreover, it leads to memory leak and is reported by > kmemleak as (on 3.10 kernel, and same shall happen on mainline): > > unreferenced object

[PATCH] dmaengine: device must have at least one channel

2016-07-27 Thread Viresh Kumar
The DMA device can't be registered if it doesn't have any channels registered at all. Moreover, it leads to memory leak and is reported by kmemleak as (on 3.10 kernel, and same shall happen on mainline): unreferenced object 0xffc09e597240 (size 64): comm "swapper/0", pid 1, jiffies

[PATCH] dmaengine: device must have at least one channel

2016-07-27 Thread Viresh Kumar
The DMA device can't be registered if it doesn't have any channels registered at all. Moreover, it leads to memory leak and is reported by kmemleak as (on 3.10 kernel, and same shall happen on mainline): unreferenced object 0xffc09e597240 (size 64): comm "swapper/0", pid 1, jiffies