Re: [PATCH] docuement filesystem helpers for custom 'struct file's

2007-09-20 Thread Christoph Hellwig
On Thu, Sep 20, 2007 at 10:25:56AM -0700, Dave Hansen wrote: > Should we do comments for every single function argument, or is it OK to > leave them out for the obvious ones? Yes, we should keep the kerneldoc comments coherent, even if it seems useless in a few cases. - To unsubscribe from this

Re: [PATCH] docuement filesystem helpers for custom 'struct file's

2007-09-20 Thread Dave Hansen
On Wed, 2007-09-19 at 15:07 -0700, Randy Dunlap wrote: > > They aren't quite in kernel-doc format. Holler if you need help > with that, or see examples, or > Documentation/kernel-doc-nano-HOWTO.txt. Should we do comments for every single function argument, or is it OK to leave them out for the

Re: [PATCH] docuement filesystem helpers for custom 'struct file's

2007-09-20 Thread Dave Hansen
On Wed, 2007-09-19 at 15:07 -0700, Randy Dunlap wrote: They aren't quite in kernel-doc format. Holler if you need help with that, or see examples, or Documentation/kernel-doc-nano-HOWTO.txt. Should we do comments for every single function argument, or is it OK to leave them out for the

Re: [PATCH] docuement filesystem helpers for custom 'struct file's

2007-09-20 Thread Christoph Hellwig
On Thu, Sep 20, 2007 at 10:25:56AM -0700, Dave Hansen wrote: Should we do comments for every single function argument, or is it OK to leave them out for the obvious ones? Yes, we should keep the kerneldoc comments coherent, even if it seems useless in a few cases. - To unsubscribe from this

Re: [PATCH] docuement filesystem helpers for custom 'struct file's

2007-09-19 Thread Randy Dunlap
On Wed, 19 Sep 2007 10:47:23 -0700 Dave Hansen wrote: > On Wed, 2007-09-19 at 18:26 +0100, Christoph Hellwig wrote: > > On Mon, Sep 17, 2007 at 11:27:18AM -0700, Dave Hansen wrote: > > > > > > Christoph H. says this stands on its own and can go in before the > > > rest of the r/o bind mount set.

[PATCH] docuement filesystem helpers for custom 'struct file's

2007-09-19 Thread Dave Hansen
On Wed, 2007-09-19 at 18:26 +0100, Christoph Hellwig wrote: > On Mon, Sep 17, 2007 at 11:27:18AM -0700, Dave Hansen wrote: > > > > Christoph H. says this stands on its own and can go in before the > > rest of the r/o bind mount set. > > > > --- > > > > Some filesystems forego the vfs and

[PATCH] docuement filesystem helpers for custom 'struct file's

2007-09-19 Thread Dave Hansen
On Wed, 2007-09-19 at 18:26 +0100, Christoph Hellwig wrote: On Mon, Sep 17, 2007 at 11:27:18AM -0700, Dave Hansen wrote: Christoph H. says this stands on its own and can go in before the rest of the r/o bind mount set. --- Some filesystems forego the vfs and may_open() and

Re: [PATCH] docuement filesystem helpers for custom 'struct file's

2007-09-19 Thread Randy Dunlap
On Wed, 19 Sep 2007 10:47:23 -0700 Dave Hansen wrote: On Wed, 2007-09-19 at 18:26 +0100, Christoph Hellwig wrote: On Mon, Sep 17, 2007 at 11:27:18AM -0700, Dave Hansen wrote: Christoph H. says this stands on its own and can go in before the rest of the r/o bind mount set.