Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-31 Thread Marcel Apfelbaum
On 30/07/2017 12:57, Moni Shoua wrote: Have you considered using ip_route_output_key() for IPv4 or ip6_route_output() for IPv6 to decide if this is a loopback? For reference you can check the flow starting at rdma_resolve_ip() Hi Moni, Yes, I had looked into it, but I haven't seen how I

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-31 Thread Marcel Apfelbaum
On 30/07/2017 12:57, Moni Shoua wrote: Have you considered using ip_route_output_key() for IPv4 or ip6_route_output() for IPv6 to decide if this is a loopback? For reference you can check the flow starting at rdma_resolve_ip() Hi Moni, Yes, I had looked into it, but I haven't seen how I

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-30 Thread Moni Shoua
>> Have you considered using ip_route_output_key() for IPv4 or >> ip6_route_output() for IPv6 to decide if this is a loopback? >> For reference you can check the flow starting at rdma_resolve_ip() >> > > Hi Moni, > > Yes, I had looked into it, but I haven't seen how I can find > out if the

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-30 Thread Moni Shoua
>> Have you considered using ip_route_output_key() for IPv4 or >> ip6_route_output() for IPv6 to decide if this is a loopback? >> For reference you can check the flow starting at rdma_resolve_ip() >> > > Hi Moni, > > Yes, I had looked into it, but I haven't seen how I can find > out if the

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread kbuild test robot
Hi Marcel, [auto build test ERROR on rdma/master] [also build test ERROR on v4.13-rc2 next-20170727] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread kbuild test robot
Hi Marcel, [auto build test ERROR on rdma/master] [also build test ERROR on v4.13-rc2 next-20170727] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Leon Romanovsky
On Thu, Jul 27, 2017 at 12:49:17PM +0300, Marcel Apfelbaum wrote: > On 27/07/2017 10:36, Leon Romanovsky wrote: > > On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > > > Currently a packet is marked for loopback only if the source and > > > destination address match. This is not

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Leon Romanovsky
On Thu, Jul 27, 2017 at 12:49:17PM +0300, Marcel Apfelbaum wrote: > On 27/07/2017 10:36, Leon Romanovsky wrote: > > On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > > > Currently a packet is marked for loopback only if the source and > > > destination address match. This is not

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Marcel Apfelbaum
On 27/07/2017 10:04, Moni Shoua wrote: On Wed, Jul 26, 2017 at 10:57 PM, Yuval Shaia wrote: On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: Currently a packet is marked for loopback only if the source and destination address match. This is not enough

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Marcel Apfelbaum
On 27/07/2017 10:04, Moni Shoua wrote: On Wed, Jul 26, 2017 at 10:57 PM, Yuval Shaia wrote: On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: Currently a packet is marked for loopback only if the source and destination address match. This is not enough when multiple gids are

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Marcel Apfelbaum
On 27/07/2017 10:36, Leon Romanovsky wrote: On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: Currently a packet is marked for loopback only if the source and destination address match. This is not enough when multiple gids are present in rxe's gid table and the traffic is from

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Marcel Apfelbaum
On 27/07/2017 10:36, Leon Romanovsky wrote: On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: Currently a packet is marked for loopback only if the source and destination address match. This is not enough when multiple gids are present in rxe's gid table and the traffic is from

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Leon Romanovsky
On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > Currently a packet is marked for loopback only if the source and > destination address match. This is not enough when multiple > gids are present in rxe's gid table and the traffic is > from one gid to another. > > Fix it by

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Leon Romanovsky
On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > Currently a packet is marked for loopback only if the source and > destination address match. This is not enough when multiple > gids are present in rxe's gid table and the traffic is > from one gid to another. > > Fix it by

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Moni Shoua
On Wed, Jul 26, 2017 at 10:57 PM, Yuval Shaia wrote: > On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: >> Currently a packet is marked for loopback only if the source and >> destination address match. This is not enough when multiple >> gids are present

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-27 Thread Moni Shoua
On Wed, Jul 26, 2017 at 10:57 PM, Yuval Shaia wrote: > On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: >> Currently a packet is marked for loopback only if the source and >> destination address match. This is not enough when multiple >> gids are present in rxe's gid table and

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-26 Thread Yuval Shaia
On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > Currently a packet is marked for loopback only if the source and > destination address match. This is not enough when multiple > gids are present in rxe's gid table and the traffic is > from one gid to another. > > Fix it by

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-26 Thread Yuval Shaia
On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > Currently a packet is marked for loopback only if the source and > destination address match. This is not enough when multiple > gids are present in rxe's gid table and the traffic is > from one gid to another. > > Fix it by

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-26 Thread Yuval Shaia
> > + endfor_ifa(in_dev); > > The above endfor_ifa should move to below. Please ignore, my mistake. > > > +out:

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-26 Thread Yuval Shaia
> > + endfor_ifa(in_dev); > > The above endfor_ifa should move to below. Please ignore, my mistake. > > > +out:

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-26 Thread Yuval Shaia
On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > Currently a packet is marked for loopback only if the source and > destination address match. This is not enough when multiple > gids are present in rxe's gid table and the traffic is > from one gid to another. > > Fix it by

Re: [PATCH] drivers/rxe: improve rxe loopback

2017-07-26 Thread Yuval Shaia
On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote: > Currently a packet is marked for loopback only if the source and > destination address match. This is not enough when multiple > gids are present in rxe's gid table and the traffic is > from one gid to another. > > Fix it by

[PATCH] drivers/rxe: improve rxe loopback

2017-07-26 Thread Marcel Apfelbaum
Currently a packet is marked for loopback only if the source and destination address match. This is not enough when multiple gids are present in rxe's gid table and the traffic is from one gid to another. Fix it by marking the packet for loopback if the destination address appears in rxe's gid

[PATCH] drivers/rxe: improve rxe loopback

2017-07-26 Thread Marcel Apfelbaum
Currently a packet is marked for loopback only if the source and destination address match. This is not enough when multiple gids are present in rxe's gid table and the traffic is from one gid to another. Fix it by marking the packet for loopback if the destination address appears in rxe's gid