Re: [f2fs-dev] [PATCH] f2fs: allocate a bio for discarding when actually issuing it

2017-03-08 Thread Chao Yu
Hi Jaegeuk, On 2017/3/8 10:33, Jaegeuk Kim wrote: > Let's allocate a bio when issuing discard commands later. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h| 4 +- > fs/f2fs/segment.c | 113 > -- > 2 files

Re: [f2fs-dev] [PATCH] f2fs: allocate a bio for discarding when actually issuing it

2017-03-08 Thread Chao Yu
Hi Jaegeuk, On 2017/3/8 10:33, Jaegeuk Kim wrote: > Let's allocate a bio when issuing discard commands later. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h| 4 +- > fs/f2fs/segment.c | 113 > -- > 2 files changed, 62

Re: [PATCH] f2fs: allocate a bio for discarding when actually issuing it

2017-03-08 Thread Jaegeuk Kim
On 03/08, Christoph Hellwig wrote: > On Tue, Mar 07, 2017 at 06:33:33PM -0800, Jaegeuk Kim wrote: > > Let's allocate a bio when issuing discard commands later. > > Does this solve the issue with your queue stalls? No, the patch just changes bio_alloc timings, but the stall happens when doing

Re: [PATCH] f2fs: allocate a bio for discarding when actually issuing it

2017-03-08 Thread Jaegeuk Kim
On 03/08, Christoph Hellwig wrote: > On Tue, Mar 07, 2017 at 06:33:33PM -0800, Jaegeuk Kim wrote: > > Let's allocate a bio when issuing discard commands later. > > Does this solve the issue with your queue stalls? No, the patch just changes bio_alloc timings, but the stall happens when doing

Re: [PATCH] f2fs: allocate a bio for discarding when actually issuing it

2017-03-08 Thread Christoph Hellwig
On Tue, Mar 07, 2017 at 06:33:33PM -0800, Jaegeuk Kim wrote: > Let's allocate a bio when issuing discard commands later. Does this solve the issue with your queue stalls? > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h| 4 +- > fs/f2fs/segment.c | 113 >

Re: [PATCH] f2fs: allocate a bio for discarding when actually issuing it

2017-03-08 Thread Christoph Hellwig
On Tue, Mar 07, 2017 at 06:33:33PM -0800, Jaegeuk Kim wrote: > Let's allocate a bio when issuing discard commands later. Does this solve the issue with your queue stalls? > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h| 4 +- > fs/f2fs/segment.c | 113 >

[PATCH] f2fs: allocate a bio for discarding when actually issuing it

2017-03-07 Thread Jaegeuk Kim
Let's allocate a bio when issuing discard commands later. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h| 4 +- fs/f2fs/segment.c | 113 -- 2 files changed, 62 insertions(+), 55 deletions(-) diff --git

[PATCH] f2fs: allocate a bio for discarding when actually issuing it

2017-03-07 Thread Jaegeuk Kim
Let's allocate a bio when issuing discard commands later. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h| 4 +- fs/f2fs/segment.c | 113 -- 2 files changed, 62 insertions(+), 55 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h