Re: [PATCH] mm/memory-failure: fix race with compound page split/merge

2016-04-21 Thread Andrew Morton
On Mon, 18 Apr 2016 23:15:52 + Naoya Horiguchi wrote: > # CCed Andrew, Thanks. > On Mon, Apr 18, 2016 at 02:43:45PM +0300, Konstantin Khlebnikov wrote: > > Get_hwpoison_page() must recheck relation between head and tail pages. > > > > Signed-off-by: Konstantin

Re: [PATCH] mm/memory-failure: fix race with compound page split/merge

2016-04-21 Thread Andrew Morton
On Mon, 18 Apr 2016 23:15:52 + Naoya Horiguchi wrote: > # CCed Andrew, Thanks. > On Mon, Apr 18, 2016 at 02:43:45PM +0300, Konstantin Khlebnikov wrote: > > Get_hwpoison_page() must recheck relation between head and tail pages. > > > > Signed-off-by: Konstantin Khlebnikov > > Looks good

Re: [PATCH] mm/memory-failure: fix race with compound page split/merge

2016-04-18 Thread Konstantin Khlebnikov
On Tue, Apr 19, 2016 at 2:15 AM, Naoya Horiguchi wrote: > # CCed Andrew, > > On Mon, Apr 18, 2016 at 02:43:45PM +0300, Konstantin Khlebnikov wrote: >> Get_hwpoison_page() must recheck relation between head and tail pages. >> >> Signed-off-by: Konstantin Khlebnikov

Re: [PATCH] mm/memory-failure: fix race with compound page split/merge

2016-04-18 Thread Konstantin Khlebnikov
On Tue, Apr 19, 2016 at 2:15 AM, Naoya Horiguchi wrote: > # CCed Andrew, > > On Mon, Apr 18, 2016 at 02:43:45PM +0300, Konstantin Khlebnikov wrote: >> Get_hwpoison_page() must recheck relation between head and tail pages. >> >> Signed-off-by: Konstantin Khlebnikov > > Looks good to me. Without

Re: [PATCH] mm/memory-failure: fix race with compound page split/merge

2016-04-18 Thread Naoya Horiguchi
# CCed Andrew, On Mon, Apr 18, 2016 at 02:43:45PM +0300, Konstantin Khlebnikov wrote: > Get_hwpoison_page() must recheck relation between head and tail pages. > > Signed-off-by: Konstantin Khlebnikov Looks good to me. Without this recheck, the race causes kernel to

Re: [PATCH] mm/memory-failure: fix race with compound page split/merge

2016-04-18 Thread Naoya Horiguchi
# CCed Andrew, On Mon, Apr 18, 2016 at 02:43:45PM +0300, Konstantin Khlebnikov wrote: > Get_hwpoison_page() must recheck relation between head and tail pages. > > Signed-off-by: Konstantin Khlebnikov Looks good to me. Without this recheck, the race causes kernel to pin an irrelevant page, and

[PATCH] mm/memory-failure: fix race with compound page split/merge

2016-04-18 Thread Konstantin Khlebnikov
Get_hwpoison_page() must recheck relation between head and tail pages. Signed-off-by: Konstantin Khlebnikov --- mm/memory-failure.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index

[PATCH] mm/memory-failure: fix race with compound page split/merge

2016-04-18 Thread Konstantin Khlebnikov
Get_hwpoison_page() must recheck relation between head and tail pages. Signed-off-by: Konstantin Khlebnikov --- mm/memory-failure.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 78f5f2641b91..ca5acee53b7a 100644