Re: [PATCH] mtime attribute is not being updated on client

2005-04-08 Thread Linda Dunaphant
On Fri, 2005-04-08 at 16:54, Linda Dunaphant wrote: >Do you think it would be better for nfs_refresh_inode() to check the mtime, >perform the mtime update if needed, and not set the NFS_INO_INVALID_ATTR >flag if the data_unstable flag is set? This is how nfs_update_inode() >handles its mtime

Re: [PATCH] mtime attribute is not being updated on client

2005-04-08 Thread Linda Dunaphant
On Fri, 2005-04-08 at 09:11, Trond Myklebust wrote: > I'm a bit unclear as to what your end-goal is here. Is it basically to >ensure that fstat() always return the correct value for the mtime? > > The reason I ask is that I think your change is likely to have nasty >consequences for the general

Re: [PATCH] mtime attribute is not being updated on client

2005-04-08 Thread Trond Myklebust
to den 07.04.2005 Klokka 20:52 (-0400) skreiv Linda Dunaphant: > Hi Trond, > > The acregmin (default=3) and acregmax (default=60) NFS attributes that > control the min and max attribute cache lifetimes don't appear to be > working after the first few timeouts. Using a test program that loops >

Re: [PATCH] mtime attribute is not being updated on client

2005-04-08 Thread Trond Myklebust
to den 07.04.2005 Klokka 20:52 (-0400) skreiv Linda Dunaphant: Hi Trond, The acregmin (default=3) and acregmax (default=60) NFS attributes that control the min and max attribute cache lifetimes don't appear to be working after the first few timeouts. Using a test program that loops on the

Re: [PATCH] mtime attribute is not being updated on client

2005-04-08 Thread Linda Dunaphant
On Fri, 2005-04-08 at 09:11, Trond Myklebust wrote: I'm a bit unclear as to what your end-goal is here. Is it basically to ensure that fstat() always return the correct value for the mtime? The reason I ask is that I think your change is likely to have nasty consequences for the general

Re: [PATCH] mtime attribute is not being updated on client

2005-04-08 Thread Linda Dunaphant
On Fri, 2005-04-08 at 16:54, Linda Dunaphant wrote: Do you think it would be better for nfs_refresh_inode() to check the mtime, perform the mtime update if needed, and not set the NFS_INO_INVALID_ATTR flag if the data_unstable flag is set? This is how nfs_update_inode() handles its mtime check.

[PATCH] mtime attribute is not being updated on client

2005-04-07 Thread Linda Dunaphant
Hi Trond, The acregmin (default=3) and acregmax (default=60) NFS attributes that control the min and max attribute cache lifetimes don't appear to be working after the first few timeouts. Using a test program that loops on the following sequence: - write to a file on an NFS3 mounted

[PATCH] mtime attribute is not being updated on client

2005-04-07 Thread Linda Dunaphant
Hi Trond, The acregmin (default=3) and acregmax (default=60) NFS attributes that control the min and max attribute cache lifetimes don't appear to be working after the first few timeouts. Using a test program that loops on the following sequence: - write to a file on an NFS3 mounted