Re: [PATCH] net: phy: add Marvell 88X2222 transceiver support

2021-02-02 Thread Ivan Bornyakov
On Tue, Feb 02, 2021 at 04:48:01PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 01, 2021 at 10:22:51PM +0300, Ivan Bornyakov wrote: > > +/* PMD Transmit Disable */ > > +#defineMV_TX_DISABLE 0x0009 > > +#defineMV_TX_DISABLE_GLOBALBIT(0) > > Please use

Re: [PATCH] net: phy: add Marvell 88X2222 transceiver support

2021-02-02 Thread Russell King - ARM Linux admin
On Mon, Feb 01, 2021 at 10:22:51PM +0300, Ivan Bornyakov wrote: > +/* PMD Transmit Disable */ > +#define MV_TX_DISABLE 0x0009 > +#define MV_TX_DISABLE_GLOBALBIT(0) Please use MDIO_PMA_TXDIS and MDIO_PMD_TXDIS_GLOBAL; this is an IEEE802.3 defined register. > +/* 10GBASE-R

Re: [PATCH] net: phy: add Marvell 88X2222 transceiver support

2021-02-02 Thread Ivan Bornyakov
On Mon, Feb 01, 2021 at 11:56:01PM +0100, Andrew Lunn wrote: > > +static int mv_config_init(struct phy_device *phydev) > > +{ > > + linkmode_zero(phydev->supported); > > + linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->supported); > > +

Re: [PATCH] net: phy: add Marvell 88X2222 transceiver support

2021-02-01 Thread Andrew Lunn
> +static int mv_config_init(struct phy_device *phydev) > +{ > + linkmode_zero(phydev->supported); > + linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->supported); > + linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, phydev->supported); > +

[PATCH] net: phy: add Marvell 88X2222 transceiver support

2021-02-01 Thread Ivan Bornyakov
Add basic support for the Marvell 88X multi-speed ethernet transceiver. This PHY provides data transmission over fiber-optic as well as Twinax copper links. The 88X supports 2 ports of 10GBase-R and 1000Base-X on the line-side interface. The host-side interface supports 4 ports of