Re: [PATCH] ntb_transport: use put_device() instead of kfree()

2018-05-22 Thread Logan Gunthorpe
On 21/05/18 06:48 PM, Jon Mason wrote: > On Fri, Mar 09, 2018 at 04:03:24PM +0530, Arvind Yadav wrote: >> Never directly free @dev after calling device_register(), even >> if it returned an error! Always use put_device() to give up the >> reference initialized. >> >> Signed-off-by: Arvind Yadav

Re: [PATCH] ntb_transport: use put_device() instead of kfree()

2018-05-22 Thread Logan Gunthorpe
On 21/05/18 06:48 PM, Jon Mason wrote: > On Fri, Mar 09, 2018 at 04:03:24PM +0530, Arvind Yadav wrote: >> Never directly free @dev after calling device_register(), even >> if it returned an error! Always use put_device() to give up the >> reference initialized. >> >> Signed-off-by: Arvind Yadav

Re: [PATCH] ntb_transport: use put_device() instead of kfree()

2018-05-21 Thread Jon Mason
On Fri, Mar 09, 2018 at 04:03:24PM +0530, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav > --- >

Re: [PATCH] ntb_transport: use put_device() instead of kfree()

2018-05-21 Thread Jon Mason
On Fri, Mar 09, 2018 at 04:03:24PM +0530, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav > --- > drivers/ntb/ntb_transport.c | 2 +- >

Re: [PATCH] ntb_transport: use put_device() instead of kfree()

2018-03-09 Thread Logan Gunthorpe
Looks correct to me. Thanks! Reviewed-by: Logan Gunthorpe On 09/03/18 03:33 AM, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind

Re: [PATCH] ntb_transport: use put_device() instead of kfree()

2018-03-09 Thread Logan Gunthorpe
Looks correct to me. Thanks! Reviewed-by: Logan Gunthorpe On 09/03/18 03:33 AM, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav ---

[PATCH] ntb_transport: use put_device() instead of kfree()

2018-03-09 Thread Arvind Yadav
Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/ntb/ntb_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] ntb_transport: use put_device() instead of kfree()

2018-03-09 Thread Arvind Yadav
Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/ntb/ntb_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git