Re: [PATCH] objtool: prevent memory leak in error paths

2021-04-19 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 15, 2021 at 09:24:41AM +0200, Peter Zijlstra escreveu: > On Wed, Apr 14, 2021 at 11:47:09AM +0300, Dan Carpenter wrote: > > On Wed, Apr 14, 2021 at 01:45:11AM +0500, Muhammad Usama Anjum wrote: > > > Memory allocated by sym and sym->name isn't being freed if some error > > > occurs in

Re: [PATCH] objtool: prevent memory leak in error paths

2021-04-15 Thread Peter Zijlstra
On Wed, Apr 14, 2021 at 11:47:09AM +0300, Dan Carpenter wrote: > On Wed, Apr 14, 2021 at 01:45:11AM +0500, Muhammad Usama Anjum wrote: > > Memory allocated by sym and sym->name isn't being freed if some error > > occurs in elf_create_undef_symbol(). Free the sym and sym->name if error > > is

Re: [PATCH] objtool: prevent memory leak in error paths

2021-04-14 Thread Dan Carpenter
On Wed, Apr 14, 2021 at 01:45:11AM +0500, Muhammad Usama Anjum wrote: > Memory allocated by sym and sym->name isn't being freed if some error > occurs in elf_create_undef_symbol(). Free the sym and sym->name if error > is detected before returning NULL. > > Addresses-Coverity: ("Prevent memory

Re: [PATCH] objtool: prevent memory leak in error paths

2021-04-14 Thread Peter Zijlstra
On Wed, Apr 14, 2021 at 01:45:11AM +0500, Muhammad Usama Anjum wrote: > Memory allocated by sym and sym->name isn't being freed if some error > occurs in elf_create_undef_symbol(). Free the sym and sym->name if error > is detected before returning NULL. > > Addresses-Coverity: ("Prevent memory

[PATCH] objtool: prevent memory leak in error paths

2021-04-13 Thread Muhammad Usama Anjum
Memory allocated by sym and sym->name isn't being freed if some error occurs in elf_create_undef_symbol(). Free the sym and sym->name if error is detected before returning NULL. Addresses-Coverity: ("Prevent memory leak") Fixes: 2f2f7e47f052 ("objtool: Add elf_create_undef_symbol()")