Re: [PATCH] perf annotate: improve --stdio mode

2021-04-19 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 19, 2021 at 09:39:37AM +0200, Martin Liška escreveu: > @Arnaldo: May I please ping this? Applied the refreshed version, - Arnaldo > Thanks, > Martin > > On 4/8/21 12:08 PM, Martin Liška wrote: > > On 4/7/21 10:25 PM, Arnaldo Carvalho de Melo wrote: > >> Em Wed, Apr 07, 2021 at

Re: [PATCH] perf annotate: improve --stdio mode

2021-04-19 Thread Martin Liška
@Arnaldo: May I please ping this? Thanks, Martin On 4/8/21 12:08 PM, Martin Liška wrote: > On 4/7/21 10:25 PM, Arnaldo Carvalho de Melo wrote: >> Em Wed, Apr 07, 2021 at 04:30:46PM -0300, Arnaldo Carvalho de Melo escreveu: >>> Em Fri, Feb 26, 2021 at 10:24:00AM +0100, Martin Liška escreveu:

Re: [PATCH] perf annotate: improve --stdio mode

2021-04-08 Thread Martin Liška
On 4/7/21 10:25 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 07, 2021 at 04:30:46PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Feb 26, 2021 at 10:24:00AM +0100, Martin Liška escreveu: >>> On 2/23/21 8:47 PM, Arnaldo Carvalho de Melo wrote: >>> Sure. But I think the current format

Re: [PATCH] perf annotate: improve --stdio mode

2021-04-07 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 07, 2021 at 04:30:46PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 26, 2021 at 10:24:00AM +0100, Martin Liška escreveu: > > On 2/23/21 8:47 PM, Arnaldo Carvalho de Melo wrote: > > Sure. But I think the current format provides quite broken visual layout: > > > > 0.00

Re: [PATCH] perf annotate: improve --stdio mode

2021-04-07 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2021 at 10:24:00AM +0100, Martin Liška escreveu: > On 2/23/21 8:47 PM, Arnaldo Carvalho de Melo wrote: > > Em Sun, Feb 21, 2021 at 01:46:36PM +0100, Martin Liška escreveu: > > > The patch changes the output format in 2 ways: > > > - line number is displayed for all source lines

Re: [PATCH] perf annotate: improve --stdio mode

2021-04-07 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 19, 2021 at 10:38:26AM +0100, Martin Liška escreveu: > PING Can you please try to refresh the patch? It isn't applying, probably my bad for not having processed it already :-\ - Arnaldo > On 2/26/21 10:24 AM, Martin Liška wrote: > > On 2/23/21 8:47 PM, Arnaldo Carvalho de Melo

Re: [PATCH] perf annotate: improve --stdio mode

2021-03-19 Thread Martin Liška
PING On 2/26/21 10:24 AM, Martin Liška wrote: On 2/23/21 8:47 PM, Arnaldo Carvalho de Melo wrote: Em Sun, Feb 21, 2021 at 01:46:36PM +0100, Martin Liška escreveu: The patch changes the output format in 2 ways: - line number is displayed for all source lines (matching TUI mode) Are you aware

Re: [PATCH] perf annotate: improve --stdio mode

2021-02-26 Thread Martin Liška
On 2/23/21 8:47 PM, Arnaldo Carvalho de Melo wrote: Em Sun, Feb 21, 2021 at 01:46:36PM +0100, Martin Liška escreveu: The patch changes the output format in 2 ways: - line number is displayed for all source lines (matching TUI mode) Are you aware of 'perf annotate --stdio2' ? If the goal is to

Re: [PATCH] perf annotate: improve --stdio mode

2021-02-23 Thread Arnaldo Carvalho de Melo
Em Sun, Feb 21, 2021 at 01:46:36PM +0100, Martin Liška escreveu: > The patch changes the output format in 2 ways: > - line number is displayed for all source lines (matching TUI mode) Are you aware of 'perf annotate --stdio2' ? If the goal is to make the stdio mode better, doing it in that mode

[PATCH] perf annotate: improve --stdio mode

2021-02-21 Thread Martin Liška
The patch changes the output format in 2 ways: - line number is displayed for all source lines (matching TUI mode) - source locations for the hottest lines are printed at the line end in order to preserve layout Before: 0.00 : 405ef1: inc%r15 :tmpsd * (TD +