Re: [PATCH] perf record: Disallow -c and -F option at the same time

2021-04-03 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 02, 2021 at 08:25:30PM -0700, Alexey Alexandrov escreveu: > A warning can be missed when the tool is run by some kind of automation. > Backward compatibility aside, I think conflicting flags should result in an > early exit to avoid later surprises. Sure, I agree with you in

Re: [PATCH] perf record: Disallow -c and -F option at the same time

2021-04-02 Thread Arnaldo Carvalho de Melo
Em Fri, Apr 02, 2021 at 06:40:20PM +0900, Namhyung Kim escreveu: > It's confusing which one is effective when the both options are given. > The current code happens to use -c in this case but users might not be > aware of it. We can change it to complain about that instead of > relying on the

[PATCH] perf record: Disallow -c and -F option at the same time

2021-04-02 Thread Namhyung Kim
It's confusing which one is effective when the both options are given. The current code happens to use -c in this case but users might not be aware of it. We can change it to complain about that instead of relying on the implicit priority. Before: $ perf record -c 11 -F 99 true [ perf