Re: [PATCH] rcu: fix section mismatch

2008-01-22 Thread Randy Dunlap
Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 03:34:09PM -0800, Randy Dunlap wrote: On Mon, 21 Jan 2008 11:38:38 +1100 Rusty Russell wrote: On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: rcu_online_cpu() should be __cpuinit

Re: [PATCH] rcu: fix section mismatch

2008-01-22 Thread Randy Dunlap
Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 03:34:09PM -0800, Randy Dunlap wrote: On Mon, 21 Jan 2008 11:38:38 +1100 Rusty Russell wrote: On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: rcu_online_cpu() should be __cpuinit

Re: [PATCH] rcu: fix section mismatch

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 03:34:09PM -0800, Randy Dunlap wrote: > On Mon, 21 Jan 2008 11:38:38 +1100 Rusty Russell wrote: > > > On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: > > > On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: > > > > rcu_online_cpu() should be __cpuinit

Re: [PATCH] rcu: fix section mismatch

2008-01-21 Thread Randy Dunlap
On Mon, 21 Jan 2008 11:38:38 +1100 Rusty Russell wrote: > On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: > > On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: > > > rcu_online_cpu() should be __cpuinit instead of __devinit. > > > > So if we have: > > CONFIG_HOTPLUG=n > >

Re: [PATCH] rcu: fix section mismatch

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 11:38:38AM +1100, Rusty Russell wrote: > On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: > > On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: > > > rcu_online_cpu() should be __cpuinit instead of __devinit. > > > > So if we have: > > CONFIG_HOTPLUG=n > >

Re: [PATCH] rcu: fix section mismatch

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 11:38:38AM +1100, Rusty Russell wrote: On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: rcu_online_cpu() should be __cpuinit instead of __devinit. So if we have: CONFIG_HOTPLUG=n

Re: [PATCH] rcu: fix section mismatch

2008-01-21 Thread Randy Dunlap
On Mon, 21 Jan 2008 11:38:38 +1100 Rusty Russell wrote: On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: rcu_online_cpu() should be __cpuinit instead of __devinit. So if we have: CONFIG_HOTPLUG=n

Re: [PATCH] rcu: fix section mismatch

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 03:34:09PM -0800, Randy Dunlap wrote: On Mon, 21 Jan 2008 11:38:38 +1100 Rusty Russell wrote: On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: rcu_online_cpu() should be __cpuinit instead of

Re: [PATCH] rcu: fix section mismatch

2008-01-20 Thread Rusty Russell
On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: > On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: > > rcu_online_cpu() should be __cpuinit instead of __devinit. > > So if we have: > CONFIG_HOTPLUG=n > CONFIG_HOTPLUG_CPU=y > > then this is a oops candidate. At first glance,

Re: [PATCH] rcu: fix section mismatch

2008-01-20 Thread Rusty Russell
On Sunday 20 January 2008 08:25:49 Sam Ravnborg wrote: On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: rcu_online_cpu() should be __cpuinit instead of __devinit. So if we have: CONFIG_HOTPLUG=n CONFIG_HOTPLUG_CPU=y then this is a oops candidate. At first glance, this can't

Re: [PATCH] rcu: fix section mismatch

2008-01-19 Thread Sam Ravnborg
On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > rcu_online_cpu() should be __cpuinit instead of __devinit. > > WARNING: vmlinux.o(.text+0x4b6d5): Section mismatch: reference to .init.text: > (between 'rcu_cpu_notify' and

[PATCH] rcu: fix section mismatch

2008-01-19 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> rcu_online_cpu() should be __cpuinit instead of __devinit. WARNING: vmlinux.o(.text+0x4b6d5): Section mismatch: reference to .init.text: (between 'rcu_cpu_notify' and 'wakeme_after_rcu') Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> ---

[PATCH] rcu: fix section mismatch

2008-01-19 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] rcu_online_cpu() should be __cpuinit instead of __devinit. WARNING: vmlinux.o(.text+0x4b6d5): Section mismatch: reference to .init.text: (between 'rcu_cpu_notify' and 'wakeme_after_rcu') Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- kernel/rcupdate.c |

Re: [PATCH] rcu: fix section mismatch

2008-01-19 Thread Sam Ravnborg
On Sat, Jan 19, 2008 at 11:56:43AM -0800, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] rcu_online_cpu() should be __cpuinit instead of __devinit. WARNING: vmlinux.o(.text+0x4b6d5): Section mismatch: reference to .init.text: (between 'rcu_cpu_notify' and 'wakeme_after_rcu')