Re: [PATCH] scsi: mpt3sas: Simplify _base_display_OEMs_branding

2021-01-12 Thread Joe Perches
On Tue, 2021-01-12 at 17:40 +, Johannes Thumshirn wrote: > On 12/01/2021 18:38, Joe Perches wrote: > >  static void > >  _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc) > >  { > > + const char *b = NULL; /* brand */ > > + const char *v = NULL; /* vendor */ > > Any reason you

Re: [PATCH] scsi: mpt3sas: Simplify _base_display_OEMs_branding

2021-01-12 Thread Johannes Thumshirn
On 12/01/2021 18:38, Joe Perches wrote: > static void > _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc) > { > + const char *b = NULL; /* brand */ > + const char *v = NULL; /* vendor */ Any reason you didn't spell out brand and vendor as the variable names?

[PATCH] scsi: mpt3sas: Simplify _base_display_OEMs_branding

2021-01-12 Thread Joe Perches
Simplify code by using char pointers and not individual calls to ioc_info() when identifying OEMs branding. Reduces object size a bit too: $ size drivers/scsi/mpt3sas/mpt3sas_base.o* textdata bss dec hex filename 72024 88 288 72400 11ad0