Re: [PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-18 Thread Gustavo A. R. Silva
Hi Sasha, On 2/18/19 3:14 PM, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 58dd7c0a2a6e Staging: comedi: add ni_660x driver. > > The bot has tested the following trees: v4.20.8, v4.19.21,

Re: [PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-15 Thread Ian Abbott
On 15/02/2019 15:48, Sasha Levin wrote: Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 58dd7c0a2a6e Staging: comedi: add ni_660x driver. The bot has tested the following trees: v4.20.8, v4.19.21, v4.14.99, v4.9.156,

Re: [PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-12 Thread Gustavo A. R. Silva
Hi, Please, drop this. I've just sent v2 with the right Fixes tag: https://lore.kernel.org/patchwork/patch/1041301/ Thanks -- Gustavo On 2/12/19 12:08 PM, Gustavo A. R. Silva wrote: > Add missing break statement in order to prevent the code from falling > through to the default case and

[PATCH] staging: comedi: ni_660x: fix missing break in switch statement

2019-02-12 Thread Gustavo A. R. Silva
Add missing break statement in order to prevent the code from falling through to the default case and return -EINVAL every time. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: 58dd7c0a2a6e ("Staging: comedi: add ni_660x driver") Cc: