Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-19 Thread Jarkko Sakkinen
On Tue, Apr 19, 2016 at 11:09:53AM -0600, Jason Gunthorpe wrote: > On Tue, Apr 19, 2016 at 12:54:18PM +0300, Jarkko Sakkinen wrote: > > Cc: sta...@vger.kernel.org > > Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource") > > Signed-off-by: Jarkko Sakkinen > >

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-19 Thread Jarkko Sakkinen
On Tue, Apr 19, 2016 at 11:09:53AM -0600, Jason Gunthorpe wrote: > On Tue, Apr 19, 2016 at 12:54:18PM +0300, Jarkko Sakkinen wrote: > > Cc: sta...@vger.kernel.org > > Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource") > > Signed-off-by: Jarkko Sakkinen > > drivers/char/tpm/tpm_crb.c | 39

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-19 Thread Jason Gunthorpe
On Tue, Apr 19, 2016 at 12:54:18PM +0300, Jarkko Sakkinen wrote: > Cc: sta...@vger.kernel.org > Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource") > Signed-off-by: Jarkko Sakkinen > drivers/char/tpm/tpm_crb.c | 39 --- >

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-19 Thread Jason Gunthorpe
On Tue, Apr 19, 2016 at 12:54:18PM +0300, Jarkko Sakkinen wrote: > Cc: sta...@vger.kernel.org > Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource") > Signed-off-by: Jarkko Sakkinen > drivers/char/tpm/tpm_crb.c | 39 --- > 1 file changed, 28

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-19 Thread Jarkko Sakkinen
On Tue, Apr 19, 2016 at 12:54:18PM +0300, Jarkko Sakkinen wrote: > On my Lenovo x250 the following situation occurs: > > [18697.813871] tpm_crb MSFT0101:00: can't request region for resource > [mem 0xacdff080-0xacdf] > > The mapping of the control area overlaps the mapping of the command >

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-19 Thread Jarkko Sakkinen
On Tue, Apr 19, 2016 at 12:54:18PM +0300, Jarkko Sakkinen wrote: > On my Lenovo x250 the following situation occurs: > > [18697.813871] tpm_crb MSFT0101:00: can't request region for resource > [mem 0xacdff080-0xacdf] > > The mapping of the control area overlaps the mapping of the command >

[PATCH] tpm_crb: fix mapping of the buffers

2016-04-19 Thread Jarkko Sakkinen
On my Lenovo x250 the following situation occurs: [18697.813871] tpm_crb MSFT0101:00: can't request region for resource [mem 0xacdff080-0xacdf] The mapping of the control area overlaps the mapping of the command buffer. The control area is mapped over page, which is not right. It should

[PATCH] tpm_crb: fix mapping of the buffers

2016-04-19 Thread Jarkko Sakkinen
On my Lenovo x250 the following situation occurs: [18697.813871] tpm_crb MSFT0101:00: can't request region for resource [mem 0xacdff080-0xacdf] The mapping of the control area overlaps the mapping of the command buffer. The control area is mapped over page, which is not right. It should

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-18 Thread Jarkko Sakkinen
On Tue, Apr 19, 2016 at 07:59:24AM +0300, Jarkko Sakkinen wrote: > On Mon, Apr 18, 2016 at 05:34:57PM -0600, Jason Gunthorpe wrote: > > On Tue, Apr 19, 2016 at 02:08:00AM +0300, Jarkko Sakkinen wrote: > > > On my Lenovo x250 the following situation occurs: > > > > > > [18697.813871] tpm_crb

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-18 Thread Jarkko Sakkinen
On Tue, Apr 19, 2016 at 07:59:24AM +0300, Jarkko Sakkinen wrote: > On Mon, Apr 18, 2016 at 05:34:57PM -0600, Jason Gunthorpe wrote: > > On Tue, Apr 19, 2016 at 02:08:00AM +0300, Jarkko Sakkinen wrote: > > > On my Lenovo x250 the following situation occurs: > > > > > > [18697.813871] tpm_crb

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-18 Thread Jarkko Sakkinen
On Mon, Apr 18, 2016 at 05:34:57PM -0600, Jason Gunthorpe wrote: > On Tue, Apr 19, 2016 at 02:08:00AM +0300, Jarkko Sakkinen wrote: > > On my Lenovo x250 the following situation occurs: > > > > [18697.813871] tpm_crb MSFT0101:00: can't request region for resource > > [mem 0xacdff080-0xacdf] >

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-18 Thread Jarkko Sakkinen
On Mon, Apr 18, 2016 at 05:34:57PM -0600, Jason Gunthorpe wrote: > On Tue, Apr 19, 2016 at 02:08:00AM +0300, Jarkko Sakkinen wrote: > > On my Lenovo x250 the following situation occurs: > > > > [18697.813871] tpm_crb MSFT0101:00: can't request region for resource > > [mem 0xacdff080-0xacdf] >

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-18 Thread Jason Gunthorpe
On Tue, Apr 19, 2016 at 02:08:00AM +0300, Jarkko Sakkinen wrote: > On my Lenovo x250 the following situation occurs: > > [18697.813871] tpm_crb MSFT0101:00: can't request region for resource > [mem 0xacdff080-0xacdf] Sigh, the BIOS vendors seem to be screwing this up a lot.. No doubt because

Re: [PATCH] tpm_crb: fix mapping of the buffers

2016-04-18 Thread Jason Gunthorpe
On Tue, Apr 19, 2016 at 02:08:00AM +0300, Jarkko Sakkinen wrote: > On my Lenovo x250 the following situation occurs: > > [18697.813871] tpm_crb MSFT0101:00: can't request region for resource > [mem 0xacdff080-0xacdf] Sigh, the BIOS vendors seem to be screwing this up a lot.. No doubt because

[PATCH] tpm_crb: fix mapping of the buffers

2016-04-18 Thread Jarkko Sakkinen
On my Lenovo x250 the following situation occurs: [18697.813871] tpm_crb MSFT0101:00: can't request region for resource [mem 0xacdff080-0xacdf] The mapping of the control area interleaves the mapping of the command buffer. The control area is mapped over page, which is not right. It should

[PATCH] tpm_crb: fix mapping of the buffers

2016-04-18 Thread Jarkko Sakkinen
On my Lenovo x250 the following situation occurs: [18697.813871] tpm_crb MSFT0101:00: can't request region for resource [mem 0xacdff080-0xacdf] The mapping of the control area interleaves the mapping of the command buffer. The control area is mapped over page, which is not right. It should