Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-11 Thread David Miller
From: Ingo Molnar Date: Sat, 11 Nov 2017 09:16:00 +0100 > Please don't apply it yet as the series is still under active > discussion - for now Fine, reverted.

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-11 Thread David Miller
From: Ingo Molnar Date: Sat, 11 Nov 2017 09:16:00 +0100 > Please don't apply it yet as the series is still under active > discussion - for now Fine, reverted.

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-11 Thread Ingo Molnar
* David Miller wrote: > From: Josef Bacik > Date: Tue, 7 Nov 2017 15:28:41 -0500 > > > I'm sending this through Dave since it'll conflict with other BPF changes > > in his > > tree, but since it touches tracing as well Dave would like a review from

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-11 Thread Ingo Molnar
* David Miller wrote: > From: Josef Bacik > Date: Tue, 7 Nov 2017 15:28:41 -0500 > > > I'm sending this through Dave since it'll conflict with other BPF changes > > in his > > tree, but since it touches tracing as well Dave would like a review from > > somebody on the tracing side. > ... >

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread David Miller
From: Josef Bacik Date: Tue, 7 Nov 2017 15:28:41 -0500 > I'm sending this through Dave since it'll conflict with other BPF changes in > his > tree, but since it touches tracing as well Dave would like a review from > somebody on the tracing side. ... > A lot of our error

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread David Miller
From: Josef Bacik Date: Tue, 7 Nov 2017 15:28:41 -0500 > I'm sending this through Dave since it'll conflict with other BPF changes in > his > tree, but since it touches tracing as well Dave would like a review from > somebody on the tracing side. ... > A lot of our error paths are not well

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread Peter Zijlstra
On Wed, Nov 08, 2017 at 06:43:25AM +0900, Alexei Starovoitov wrote: > On 11/8/17 5:28 AM, Josef Bacik wrote: > > I'm sending this through Dave since it'll conflict with other BPF changes > > in his > > tree, but since it touches tracing as well Dave would like a review from > > somebody on the

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread Peter Zijlstra
On Wed, Nov 08, 2017 at 06:43:25AM +0900, Alexei Starovoitov wrote: > On 11/8/17 5:28 AM, Josef Bacik wrote: > > I'm sending this through Dave since it'll conflict with other BPF changes > > in his > > tree, but since it touches tracing as well Dave would like a review from > > somebody on the

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread David Miller
From: Alexei Starovoitov Date: Wed, 8 Nov 2017 06:43:25 +0900 > looks great to me. > Peter, > could you please review x86 bits? I'm still waiting for this.

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread David Miller
From: Alexei Starovoitov Date: Wed, 8 Nov 2017 06:43:25 +0900 > looks great to me. > Peter, > could you please review x86 bits? I'm still waiting for this.

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-07 Thread Alexei Starovoitov
On 11/8/17 5:28 AM, Josef Bacik wrote: I'm sending this through Dave since it'll conflict with other BPF changes in his tree, but since it touches tracing as well Dave would like a review from somebody on the tracing side. v4->v5: - disallow kprobe_override programs from being put in the prog

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-07 Thread Alexei Starovoitov
On 11/8/17 5:28 AM, Josef Bacik wrote: I'm sending this through Dave since it'll conflict with other BPF changes in his tree, but since it touches tracing as well Dave would like a review from somebody on the tracing side. v4->v5: - disallow kprobe_override programs from being put in the prog

[PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-07 Thread Josef Bacik
I'm sending this through Dave since it'll conflict with other BPF changes in his tree, but since it touches tracing as well Dave would like a review from somebody on the tracing side. v4->v5: - disallow kprobe_override programs from being put in the prog map array so we don't tail call into

[PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-07 Thread Josef Bacik
I'm sending this through Dave since it'll conflict with other BPF changes in his tree, but since it touches tracing as well Dave would like a review from somebody on the tracing side. v4->v5: - disallow kprobe_override programs from being put in the prog map array so we don't tail call into