Re: [dm-devel] [PATCH 0/2] block layer filter and block device snapshot module

2020-10-23 Thread h...@infradead.org
On Fri, Oct 23, 2020 at 12:31:05PM +0200, Hannes Reinecke wrote: > My thoughts went more into the direction of hooking into ->submit_bio, > seeing that it's a NULL pointer for most (all?) block drivers. > > But sure, I'll check how the interposer approach would turn out. submit_bio is owned by

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-23 Thread Sergei Shtepa
The 10/23/2020 13:31, Hannes Reinecke wrote: > On 10/23/20 11:13 AM, h...@infradead.org wrote: > > On Thu, Oct 22, 2020 at 01:54:16PM -0400, Mike Snitzer wrote: > >> On Thu, Oct 22, 2020 at 11:14 AM Darrick J. Wong > >>> Stupid question: Why don't you change the block layer to make it > >>>

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-23 Thread Hannes Reinecke
On 10/23/20 11:13 AM, h...@infradead.org wrote: On Thu, Oct 22, 2020 at 01:54:16PM -0400, Mike Snitzer wrote: On Thu, Oct 22, 2020 at 11:14 AM Darrick J. Wong Stupid question: Why don't you change the block layer to make it possible to insert device mapper devices after the blockdev has been

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-23 Thread h...@infradead.org
On Thu, Oct 22, 2020 at 01:54:16PM -0400, Mike Snitzer wrote: > On Thu, Oct 22, 2020 at 11:14 AM Darrick J. Wong > > Stupid question: Why don't you change the block layer to make it > > possible to insert device mapper devices after the blockdev has been set > > up? > > Not a stupid question.

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Mike Snitzer
On Wed, Oct 21, 2020 at 5:04 AM Sergei Shtepa wrote: > > Hello everyone! Requesting for your comments and suggestions. > > # blk-filter > > Block layer filter allows to intercept BIO requests to a block device. > > Interception is performed at the very beginning of the BIO request > processing,

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Mike Snitzer
On Thu, Oct 22, 2020 at 11:14 AM Darrick J. Wong wrote: > > On Thu, Oct 22, 2020 at 04:52:13PM +0300, Sergei Shtepa wrote: > > The 10/22/2020 13:28, Damien Le Moal wrote: > > > On 2020/10/22 18:43, Sergei Shtepa wrote: > > > > > > > > Maybe, but the problem is that I can't imagine how to

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Darrick J. Wong
On Thu, Oct 22, 2020 at 04:52:13PM +0300, Sergei Shtepa wrote: > The 10/22/2020 13:28, Damien Le Moal wrote: > > On 2020/10/22 18:43, Sergei Shtepa wrote: > > > > > > Maybe, but the problem is that I can't imagine how to implement > > > dm-intercept yet. > > > How to use dm to implement

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Sergei Shtepa
The 10/22/2020 13:28, Damien Le Moal wrote: > On 2020/10/22 18:43, Sergei Shtepa wrote: > > > > Maybe, but the problem is that I can't imagine how to implement > > dm-intercept yet. > > How to use dm to implement interception without changing the stack > > of block devices. We'll have to make a

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Damien Le Moal
On 2020/10/22 18:43, Sergei Shtepa wrote: > The 10/22/2020 08:58, Hannes Reinecke wrote: >> On 10/21/20 4:10 PM, Sergei Shtepa wrote: >>> The 10/21/2020 16:31, Hannes Reinecke wrote: I do understand where you are coming from, but then we already have a dm-snap which does exactly what you

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Sergei Shtepa
The 10/22/2020 08:58, Hannes Reinecke wrote: > On 10/21/20 4:10 PM, Sergei Shtepa wrote: > > The 10/21/2020 16:31, Hannes Reinecke wrote: > >> I do understand where you are coming from, but then we already have a > >> dm-snap which does exactly what you want to achieve. > >> Of course, that would

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-21 Thread Hannes Reinecke
On 10/21/20 4:10 PM, Sergei Shtepa wrote: The 10/21/2020 16:31, Hannes Reinecke wrote: I do understand where you are coming from, but then we already have a dm-snap which does exactly what you want to achieve. Of course, that would require a reconfiguration of the storage stack on the machine,

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-21 Thread Sergei Shtepa
The 10/21/2020 16:31, Hannes Reinecke wrote: > I do understand where you are coming from, but then we already have a > dm-snap which does exactly what you want to achieve. > Of course, that would require a reconfiguration of the storage stack on > the machine, which is not always possible (or

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-21 Thread Hannes Reinecke
On 10/21/20 11:04 AM, Sergei Shtepa wrote: Hello everyone! Requesting for your comments and suggestions. # blk-filter Block layer filter allows to intercept BIO requests to a block device. Interception is performed at the very beginning of the BIO request processing, and therefore does not

[PATCH 0/2] block layer filter and block device snapshot module

2020-10-21 Thread Sergei Shtepa
Hello everyone! Requesting for your comments and suggestions. # blk-filter Block layer filter allows to intercept BIO requests to a block device. Interception is performed at the very beginning of the BIO request processing, and therefore does not affect the operation of the request processing