Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Theodore Ts'o
On Thu, Mar 09, 2017 at 07:43:12AM -0500, Jeff Layton wrote: > > Maybe we need a systemwide (or fs-level) tunable that makes ENOSPC a > transient error? Just have it hang until we get enough space when that > tunable is enabled? Or maybe we need a new kernel-internal errno (ala ERESTARSYS) which

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Theodore Ts'o
On Thu, Mar 09, 2017 at 07:43:12AM -0500, Jeff Layton wrote: > > Maybe we need a systemwide (or fs-level) tunable that makes ENOSPC a > transient error? Just have it hang until we get enough space when that > tunable is enabled? Or maybe we need a new kernel-internal errno (ala ERESTARSYS) which

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Brian Foster
On Thu, Mar 09, 2017 at 07:43:12AM -0500, Jeff Layton wrote: > On Thu, 2017-03-09 at 12:02 +0100, Jan Kara wrote: > > On Thu 09-03-17 05:47:51, Jeff Layton wrote: > > > On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > > > > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > > > > On Tue, Mar 07,

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Brian Foster
On Thu, Mar 09, 2017 at 07:43:12AM -0500, Jeff Layton wrote: > On Thu, 2017-03-09 at 12:02 +0100, Jan Kara wrote: > > On Thu 09-03-17 05:47:51, Jeff Layton wrote: > > > On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > > > > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > > > > On Tue, Mar 07,

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Jeff Layton
On Thu, 2017-03-09 at 12:02 +0100, Jan Kara wrote: > On Thu 09-03-17 05:47:51, Jeff Layton wrote: > > On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > > > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > > > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > > > > On a more general note

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Jeff Layton
On Thu, 2017-03-09 at 12:02 +0100, Jan Kara wrote: > On Thu 09-03-17 05:47:51, Jeff Layton wrote: > > On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > > > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > > > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > > > > On a more general note

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Jan Kara
On Thu 09-03-17 05:47:51, Jeff Layton wrote: > On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > > > On a more general note (DAX is actually fine here), I find the current > > > >

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Jan Kara
On Thu 09-03-17 05:47:51, Jeff Layton wrote: > On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > > > On a more general note (DAX is actually fine here), I find the current > > > >

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Jeff Layton
On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > > On a more general note (DAX is actually fine here), I find the current > > > practice of clearing page dirty bits on error and reporting

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Jeff Layton
On Thu, 2017-03-09 at 10:04 +0100, Jan Kara wrote: > On Wed 08-03-17 21:57:25, Ted Tso wrote: > > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > > On a more general note (DAX is actually fine here), I find the current > > > practice of clearing page dirty bits on error and reporting

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Jan Kara
On Wed 08-03-17 21:57:25, Ted Tso wrote: > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > On a more general note (DAX is actually fine here), I find the current > > practice of clearing page dirty bits on error and reporting it just once > > problematic. It keeps the system running

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-09 Thread Jan Kara
On Wed 08-03-17 21:57:25, Ted Tso wrote: > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > On a more general note (DAX is actually fine here), I find the current > > practice of clearing page dirty bits on error and reporting it just once > > problematic. It keeps the system running

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-08 Thread Theodore Ts'o
On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > On a more general note (DAX is actually fine here), I find the current > practice of clearing page dirty bits on error and reporting it just once > problematic. It keeps the system running but data is lost and possibly > without getting

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-08 Thread Theodore Ts'o
On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > On a more general note (DAX is actually fine here), I find the current > practice of clearing page dirty bits on error and reporting it just once > problematic. It keeps the system running but data is lost and possibly > without getting

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-07 Thread Jan Kara
On Tue 07-03-17 08:59:16, Ross Zwisler wrote: > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > On Mon 06-03-17 16:08:01, Ross Zwisler wrote: > > > On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > > > > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > > > > I

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-07 Thread Jan Kara
On Tue 07-03-17 08:59:16, Ross Zwisler wrote: > On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > > On Mon 06-03-17 16:08:01, Ross Zwisler wrote: > > > On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > > > > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > > > > I

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-07 Thread Ross Zwisler
On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > On Mon 06-03-17 16:08:01, Ross Zwisler wrote: > > On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > > > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > > > I recently did some work to wire up -ENOSPC handling in

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-07 Thread Ross Zwisler
On Tue, Mar 07, 2017 at 11:26:22AM +0100, Jan Kara wrote: > On Mon 06-03-17 16:08:01, Ross Zwisler wrote: > > On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > > > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > > > I recently did some work to wire up -ENOSPC handling in

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-07 Thread Jeff Layton
On Tue, 2017-03-07 at 11:26 +0100, Jan Kara wrote: > On Mon 06-03-17 16:08:01, Ross Zwisler wrote: > > On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > > > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > > > I recently did some work to wire up -ENOSPC handling in ceph, and

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-07 Thread Jeff Layton
On Tue, 2017-03-07 at 11:26 +0100, Jan Kara wrote: > On Mon 06-03-17 16:08:01, Ross Zwisler wrote: > > On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > > > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > > > I recently did some work to wire up -ENOSPC handling in ceph, and

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-07 Thread Jan Kara
On Mon 06-03-17 16:08:01, Ross Zwisler wrote: > On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > > I recently did some work to wire up -ENOSPC handling in ceph, and found > > > I could get back -EIO errors in some cases when

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-07 Thread Jan Kara
On Mon 06-03-17 16:08:01, Ross Zwisler wrote: > On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > > I recently did some work to wire up -ENOSPC handling in ceph, and found > > > I could get back -EIO errors in some cases when

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-06 Thread Ross Zwisler
On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > I recently did some work to wire up -ENOSPC handling in ceph, and found > > I could get back -EIO errors in some cases when I should have instead > > gotten -ENOSPC. The problem

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-06 Thread Ross Zwisler
On Sun, Mar 05, 2017 at 09:40:54AM -0500, Jeff Layton wrote: > On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > > I recently did some work to wire up -ENOSPC handling in ceph, and found > > I could get back -EIO errors in some cases when I should have instead > > gotten -ENOSPC. The problem

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-06 Thread Jeff Layton
On Mon, 2017-03-06 at 14:06 +1100, NeilBrown wrote: > On Sun, Mar 05 2017, Jeff Layton wrote: > > > I recently did some work to wire up -ENOSPC handling in ceph, and found > > I could get back -EIO errors in some cases when I should have instead > > gotten -ENOSPC. The problem was that the ceph

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-06 Thread Jeff Layton
On Mon, 2017-03-06 at 14:06 +1100, NeilBrown wrote: > On Sun, Mar 05 2017, Jeff Layton wrote: > > > I recently did some work to wire up -ENOSPC handling in ceph, and found > > I could get back -EIO errors in some cases when I should have instead > > gotten -ENOSPC. The problem was that the ceph

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-05 Thread NeilBrown
On Sun, Mar 05 2017, Jeff Layton wrote: > I recently did some work to wire up -ENOSPC handling in ceph, and found > I could get back -EIO errors in some cases when I should have instead > gotten -ENOSPC. The problem was that the ceph writeback code would set > PG_error on a writeback error, and

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-05 Thread NeilBrown
On Sun, Mar 05 2017, Jeff Layton wrote: > I recently did some work to wire up -ENOSPC handling in ceph, and found > I could get back -EIO errors in some cases when I should have instead > gotten -ENOSPC. The problem was that the ceph writeback code would set > PG_error on a writeback error, and

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-05 Thread Jeff Layton
On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > I recently did some work to wire up -ENOSPC handling in ceph, and found > I could get back -EIO errors in some cases when I should have instead > gotten -ENOSPC. The problem was that the ceph writeback code would set > PG_error on a writeback

Re: [PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-05 Thread Jeff Layton
On Sun, 2017-03-05 at 08:35 -0500, Jeff Layton wrote: > I recently did some work to wire up -ENOSPC handling in ceph, and found > I could get back -EIO errors in some cases when I should have instead > gotten -ENOSPC. The problem was that the ceph writeback code would set > PG_error on a writeback

[PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-05 Thread Jeff Layton
I recently did some work to wire up -ENOSPC handling in ceph, and found I could get back -EIO errors in some cases when I should have instead gotten -ENOSPC. The problem was that the ceph writeback code would set PG_error on a writeback error, and that error would clobber the mapping error. While

[PATCH 0/3] mm/fs: get PG_error out of the writeback reporting business

2017-03-05 Thread Jeff Layton
I recently did some work to wire up -ENOSPC handling in ceph, and found I could get back -EIO errors in some cases when I should have instead gotten -ENOSPC. The problem was that the ceph writeback code would set PG_error on a writeback error, and that error would clobber the mapping error. While