Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-14 Thread Sam Ravnborg
On Mon, Jan 14, 2008 at 09:25:54AM +, Jan Beulich wrote: > >> The one thing that I'm not sure is really consistent yet wrt. the > >> constification is that now you need to write e.g. > >> > >> static const char __cpuinitcdata example[]; > >> > >> and (accidentally) omitting the 'const' (as

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-14 Thread Jan Beulich
>> The one thing that I'm not sure is really consistent yet wrt. the >> constification is that now you need to write e.g. >> >> static const char __cpuinitcdata example[]; >> >> and (accidentally) omitting the 'const' (as it's really an apparently >> redundant thing now) as in >> >> static char

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-14 Thread Sam Ravnborg
On Mon, Jan 14, 2008 at 08:33:35AM +, Jan Beulich wrote: > >>> Sam Ravnborg <[EMAIL PROTECTED]> 13.01.08 22:42 >>> > >> And I found another small buglet too. I hope to post a complete > >> solution later today. > > > >The modpost bits turned out to take longer than expected so > >they are not

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-14 Thread Jan Beulich
>>> Sam Ravnborg <[EMAIL PROTECTED]> 13.01.08 22:42 >>> >> And I found another small buglet too. I hope to post a complete >> solution later today. > >The modpost bits turned out to take longer than expected so >they are not done yet. The problem was the modpost structure >were not prepared for

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-14 Thread Jan Beulich
Sam Ravnborg [EMAIL PROTECTED] 13.01.08 22:42 And I found another small buglet too. I hope to post a complete solution later today. The modpost bits turned out to take longer than expected so they are not done yet. The problem was the modpost structure were not prepared for adding such

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-14 Thread Sam Ravnborg
On Mon, Jan 14, 2008 at 08:33:35AM +, Jan Beulich wrote: Sam Ravnborg [EMAIL PROTECTED] 13.01.08 22:42 And I found another small buglet too. I hope to post a complete solution later today. The modpost bits turned out to take longer than expected so they are not done yet. The

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-14 Thread Jan Beulich
The one thing that I'm not sure is really consistent yet wrt. the constification is that now you need to write e.g. static const char __cpuinitcdata example[]; and (accidentally) omitting the 'const' (as it's really an apparently redundant thing now) as in static char __cpuinitcdata

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-14 Thread Sam Ravnborg
On Mon, Jan 14, 2008 at 09:25:54AM +, Jan Beulich wrote: The one thing that I'm not sure is really consistent yet wrt. the constification is that now you need to write e.g. static const char __cpuinitcdata example[]; and (accidentally) omitting the 'const' (as it's really an

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-13 Thread Sam Ravnborg
> And I found another small buglet too. I hope to post a complete > solution later today. The modpost bits turned out to take longer than expected so they are not done yet. The problem was the modpost structure were not prepared for adding such additional chacks. So I reworked those bits and the

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-13 Thread Sam Ravnborg
And I found another small buglet too. I hope to post a complete solution later today. The modpost bits turned out to take longer than expected so they are not done yet. The problem was the modpost structure were not prepared for adding such additional chacks. So I reworked those bits and the

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-12 Thread Sam Ravnborg
> > +#ifdef CONFIG_HOTPLUG > +#define DEV_KEEP(sec) > +#define DEV_DISCARD(sec) *(.dev##sec) > +#else > +#define DEV_KEEP(sec)*(.dev##sec) > +#define DEV_DISCARD(sec) > +#endif > + > +#ifdef CONFIG_HOTPLUG_CPU > +#define CPU_KEEP(sec) > +#define CPU_DISCARD(sec) *(.cpu##sec) > +#else >

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-12 Thread Sam Ravnborg
On Fri, Jan 11, 2008 at 08:44:28PM +0100, Sam Ravnborg wrote: > Hi Jan. > > On Fri, Jan 11, 2008 at 08:55:29AM +, Jan Beulich wrote: > > Since __cpuinitdata/__devinitdata don't allow const to be specified with > > them (otherwise .init.data sections with and without the writeable attribute >

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-12 Thread Sam Ravnborg
On Fri, Jan 11, 2008 at 08:44:28PM +0100, Sam Ravnborg wrote: Hi Jan. On Fri, Jan 11, 2008 at 08:55:29AM +, Jan Beulich wrote: Since __cpuinitdata/__devinitdata don't allow const to be specified with them (otherwise .init.data sections with and without the writeable attribute will be

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-12 Thread Sam Ravnborg
+#ifdef CONFIG_HOTPLUG +#define DEV_KEEP(sec) +#define DEV_DISCARD(sec) *(.dev##sec) +#else +#define DEV_KEEP(sec)*(.dev##sec) +#define DEV_DISCARD(sec) +#endif + +#ifdef CONFIG_HOTPLUG_CPU +#define CPU_KEEP(sec) +#define CPU_DISCARD(sec) *(.cpu##sec) +#else +#define

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-11 Thread Sam Ravnborg
Hi Jan. On Fri, Jan 11, 2008 at 08:55:29AM +, Jan Beulich wrote: > Since __cpuinitdata/__devinitdata don't allow const to be specified with > them (otherwise .init.data sections with and without the writeable attribute > will be generated by the compiler), and since __devinitdata except for >

[PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-11 Thread Jan Beulich
Since __cpuinitdata/__devinitdata don't allow const to be specified with them (otherwise .init.data sections with and without the writeable attribute will be generated by the compiler), and since __devinitdata except for embedded systems evaluates to unconditionally and __cpuinitdata at least in

[PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-11 Thread Jan Beulich
Since __cpuinitdata/__devinitdata don't allow const to be specified with them (otherwise .init.data sections with and without the writeable attribute will be generated by the compiler), and since __devinitdata except for embedded systems evaluates to empty unconditionally and __cpuinitdata at

Re: [PATCH 0/4] __cpuinitconst and __devinitconst

2008-01-11 Thread Sam Ravnborg
Hi Jan. On Fri, Jan 11, 2008 at 08:55:29AM +, Jan Beulich wrote: Since __cpuinitdata/__devinitdata don't allow const to be specified with them (otherwise .init.data sections with and without the writeable attribute will be generated by the compiler), and since __devinitdata except for